debian-mirror-gitlab/spec/lib/gitlab/middleware/multipart_spec.rb

149 lines
5.4 KiB
Ruby
Raw Normal View History

2019-12-04 20:38:33 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
require 'tempfile'
describe Gitlab::Middleware::Multipart do
let(:app) { double(:app) }
let(:middleware) { described_class.new(app) }
2018-03-17 18:26:18 +05:30
let(:original_filename) { 'filename' }
2017-08-17 22:00:37 +05:30
2018-11-08 19:23:39 +05:30
shared_examples_for 'multipart upload files' do
it 'opens top-level files' do
Tempfile.open('top-level') do |tempfile|
2019-02-15 15:39:39 +05:30
rewritten = { 'file' => tempfile.path }
in_params = { 'file.name' => original_filename, 'file.path' => tempfile.path, 'file.remote_id' => remote_id }
env = post_env(rewritten, in_params, Gitlab::Workhorse.secret, 'gitlab-workhorse')
2017-08-17 22:00:37 +05:30
2018-11-08 19:23:39 +05:30
expect_uploaded_file(tempfile, %w(file))
middleware.call(env)
end
end
it 'opens files one level deep' do
Tempfile.open('one-level') do |tempfile|
in_params = { 'user' => { 'avatar' => { '.name' => original_filename, '.path' => tempfile.path, '.remote_id' => remote_id } } }
2019-02-15 15:39:39 +05:30
rewritten = { 'user[avatar]' => tempfile.path }
env = post_env(rewritten, in_params, Gitlab::Workhorse.secret, 'gitlab-workhorse')
2018-11-08 19:23:39 +05:30
expect_uploaded_file(tempfile, %w(user avatar))
middleware.call(env)
end
end
it 'opens files two levels deep' do
Tempfile.open('two-levels') do |tempfile|
in_params = { 'project' => { 'milestone' => { 'themesong' => { '.name' => original_filename, '.path' => tempfile.path, '.remote_id' => remote_id } } } }
2019-02-15 15:39:39 +05:30
rewritten = { 'project[milestone][themesong]' => tempfile.path }
env = post_env(rewritten, in_params, Gitlab::Workhorse.secret, 'gitlab-workhorse')
2018-11-08 19:23:39 +05:30
expect_uploaded_file(tempfile, %w(project milestone themesong))
middleware.call(env)
end
end
def expect_uploaded_file(tempfile, path, remote: false)
2017-08-17 22:00:37 +05:30
expect(app).to receive(:call) do |env|
2019-02-15 15:39:39 +05:30
file = get_params(env).dig(*path)
2017-08-17 22:00:37 +05:30
expect(file).to be_a(::UploadedFile)
expect(file.path).to eq(tempfile.path)
2018-03-17 18:26:18 +05:30
expect(file.original_filename).to eq(original_filename)
2018-11-08 19:23:39 +05:30
expect(file.remote_id).to eq(remote_id)
2017-08-17 22:00:37 +05:30
end
end
end
it 'rejects headers signed with the wrong secret' do
env = post_env({ 'file' => '/var/empty/nonesuch' }, {}, 'x' * 32, 'gitlab-workhorse')
expect { middleware.call(env) }.to raise_error(JWT::VerificationError)
end
it 'rejects headers signed with the wrong issuer' do
env = post_env({ 'file' => '/var/empty/nonesuch' }, {}, Gitlab::Workhorse.secret, 'acme-inc')
expect { middleware.call(env) }.to raise_error(JWT::InvalidIssuerError)
end
2018-11-08 19:23:39 +05:30
context 'with remote file' do
let(:remote_id) { 'someid' }
2017-08-17 22:00:37 +05:30
2018-11-08 19:23:39 +05:30
it_behaves_like 'multipart upload files'
end
2017-08-17 22:00:37 +05:30
2018-11-08 19:23:39 +05:30
context 'with local file' do
let(:remote_id) { nil }
it_behaves_like 'multipart upload files'
2017-08-17 22:00:37 +05:30
end
2018-11-20 20:47:30 +05:30
it 'allows files in uploads/tmp directory' do
Dir.mktmpdir do |dir|
uploads_dir = File.join(dir, 'public/uploads/tmp')
FileUtils.mkdir_p(uploads_dir)
allow(Rails).to receive(:root).and_return(dir)
allow(Dir).to receive(:tmpdir).and_return(File.join(Dir.tmpdir, 'tmpsubdir'))
Tempfile.open('top-level', uploads_dir) do |tempfile|
env = post_env({ 'file' => tempfile.path }, { 'file.name' => original_filename, 'file.path' => tempfile.path }, Gitlab::Workhorse.secret, 'gitlab-workhorse')
expect(app).to receive(:call) do |env|
2019-02-15 15:39:39 +05:30
expect(get_params(env)['file']).to be_a(::UploadedFile)
2018-11-20 20:47:30 +05:30
end
middleware.call(env)
end
end
end
2018-11-08 19:23:39 +05:30
it 'allows symlinks for uploads dir' do
2017-08-17 22:00:37 +05:30
Tempfile.open('two-levels') do |tempfile|
2018-11-08 19:23:39 +05:30
symlinked_dir = '/some/dir/uploads'
symlinked_path = File.join(symlinked_dir, File.basename(tempfile.path))
env = post_env({ 'file' => symlinked_path }, { 'file.name' => original_filename, 'file.path' => symlinked_path }, Gitlab::Workhorse.secret, 'gitlab-workhorse')
allow(FileUploader).to receive(:root).and_return(symlinked_dir)
allow(UploadedFile).to receive(:allowed_paths).and_return([symlinked_dir, Gitlab.config.uploads.storage_path])
allow(File).to receive(:realpath).and_call_original
allow(File).to receive(:realpath).with(symlinked_dir).and_return(Dir.tmpdir)
allow(File).to receive(:realpath).with(symlinked_path).and_return(tempfile.path)
allow(File).to receive(:exist?).and_call_original
allow(File).to receive(:exist?).with(symlinked_dir).and_return(true)
# override Dir.tmpdir because this dir is in the list of allowed paths
# and it would match FileUploader.root path (which in this test is linked
# to /tmp too)
allow(Dir).to receive(:tmpdir).and_return(File.join(Dir.tmpdir, 'tmpsubdir'))
2017-08-17 22:00:37 +05:30
expect(app).to receive(:call) do |env|
2019-02-15 15:39:39 +05:30
expect(get_params(env)['file']).to be_a(::UploadedFile)
2017-08-17 22:00:37 +05:30
end
middleware.call(env)
end
end
2019-02-15 15:39:39 +05:30
# Rails 5 doesn't combine the GET/POST parameters in
# ActionDispatch::HTTP::Parameters if action_dispatch.request.parameters is set:
# https://github.com/rails/rails/blob/aea6423f013ca48f7704c70deadf2cd6ac7d70a1/actionpack/lib/action_dispatch/http/parameters.rb#L41
def get_params(env)
req = ActionDispatch::Request.new(env)
req.GET.merge(req.POST)
end
2017-08-17 22:00:37 +05:30
def post_env(rewritten_fields, params, secret, issuer)
token = JWT.encode({ 'iss' => issuer, 'rewritten_fields' => rewritten_fields }, secret, 'HS256')
Rack::MockRequest.env_for(
'/',
method: 'post',
params: params,
described_class::RACK_ENV_KEY => token
)
end
end