2021-11-11 11:23:49 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe Preloaders::UserMaxAccessLevelInGroupsPreloader do
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:group1) { create(:group, :private).tap { |g| g.add_developer(user) } }
|
|
|
|
let_it_be(:group2) { create(:group, :private).tap { |g| g.add_developer(user) } }
|
|
|
|
let_it_be(:group3) { create(:group, :private) }
|
|
|
|
|
|
|
|
let(:max_query_regex) { /SELECT MAX\("members"\."access_level"\).+/ }
|
|
|
|
let(:groups) { [group1, group2, group3] }
|
|
|
|
|
|
|
|
shared_examples 'executes N max member permission queries to the DB' do
|
|
|
|
it 'executes the specified max membership queries' do
|
2021-12-07 22:27:20 +05:30
|
|
|
expect { groups.each { |group| user.can?(:read_group, group) } }
|
|
|
|
.to make_queries_matching(max_query_regex, expected_query_count)
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
2021-12-11 22:18:48 +05:30
|
|
|
|
|
|
|
it 'caches the correct access_level for each group' do
|
|
|
|
groups.each do |group|
|
|
|
|
access_level_from_db = group.members_with_parents.where(user_id: user.id).group(:user_id).maximum(:access_level)[user.id] || Gitlab::Access::NO_ACCESS
|
|
|
|
cached_access_level = group.max_member_access_for_user(user)
|
|
|
|
|
|
|
|
expect(cached_access_level).to eq(access_level_from_db)
|
|
|
|
end
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the preloader is used', :request_store do
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when user has indirect access to groups' do
|
|
|
|
let_it_be(:child_maintainer) { create(:group, :private, parent: group1).tap {|g| g.add_maintainer(user)} }
|
|
|
|
let_it_be(:child_indirect_access) { create(:group, :private, parent: group1) }
|
2021-11-11 11:23:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
let(:groups) { [group1, group2, group3, child_maintainer, child_indirect_access] }
|
|
|
|
|
|
|
|
context 'when traversal_ids feature flag is disabled' do
|
|
|
|
it_behaves_like 'executes N max member permission queries to the DB' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(use_traversal_ids: false)
|
|
|
|
described_class.new(groups, user).execute
|
|
|
|
end
|
|
|
|
|
|
|
|
# One query for group with no access and another one per group where the user is not a direct member
|
|
|
|
let(:expected_query_count) { 2 }
|
|
|
|
end
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
context 'when traversal_ids feature flag is enabled' do
|
|
|
|
it_behaves_like 'executes N max member permission queries to the DB' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(use_traversal_ids: true)
|
|
|
|
described_class.new(groups, user).execute
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
let(:expected_query_count) { 0 }
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the preloader is not used', :request_store do
|
|
|
|
it_behaves_like 'executes N max member permission queries to the DB' do
|
|
|
|
let(:expected_query_count) { groups.count }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|