debian-mirror-gitlab/doc/development/snowplow/review_guidelines.md

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

44 lines
1.8 KiB
Markdown
Raw Normal View History

2021-09-30 23:02:18 +05:30
---
stage: Growth
group: Product Intelligence
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments
---
# Snowplow review guidelines
This page includes introductory material for a
[Product Intelligence](https://about.gitlab.com/handbook/engineering/development/growth/product-intelligence/)
review, and is specific to Snowplow related reviews. For broader advice and
general best practices for code reviews, refer to our [code review guide](../code_review.md).
## Resources for reviewers
- [Snowplow Guide](index.md)
2022-04-04 11:22:00 +05:30
- [Event Dictionary](https://metrics.gitlab.com/snowplow/)
2021-09-30 23:02:18 +05:30
## Review process
We recommend a Product Intelligence review when a merge request (MR) involves changes in
events or touches Snowplow related files.
### Roles and process
#### The merge request **author** should
- For frontend events, when relevant, add a screenshot of the event in
2021-11-18 22:05:49 +05:30
the [testing tool](implementation.md#develop-and-test-snowplow) used.
2021-09-30 23:02:18 +05:30
- For backend events, when relevant, add the output of the
2021-11-18 22:05:49 +05:30
[Snowplow Micro](implementation.md#snowplow-micro) good events
2021-09-30 23:02:18 +05:30
`GET http://localhost:9090/micro/good` (it might be a good idea
to reset with `GET http://localhost:9090/micro/reset` first).
- Update the [Event Dictionary](event_dictionary_guide.md).
#### The Product Intelligence **reviewer** should
2021-11-18 22:05:49 +05:30
- Check that the [event taxonomy](index.md#structured-event-taxonomy) is correct.
- Check the [usage recommendations](implementation.md#usage-recommendations).
2021-09-30 23:02:18 +05:30
- Check that the [Event Dictionary](event_dictionary_guide.md) is up-to-date.
- If needed, check that the events are firing locally using one of the
2021-11-18 22:05:49 +05:30
[testing tools](implementation.md#develop-and-test-snowplow) available.
2021-09-30 23:02:18 +05:30
- Approve the MR, and relabel the MR with `~"product intelligence::approved"`.