debian-mirror-gitlab/doc/development/fe_guide/style/javascript.md

331 lines
7.5 KiB
Markdown
Raw Normal View History

2020-01-01 13:55:28 +05:30
---
2021-01-29 00:20:46 +05:30
stage: none
group: unassigned
2021-02-22 17:27:13 +05:30
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments
2020-01-01 13:55:28 +05:30
disqus_identifier: 'https://docs.gitlab.com/ee/development/fe_guide/style_guide_js.html'
---
# JavaScript style guide
2021-03-08 18:12:59 +05:30
We use [Airbnb's JavaScript Style Guide](https://github.com/airbnb/javascript) and its accompanying
2020-01-01 13:55:28 +05:30
linter to manage most of our JavaScript style guidelines.
In addition to the style guidelines set by Airbnb, we also have a few specific rules
listed below.
2021-02-22 17:27:13 +05:30
NOTE:
2021-04-17 20:07:23 +05:30
You can run ESLint locally by running `yarn run lint:eslint:all` or `yarn run lint:eslint $PATH_TO_FILE`.
2020-01-01 13:55:28 +05:30
## Avoid forEach
Avoid forEach when mutating data. Use `map`, `reduce` or `filter` instead of `forEach`
2021-02-22 17:27:13 +05:30
when mutating data. This minimizes mutations in functions,
2020-01-01 13:55:28 +05:30
which aligns with [Airbnb's style guide](https://github.com/airbnb/javascript#testing--for-real).
```javascript
// bad
users.forEach((user, index) => {
user.id = index;
});
// good
const usersWithId = users.map((user, index) => {
return Object.assign({}, user, { id: index });
});
```
## Limit number of parameters
If your function or method has more than 3 parameters, use an object as a parameter
instead.
```javascript
// bad
function a(p1, p2, p3) {
// ...
};
// good
function a(p) {
// ...
};
```
## Avoid classes to handle DOM events
If the only purpose of the class is to bind a DOM event and handle the callback, prefer
using a function.
```javascript
// bad
class myClass {
constructor(config) {
this.config = config;
}
init() {
document.addEventListener('click', () => {});
}
}
// good
const myFunction = () => {
document.addEventListener('click', () => {
// handle callback here
});
}
```
## Pass element container to constructor
When your class manipulates the DOM, receive the element container as a parameter.
This is more maintainable and performant.
```javascript
// bad
class a {
constructor() {
document.querySelector('.b');
}
}
// good
class a {
constructor(options) {
options.container.querySelector('.b');
}
}
```
2021-04-29 21:17:54 +05:30
## Converting Strings to Integers
2020-01-01 13:55:28 +05:30
2022-07-23 23:45:48 +05:30
When converting strings to integers, `Number` is semantic and can be more readable. Both are allowable, but `Number` has a slight maintainability advantage.
2021-04-29 21:17:54 +05:30
**WARNING:** `parseInt` **must** include the [radix argument](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt).
2020-01-01 13:55:28 +05:30
```javascript
2022-07-23 23:45:48 +05:30
// bad (missing radix argument)
2021-04-29 21:17:54 +05:30
parseInt('10');
2022-07-23 23:45:48 +05:30
// good
parseInt("106", 10);
2021-04-29 21:17:54 +05:30
// good
2022-07-23 23:45:48 +05:30
Number("106");
```
```javascript
// bad (missing radix argument)
things.map(parseInt);
2020-01-01 13:55:28 +05:30
// good
2022-07-23 23:45:48 +05:30
things.map(Number);
2020-01-01 13:55:28 +05:30
```
2022-07-23 23:45:48 +05:30
**PLEASE NOTE:** If the String could represent a non-integer (i.e., it includes a decimal), **do not** use `parseInt`. Consider `Number` or `parseFloat` instead.
2020-01-01 13:55:28 +05:30
## CSS Selectors - Use `js-` prefix
If a CSS class is only being used in JavaScript as a reference to the element, prefix
the class name with `js-`.
```html
// bad
<button class="add-user"></button>
// good
<button class="js-add-user"></button>
```
## ES Module Syntax
2022-05-07 20:08:51 +05:30
For most JavaScript files, use ES module syntax to import or export from modules.
2022-04-04 11:22:00 +05:30
Prefer named exports, as they improve name consistency.
2020-01-01 13:55:28 +05:30
```javascript
2022-04-04 11:22:00 +05:30
// bad (with exceptions, see below)
export default SomeClass;
import SomeClass from 'file';
2020-01-01 13:55:28 +05:30
// good
2022-04-04 11:22:00 +05:30
export { SomeClass };
import { SomeClass } from 'file';
```
Using default exports is acceptable in a few particular circumstances:
- Vue Single File Components (SFCs)
- Vuex mutation files
For more information, see [RFC 20](https://gitlab.com/gitlab-org/frontend/rfcs/-/issues/20).
2020-01-01 13:55:28 +05:30
2022-04-04 11:22:00 +05:30
## CommonJS Module Syntax
Our Node configuration requires CommonJS module syntax. Prefer named exports.
```javascript
2020-01-01 13:55:28 +05:30
// bad
module.exports = SomeClass;
2022-04-04 11:22:00 +05:30
const SomeClass = require('./some_class');
2020-01-01 13:55:28 +05:30
// good
2022-04-04 11:22:00 +05:30
module.exports = { SomeClass };
const { SomeClass } = require('./some_class');
2020-01-01 13:55:28 +05:30
```
## Absolute vs relative paths for modules
Use relative paths if the module you are importing is less than two levels up.
```javascript
// bad
import GitLabStyleGuide from '~/guides/GitLabStyleGuide';
// good
import GitLabStyleGuide from '../GitLabStyleGuide';
```
If the module you are importing is two or more levels up, use an absolute path instead:
```javascript
// bad
import GitLabStyleGuide from '../../../guides/GitLabStyleGuide';
// good
import GitLabStyleGuide from '~/GitLabStyleGuide';
```
Additionally, **do not add to global namespace**.
## Do not use `DOMContentLoaded` in non-page modules
Imported modules should act the same each time they are loaded. `DOMContentLoaded`
events are only allowed on modules loaded in the `/pages/*` directory because those
are loaded dynamically with webpack.
## Avoid XSS
Do not use `innerHTML`, `append()` or `html()` to set content. It opens up too many
vulnerabilities.
## ESLint
2020-05-24 23:13:21 +05:30
ESLint behavior can be found in our [tooling guide](../tooling.md).
2020-01-01 13:55:28 +05:30
## IIFEs
Avoid using IIFEs (Immediately-Invoked Function Expressions). Although
we have a lot of examples of files which wrap their contents in IIFEs,
this is no longer necessary after the transition from Sprockets to webpack.
Do not use them anymore and feel free to remove them when refactoring legacy code.
## Global namespace
Avoid adding to the global namespace.
```javascript
// bad
window.MyClass = class { /* ... */ };
// good
export default class MyClass { /* ... */ }
```
## Side effects
### Top-level side effects
Top-level side effects are forbidden in any script which contains `export`:
```javascript
// bad
export default class MyClass { /* ... */ }
document.addEventListener("DOMContentLoaded", function(event) {
new MyClass();
}
```
### Avoid side effects in constructors
Avoid making asynchronous calls, API requests or DOM manipulations in the `constructor`.
2021-02-22 17:27:13 +05:30
Move them into separate functions instead. This makes tests easier to write and
2020-01-01 13:55:28 +05:30
avoids violating the [Single Responsibility Principle](https://en.wikipedia.org/wiki/Single_responsibility_principle).
```javascript
// bad
class myClass {
constructor(config) {
this.config = config;
axios.get(this.config.endpoint)
}
}
// good
class myClass {
constructor(config) {
this.config = config;
}
makeRequest() {
axios.get(this.config.endpoint)
}
}
const instance = new myClass();
instance.makeRequest();
```
## Pure Functions and Data Mutation
Strive to write many small pure functions and minimize where mutations occur
```javascript
// bad
const values = {foo: 1};
function impureFunction(items) {
const bar = 1;
items.foo = items.a * bar + 2;
return items.a;
}
const c = impureFunction(values);
// good
var values = {foo: 1};
function pureFunction (foo) {
var bar = 1;
foo = foo * bar + 2;
return foo;
}
var c = pureFunction(values.foo);
```
2021-04-17 20:07:23 +05:30
## Export constants as primitives
2021-04-29 21:17:54 +05:30
Prefer exporting constant primitives with a common namespace over exporting objects. This allows for better compile-time reference checks and helps to avoid accidental `undefined`s at runtime. In addition, it helps in reducing bundle sizes.
2021-04-17 20:07:23 +05:30
Only export the constants as a collection (array, or object) when there is a need to iterate over them, for instance, for a prop validator.
```javascript
// bad
export const VARIANT = {
WARNING: 'warning',
ERROR: 'error',
};
// good
export const VARIANT_WARNING = 'warning';
export const VARIANT_ERROR = 'error';
// good, if the constants need to be iterated over
export const VARIANTS = [VARIANT_WARNING, VARIANT_ERROR];
```