debian-mirror-gitlab/spec/lib/gitlab/error_tracking_spec.rb

333 lines
11 KiB
Ruby
Raw Normal View History

2020-01-01 13:55:28 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-06-23 00:09:42 +05:30
require 'raven/transports/dummy'
2020-07-28 23:09:34 +05:30
RSpec.describe Gitlab::ErrorTracking do
2020-01-01 13:55:28 +05:30
let(:exception) { RuntimeError.new('boom') }
let(:issue_url) { 'http://gitlab.com/gitlab-org/gitlab-foss/issues/1' }
2021-04-29 21:17:54 +05:30
let(:extra) { { issue_url: issue_url, some_other_info: 'info' } }
2020-01-01 13:55:28 +05:30
2021-04-17 20:07:23 +05:30
let(:user) { create(:user) }
let(:sentry_payload) do
{
tags: {
program: 'test',
locale: 'en',
feature_category: 'feature_a',
correlation_id: 'cid'
},
user: {
username: user.username
},
extra: {
some_other_info: 'info',
issue_url: 'http://gitlab.com/gitlab-org/gitlab-foss/issues/1'
}
}
2020-01-01 13:55:28 +05:30
end
2021-04-17 20:07:23 +05:30
let(:logger_payload) do
{
'exception.class' => 'RuntimeError',
'exception.message' => 'boom',
'tags.program' => 'test',
'tags.locale' => 'en',
'tags.feature_category' => 'feature_a',
'tags.correlation_id' => 'cid',
'user.username' => user.username,
'extra.some_other_info' => 'info',
'extra.issue_url' => 'http://gitlab.com/gitlab-org/gitlab-foss/issues/1'
}
end
2020-07-28 23:09:34 +05:30
2021-04-29 21:17:54 +05:30
let(:sentry_event) { Gitlab::Json.parse(Raven.client.transport.events.last[1]) }
2020-01-01 13:55:28 +05:30
before do
stub_sentry_settings
allow(described_class).to receive(:sentry_dsn).and_return(Gitlab.config.sentry.dsn)
allow(Labkit::Correlation::CorrelationId).to receive(:current_id).and_return('cid')
2021-04-17 20:07:23 +05:30
allow(I18n).to receive(:locale).and_return('en')
2020-01-01 13:55:28 +05:30
2020-06-23 00:09:42 +05:30
described_class.configure do |config|
config.encoding = 'json'
end
2020-01-01 13:55:28 +05:30
end
2021-04-17 20:07:23 +05:30
around do |example|
Gitlab::ApplicationContext.with_context(user: user, feature_category: 'feature_a') do
example.run
2020-01-01 13:55:28 +05:30
end
end
describe '.track_and_raise_for_dev_exception' do
context 'when exceptions for dev should be raised' do
before do
expect(described_class).to receive(:should_raise_for_dev?).and_return(true)
end
it 'raises the exception' do
2021-04-17 20:07:23 +05:30
expect(Raven).to receive(:capture_exception).with(exception, sentry_payload)
expect do
described_class.track_and_raise_for_dev_exception(
exception,
issue_url: issue_url,
some_other_info: 'info'
)
end.to raise_error(RuntimeError, /boom/)
2020-01-01 13:55:28 +05:30
end
end
context 'when exceptions for dev should not be raised' do
before do
expect(described_class).to receive(:should_raise_for_dev?).and_return(false)
end
it 'logs the exception with all attributes passed' do
2021-04-17 20:07:23 +05:30
expect(Raven).to receive(:capture_exception).with(exception, sentry_payload)
2020-01-01 13:55:28 +05:30
described_class.track_and_raise_for_dev_exception(
exception,
issue_url: issue_url,
some_other_info: 'info'
)
end
it 'calls Gitlab::ErrorTracking::Logger.error with formatted payload' do
2021-04-17 20:07:23 +05:30
expect(Gitlab::ErrorTracking::Logger).to receive(:error).with(logger_payload)
2020-01-01 13:55:28 +05:30
described_class.track_and_raise_for_dev_exception(
exception,
issue_url: issue_url,
some_other_info: 'info'
)
end
end
end
describe '.track_and_raise_exception' do
it 'always raises the exception' do
2021-04-17 20:07:23 +05:30
expect(Raven).to receive(:capture_exception).with(exception, sentry_payload)
2020-01-01 13:55:28 +05:30
2021-04-17 20:07:23 +05:30
expect do
described_class.track_and_raise_for_dev_exception(
exception,
issue_url: issue_url,
some_other_info: 'info'
)
end.to raise_error(RuntimeError, /boom/)
2020-01-01 13:55:28 +05:30
end
it 'calls Gitlab::ErrorTracking::Logger.error with formatted payload' do
2021-04-17 20:07:23 +05:30
expect(Gitlab::ErrorTracking::Logger).to receive(:error).with(logger_payload)
2020-01-01 13:55:28 +05:30
expect do
described_class.track_and_raise_exception(
exception,
issue_url: issue_url,
some_other_info: 'info'
)
end.to raise_error(RuntimeError)
end
end
describe '.track_exception' do
2021-01-29 00:20:46 +05:30
subject(:track_exception) { described_class.track_exception(exception, extra) }
2020-01-01 13:55:28 +05:30
2021-01-29 00:20:46 +05:30
before do
allow(Raven).to receive(:capture_exception).and_call_original
allow(Gitlab::ErrorTracking::Logger).to receive(:error)
end
it 'calls Raven.capture_exception' do
track_exception
2021-04-17 20:07:23 +05:30
expect(Raven).to have_received(:capture_exception).with(
exception,
sentry_payload
)
2020-01-01 13:55:28 +05:30
end
it 'calls Gitlab::ErrorTracking::Logger.error with formatted payload' do
2021-01-29 00:20:46 +05:30
track_exception
2020-01-01 13:55:28 +05:30
2021-04-17 20:07:23 +05:30
expect(Gitlab::ErrorTracking::Logger).to have_received(:error).with(logger_payload)
2020-01-01 13:55:28 +05:30
end
2020-03-13 15:44:24 +05:30
context 'with filterable parameters' do
let(:extra) { { test: 1, my_token: 'test' } }
it 'filters parameters' do
2021-01-29 00:20:46 +05:30
track_exception
2020-03-13 15:44:24 +05:30
2021-04-17 20:07:23 +05:30
expect(Gitlab::ErrorTracking::Logger).to have_received(:error).with(
hash_including({ 'extra.test' => 1, 'extra.my_token' => '[FILTERED]' })
)
2020-03-13 15:44:24 +05:30
end
end
2020-01-01 13:55:28 +05:30
context 'the exception implements :sentry_extra_data' do
let(:extra_info) { { event: 'explosion', size: :massive } }
2021-03-08 18:12:59 +05:30
let(:exception) { double(message: 'bang!', sentry_extra_data: extra_info, backtrace: caller, cause: nil) }
2020-01-01 13:55:28 +05:30
it 'includes the extra data from the exception in the tracking information' do
2021-01-29 00:20:46 +05:30
track_exception
2020-01-01 13:55:28 +05:30
2021-04-17 20:07:23 +05:30
expect(Raven).to have_received(:capture_exception).with(
exception, a_hash_including(extra: a_hash_including(extra_info))
)
2020-01-01 13:55:28 +05:30
end
end
context 'the exception implements :sentry_extra_data, which returns nil' do
2021-03-08 18:12:59 +05:30
let(:exception) { double(message: 'bang!', sentry_extra_data: nil, backtrace: caller, cause: nil) }
2021-01-29 00:20:46 +05:30
let(:extra) { { issue_url: issue_url } }
2020-01-01 13:55:28 +05:30
it 'just includes the other extra info' do
2021-01-29 00:20:46 +05:30
track_exception
2020-01-01 13:55:28 +05:30
2021-04-17 20:07:23 +05:30
expect(Raven).to have_received(:capture_exception).with(
exception, a_hash_including(extra: a_hash_including(extra))
)
2020-01-01 13:55:28 +05:30
end
end
2020-06-23 00:09:42 +05:30
2021-04-29 21:17:54 +05:30
context 'when the error is kind of an `ActiveRecord::StatementInvalid`' do
let(:exception) { ActiveRecord::StatementInvalid.new(sql: 'SELECT "users".* FROM "users" WHERE "users"."id" = 1 AND "users"."foo" = $1') }
it 'injects the normalized sql query into extra' do
track_exception
expect(sentry_event.dig('extra', 'sql')).to eq('SELECT "users".* FROM "users" WHERE "users"."id" = $2 AND "users"."foo" = $1')
end
2021-06-08 01:23:25 +05:30
context 'when SQL cannot be parsed' do
let(:pg12_query) do
<<-SQL
CREATE INDEX CONCURRENTLY my_index ON merge_requests
USING btree (target_project_id) INCLUDE (id, latest_merge_request_diff_id)
SQL
end
let(:exception) { ActiveRecord::StatementInvalid.new(sql: pg12_query) }
it 'injects the raw sql query into extra' do
track_exception
expect(sentry_event.dig('extra', 'sql')).to eq(pg12_query)
end
end
2021-04-29 21:17:54 +05:30
end
context 'when the `ActiveRecord::StatementInvalid` is wrapped in another exception' do
it 'injects the normalized sql query into extra' do
allow(exception).to receive(:cause).and_return(ActiveRecord::StatementInvalid.new(sql: 'SELECT "users".* FROM "users" WHERE "users"."id" = 1 AND "users"."foo" = $1'))
track_exception
expect(sentry_event.dig('extra', 'sql')).to eq('SELECT "users".* FROM "users" WHERE "users"."id" = $2 AND "users"."foo" = $1')
end
end
end
2021-06-08 01:23:25 +05:30
context 'event processors' do
2021-04-29 21:17:54 +05:30
subject(:track_exception) { described_class.track_exception(exception, extra) }
before do
allow(Raven).to receive(:capture_exception).and_call_original
allow(Gitlab::ErrorTracking::Logger).to receive(:error)
end
context 'custom GitLab context when using Raven.capture_exception directly' do
subject(:raven_capture_exception) { Raven.capture_exception(exception) }
it 'merges a default set of tags into the existing tags' do
allow(Raven.context).to receive(:tags).and_return(foo: 'bar')
raven_capture_exception
expect(sentry_event['tags']).to include('correlation_id', 'feature_category', 'foo', 'locale', 'program')
end
it 'merges the current user information into the existing user information' do
Raven.user_context(id: -1)
raven_capture_exception
expect(sentry_event['user']).to eq('id' => -1, 'username' => user.username)
end
end
2020-06-23 00:09:42 +05:30
context 'with sidekiq args' do
2021-01-29 00:20:46 +05:30
context 'when the args does not have anything sensitive' do
let(:extra) { { sidekiq: { 'class' => 'PostReceive', 'args' => [1, { 'id' => 2, 'name' => 'hello' }, 'some-value', 'another-value'] } } }
2020-06-23 00:09:42 +05:30
2021-01-29 00:20:46 +05:30
it 'ensures extra.sidekiq.args is a string' do
track_exception
2020-06-23 00:09:42 +05:30
2021-01-29 00:20:46 +05:30
expect(Gitlab::ErrorTracking::Logger).to have_received(:error).with(
2021-04-17 20:07:23 +05:30
hash_including(
'extra.sidekiq' => {
'class' => 'PostReceive',
'args' => ['1', '{"id"=>2, "name"=>"hello"}', 'some-value', 'another-value']
}
)
)
2021-01-29 00:20:46 +05:30
end
2021-04-29 21:17:54 +05:30
it 'does not filter parameters when sending to Sentry' do
track_exception
expect(sentry_event.dig('extra', 'sidekiq', 'args')).to eq([1, { 'id' => 2, 'name' => 'hello' }, 'some-value', 'another-value'])
end
2020-06-23 00:09:42 +05:30
end
2021-01-29 00:20:46 +05:30
context 'when the args has sensitive information' do
let(:extra) { { sidekiq: { 'class' => 'UnknownWorker', 'args' => ['sensitive string', 1, 2] } } }
2021-04-29 21:17:54 +05:30
it 'filters sensitive arguments before sending and logging' do
2021-01-29 00:20:46 +05:30
track_exception
expect(sentry_event.dig('extra', 'sidekiq', 'args')).to eq(['[FILTERED]', 1, 2])
expect(Gitlab::ErrorTracking::Logger).to have_received(:error).with(
2021-04-17 20:07:23 +05:30
hash_including(
'extra.sidekiq' => {
'class' => 'UnknownWorker',
'args' => ['[FILTERED]', '1', '2']
}
)
)
2021-01-29 00:20:46 +05:30
end
end
end
2020-06-23 00:09:42 +05:30
2021-04-29 21:17:54 +05:30
context 'when the error is a GRPC error' do
context 'when the GRPC error contains a debug_error_string value' do
let(:exception) { GRPC::DeadlineExceeded.new('unknown cause', {}, '{"hello":1}') }
2020-06-23 00:09:42 +05:30
2021-04-29 21:17:54 +05:30
it 'sets the GRPC debug error string in the Sentry event and adds a custom fingerprint' do
track_exception
expect(sentry_event.dig('extra', 'grpc_debug_error_string')).to eq('{"hello":1}')
expect(sentry_event['fingerprint']).to eq(['GRPC::DeadlineExceeded', '4:unknown cause.'])
2021-03-08 18:12:59 +05:30
end
2021-04-29 21:17:54 +05:30
end
2021-03-08 18:12:59 +05:30
2021-04-29 21:17:54 +05:30
context 'when the GRPC error does not contain a debug_error_string value' do
let(:exception) { GRPC::DeadlineExceeded.new }
it 'does not do any processing on the event' do
track_exception
expect(sentry_event['extra']).not_to include('grpc_debug_error_string')
expect(sentry_event['fingerprint']).to eq(['GRPC::DeadlineExceeded', '4:unknown cause'])
end
2021-03-08 18:12:59 +05:30
end
end
2021-04-29 21:17:54 +05:30
end
2020-01-01 13:55:28 +05:30
end