2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
shared_examples_for 'snippet editor' do
|
|
|
|
before do
|
2020-04-22 19:07:51 +05:30
|
|
|
stub_feature_flags(snippets_edit_vue: false)
|
2020-04-08 14:13:33 +05:30
|
|
|
stub_feature_flags(monaco_snippets: flag)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
def description_field
|
2020-04-08 14:13:33 +05:30
|
|
|
find('.js-description-input').find('input,textarea')
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
def fill_form
|
|
|
|
fill_in 'project_snippet_title', with: 'My Snippet Title'
|
2020-03-13 15:44:24 +05:30
|
|
|
|
|
|
|
# Click placeholder first to expand full description field
|
|
|
|
description_field.click
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'project_snippet_description', with: 'My Snippet **Description**'
|
2020-03-13 15:44:24 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
page.within('.file-editor') do
|
2020-04-08 14:13:33 +05:30
|
|
|
el = flag == true ? find('.inputarea') : find('.ace_text-input', visible: false)
|
|
|
|
el.send_keys 'Hello World!'
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a user is authenticated' do
|
|
|
|
before do
|
2020-01-01 13:55:28 +05:30
|
|
|
stub_feature_flags(snippets_vue: false)
|
2018-11-18 11:00:15 +05:30
|
|
|
project.add_maintainer(user)
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
visit project_snippets_path(project)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
# Wait for the SVG to ensure the button location doesn't shift
|
|
|
|
within('.empty-state') { find('img.js-lazy-loaded') }
|
2017-09-10 17:25:29 +05:30
|
|
|
click_on('New snippet')
|
2020-04-08 14:13:33 +05:30
|
|
|
wait_for_requests
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'shows collapsible description input' do
|
|
|
|
collapsed = description_field
|
|
|
|
|
|
|
|
expect(page).not_to have_field('project_snippet_description')
|
|
|
|
expect(collapsed).to be_visible
|
|
|
|
|
|
|
|
collapsed.click
|
|
|
|
|
|
|
|
expect(page).to have_field('project_snippet_description')
|
|
|
|
expect(collapsed).not_to be_visible
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'creates a new snippet' do
|
|
|
|
fill_form
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
expect(page).to have_content('Hello World!')
|
|
|
|
page.within('.snippet-header .description') do
|
|
|
|
expect(page).to have_content('My Snippet Description')
|
|
|
|
expect(page).to have_selector('strong')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'uploads a file when dragging into textarea' do
|
|
|
|
fill_form
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
|
|
|
|
expect(page.find_field("project_snippet_description").value).to have_content('banana_sample')
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
link = find('a.no-attachment-icon img[alt="banana_sample"]')['src']
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(link).to match(%r{/#{Regexp.escape(project.full_path)}/uploads/\h{32}/banana_sample\.gif\z})
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
it 'creates a snippet when all required fields are filled in after validation failing' do
|
2017-09-10 17:25:29 +05:30
|
|
|
fill_in 'project_snippet_title', with: 'My Snippet Title'
|
|
|
|
click_button('Create snippet')
|
|
|
|
|
|
|
|
expect(page).to have_selector('#error_explanation')
|
|
|
|
|
|
|
|
fill_form
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
find("input[value='Create snippet']").send_keys(:return)
|
2017-09-10 17:25:29 +05:30
|
|
|
wait_for_requests
|
|
|
|
|
|
|
|
expect(page).to have_content('My Snippet Title')
|
|
|
|
expect(page).to have_content('Hello World!')
|
|
|
|
page.within('.snippet-header .description') do
|
|
|
|
expect(page).to have_content('My Snippet Description')
|
|
|
|
expect(page).to have_selector('strong')
|
|
|
|
end
|
|
|
|
link = find('a.no-attachment-icon img[alt="banana_sample"]')['src']
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(link).to match(%r{/#{Regexp.escape(project.full_path)}/uploads/\h{32}/banana_sample\.gif\z})
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
context 'when the git operation fails' do
|
|
|
|
let(:error) { 'This is a git error' }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow_next_instance_of(Snippets::CreateService) do |instance|
|
|
|
|
allow(instance).to receive(:create_commit).and_raise(StandardError, error)
|
|
|
|
end
|
|
|
|
|
|
|
|
fill_form
|
|
|
|
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'displays the error' do
|
|
|
|
expect(page).to have_content(error)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders new page' do
|
|
|
|
expect(page).to have_content('New Snippet')
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a user is not authenticated' do
|
2020-01-01 13:55:28 +05:30
|
|
|
before do
|
|
|
|
stub_feature_flags(snippets_vue: false)
|
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'shows a public snippet on the index page but not the New snippet button' do
|
2020-04-08 14:13:33 +05:30
|
|
|
snippet = create(:project_snippet, :public, :repository, project: project)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
visit project_snippets_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content(snippet.title)
|
|
|
|
expect(page).not_to have_content('New snippet')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
describe 'Projects > Snippets > Create Snippet', :js do
|
|
|
|
include DropzoneHelper
|
|
|
|
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
context 'when using Monaco' do
|
|
|
|
it_behaves_like "snippet editor" do
|
|
|
|
let(:flag) { true }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when using ACE' do
|
|
|
|
it_behaves_like "snippet editor" do
|
|
|
|
let(:flag) { false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|