2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-22 15:30:34 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe NotificationSettingsController do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project) }
|
2016-08-24 12:49:21 +05:30
|
|
|
let(:group) { create(:group, :internal) }
|
2016-06-22 15:30:34 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
project.add_developer(user)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe '#create' do
|
|
|
|
context 'when not authorized' do
|
|
|
|
it 'redirects to sign in page' do
|
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
project_id: project.id,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when authorized' do
|
2018-11-20 20:47:30 +05:30
|
|
|
let(:notification_setting) { user.notification_settings_for(source) }
|
2016-08-24 12:49:21 +05:30
|
|
|
let(:custom_events) do
|
|
|
|
events = {}
|
|
|
|
|
2018-11-20 20:47:30 +05:30
|
|
|
NotificationSetting.email_events(source).each do |event|
|
2016-08-24 12:49:21 +05:30
|
|
|
events[event.to_s] = true
|
|
|
|
end
|
|
|
|
|
|
|
|
events
|
|
|
|
end
|
|
|
|
|
2016-06-22 15:30:34 +05:30
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'for projects' do
|
2018-11-20 20:47:30 +05:30
|
|
|
let(:source) { project }
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
it 'creates notification setting' do
|
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
project_id: project.id,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(notification_setting.level).to eq("participating")
|
|
|
|
expect(notification_setting.user_id).to eq(user.id)
|
|
|
|
expect(notification_setting.source_id).to eq(project.id)
|
|
|
|
expect(notification_setting.source_type).to eq("Project")
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'with custom settings' do
|
|
|
|
it 'creates notification setting' do
|
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
project_id: project.id,
|
|
|
|
notification_setting: { level: :custom }.merge(custom_events)
|
|
|
|
}
|
2016-08-24 12:49:21 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(notification_setting.level).to eq("custom")
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
custom_events.each do |event, value|
|
|
|
|
expect(notification_setting.event_enabled?(event)).to eq(value)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'for groups' do
|
2018-11-20 20:47:30 +05:30
|
|
|
let(:source) { group }
|
2016-08-24 12:49:21 +05:30
|
|
|
|
|
|
|
it 'creates notification setting' do
|
2016-06-22 15:30:34 +05:30
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
namespace_id: group.id,
|
|
|
|
notification_setting: { level: :watch }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(notification_setting.level).to eq("watch")
|
|
|
|
expect(notification_setting.user_id).to eq(user.id)
|
|
|
|
expect(notification_setting.source_id).to eq(group.id)
|
|
|
|
expect(notification_setting.source_type).to eq("Namespace")
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with custom settings' do
|
|
|
|
it 'creates notification setting' do
|
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
namespace_id: group.id,
|
|
|
|
notification_setting: { level: :custom }.merge(custom_events)
|
|
|
|
}
|
2016-08-24 12:49:21 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(notification_setting.level).to eq("custom")
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
custom_events.each do |event, value|
|
|
|
|
expect(notification_setting.event_enabled?(event)).to eq(value)
|
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'not authorized' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:private_project) { create(:project, :private) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
post :create,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
project_id: private_project.id,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#update' do
|
|
|
|
let(:notification_setting) { user.global_notification_setting }
|
|
|
|
|
|
|
|
context 'when not authorized' do
|
|
|
|
it 'redirects to sign in page' do
|
|
|
|
put :update,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
id: notification_setting,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
expect(response).to redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when authorized' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
it 'returns success' do
|
|
|
|
put :update,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
id: notification_setting,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'and setting custom notification setting' do
|
|
|
|
let(:custom_events) do
|
|
|
|
events = {}
|
|
|
|
|
2018-11-20 20:47:30 +05:30
|
|
|
notification_setting.email_events.each do |event|
|
2016-06-22 15:30:34 +05:30
|
|
|
events[event] = "true"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns success' do
|
|
|
|
put :update,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
id: notification_setting,
|
|
|
|
notification_setting: { level: :participating, events: custom_events }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'not authorized' do
|
|
|
|
let(:other_user) { create(:user) }
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
sign_in(other_user)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
put :update,
|
2019-02-15 15:39:39 +05:30
|
|
|
params: {
|
|
|
|
id: notification_setting,
|
|
|
|
notification_setting: { level: :participating }
|
|
|
|
}
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|