2014-09-02 18:07:02 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe Projects::CreateService, '#execute' do
|
2018-12-05 23:21:45 +05:30
|
|
|
include GitHelpers
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:gitlab_shell) { Gitlab::Shell.new }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:user) { create :user }
|
|
|
|
let(:opts) do
|
|
|
|
{
|
2017-09-10 17:25:29 +05:30
|
|
|
name: 'GitLab',
|
|
|
|
namespace_id: user.namespace.id
|
2017-08-17 22:00:37 +05:30
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates labels on Project creation if there are templates' do
|
|
|
|
Label.create(title: "bug", template: true)
|
|
|
|
project = create_project(user, opts)
|
|
|
|
|
2019-03-02 22:35:43 +05:30
|
|
|
created_label = project.reload.labels.last
|
|
|
|
|
|
|
|
expect(created_label.type).to eq('ProjectLabel')
|
|
|
|
expect(created_label.project_id).to eq(project.id)
|
|
|
|
expect(created_label.title).to eq('bug')
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'user namespace' do
|
|
|
|
it do
|
|
|
|
project = create_project(user, opts)
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project).to be_valid
|
|
|
|
expect(project.owner).to eq(user)
|
2018-11-18 11:00:15 +05:30
|
|
|
expect(project.team.maintainers).to include(user)
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project.namespace).to eq(user.namespace)
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
describe 'after create actions' do
|
|
|
|
it 'invalidate personal_projects_count caches' do
|
|
|
|
expect(user).to receive(:invalidate_personal_projects_count)
|
|
|
|
|
|
|
|
create_project(user, opts)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context "admin creates project with other user's namespace_id" do
|
|
|
|
it 'sets the correct permissions' do
|
|
|
|
admin = create(:admin)
|
|
|
|
opts = {
|
|
|
|
name: 'GitLab',
|
|
|
|
namespace_id: user.namespace.id
|
|
|
|
}
|
|
|
|
project = create_project(admin, opts)
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project).to be_persisted
|
|
|
|
expect(project.owner).to eq(user)
|
2018-11-18 11:00:15 +05:30
|
|
|
expect(project.team.maintainers).to contain_exactly(user)
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project.namespace).to eq(user.namespace)
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'group namespace' do
|
|
|
|
let(:group) do
|
|
|
|
create(:group).tap do |group|
|
|
|
|
group.add_owner(user)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
before do
|
|
|
|
user.refresh_authorized_projects # Ensure cache is warm
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it do
|
|
|
|
project = create_project(user, opts.merge!(namespace_id: group.id))
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project).to be_valid
|
|
|
|
expect(project.owner).to eq(group)
|
|
|
|
expect(project.namespace).to eq(group)
|
|
|
|
expect(user.authorized_projects).to include(project)
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'error handling' do
|
|
|
|
it 'handles invalid options' do
|
|
|
|
opts[:default_branch] = 'master'
|
|
|
|
expect(create_project(user, opts)).to eq(nil)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'sets invalid service as inactive' do
|
|
|
|
create(:service, type: 'JiraService', project: nil, template: true, active: true)
|
|
|
|
|
|
|
|
project = create_project(user, opts)
|
|
|
|
service = project.services.first
|
|
|
|
|
|
|
|
expect(project).to be_persisted
|
|
|
|
expect(service.active).to be false
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'wiki_enabled creates repository directory' do
|
|
|
|
context 'wiki_enabled true creates wiki repository directory' do
|
|
|
|
it do
|
|
|
|
project = create_project(user, opts)
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(wiki_repo(project).exists?).to be_truthy
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'wiki_enabled false does not create wiki repository directory' do
|
|
|
|
it do
|
|
|
|
opts[:wiki_enabled] = false
|
|
|
|
project = create_project(user, opts)
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(wiki_repo(project).exists?).to be_falsey
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
def wiki_repo(project)
|
|
|
|
relative_path = ProjectWiki.new(project).disk_path + '.git'
|
2019-03-02 22:35:43 +05:30
|
|
|
Gitlab::Git::Repository.new(project.repository_storage, relative_path, 'foobar', project.full_path)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-11-18 11:00:15 +05:30
|
|
|
context 'import data' do
|
|
|
|
it 'stores import data and URL' do
|
|
|
|
import_data = { data: { 'test' => 'some data' } }
|
|
|
|
project = create_project(user, { name: 'test', import_url: 'http://import-url', import_data: import_data })
|
|
|
|
|
|
|
|
expect(project.import_data).to be_persisted
|
|
|
|
expect(project.import_data.data).to eq(import_data[:data])
|
|
|
|
expect(project.import_url).to eq('http://import-url')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'builds_enabled global setting' do
|
|
|
|
let(:project) { create_project(user, opts) }
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
subject { project.builds_enabled? }
|
|
|
|
|
|
|
|
context 'global builds_enabled false does not enable CI by default' do
|
|
|
|
before do
|
|
|
|
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
it { is_expected.to be_falsey }
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'global builds_enabled true does enable CI by default' do
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'restricted visibility level' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PUBLIC])
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
opts.merge!(
|
2017-09-10 17:25:29 +05:30
|
|
|
visibility_level: Gitlab::VisibilityLevel::PUBLIC
|
2017-08-17 22:00:37 +05:30
|
|
|
)
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'does not allow a restricted visibility level for non-admins' do
|
|
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to respond_to(:errors)
|
|
|
|
expect(project.errors.messages).to have_key(:visibility_level)
|
|
|
|
expect(project.errors.messages[:visibility_level].first).to(
|
|
|
|
match('restricted by your GitLab administrator')
|
|
|
|
)
|
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'allows a restricted visibility level for admins' do
|
|
|
|
admin = create(:admin)
|
|
|
|
project = create_project(admin, opts)
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project.errors.any?).to be(false)
|
|
|
|
expect(project.saved?).to be(true)
|
2015-11-26 14:37:03 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-11-26 14:37:03 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'repository creation' do
|
|
|
|
it 'synchronously creates the repository' do
|
|
|
|
expect_any_instance_of(Project).to receive(:create_repository)
|
2015-04-26 12:48:37 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
project = create_project(user, opts)
|
|
|
|
expect(project).to be_valid
|
|
|
|
expect(project.owner).to eq(user)
|
|
|
|
expect(project.namespace).to eq(user.namespace)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
context 'when another repository already exists on disk' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:repository_storage) { 'default' }
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:opts) do
|
|
|
|
{
|
|
|
|
name: 'Existing',
|
|
|
|
namespace_id: user.namespace.id
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'with legacy storage' do
|
|
|
|
before do
|
2019-03-02 22:35:43 +05:30
|
|
|
gitlab_shell.create_repository(repository_storage, "#{user.namespace.full_path}/existing", 'group/project')
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
after do
|
2018-10-15 14:42:47 +05:30
|
|
|
gitlab_shell.remove_repository(repository_storage, "#{user.namespace.full_path}/existing")
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'does not allow to create a project when path matches existing repository on disk' do
|
|
|
|
project = create_project(user, opts)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(project).not_to be_persisted
|
|
|
|
expect(project).to respond_to(:errors)
|
|
|
|
expect(project.errors.messages).to have_key(:base)
|
|
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow to import project when path matches existing repository on disk' do
|
|
|
|
project = create_project(user, opts.merge({ import_url: 'https://gitlab.com/gitlab-org/gitlab-test.git' }))
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(project).not_to be_persisted
|
|
|
|
expect(project).to respond_to(:errors)
|
|
|
|
expect(project.errors.messages).to have_key(:base)
|
|
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'with hashed storage' do
|
|
|
|
let(:hash) { '6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b' }
|
|
|
|
let(:hashed_path) { '@hashed/6b/86/6b86b273ff34fce19d6b804eff5a3f5747ada4eaa22f1d49c01e52ddb7875b4b' }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_application_setting(hashed_storage_enabled: true)
|
|
|
|
allow(Digest::SHA2).to receive(:hexdigest) { hash }
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
2019-03-02 22:35:43 +05:30
|
|
|
gitlab_shell.create_repository(repository_storage, hashed_path, 'group/project')
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
2018-10-15 14:42:47 +05:30
|
|
|
gitlab_shell.remove_repository(repository_storage, hashed_path)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'does not allow to create a project when path matches existing repository on disk' do
|
|
|
|
project = create_project(user, opts)
|
|
|
|
|
|
|
|
expect(project).not_to be_persisted
|
|
|
|
expect(project).to respond_to(:errors)
|
|
|
|
expect(project.errors.messages).to have_key(:base)
|
|
|
|
expect(project.errors.messages[:base].first).to match('There is already a repository with that name on disk')
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
context 'when readme initialization is requested' do
|
|
|
|
it 'creates README.md' do
|
|
|
|
opts[:initialize_with_readme] = '1'
|
|
|
|
|
|
|
|
project = create_project(user, opts)
|
|
|
|
|
|
|
|
expect(project.repository.commit_count).to be(1)
|
|
|
|
expect(project.repository.readme.name).to eql('README.md')
|
|
|
|
expect(project.repository.readme.data).to include('# GitLab')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'when group has kubernetes cluster' do
|
|
|
|
let(:group_cluster) { create(:cluster, :group, :provided_by_gcp) }
|
|
|
|
let(:group) { group_cluster.group }
|
|
|
|
|
|
|
|
let(:token) { 'aaaa' }
|
|
|
|
let(:service_account_creator) { double(Clusters::Gcp::Kubernetes::CreateOrUpdateServiceAccountService, execute: true) }
|
|
|
|
let(:secrets_fetcher) { double(Clusters::Gcp::Kubernetes::FetchKubernetesTokenService, execute: token) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
|
|
|
|
expect(Clusters::Gcp::Kubernetes::CreateOrUpdateServiceAccountService).to receive(:namespace_creator).and_return(service_account_creator)
|
|
|
|
expect(Clusters::Gcp::Kubernetes::FetchKubernetesTokenService).to receive(:new).and_return(secrets_fetcher)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates kubernetes namespace for the project' do
|
|
|
|
project = create_project(user, opts.merge!(namespace_id: group.id))
|
|
|
|
|
|
|
|
expect(project).to be_valid
|
|
|
|
|
|
|
|
kubernetes_namespace = group_cluster.kubernetes_namespaces.first
|
|
|
|
expect(kubernetes_namespace).to be_present
|
|
|
|
expect(kubernetes_namespace.project).to eq(project)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'when there is an active service template' do
|
|
|
|
before do
|
|
|
|
create(:service, project: nil, template: true, active: true)
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'creates a service from this template' do
|
|
|
|
project = create_project(user, opts)
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(project.services.count).to eq 1
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'when a bad service template is created' do
|
2018-05-09 12:01:36 +05:30
|
|
|
it 'sets service to be inactive' do
|
2017-08-17 22:00:37 +05:30
|
|
|
opts[:import_url] = 'http://www.gitlab.com/gitlab-org/gitlab-ce'
|
2017-09-10 17:25:29 +05:30
|
|
|
create(:service, type: 'DroneCiService', project: nil, template: true, active: true)
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
project = create_project(user, opts)
|
2018-05-09 12:01:36 +05:30
|
|
|
service = project.services.first
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(project).to be_persisted
|
|
|
|
expect(service.active).to be false
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when skip_disk_validation is used' do
|
|
|
|
it 'sets the project attribute' do
|
|
|
|
opts[:skip_disk_validation] = true
|
|
|
|
project = create_project(user, opts)
|
|
|
|
|
|
|
|
expect(project.skip_disk_validation).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
it 'calls the passed block' do
|
|
|
|
fake_block = double('block')
|
|
|
|
opts[:relations_block] = fake_block
|
|
|
|
|
|
|
|
expect_next_instance_of(Project) do |project|
|
|
|
|
expect(fake_block).to receive(:call).with(project)
|
|
|
|
end
|
|
|
|
|
|
|
|
create_project(user, opts)
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'writes project full path to .git/config' do
|
|
|
|
project = create_project(user, opts)
|
2018-12-05 23:21:45 +05:30
|
|
|
rugged = rugged_repo(project.repository)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
expect(rugged.config['gitlab.fullpath']).to eq project.full_path
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
def create_project(user, opts)
|
|
|
|
Projects::CreateService.new(user, opts).execute
|
|
|
|
end
|
|
|
|
end
|