debian-mirror-gitlab/spec/frontend/notes/components/note_form_spec.js

341 lines
9.2 KiB
JavaScript
Raw Normal View History

2019-07-07 11:18:12 +05:30
import { shallowMount, createLocalVue } from '@vue/test-utils';
2018-11-08 19:23:39 +05:30
import createStore from '~/notes/stores';
2019-07-07 11:18:12 +05:30
import NoteForm from '~/notes/components/note_form.vue';
2020-06-23 00:09:42 +05:30
import batchComments from '~/batch_comments/stores/modules/batch_comments';
2019-07-07 11:18:12 +05:30
import MarkdownField from '~/vue_shared/components/markdown/field.vue';
2020-06-23 00:09:42 +05:30
import { noteableDataMock, notesDataMock, discussionMock } from '../mock_data';
2018-03-17 18:26:18 +05:30
2020-04-22 19:07:51 +05:30
import { getDraft, updateDraft } from '~/lib/utils/autosave';
jest.mock('~/lib/utils/autosave');
2018-03-17 18:26:18 +05:30
describe('issue_note_form component', () => {
2019-07-07 11:18:12 +05:30
const dummyAutosaveKey = 'some-autosave-key';
const dummyDraft = 'dummy draft content';
2018-11-08 19:23:39 +05:30
let store;
2019-07-07 11:18:12 +05:30
let wrapper;
2018-03-17 18:26:18 +05:30
let props;
2019-07-07 11:18:12 +05:30
const createComponentWrapper = () => {
const localVue = createLocalVue();
2020-01-01 13:55:28 +05:30
return shallowMount(localVue.extend(NoteForm), {
2019-07-07 11:18:12 +05:30
store,
propsData: props,
2019-12-04 20:38:33 +05:30
// see https://gitlab.com/gitlab-org/gitlab-foss/issues/56317 for the following
2019-07-07 11:18:12 +05:30
localVue,
});
};
2018-03-17 18:26:18 +05:30
beforeEach(() => {
2020-04-22 19:07:51 +05:30
getDraft.mockImplementation(key => {
2019-07-07 11:18:12 +05:30
if (key === dummyAutosaveKey) {
return dummyDraft;
}
return null;
});
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
store = createStore();
2018-03-17 18:26:18 +05:30
store.dispatch('setNoteableData', noteableDataMock);
store.dispatch('setNotesData', notesDataMock);
props = {
isEditing: false,
noteBody: 'Magni suscipit eius consectetur enim et ex et commodi.',
2018-11-20 20:47:30 +05:30
noteId: '545',
2018-03-17 18:26:18 +05:30
};
});
afterEach(() => {
2019-07-07 11:18:12 +05:30
wrapper.destroy();
2018-03-17 18:26:18 +05:30
});
2018-11-20 20:47:30 +05:30
describe('noteHash', () => {
2019-07-07 11:18:12 +05:30
beforeEach(() => {
wrapper = createComponentWrapper();
});
2018-11-20 20:47:30 +05:30
it('returns note hash string based on `noteId`', () => {
2019-07-07 11:18:12 +05:30
expect(wrapper.vm.noteHash).toBe(`#note_${props.noteId}`);
2018-11-20 20:47:30 +05:30
});
2020-04-22 19:07:51 +05:30
it('return note hash as `#` when `noteId` is empty', () => {
2019-07-07 11:18:12 +05:30
wrapper.setProps({
...props,
noteId: '',
});
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick().then(() => {
expect(wrapper.vm.noteHash).toBe('#');
});
2018-11-20 20:47:30 +05:30
});
});
2018-03-17 18:26:18 +05:30
describe('conflicts editing', () => {
2019-07-07 11:18:12 +05:30
beforeEach(() => {
wrapper = createComponentWrapper();
});
2020-04-22 19:07:51 +05:30
it('should show conflict message if note changes outside the component', () => {
2019-07-07 11:18:12 +05:30
wrapper.setProps({
...props,
isEditing: true,
noteBody: 'Foo',
});
2018-11-08 19:23:39 +05:30
const message =
'This comment has changed since you started editing, please review the updated comment to ensure information is not lost.';
2018-03-17 18:26:18 +05:30
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick().then(() => {
const conflictWarning = wrapper.find('.js-conflict-edit-warning');
expect(conflictWarning.exists()).toBe(true);
expect(
conflictWarning
.text()
.replace(/\s+/g, ' ')
.trim(),
).toBe(message);
});
2018-03-17 18:26:18 +05:30
});
});
describe('form', () => {
2019-07-07 11:18:12 +05:30
beforeEach(() => {
wrapper = createComponentWrapper();
});
2018-03-17 18:26:18 +05:30
it('should render text area with placeholder', () => {
2019-07-07 11:18:12 +05:30
const textarea = wrapper.find('textarea');
expect(textarea.attributes('placeholder')).toEqual(
2018-11-08 19:23:39 +05:30
'Write a comment or drag your files here…',
);
2018-03-17 18:26:18 +05:30
});
it('should link to markdown docs', () => {
const { markdownDocsPath } = notesDataMock;
2019-07-07 11:18:12 +05:30
const markdownField = wrapper.find(MarkdownField);
const markdownFieldProps = markdownField.props();
2018-12-13 13:39:08 +05:30
2019-07-07 11:18:12 +05:30
expect(markdownFieldProps.markdownDocsPath).toBe(markdownDocsPath);
2018-03-17 18:26:18 +05:30
});
describe('keyboard events', () => {
2019-07-07 11:18:12 +05:30
let textarea;
beforeEach(() => {
textarea = wrapper.find('textarea');
textarea.setValue('Foo');
});
2018-03-17 18:26:18 +05:30
describe('up', () => {
it('should ender edit mode', () => {
2019-07-07 11:18:12 +05:30
// TODO: do not spy on vm
2020-04-22 19:07:51 +05:30
jest.spyOn(wrapper.vm, 'editMyLastNote');
2018-03-17 18:26:18 +05:30
2019-07-07 11:18:12 +05:30
textarea.trigger('keydown.up');
expect(wrapper.vm.editMyLastNote).toHaveBeenCalled();
2018-03-17 18:26:18 +05:30
});
});
describe('enter', () => {
it('should save note when cmd+enter is pressed', () => {
2019-07-07 11:18:12 +05:30
textarea.trigger('keydown.enter', { metaKey: true });
const { handleFormUpdate } = wrapper.emitted();
2018-03-17 18:26:18 +05:30
2019-07-07 11:18:12 +05:30
expect(handleFormUpdate.length).toBe(1);
2018-03-17 18:26:18 +05:30
});
2018-12-13 13:39:08 +05:30
2018-03-17 18:26:18 +05:30
it('should save note when ctrl+enter is pressed', () => {
2019-07-07 11:18:12 +05:30
textarea.trigger('keydown.enter', { ctrlKey: true });
2018-03-17 18:26:18 +05:30
2019-07-07 11:18:12 +05:30
const { handleFormUpdate } = wrapper.emitted();
expect(handleFormUpdate.length).toBe(1);
2018-03-17 18:26:18 +05:30
});
});
});
describe('actions', () => {
2020-04-22 19:07:51 +05:30
it('should be possible to cancel', () => {
2020-05-24 23:13:21 +05:30
const cancelHandler = jest.fn();
2019-07-07 11:18:12 +05:30
wrapper.setProps({
...props,
isEditing: true,
});
2020-05-24 23:13:21 +05:30
wrapper.setMethods({ cancelHandler });
2018-03-17 18:26:18 +05:30
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick().then(() => {
2020-05-24 23:13:21 +05:30
const cancelButton = wrapper.find('[data-testid="cancel"]');
2020-04-22 19:07:51 +05:30
cancelButton.trigger('click');
2018-03-17 18:26:18 +05:30
2020-05-24 23:13:21 +05:30
expect(cancelHandler).toHaveBeenCalledWith(true);
2020-04-22 19:07:51 +05:30
});
2019-05-18 00:54:41 +05:30
});
2020-04-22 19:07:51 +05:30
it('should be possible to update the note', () => {
2019-07-07 11:18:12 +05:30
wrapper.setProps({
...props,
isEditing: true,
});
2019-05-18 00:54:41 +05:30
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick().then(() => {
const textarea = wrapper.find('textarea');
textarea.setValue('Foo');
const saveButton = wrapper.find('.js-vue-issue-save');
saveButton.trigger('click');
expect(wrapper.vm.isSubmitting).toBe(true);
});
2019-07-07 11:18:12 +05:30
});
});
});
describe('with autosaveKey', () => {
describe('with draft', () => {
2020-04-22 19:07:51 +05:30
beforeEach(() => {
2019-07-07 11:18:12 +05:30
Object.assign(props, {
noteBody: '',
autosaveKey: dummyAutosaveKey,
2019-05-18 00:54:41 +05:30
});
2019-07-07 11:18:12 +05:30
wrapper = createComponentWrapper();
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick();
2019-05-18 00:54:41 +05:30
});
2019-07-07 11:18:12 +05:30
it('displays the draft in textarea', () => {
const textarea = wrapper.find('textarea');
expect(textarea.element.value).toBe(dummyDraft);
});
});
describe('without draft', () => {
2020-04-22 19:07:51 +05:30
beforeEach(() => {
2019-07-07 11:18:12 +05:30
Object.assign(props, {
noteBody: '',
autosaveKey: 'some key without draft',
});
wrapper = createComponentWrapper();
2020-04-22 19:07:51 +05:30
return wrapper.vm.$nextTick();
2019-07-07 11:18:12 +05:30
});
it('leaves the textarea empty', () => {
const textarea = wrapper.find('textarea');
expect(textarea.element.value).toBe('');
});
});
it('updates the draft if textarea content changes', () => {
Object.assign(props, {
noteBody: '',
autosaveKey: dummyAutosaveKey,
});
wrapper = createComponentWrapper();
const textarea = wrapper.find('textarea');
const dummyContent = 'some new content';
textarea.setValue(dummyContent);
2020-04-22 19:07:51 +05:30
expect(updateDraft).toHaveBeenCalledWith(dummyAutosaveKey, dummyContent);
2019-05-18 00:54:41 +05:30
});
2020-07-28 23:09:34 +05:30
it('does not save draft when ctrl+enter is pressed', () => {
const options = {
noteBody: '',
autosaveKey: dummyAutosaveKey,
};
props = { ...props, ...options };
wrapper = createComponentWrapper();
wrapper.setData({ isSubmittingWithKeydown: true });
const textarea = wrapper.find('textarea');
textarea.setValue('some content');
textarea.trigger('keydown.enter', { metaKey: true });
expect(updateDraft).not.toHaveBeenCalled();
});
2018-03-17 18:26:18 +05:30
});
2020-06-23 00:09:42 +05:30
describe('with batch comments', () => {
beforeEach(() => {
store.registerModule('batchComments', batchComments());
wrapper = createComponentWrapper();
wrapper.setProps({
...props,
2021-01-29 00:20:46 +05:30
isDraft: true,
2020-06-23 00:09:42 +05:30
noteId: '',
discussion: { ...discussionMock, for_commit: false },
});
});
it('should be possible to cancel', () => {
jest.spyOn(wrapper.vm, 'cancelHandler');
return wrapper.vm.$nextTick().then(() => {
const cancelButton = wrapper.find('[data-testid="cancelBatchCommentsEnabled"]');
cancelButton.trigger('click');
expect(wrapper.vm.cancelHandler).toHaveBeenCalledWith(true);
});
});
it('shows resolve checkbox', () => {
expect(wrapper.find('.js-resolve-checkbox').exists()).toBe(true);
});
2021-01-29 00:20:46 +05:30
it('hides resolve checkbox', async () => {
wrapper.setProps({
isDraft: false,
discussion: {
...discussionMock,
notes: [
...discussionMock.notes.map(n => ({
...n,
resolvable: true,
current_user: { ...n.current_user, can_resolve_discussion: false },
})),
],
for_commit: false,
},
});
await wrapper.vm.$nextTick();
expect(wrapper.find('.js-resolve-checkbox').exists()).toBe(false);
});
2020-06-23 00:09:42 +05:30
it('hides actions for commits', () => {
wrapper.setProps({ discussion: { for_commit: true } });
return wrapper.vm.$nextTick(() => {
expect(wrapper.find('.note-form-actions').text()).not.toContain('Start a review');
});
});
describe('on enter', () => {
it('should start review or add to review when cmd+enter is pressed', () => {
const textarea = wrapper.find('textarea');
jest.spyOn(wrapper.vm, 'handleAddToReview');
textarea.setValue('Foo');
textarea.trigger('keydown.enter', { metaKey: true });
return wrapper.vm.$nextTick(() => {
expect(wrapper.vm.handleAddToReview).toHaveBeenCalled();
});
});
});
});
2018-03-17 18:26:18 +05:30
});