2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe PipelinesEmailService, :mailer do
|
2016-11-03 12:29:30 +05:30
|
|
|
let(:pipeline) do
|
2019-09-04 21:01:54 +05:30
|
|
|
create(:ci_pipeline, :failed,
|
|
|
|
project: project,
|
|
|
|
sha: project.commit('master').sha,
|
|
|
|
ref: project.default_branch
|
|
|
|
)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:project) { create(:project, :repository) }
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:recipients) { 'test@gitlab.com' }
|
|
|
|
let(:receivers) { [recipients] }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
let(:data) do
|
|
|
|
Gitlab::DataBuilder::Pipeline.build(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Validations' do
|
|
|
|
context 'when service is active' do
|
|
|
|
before do
|
|
|
|
subject.active = true
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to validate_presence_of(:recipients) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service is inactive' do
|
|
|
|
before do
|
|
|
|
subject.active = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.not_to validate_presence_of(:recipients) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#test_data' do
|
|
|
|
let(:build) { create(:ci_build) }
|
|
|
|
let(:project) { build.project }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
project.add_developer(user)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'builds test data' do
|
|
|
|
data = subject.test_data(project, user)
|
|
|
|
|
|
|
|
expect(data[:object_kind]).to eq('pipeline')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
shared_examples 'sending email' do |branches_to_be_notified: nil|
|
2016-11-03 12:29:30 +05:30
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
subject.recipients = recipients
|
2019-12-04 20:38:33 +05:30
|
|
|
subject.branches_to_be_notified = branches_to_be_notified if branches_to_be_notified
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
perform_enqueued_jobs do
|
|
|
|
run
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sends email' do
|
2018-03-17 18:26:18 +05:30
|
|
|
emails = receivers.map { |r| double(notification_email: r) }
|
|
|
|
|
|
|
|
should_only_email(*emails, kind: :bcc)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
shared_examples 'not sending email' do |branches_to_be_notified: nil|
|
2016-11-03 12:29:30 +05:30
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
subject.recipients = recipients
|
2019-12-04 20:38:33 +05:30
|
|
|
subject.branches_to_be_notified = branches_to_be_notified if branches_to_be_notified
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
perform_enqueued_jobs do
|
|
|
|
run
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not send email' do
|
2017-08-17 22:00:37 +05:30
|
|
|
should_not_email_anyone
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#test' do
|
|
|
|
def run
|
|
|
|
subject.test(data)
|
|
|
|
end
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
context 'when pipeline is failed and on default branch' do
|
2016-11-03 12:29:30 +05:30
|
|
|
it_behaves_like 'sending email'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pipeline is succeeded' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:status] = 'success'
|
|
|
|
pipeline.update(status: 'success')
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'sending email'
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'when the pipeline failed' do
|
|
|
|
context 'on default branch' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:ref] = project.default_branch
|
|
|
|
pipeline.update(ref: project.default_branch)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'on a protected branch' do
|
2019-09-04 21:01:54 +05:30
|
|
|
before do
|
2019-12-04 20:38:33 +05:30
|
|
|
create(:protected_branch, project: project, name: 'a-protected-branch')
|
|
|
|
data[:object_attributes][:ref] = 'a-protected-branch'
|
|
|
|
pipeline.update(ref: 'a-protected-branch')
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'on a neither protected nor default branch' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:ref] = 'a-random-branch'
|
|
|
|
pipeline.update(ref: 'a-random-branch')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe '#execute' do
|
2019-12-04 20:38:33 +05:30
|
|
|
before do
|
|
|
|
subject.project = project
|
|
|
|
end
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
def run
|
|
|
|
subject.execute(data)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with recipients' do
|
|
|
|
context 'with failed pipeline' do
|
|
|
|
it_behaves_like 'sending email'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with succeeded pipeline' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:status] = 'success'
|
|
|
|
pipeline.update(status: 'success')
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'not sending email'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with notify_only_broken_pipelines on' do
|
|
|
|
before do
|
|
|
|
subject.notify_only_broken_pipelines = true
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with failed pipeline' do
|
|
|
|
it_behaves_like 'sending email'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with succeeded pipeline' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:status] = 'success'
|
|
|
|
pipeline.update(status: 'success')
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'not sending email'
|
|
|
|
end
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'when the pipeline failed' do
|
|
|
|
context 'on default branch' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:ref] = project.default_branch
|
|
|
|
pipeline.update(ref: project.default_branch)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'not sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'on a protected branch' do
|
2019-09-04 21:01:54 +05:30
|
|
|
before do
|
2019-12-04 20:38:33 +05:30
|
|
|
create(:protected_branch, project: project, name: 'a-protected-branch')
|
|
|
|
data[:object_attributes][:ref] = 'a-protected-branch'
|
|
|
|
pipeline.update(ref: 'a-protected-branch')
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'not sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'on a neither protected nor default branch' do
|
2019-09-04 21:01:54 +05:30
|
|
|
before do
|
2019-12-04 20:38:33 +05:30
|
|
|
data[:object_attributes][:ref] = 'a-random-branch'
|
|
|
|
pipeline.update(ref: 'a-random-branch')
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
context 'notifications are enabled only for default branch' do
|
|
|
|
it_behaves_like 'not sending email', branches_to_be_notified: "default"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for protected branch' do
|
|
|
|
it_behaves_like 'not sending email', branches_to_be_notified: "protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for default and protected branches ' do
|
|
|
|
it_behaves_like 'not sending email', branches_to_be_notified: "default_and_protected"
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'notifications are enabled only for all branches' do
|
|
|
|
it_behaves_like 'sending email', branches_to_be_notified: "all"
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'with empty recipients list' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:recipients) { ' ,, ' }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
context 'with failed pipeline' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:status] = 'failed'
|
|
|
|
pipeline.update(status: 'failed')
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'not sending email'
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context 'with recipients list separating with newlines' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:recipients) { "\ntest@gitlab.com, \r\nexample@gitlab.com\rother@gitlab.com" }
|
|
|
|
let(:receivers) { %w[test@gitlab.com example@gitlab.com other@gitlab.com] }
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context 'with failed pipeline' do
|
|
|
|
before do
|
|
|
|
data[:object_attributes][:status] = 'failed'
|
|
|
|
pipeline.update(status: 'failed')
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'sending email'
|
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|