2019-12-26 22:10:19 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe Ci::PipelinePolicy, :models do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:pipeline) { create(:ci_empty_pipeline, project: project) }
|
|
|
|
|
|
|
|
let(:policy) do
|
|
|
|
described_class.new(user, pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'rules' do
|
|
|
|
describe 'rules for protected ref' do
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no one can push or merge to the branch' do
|
|
|
|
before do
|
|
|
|
create(:protected_branch, :no_one_can_push,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include ability to update pipeline' do
|
|
|
|
expect(policy).to be_disallowed :update_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when developers can push to the branch' do
|
|
|
|
before do
|
|
|
|
create(:protected_branch, :developers_can_merge,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes ability to update pipeline' do
|
|
|
|
expect(policy).to be_allowed :update_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no one can create the tag' do
|
|
|
|
before do
|
|
|
|
create(:protected_tag, :no_one_can_create,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
pipeline.update!(tag: true)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include ability to update pipeline' do
|
|
|
|
expect(policy).to be_disallowed :update_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no one can create the tag but it is not a tag' do
|
|
|
|
before do
|
|
|
|
create(:protected_tag, :no_one_can_create,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes ability to update pipeline' do
|
|
|
|
expect(policy).to be_allowed :update_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-11-08 19:23:39 +05:30
|
|
|
|
|
|
|
context 'when maintainer is allowed to push to pipeline branch' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:owner) { user }
|
|
|
|
|
|
|
|
it 'enables update_pipeline if user is maintainer' do
|
|
|
|
allow_any_instance_of(Project).to receive(:empty_repo?).and_return(false)
|
|
|
|
allow_any_instance_of(Project).to receive(:branch_allows_collaboration?).and_return(true)
|
|
|
|
|
|
|
|
expect(policy).to be_allowed :update_pipeline
|
|
|
|
end
|
|
|
|
end
|
2019-02-02 18:00:53 +05:30
|
|
|
|
|
|
|
context 'when user does not have access to internal CI' do
|
|
|
|
let(:project) { create(:project, :builds_disabled, :public) }
|
|
|
|
|
|
|
|
it 'disallows the user from reading the pipeline' do
|
|
|
|
expect(policy).to be_disallowed :read_pipeline
|
|
|
|
end
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
describe 'destroy_pipeline' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
context 'when user has owner access' do
|
|
|
|
let(:user) { project.owner }
|
|
|
|
|
|
|
|
it 'is enabled' do
|
|
|
|
expect(policy).to be_allowed :destroy_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
it 'is disabled' do
|
|
|
|
expect(policy).not_to be_allowed :destroy_pipeline
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-07-31 22:56:46 +05:30
|
|
|
|
|
|
|
describe 'read_pipeline_variable' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
context 'when user has owner access' do
|
|
|
|
let(:user) { project.owner }
|
|
|
|
|
|
|
|
it 'is enabled' do
|
|
|
|
expect(policy).to be_allowed :read_pipeline_variable
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is developer and the creator of the pipeline' do
|
|
|
|
let(:pipeline) { create(:ci_empty_pipeline, project: project, user: user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
create(:protected_branch, :developers_can_merge,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is enabled' do
|
|
|
|
expect(policy).to be_allowed :read_pipeline_variable
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is developer and it is not the creator of the pipeline' do
|
|
|
|
let(:pipeline) { create(:ci_empty_pipeline, project: project, user: project.owner) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(user)
|
|
|
|
create(:protected_branch, :developers_can_merge,
|
|
|
|
name: pipeline.ref, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is disabled' do
|
|
|
|
expect(policy).to be_disallowed :read_pipeline_variable
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner nor developer' do
|
|
|
|
it 'is disabled' do
|
|
|
|
expect(policy).not_to be_allowed :read_pipeline_variable
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|