2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe 'User views an open merge request' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:merge_request) do
|
|
|
|
create(:merge_request, source_project: project, target_project: project, description: '# Description header')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a merge request does not have repository' do
|
|
|
|
let(:project) { create(:project, :public, :repository) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
visit(merge_request_path(merge_request))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders both the title and the description' do
|
2019-07-07 11:18:12 +05:30
|
|
|
node = find('.md h1 a#user-content-description-header')
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(node[:href]).to end_with('#description-header')
|
|
|
|
|
|
|
|
# Work around a weird Capybara behavior where calling `parent` on a node
|
|
|
|
# returns the whole document, not the node's actual parent element
|
2022-01-26 12:08:38 +05:30
|
|
|
expect(find(:xpath, "#{node.path}/..").text).to eq(merge_request.description[2..])
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2021-01-03 14:25:43 +05:30
|
|
|
expect(page).to have_content(merge_request.title)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has reviewers in sidebar' do
|
|
|
|
expect(page).to have_css('.reviewer')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when a merge request has repository', :js do
|
|
|
|
let(:project) { create(:project, :public, :repository) }
|
|
|
|
|
|
|
|
context 'when rendering description preview' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
2018-11-18 11:00:15 +05:30
|
|
|
project.add_maintainer(user)
|
2018-03-17 18:26:18 +05:30
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
visit(edit_project_merge_request_path(project, merge_request))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders empty description preview' do
|
|
|
|
find('.gfm-form').fill_in(:merge_request_description, with: '')
|
|
|
|
|
|
|
|
page.within('.gfm-form') do
|
2018-12-13 13:39:08 +05:30
|
|
|
click_button('Preview')
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
expect(find('.js-md-preview')).to have_content('Nothing to preview.')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders description preview' do
|
|
|
|
find('.gfm-form').fill_in(:merge_request_description, with: ':+1: Nice')
|
|
|
|
|
|
|
|
page.within('.gfm-form') do
|
2018-12-13 13:39:08 +05:30
|
|
|
click_button('Preview')
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
expect(find('.js-md-preview')).to have_css('gl-emoji')
|
|
|
|
end
|
|
|
|
|
2018-12-13 13:39:08 +05:30
|
|
|
expect(find('.gfm-form')).to have_css('.js-md-preview').and have_button('Write')
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(find('#merge_request_description', visible: false)).not_to be_visible
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the branch is rebased on the target' do
|
|
|
|
let(:merge_request) { create(:merge_request, :rebased, source_project: project, target_project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
visit(merge_request_path(merge_request))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show diverged commits count' do
|
|
|
|
page.within('.mr-source-target') do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(page).not_to have_content(/([0-9]+ commits? behind)/)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the branch is diverged on the target' do
|
|
|
|
let(:merge_request) { create(:merge_request, :diverged, source_project: project, target_project: project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
visit(merge_request_path(merge_request))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows diverged commits count' do
|
|
|
|
page.within('.mr-source-target') do
|
|
|
|
expect(page).to have_content(/([0-9]+ commits behind)/)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-03-11 19:13:27 +05:30
|
|
|
|
|
|
|
context 'when the assignee\'s availability set' do
|
|
|
|
before do
|
|
|
|
merge_request.author.create_status(availability: 'busy')
|
|
|
|
merge_request.assignees << merge_request.author
|
|
|
|
|
|
|
|
visit(merge_request_path(merge_request))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'exposes the availability in the data-availability attribute' do
|
|
|
|
assignees_data = find_all("input[name='merge_request[assignee_ids][]']", visible: false)
|
|
|
|
|
|
|
|
expect(assignees_data.size).to eq(1)
|
|
|
|
expect(assignees_data.first['data-availability']).to eq('busy')
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2021-04-01 16:36:13 +05:30
|
|
|
|
|
|
|
context 'XSS source branch' do
|
|
|
|
let(:project) { create(:project, :public, :repository) }
|
|
|
|
let(:source_branch) { "'><iframe/srcdoc=''></iframe>" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.repository.create_branch(source_branch, "master")
|
|
|
|
|
|
|
|
mr = create(:merge_request, source_project: project, target_project: project, source_branch: source_branch)
|
|
|
|
|
|
|
|
visit(merge_request_path(mr))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'encodes branch name' do
|
2021-04-29 21:17:54 +05:30
|
|
|
expect(find("[data-testid='ref-name']")[:title]).to eq(source_branch)
|
2021-04-01 16:36:13 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|