debian-mirror-gitlab/spec/commands/sidekiq_cluster/cli_spec.rb

556 lines
19 KiB
Ruby
Raw Normal View History

2020-04-08 14:13:33 +05:30
# frozen_string_literal: true
require 'fast_spec_helper'
require 'rspec-parameterized'
2021-12-11 22:18:48 +05:30
require_relative '../../../sidekiq_cluster/cli'
2022-03-02 08:16:31 +05:30
RSpec.describe Gitlab::SidekiqCluster::CLI, stubbing_settings_source: true do # rubocop:disable RSpec/FilePath
2020-04-08 14:13:33 +05:30
let(:cli) { described_class.new('/dev/null') }
2021-12-11 22:18:48 +05:30
let(:timeout) { Gitlab::SidekiqCluster::DEFAULT_SOFT_TIMEOUT_SECONDS }
2020-04-08 14:13:33 +05:30
let(:default_options) do
2020-04-22 19:07:51 +05:30
{ env: 'test', directory: Dir.pwd, max_concurrency: 50, min_concurrency: 0, dryrun: false, timeout: timeout }
2020-04-08 14:13:33 +05:30
end
2022-01-26 12:08:38 +05:30
let(:sidekiq_exporter_enabled) { false }
let(:sidekiq_exporter_port) { '3807' }
let(:sidekiq_health_checks_port) { '3807' }
2022-03-02 08:16:31 +05:30
let(:config_file) { Tempfile.new('gitlab.yml') }
let(:config) do
{
'test' => {
'monitoring' => {
'sidekiq_exporter' => {
'address' => 'localhost',
'enabled' => sidekiq_exporter_enabled,
'port' => sidekiq_exporter_port
},
'sidekiq_health_checks' => {
'address' => 'localhost',
'enabled' => sidekiq_exporter_enabled,
'port' => sidekiq_health_checks_port
}
2022-01-26 12:08:38 +05:30
}
}
2022-03-02 08:16:31 +05:30
}
end
before do
stub_env('RAILS_ENV', 'test')
config_file.write(YAML.dump(config))
config_file.close
allow(::Settings).to receive(:source).and_return(config_file.path)
::Settings.reload!
end
after do
config_file.unlink
2020-04-08 14:13:33 +05:30
end
describe '#run' do
context 'without any arguments' do
it 'raises CommandError' do
expect { cli.run([]) }.to raise_error(described_class::CommandError)
end
end
context 'with arguments' do
before do
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
it 'starts the Sidekiq workers' do
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([['foo']], default_options)
.and_return([])
cli.run(%w(foo))
end
it 'allows the special * selector' do
worker_queues = %w(foo bar baz)
expect(Gitlab::SidekiqConfig::CliMethods)
.to receive(:worker_queues).and_return(worker_queues)
expect(Gitlab::SidekiqCluster)
.to receive(:start).with([worker_queues], default_options)
cli.run(%w(*))
end
2021-11-11 11:23:49 +05:30
it 'raises an error when the arguments contain newlines' do
invalid_arguments = [
["foo\n"],
["foo\r"],
%W[foo b\nar]
]
invalid_arguments.each do |arguments|
expect { cli.run(arguments) }.to raise_error(described_class::CommandError)
end
end
2020-04-08 14:13:33 +05:30
context 'with --negate flag' do
it 'starts Sidekiq workers for all queues in all_queues.yml except the ones in argv' do
expect(Gitlab::SidekiqConfig::CliMethods).to receive(:worker_queues).and_return(['baz'])
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([['baz']], default_options)
.and_return([])
cli.run(%w(foo -n))
end
end
context 'with --max-concurrency flag' do
it 'starts Sidekiq workers for specified queues with a max concurrency' do
expect(Gitlab::SidekiqConfig::CliMethods).to receive(:worker_queues).and_return(%w(foo bar baz))
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([%w(foo bar baz), %w(solo)], default_options.merge(max_concurrency: 2))
.and_return([])
cli.run(%w(foo,bar,baz solo -m 2))
end
end
context 'with --min-concurrency flag' do
it 'starts Sidekiq workers for specified queues with a min concurrency' do
expect(Gitlab::SidekiqConfig::CliMethods).to receive(:worker_queues).and_return(%w(foo bar baz))
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([%w(foo bar baz), %w(solo)], default_options.merge(min_concurrency: 2))
.and_return([])
cli.run(%w(foo,bar,baz solo --min-concurrency 2))
end
end
2021-10-27 15:23:28 +05:30
context 'with --timeout flag' do
2020-04-22 19:07:51 +05:30
it 'when given', 'starts Sidekiq workers with given timeout' do
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([['foo']], default_options.merge(timeout: 10))
cli.run(%w(foo --timeout 10))
end
it 'when not given', 'starts Sidekiq workers with default timeout' do
expect(Gitlab::SidekiqCluster).to receive(:start)
2021-12-11 22:18:48 +05:30
.with([['foo']], default_options.merge(timeout: Gitlab::SidekiqCluster::DEFAULT_SOFT_TIMEOUT_SECONDS))
2020-04-22 19:07:51 +05:30
cli.run(%w(foo))
end
end
2021-10-27 15:23:28 +05:30
context 'with --list-queues flag' do
it 'errors when given --list-queues and --dryrun' do
expect { cli.run(%w(foo --list-queues --dryrun)) }.to raise_error(described_class::CommandError)
end
it 'prints out a list of queues in alphabetical order' do
expected_queues = [
'epics:epics_update_epics_dates',
'epics_new_epic_issue',
'new_epic',
'todos_destroyer:todos_destroyer_confidential_epic'
]
allow(Gitlab::SidekiqConfig::CliMethods).to receive(:query_queues).and_return(expected_queues.shuffle)
expect(cli).to receive(:puts).with([expected_queues])
cli.run(%w(--queue-selector feature_category=epics --list-queues))
end
end
2020-04-08 14:13:33 +05:30
context 'queue namespace expansion' do
it 'starts Sidekiq workers for all queues in all_queues.yml with a namespace in argv' do
expect(Gitlab::SidekiqConfig::CliMethods).to receive(:worker_queues).and_return(['cronjob:foo', 'cronjob:bar'])
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([['cronjob', 'cronjob:foo', 'cronjob:bar']], default_options)
.and_return([])
cli.run(%w(cronjob))
end
end
2021-09-04 01:27:46 +05:30
context "with --queue-selector" do
where do
{
'memory-bound queues' => {
query: 'resource_boundary=memory',
included_queues: %w(project_export),
excluded_queues: %w(merge)
},
'memory- or CPU-bound queues' => {
query: 'resource_boundary=memory,cpu',
included_queues: %w(auto_merge:auto_merge_process project_export),
excluded_queues: %w(merge)
},
'high urgency CI queues' => {
query: 'feature_category=continuous_integration&urgency=high',
included_queues: %w(pipeline_cache:expire_job_cache pipeline_cache:expire_pipeline_cache),
excluded_queues: %w(merge)
},
'CPU-bound high urgency CI queues' => {
query: 'feature_category=continuous_integration&urgency=high&resource_boundary=cpu',
included_queues: %w(pipeline_cache:expire_pipeline_cache),
excluded_queues: %w(pipeline_cache:expire_job_cache merge)
},
'CPU-bound high urgency non-CI queues' => {
query: 'feature_category!=continuous_integration&urgency=high&resource_boundary=cpu',
included_queues: %w(new_issue),
excluded_queues: %w(pipeline_cache:expire_pipeline_cache)
},
'CI and SCM queues' => {
query: 'feature_category=continuous_integration|feature_category=source_code_management',
included_queues: %w(pipeline_cache:expire_job_cache merge),
excluded_queues: %w(mailers)
2021-01-29 00:20:46 +05:30
}
2021-09-04 01:27:46 +05:30
}
end
2021-01-29 00:20:46 +05:30
2021-09-04 01:27:46 +05:30
with_them do
it 'expands queues by attributes' do
expect(Gitlab::SidekiqCluster).to receive(:start) do |queues, opts|
expect(opts).to eq(default_options)
expect(queues.first).to include(*included_queues)
expect(queues.first).not_to include(*excluded_queues)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
[]
2020-04-08 14:13:33 +05:30
end
2021-09-04 01:27:46 +05:30
cli.run(%W(--queue-selector #{query}))
end
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
it 'works when negated' do
expect(Gitlab::SidekiqCluster).to receive(:start) do |queues, opts|
expect(opts).to eq(default_options)
expect(queues.first).not_to include(*included_queues)
expect(queues.first).to include(*excluded_queues)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
[]
2020-04-08 14:13:33 +05:30
end
2021-09-04 01:27:46 +05:30
cli.run(%W(--negate --queue-selector #{query}))
2020-04-08 14:13:33 +05:30
end
2021-09-04 01:27:46 +05:30
end
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
it 'expands multiple queue groups correctly' do
expect(Gitlab::SidekiqCluster)
.to receive(:start)
.with([['chat_notification'], ['project_export']], default_options)
.and_return([])
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
cli.run(%w(--queue-selector feature_category=chatops&has_external_dependencies=true resource_boundary=memory&feature_category=importers))
end
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
it 'allows the special * selector' do
worker_queues = %w(foo bar baz)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
expect(Gitlab::SidekiqConfig::CliMethods)
.to receive(:worker_queues).and_return(worker_queues)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
expect(Gitlab::SidekiqCluster)
.to receive(:start).with([worker_queues], default_options)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
cli.run(%w(--queue-selector *))
end
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
it 'errors when the selector matches no queues' do
expect(Gitlab::SidekiqCluster).not_to receive(:start)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
expect { cli.run(%w(--queue-selector has_external_dependencies=true&has_external_dependencies=false)) }
.to raise_error(described_class::CommandError)
end
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
it 'errors on an invalid query multiple queue groups correctly' do
expect(Gitlab::SidekiqCluster).not_to receive(:start)
2020-04-08 14:13:33 +05:30
2021-09-04 01:27:46 +05:30
expect { cli.run(%w(--queue-selector unknown_field=chatops)) }
.to raise_error(Gitlab::SidekiqConfig::WorkerMatcher::QueryError)
2020-04-08 14:13:33 +05:30
end
end
end
2022-01-26 12:08:38 +05:30
context 'metrics server' do
let(:trapped_signals) { described_class::TERMINATE_SIGNALS + described_class::FORWARD_SIGNALS }
let(:metrics_dir) { Dir.mktmpdir }
before do
stub_env('prometheus_multiproc_dir', metrics_dir)
end
after do
FileUtils.rm_rf(metrics_dir, secure: true)
end
context 'starting the server' do
context 'without --dryrun' do
context 'when there are no sidekiq_health_checks settings set' do
2022-03-02 08:16:31 +05:30
let(:sidekiq_exporter_enabled) { true }
2022-01-26 12:08:38 +05:30
2022-03-02 08:16:31 +05:30
before do
2022-01-26 12:08:38 +05:30
allow(Gitlab::SidekiqCluster).to receive(:start)
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
it 'does not start a sidekiq metrics server' do
expect(MetricsServer).not_to receive(:spawn)
cli.run(%w(foo))
end
end
context 'when the sidekiq_exporter.port setting is not set' do
2022-03-02 08:16:31 +05:30
let(:sidekiq_exporter_enabled) { true }
2022-01-26 12:08:38 +05:30
before do
2022-03-02 08:16:31 +05:30
allow(Gitlab::SidekiqCluster).to receive(:start)
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
it 'does not start a sidekiq metrics server' do
expect(MetricsServer).not_to receive(:spawn)
cli.run(%w(foo))
end
end
context 'when sidekiq_exporter.enabled setting is not set' do
let(:config) do
{
'test' => {
'monitoring' => {
'sidekiq_exporter' => {},
'sidekiq_health_checks' => {
'address' => 'localhost',
'enabled' => sidekiq_exporter_enabled,
'port' => sidekiq_health_checks_port
}
2022-01-26 12:08:38 +05:30
}
}
2022-03-02 08:16:31 +05:30
}
end
2022-01-26 12:08:38 +05:30
2022-03-02 08:16:31 +05:30
before do
2022-01-26 12:08:38 +05:30
allow(Gitlab::SidekiqCluster).to receive(:start)
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
it 'does not start a sidekiq metrics server' do
expect(MetricsServer).not_to receive(:spawn)
cli.run(%w(foo))
end
end
2022-03-02 08:16:31 +05:30
context 'with a blank sidekiq_exporter setting' do
let(:config) do
{
'test' => {
'monitoring' => {
'sidekiq_exporter' => nil,
'sidekiq_health_checks' => nil
2022-01-26 12:08:38 +05:30
}
}
2022-03-02 08:16:31 +05:30
}
end
2022-01-26 12:08:38 +05:30
2022-03-02 08:16:31 +05:30
before do
2022-01-26 12:08:38 +05:30
allow(Gitlab::SidekiqCluster).to receive(:start)
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
it 'does not start a sidekiq metrics server' do
expect(MetricsServer).not_to receive(:spawn)
cli.run(%w(foo))
end
2022-03-02 08:16:31 +05:30
it 'does not throw an error' do
expect { cli.run(%w(foo)) }.not_to raise_error
end
2022-01-26 12:08:38 +05:30
end
context 'with valid settings' do
using RSpec::Parameterized::TableSyntax
where(:sidekiq_exporter_enabled, :sidekiq_exporter_port, :sidekiq_health_checks_port, :start_metrics_server) do
true | '3807' | '3907' | true
true | '3807' | '3807' | false
false | '3807' | '3907' | false
false | '3807' | '3907' | false
end
with_them do
before do
allow(Gitlab::SidekiqCluster).to receive(:start)
allow(cli).to receive(:write_pid)
allow(cli).to receive(:trap_signals)
allow(cli).to receive(:start_loop)
end
specify do
if start_metrics_server
expect(MetricsServer).to receive(:spawn).with('sidekiq', metrics_dir: metrics_dir, wipe_metrics_dir: true, trapped_signals: trapped_signals)
else
expect(MetricsServer).not_to receive(:spawn)
end
cli.run(%w(foo))
end
end
end
end
context 'with --dryrun set' do
let(:sidekiq_exporter_enabled) { true }
it 'does not start the server' do
expect(MetricsServer).not_to receive(:spawn)
cli.run(%w(foo --dryrun))
end
end
end
context 'supervising the server' do
let(:sidekiq_exporter_enabled) { true }
let(:sidekiq_health_checks_port) { '3907' }
before do
allow(cli).to receive(:sleep).with(a_kind_of(Numeric))
allow(MetricsServer).to receive(:spawn).and_return(99)
cli.start_metrics_server
end
it 'stops the metrics server when one of the processes has been terminated' do
allow(Gitlab::ProcessManagement).to receive(:process_died?).and_return(false)
allow(Gitlab::ProcessManagement).to receive(:all_alive?).with(an_instance_of(Array)).and_return(false)
allow(Gitlab::ProcessManagement).to receive(:signal_processes).with(an_instance_of(Array), :TERM)
expect(Process).to receive(:kill).with(:TERM, 99)
cli.start_loop
end
it 'starts the metrics server when it is down' do
allow(Gitlab::ProcessManagement).to receive(:process_died?).and_return(true)
allow(Gitlab::ProcessManagement).to receive(:all_alive?).with(an_instance_of(Array)).and_return(false)
allow(cli).to receive(:stop_metrics_server)
expect(MetricsServer).to receive(:spawn).with(
'sidekiq', metrics_dir: metrics_dir, wipe_metrics_dir: false, trapped_signals: trapped_signals
)
cli.start_loop
end
end
end
2020-04-08 14:13:33 +05:30
end
describe '#write_pid' do
context 'when a PID is specified' do
it 'writes the PID to a file' do
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:write_pid).with('/dev/null')
2020-04-08 14:13:33 +05:30
cli.option_parser.parse!(%w(-P /dev/null))
cli.write_pid
end
end
context 'when no PID is specified' do
it 'does not write a PID' do
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).not_to receive(:write_pid)
2020-04-08 14:13:33 +05:30
cli.write_pid
end
end
end
describe '#wait_for_termination' do
it 'waits for termination of all sub-processes and succeeds after 3 checks' do
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:any_alive?)
2020-04-08 14:13:33 +05:30
.with(an_instance_of(Array)).and_return(true, true, true, false)
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:pids_alive)
2020-04-08 14:13:33 +05:30
.with([]).and_return([])
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:signal_processes)
2020-04-22 19:07:51 +05:30
.with([], "-KILL")
2020-04-08 14:13:33 +05:30
2021-12-11 22:18:48 +05:30
stub_const("Gitlab::SidekiqCluster::CHECK_TERMINATE_INTERVAL_SECONDS", 0.1)
2020-04-22 19:07:51 +05:30
allow(cli).to receive(:terminate_timeout_seconds) { 1 }
2020-04-08 14:13:33 +05:30
cli.wait_for_termination
end
context 'with hanging workers' do
before do
expect(cli).to receive(:write_pid)
expect(cli).to receive(:trap_signals)
expect(cli).to receive(:start_loop)
end
it 'hard kills workers after timeout expires' do
worker_pids = [101, 102, 103]
expect(Gitlab::SidekiqCluster).to receive(:start)
.with([['foo']], default_options)
.and_return(worker_pids)
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:any_alive?)
2020-04-08 14:13:33 +05:30
.with(worker_pids).and_return(true).at_least(10).times
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:pids_alive)
2020-04-08 14:13:33 +05:30
.with(worker_pids).and_return([102])
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:signal_processes)
2020-04-22 19:07:51 +05:30
.with([102], "-KILL")
2020-04-08 14:13:33 +05:30
cli.run(%w(foo))
2021-12-11 22:18:48 +05:30
stub_const("Gitlab::SidekiqCluster::CHECK_TERMINATE_INTERVAL_SECONDS", 0.1)
2020-04-22 19:07:51 +05:30
allow(cli).to receive(:terminate_timeout_seconds) { 1 }
2020-04-08 14:13:33 +05:30
cli.wait_for_termination
end
end
end
describe '#trap_signals' do
2022-01-26 12:08:38 +05:30
it 'traps termination and sidekiq specific signals' do
expect(Gitlab::ProcessManagement).to receive(:trap_signals).with(%i[INT TERM])
expect(Gitlab::ProcessManagement).to receive(:trap_signals).with(%i[TTIN USR1 USR2 HUP])
2020-04-08 14:13:33 +05:30
cli.trap_signals
end
end
describe '#start_loop' do
it 'runs until one of the processes has been terminated' do
allow(cli).to receive(:sleep).with(a_kind_of(Numeric))
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:all_alive?)
2020-04-08 14:13:33 +05:30
.with(an_instance_of(Array)).and_return(false)
2022-01-26 12:08:38 +05:30
expect(Gitlab::ProcessManagement).to receive(:signal_processes)
2020-04-08 14:13:33 +05:30
.with(an_instance_of(Array), :TERM)
cli.start_loop
end
end
end