2022-10-11 01:57:18 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe Gitlab::Metrics::GlobalSearchSlis do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
let(:error_rate_feature_flag_enabled) { true }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_feature_flags(global_search_error_rate_sli: error_rate_feature_flag_enabled)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#initialize_slis!' do
|
2022-11-25 23:54:43 +05:30
|
|
|
it 'initializes Apdex SLIs for global_search' do
|
|
|
|
expect(Gitlab::Metrics::Sli::Apdex).to receive(:initialize_sli).with(
|
|
|
|
:global_search,
|
|
|
|
a_kind_of(Array)
|
|
|
|
)
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
described_class.initialize_slis!
|
2022-10-11 01:57:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when global_search_error_rate_sli feature flag is enabled' do
|
|
|
|
let(:error_rate_feature_flag_enabled) { true }
|
|
|
|
|
|
|
|
it 'initializes ErrorRate SLIs for global_search' do
|
|
|
|
expect(Gitlab::Metrics::Sli::ErrorRate).to receive(:initialize_sli).with(
|
|
|
|
:global_search,
|
|
|
|
a_kind_of(Array)
|
|
|
|
)
|
|
|
|
|
|
|
|
described_class.initialize_slis!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when global_search_error_rate_sli feature flag is disabled' do
|
|
|
|
let(:error_rate_feature_flag_enabled) { false }
|
|
|
|
|
|
|
|
it 'does not initialize the ErrorRate SLIs for global_search' do
|
|
|
|
expect(Gitlab::Metrics::Sli::ErrorRate).not_to receive(:initialize_sli)
|
|
|
|
|
|
|
|
described_class.initialize_slis!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#record_apdex' do
|
2022-11-25 23:54:43 +05:30
|
|
|
where(:search_type, :code_search, :duration_target) do
|
2023-01-13 00:05:48 +05:30
|
|
|
'basic' | false | 8.812
|
|
|
|
'basic' | true | 27.538
|
|
|
|
'advanced' | false | 2.452
|
|
|
|
'advanced' | true | 15.52
|
2022-11-25 23:54:43 +05:30
|
|
|
end
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
with_them do
|
|
|
|
before do
|
|
|
|
allow(::Gitlab::ApplicationContext).to receive(:current_context_attribute).with(:caller_id).and_return('end')
|
|
|
|
end
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
let(:search_scope) { code_search ? 'blobs' : 'issues' }
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
it 'increments the global_search SLI as a success if the elapsed time is within the target' do
|
|
|
|
duration = duration_target - 0.1
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
expect(Gitlab::Metrics::Sli::Apdex[:global_search]).to receive(:increment).with(
|
|
|
|
labels: {
|
2022-10-11 01:57:18 +05:30
|
|
|
search_type: search_type,
|
|
|
|
search_level: 'global',
|
2022-11-25 23:54:43 +05:30
|
|
|
search_scope: search_scope,
|
|
|
|
endpoint_id: 'end'
|
|
|
|
},
|
|
|
|
success: true
|
|
|
|
)
|
|
|
|
|
|
|
|
described_class.record_apdex(
|
|
|
|
elapsed: duration,
|
|
|
|
search_type: search_type,
|
|
|
|
search_level: 'global',
|
|
|
|
search_scope: search_scope
|
|
|
|
)
|
2022-10-11 01:57:18 +05:30
|
|
|
end
|
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
it 'increments the global_search SLI as a failure if the elapsed time is not within the target' do
|
|
|
|
duration = duration_target + 0.1
|
2022-10-11 01:57:18 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
expect(Gitlab::Metrics::Sli::Apdex[:global_search]).to receive(:increment).with(
|
|
|
|
labels: {
|
|
|
|
search_type: search_type,
|
|
|
|
search_level: 'global',
|
|
|
|
search_scope: search_scope,
|
|
|
|
endpoint_id: 'end'
|
|
|
|
},
|
|
|
|
success: false
|
|
|
|
)
|
2022-10-11 01:57:18 +05:30
|
|
|
|
|
|
|
described_class.record_apdex(
|
2022-11-25 23:54:43 +05:30
|
|
|
elapsed: duration,
|
|
|
|
search_type: search_type,
|
2022-10-11 01:57:18 +05:30
|
|
|
search_level: 'global',
|
2022-11-25 23:54:43 +05:30
|
|
|
search_scope: search_scope
|
2022-10-11 01:57:18 +05:30
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#record_error_rate' do
|
|
|
|
context 'when global_search_error_rate_sli feature flag is enabled' do
|
|
|
|
let(:error_rate_feature_flag_enabled) { true }
|
|
|
|
|
|
|
|
it 'calls increment on the error rate SLI' do
|
|
|
|
expect(Gitlab::Metrics::Sli::ErrorRate[:global_search]).to receive(:increment)
|
|
|
|
|
|
|
|
described_class.record_error_rate(
|
|
|
|
error: true,
|
|
|
|
search_type: 'basic',
|
|
|
|
search_level: 'global',
|
|
|
|
search_scope: 'issues'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when global_search_error_rate_sli feature flag is disabled' do
|
|
|
|
let(:error_rate_feature_flag_enabled) { false }
|
|
|
|
|
|
|
|
it 'does not call increment on the error rate SLI' do
|
|
|
|
expect(Gitlab::Metrics::Sli::ErrorRate[:global_search]).not_to receive(:increment)
|
|
|
|
|
|
|
|
described_class.record_error_rate(
|
|
|
|
error: true,
|
|
|
|
search_type: 'basic',
|
|
|
|
search_level: 'global',
|
|
|
|
search_scope: 'issues'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|