debian-mirror-gitlab/spec/helpers/search_helper_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1203 lines
44 KiB
Ruby
Raw Normal View History

2019-12-21 20:55:43 +05:30
# frozen_string_literal: true
2014-09-02 18:07:02 +05:30
require 'spec_helper'
2023-03-04 22:38:38 +05:30
RSpec.describe SearchHelper, feature_category: :global_search do
2020-11-24 15:15:51 +05:30
include MarkupHelper
2022-03-02 08:16:31 +05:30
include BadgesHelper
2020-11-24 15:15:51 +05:30
2014-09-02 18:07:02 +05:30
# Override simple_sanitize for our testing purposes
def simple_sanitize(str)
str
end
2020-07-28 23:09:34 +05:30
describe 'search_autocomplete_opts' do
context "with no current user" do
before do
allow(self).to receive(:current_user).and_return(nil)
end
it "returns nil" do
expect(search_autocomplete_opts("q")).to be_nil
end
end
context "with a standard user" do
let(:user) { create(:user) }
before do
allow(self).to receive(:current_user).and_return(user)
end
it "includes Help sections" do
2021-01-03 14:25:43 +05:30
expect(search_autocomplete_opts("hel").size).to eq(8)
2020-07-28 23:09:34 +05:30
end
it "includes default sections" do
expect(search_autocomplete_opts("dash").size).to eq(1)
end
it "does not include admin sections" do
expect(search_autocomplete_opts("admin").size).to eq(0)
end
it "does not allow regular expression in search term" do
expect(search_autocomplete_opts("(webhooks|api)").size).to eq(0)
end
it "includes the user's groups" do
create(:group).add_owner(user)
expect(search_autocomplete_opts("gro").size).to eq(1)
end
it "includes nested group" do
create(:group, :nested, name: 'foo').add_owner(user)
expect(search_autocomplete_opts('foo').size).to eq(1)
end
it "includes the user's projects" do
project = create(:project, namespace: create(:namespace, owner: user))
expect(search_autocomplete_opts(project.name).size).to eq(1)
end
2023-03-04 22:38:38 +05:30
context 'for users' do
let_it_be(:another_user) { create(:user, name: 'Jane Doe') }
let(:term) { 'jane' }
it 'makes a call to SearchService' do
params = { search: term, per_page: 5, scope: 'users' }
expect(SearchService).to receive(:new).with(current_user, params).and_call_original
search_autocomplete_opts(term)
end
it 'returns users matching the term' do
result = search_autocomplete_opts(term)
expect(result.size).to eq(1)
expect(result.first[:id]).to eq(another_user.id)
end
context 'when current_user cannot read_users_list' do
before do
allow(Ability).to receive(:allowed?).and_return(true)
allow(Ability).to receive(:allowed?).with(current_user, :read_users_list).and_return(false)
end
it 'returns an empty array' do
expect(search_autocomplete_opts(term)).to eq([])
end
end
context 'with limiting' do
let!(:users) { create_list(:user, 6, name: 'Jane Doe') }
it 'only returns the first 5 users' do
result = search_autocomplete_opts(term)
expect(result.size).to eq(5)
end
end
end
2020-07-28 23:09:34 +05:30
it "includes the required project attrs" do
project = create(:project, namespace: create(:namespace, owner: user))
result = search_autocomplete_opts(project.name).first
expect(result.keys).to match_array(%i[category id value label url avatar_url])
end
it "includes the required group attrs" do
create(:group).add_owner(user)
result = search_autocomplete_opts("gro").first
2022-06-21 17:19:12 +05:30
expect(result.keys).to match_array(%i[category id value label url avatar_url])
2020-07-28 23:09:34 +05:30
end
2022-08-27 11:52:29 +05:30
it 'includes the users recently viewed issues and project with correct order', :aggregate_failures do
2020-11-24 15:15:51 +05:30
recent_issues = instance_double(::Gitlab::Search::RecentIssues)
expect(::Gitlab::Search::RecentIssues).to receive(:new).with(user: user).and_return(recent_issues)
project1 = create(:project, :with_avatar, namespace: user.namespace)
project2 = create(:project, namespace: user.namespace)
issue1 = create(:issue, title: 'issue 1', project: project1)
issue2 = create(:issue, title: 'issue 2', project: project2)
2022-08-27 11:52:29 +05:30
project = create(:project, title: 'the search term')
project.add_developer(user)
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
expect(recent_issues).to receive(:search).with('the search term').and_return(Issue.id_in_ordered([issue1.id, issue2.id]))
2020-11-24 15:15:51 +05:30
results = search_autocomplete_opts("the search term")
2022-08-27 11:52:29 +05:30
expect(results.count).to eq(3)
2020-11-24 15:15:51 +05:30
expect(results[0]).to include({
category: 'Recent issues',
id: issue1.id,
label: 'issue 1',
url: Gitlab::Routing.url_helpers.project_issue_path(issue1.project, issue1),
avatar_url: project1.avatar_url
})
expect(results[1]).to include({
category: 'Recent issues',
id: issue2.id,
label: 'issue 2',
url: Gitlab::Routing.url_helpers.project_issue_path(issue2.project, issue2),
avatar_url: '' # This project didn't have an avatar so set this to ''
})
2022-08-27 11:52:29 +05:30
expect(results[2]).to include({
category: 'Projects',
id: project.id,
label: project.full_name,
url: Gitlab::Routing.url_helpers.project_path(project)
})
2020-11-24 15:15:51 +05:30
end
2021-02-22 17:27:13 +05:30
it 'includes the users recently viewed issues with the exact same name', :aggregate_failures do
recent_issues = instance_double(::Gitlab::Search::RecentIssues)
expect(::Gitlab::Search::RecentIssues).to receive(:new).with(user: user).and_return(recent_issues)
project1 = create(:project, namespace: user.namespace)
project2 = create(:project, namespace: user.namespace)
issue1 = create(:issue, title: 'issue same_name', project: project1)
issue2 = create(:issue, title: 'issue same_name', project: project2)
expect(recent_issues).to receive(:search).with('the search term').and_return(Issue.id_in_ordered([issue1.id, issue2.id]))
results = search_autocomplete_opts("the search term")
expect(results.count).to eq(2)
expect(results[0]).to include({
category: 'Recent issues',
id: issue1.id,
label: 'issue same_name',
url: Gitlab::Routing.url_helpers.project_issue_path(issue1.project, issue1),
avatar_url: '' # This project didn't have an avatar so set this to ''
})
expect(results[1]).to include({
category: 'Recent issues',
id: issue2.id,
label: 'issue same_name',
url: Gitlab::Routing.url_helpers.project_issue_path(issue2.project, issue2),
avatar_url: '' # This project didn't have an avatar so set this to ''
})
end
2021-01-29 00:20:46 +05:30
it 'includes the users recently viewed merge requests', :aggregate_failures do
2020-11-24 15:15:51 +05:30
recent_merge_requests = instance_double(::Gitlab::Search::RecentMergeRequests)
expect(::Gitlab::Search::RecentMergeRequests).to receive(:new).with(user: user).and_return(recent_merge_requests)
project1 = create(:project, :with_avatar, namespace: user.namespace)
project2 = create(:project, namespace: user.namespace)
merge_request1 = create(:merge_request, :unique_branches, title: 'Merge request 1', target_project: project1, source_project: project1)
merge_request2 = create(:merge_request, :unique_branches, title: 'Merge request 2', target_project: project2, source_project: project2)
2021-01-03 14:25:43 +05:30
expect(recent_merge_requests).to receive(:search).with('the search term').and_return(MergeRequest.id_in_ordered([merge_request1.id, merge_request2.id]))
2020-11-24 15:15:51 +05:30
results = search_autocomplete_opts("the search term")
2021-01-03 14:25:43 +05:30
expect(results.count).to eq(2)
2020-11-24 15:15:51 +05:30
expect(results[0]).to include({
category: 'Recent merge requests',
id: merge_request1.id,
label: 'Merge request 1',
url: Gitlab::Routing.url_helpers.project_merge_request_path(merge_request1.project, merge_request1),
avatar_url: project1.avatar_url
})
expect(results[1]).to include({
category: 'Recent merge requests',
id: merge_request2.id,
label: 'Merge request 2',
url: Gitlab::Routing.url_helpers.project_merge_request_path(merge_request2.project, merge_request2),
avatar_url: '' # This project didn't have an avatar so set this to ''
})
end
2020-07-28 23:09:34 +05:30
it "does not include the public group" do
group = create(:group)
expect(search_autocomplete_opts(group.name).size).to eq(0)
end
context "with a current project" do
before do
@project = create(:project, :repository)
2021-12-07 22:27:20 +05:30
allow(self).to receive(:can?).and_return(true)
2021-01-29 00:20:46 +05:30
allow(self).to receive(:can?).with(user, :read_feature_flag, @project).and_return(false)
2020-07-28 23:09:34 +05:30
end
2021-12-07 22:27:20 +05:30
it 'returns repository related labels based on users abilities', :aggregate_failures do
2020-07-28 23:09:34 +05:30
expect(search_autocomplete_opts("Files").size).to eq(1)
expect(search_autocomplete_opts("Commits").size).to eq(1)
2021-12-07 22:27:20 +05:30
expect(search_autocomplete_opts("Network").size).to eq(1)
expect(search_autocomplete_opts("Graph").size).to eq(1)
2023-01-13 00:05:48 +05:30
allow(self).to receive(:can?).with(user, :read_code, @project).and_return(false)
2021-12-07 22:27:20 +05:30
expect(search_autocomplete_opts("Files").size).to eq(0)
expect(search_autocomplete_opts("Commits").size).to eq(0)
allow(self).to receive(:can?).with(user, :read_repository_graphs, @project).and_return(false)
expect(search_autocomplete_opts("Network").size).to eq(0)
expect(search_autocomplete_opts("Graph").size).to eq(0)
2020-07-28 23:09:34 +05:30
end
2021-01-29 00:20:46 +05:30
context 'when user does not have access to project' do
it 'does not include issues by iid' do
issue = create(:issue, project: @project)
results = search_autocomplete_opts("\##{issue.iid}")
expect(results.count).to eq(0)
end
end
context 'when user has project access' do
before do
@project = create(:project, :repository, namespace: user.namespace)
allow(self).to receive(:can?).with(user, :read_feature_flag, @project).and_return(true)
end
it 'includes issues by iid', :aggregate_failures do
issue = create(:issue, project: @project, title: 'test title')
results = search_autocomplete_opts("\##{issue.iid}")
expect(results.count).to eq(1)
expect(results.first).to include({
category: 'In this project',
id: issue.id,
label: 'test title (#1)',
url: ::Gitlab::Routing.url_helpers.project_issue_path(issue.project, issue),
avatar_url: '' # project has no avatar
})
end
end
2020-07-28 23:09:34 +05:30
end
end
context 'with an admin user' do
let(:admin) { create(:admin) }
before do
allow(self).to receive(:current_user).and_return(admin)
end
2023-03-17 16:20:25 +05:30
context 'when admin mode setting is disabled', :do_not_mock_admin_mode_setting do
it 'includes admin sections' do
expect(search_autocomplete_opts('admin').size).to eq(1)
end
end
context 'when admin mode setting is enabled' do
context 'when in admin mode', :enable_admin_mode do
it 'includes admin sections' do
expect(search_autocomplete_opts('admin').size).to eq(1)
end
end
context 'when not in admin mode' do
it 'does not include admin sections' do
expect(search_autocomplete_opts('admin').size).to eq(0)
end
end
2020-07-28 23:09:34 +05:30
end
end
end
2019-12-04 20:38:33 +05:30
describe 'search_entries_info' do
using RSpec::Parameterized::TableSyntax
where(:scope, :label) do
2019-12-21 20:55:43 +05:30
'blobs' | 'code result'
2019-12-04 20:38:33 +05:30
'commits' | 'commit'
'issues' | 'issue'
'merge_requests' | 'merge request'
'milestones' | 'milestone'
2019-12-21 20:55:43 +05:30
'notes' | 'comment'
2019-12-04 20:38:33 +05:30
'projects' | 'project'
'snippet_titles' | 'snippet'
'users' | 'user'
2019-12-21 20:55:43 +05:30
'wiki_blobs' | 'wiki result'
2019-12-04 20:38:33 +05:30
end
with_them do
it 'uses the correct singular label' do
collection = Kaminari.paginate_array([:foo]).page(1).per(10)
2021-11-18 22:05:49 +05:30
expect(search_entries_info(collection, scope, 'foo')).to eq("Showing 1 #{label} for <span>&nbsp;<code>foo</code>&nbsp;</span>")
2019-12-04 20:38:33 +05:30
end
it 'uses the correct plural label' do
collection = Kaminari.paginate_array([:foo] * 23).page(1).per(10)
2021-11-18 22:05:49 +05:30
expect(search_entries_info(collection, scope, 'foo')).to eq("Showing 1 - 10 of 23 #{label.pluralize} for <span>&nbsp;<code>foo</code>&nbsp;</span>")
2019-12-04 20:38:33 +05:30
end
end
it 'raises an error for unrecognized scopes' do
expect do
collection = Kaminari.paginate_array([:foo]).page(1).per(10)
search_entries_info(collection, 'unknown', 'foo')
end.to raise_error(RuntimeError)
end
end
2019-12-21 20:55:43 +05:30
describe 'search_entries_empty_message' do
2021-01-29 00:20:46 +05:30
let!(:group) { build(:group) }
let!(:project) { build(:project, group: group) }
context 'global search' do
let(:message) { search_entries_empty_message('projects', '<h1>foo</h1>', nil, nil) }
it 'returns the formatted entry message' do
expect(message).to eq("We couldn&#39;t find any projects matching <code>&lt;h1&gt;foo&lt;/h1&gt;</code>")
expect(message).to be_html_safe
end
end
context 'group search' do
let(:message) { search_entries_empty_message('projects', '<h1>foo</h1>', group, nil) }
2019-12-21 20:55:43 +05:30
2021-01-29 00:20:46 +05:30
it 'returns the formatted entry message' do
expect(message).to start_with('We couldn&#39;t find any projects matching <code>&lt;h1&gt;foo&lt;/h1&gt;</code> in group <a')
expect(message).to be_html_safe
end
end
context 'project search' do
let(:message) { search_entries_empty_message('projects', '<h1>foo</h1>', group, project) }
it 'returns the formatted entry message' do
expect(message).to start_with('We couldn&#39;t find any projects matching <code>&lt;h1&gt;foo&lt;/h1&gt;</code> in project <a')
expect(message).to be_html_safe
end
2019-12-21 20:55:43 +05:30
end
end
2017-09-10 17:25:29 +05:30
describe 'search_filter_input_options' do
context 'project' do
before do
@project = create(:project, :repository)
end
it 'includes id with type' do
expect(search_filter_input_options('type')[:id]).to eq('filtered-search-type')
end
it 'includes project-id' do
expect(search_filter_input_options('')[:data]['project-id']).to eq(@project.id)
end
2019-09-04 21:01:54 +05:30
it 'includes project endpoints' do
expect(search_filter_input_options('')[:data]['labels-endpoint']).to eq(project_labels_path(@project))
expect(search_filter_input_options('')[:data]['milestones-endpoint']).to eq(project_milestones_path(@project))
2019-12-26 22:10:19 +05:30
expect(search_filter_input_options('')[:data]['releases-endpoint']).to eq(project_releases_path(@project))
2017-09-10 17:25:29 +05:30
end
2018-03-17 18:26:18 +05:30
it 'includes autocomplete=off flag' do
expect(search_filter_input_options('')[:autocomplete]).to eq('off')
end
2017-09-10 17:25:29 +05:30
end
context 'group' do
before do
@group = create(:group, name: 'group')
end
it 'does not includes project-id' do
expect(search_filter_input_options('')[:data]['project-id']).to eq(nil)
end
2019-09-04 21:01:54 +05:30
it 'includes group endpoints' do
expect(search_filter_input_options('')[:data]['labels-endpoint']).to eq(group_labels_path(@group))
expect(search_filter_input_options('')[:data]['milestones-endpoint']).to eq(group_milestones_path(@group))
2017-09-10 17:25:29 +05:30
end
end
2019-02-15 15:39:39 +05:30
context 'dashboard' do
it 'does not include group-id and project-id' do
expect(search_filter_input_options('')[:data]['project-id']).to eq(nil)
expect(search_filter_input_options('')[:data]['group-id']).to eq(nil)
end
2019-09-04 21:01:54 +05:30
it 'includes dashboard endpoints' do
expect(search_filter_input_options('')[:data]['labels-endpoint']).to eq(dashboard_labels_path)
expect(search_filter_input_options('')[:data]['milestones-endpoint']).to eq(dashboard_milestones_path)
2019-02-15 15:39:39 +05:30
end
end
end
describe 'search_history_storage_prefix' do
context 'project' do
it 'returns project full_path' do
@project = create(:project, :repository)
expect(search_history_storage_prefix).to eq(@project.full_path)
end
end
context 'group' do
it 'returns group full_path' do
@group = create(:group, :nested, name: 'group-name')
expect(search_history_storage_prefix).to eq(@group.full_path)
end
end
context 'dashboard' do
it 'returns dashboard' do
expect(search_history_storage_prefix).to eq("dashboard")
end
end
2017-09-10 17:25:29 +05:30
end
2019-10-12 21:52:04 +05:30
2020-11-24 15:15:51 +05:30
describe 'search_md_sanitize' do
it 'does not do extra sql queries for partial markdown rendering' do
@project = create(:project)
description = FFaker::Lorem.characters(210)
control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) { search_md_sanitize(description) }.count
issues = create_list(:issue, 4, project: @project)
description_with_issues = description + ' ' + issues.map { |issue| "##{issue.iid}" }.join(' ')
expect { search_md_sanitize(description_with_issues) }.not_to exceed_all_query_limit(control_count)
end
end
2019-10-12 21:52:04 +05:30
describe 'search_filter_link' do
it 'renders a search filter link for the current scope' do
@scope = 'projects'
@search_results = double
expect(@search_results).to receive(:formatted_count).with('projects').and_return('23')
link = search_filter_link('projects', 'Projects')
expect(link).to have_css('li.active')
expect(link).to have_link('Projects', href: search_path(scope: 'projects'))
expect(link).to have_css('span.badge.badge-pill:not(.js-search-count):not(.hidden):not([data-url])', text: '23')
end
it 'renders a search filter link for another scope' do
link = search_filter_link('projects', 'Projects')
count_path = search_count_path(scope: 'projects')
expect(link).to have_css('li:not([class="active"])')
expect(link).to have_link('Projects', href: search_path(scope: 'projects'))
expect(link).to have_css("span.badge.badge-pill.js-search-count.hidden[data-url='#{count_path}']", text: '')
end
it 'merges in the current search params and given params' do
expect(self).to receive(:params).and_return(
ActionController::Parameters.new(
search: 'hello',
scope: 'ignored',
other_param: 'ignored'
)
)
link = search_filter_link('projects', 'Projects', search: { project_id: 23 })
expect(link).to have_link('Projects', href: search_path(scope: 'projects', search: 'hello', project_id: 23))
end
2021-01-29 00:20:46 +05:30
it 'restricts the params' do
expect(self).to receive(:params).and_return(
ActionController::Parameters.new(
search: 'hello',
unknown: 42
)
)
link = search_filter_link('projects', 'Projects')
expect(link).to have_link('Projects', href: search_path(scope: 'projects', search: 'hello'))
end
2019-10-12 21:52:04 +05:30
it 'assigns given data attributes on the list container' do
link = search_filter_link('projects', 'Projects', data: { foo: 'bar' })
expect(link).to have_css('li[data-foo="bar"]')
end
end
2019-12-26 22:10:19 +05:30
describe '#show_user_search_tab?' do
subject { show_user_search_tab? }
2022-06-21 17:19:12 +05:30
let(:current_user) { build(:user) }
before do
allow(self).to receive(:current_user).and_return(current_user)
end
2019-12-26 22:10:19 +05:30
context 'when project search' do
before do
@project = :some_project
expect(self).to receive(:project_search_tabs?)
.with(:members)
.and_return(:value)
end
it 'delegates to project_search_tabs?' do
expect(subject).to eq(:value)
end
end
2022-06-21 17:19:12 +05:30
context 'when group search' do
before do
@group = :some_group
end
2019-12-26 22:10:19 +05:30
context 'when current_user can read_users_list' do
before do
2022-06-21 17:19:12 +05:30
allow(self).to receive(:can?).with(current_user, :read_users_list).and_return(true)
2019-12-26 22:10:19 +05:30
end
it { is_expected.to eq(true) }
end
context 'when current_user cannot read_users_list' do
before do
2022-06-21 17:19:12 +05:30
allow(self).to receive(:can?).with(current_user, :read_users_list).and_return(false)
end
it { is_expected.to eq(false) }
end
end
context 'when global search' do
context 'when current_user can read_users_list' do
before do
allow(self).to receive(:can?).with(current_user, :read_users_list).and_return(true)
end
it { is_expected.to eq(true) }
context 'when global_search_user_tab feature flag is disabled' do
before do
stub_feature_flags(global_search_users_tab: false)
end
it { is_expected.to eq(false) }
end
end
context 'when current_user cannot read_users_list' do
before do
allow(self).to receive(:can?).with(current_user, :read_users_list).and_return(false)
2019-12-26 22:10:19 +05:30
end
it { is_expected.to eq(false) }
end
end
end
2021-01-03 14:25:43 +05:30
describe '#repository_ref' do
2022-07-23 23:45:48 +05:30
using RSpec::Parameterized::TableSyntax
2021-01-03 14:25:43 +05:30
let_it_be(:project) { create(:project, :repository) }
2021-04-29 21:17:54 +05:30
2022-07-23 23:45:48 +05:30
let(:default_branch) { project.default_branch }
let(:params) { { repository_ref: ref, project_id: project_id } }
2021-01-03 14:25:43 +05:30
subject { repository_ref(project) }
2022-07-23 23:45:48 +05:30
where(:project_id, :ref, :expected_ref) do
123 | 'ref-param' | 'ref-param'
123 | nil | ref(:default_branch)
123 | 111111 | '111111'
nil | 'ref-param' | ref(:default_branch)
2021-01-03 14:25:43 +05:30
end
2022-07-23 23:45:48 +05:30
with_them do
it 'returns expected_ref' do
expect(repository_ref(project)).to eq(expected_ref)
end
2021-01-03 14:25:43 +05:30
end
end
2021-01-29 00:20:46 +05:30
describe '#highlight_and_truncate_issuable' do
2021-01-03 14:25:43 +05:30
let(:description) { 'hello world' }
let(:issue) { create(:issue, description: description) }
let(:user) { create(:user) }
before do
allow(self).to receive(:current_user).and_return(user)
end
2021-01-29 00:20:46 +05:30
subject { highlight_and_truncate_issuable(issue, 'test', {}) }
2021-01-03 14:25:43 +05:30
context 'when description is not present' do
let(:description) { nil }
it 'does nothing' do
expect(self).not_to receive(:simple_search_highlight_and_truncate)
subject
end
end
context 'when description present' do
using RSpec::Parameterized::TableSyntax
where(:description, :expected) do
2021-02-22 17:27:13 +05:30
'test' | '<span class="gl-text-gray-900 gl-font-weight-bold">test</span>'
2021-04-17 20:07:23 +05:30
'<span style="color: blue;">this test should not be blue</span>' | 'this <span class="gl-text-gray-900 gl-font-weight-bold">test</span> should not be blue'
2021-02-22 17:27:13 +05:30
'<a href="#" onclick="alert(\'XSS\')">Click Me test</a>' | '<a href="#">Click Me <span class="gl-text-gray-900 gl-font-weight-bold">test</span></a>'
'<script type="text/javascript">alert(\'Another XSS\');</script> test' | ' <span class="gl-text-gray-900 gl-font-weight-bold">test</span>'
'Lorem test ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. Nulla consequat massa quis enim. Donec.' | 'Lorem <span class="gl-text-gray-900 gl-font-weight-bold">test</span> ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Don...'
2021-04-17 20:07:23 +05:30
'<img src="https://random.foo.com/test.png" width="128" height="128" />some image' | 'some image'
2023-01-13 00:05:48 +05:30
'<h2 data-sourcepos="11:1-11:26" dir="auto"><a id="user-content-additional-information" class="anchor" href="#additional-information" aria-hidden="true"></a>Additional information test:</h2><textarea data-update-url="/freepascal.org/fpc/source/-/issues/6163.json" dir="auto" data-testid="textarea" class="hidden js-task-list-field"></textarea>' | '<a class="anchor" href="#additional-information"></a>Additional information <span class="gl-text-gray-900 gl-font-weight-bold">test</span>:'
2021-01-03 14:25:43 +05:30
end
with_them do
it 'sanitizes, truncates, and highlights the search term' do
expect(subject).to eq(expected)
end
end
end
end
describe '#search_service' do
using RSpec::Parameterized::TableSyntax
subject { search_service }
before do
allow(self).to receive(:current_user).and_return(:the_current_user)
end
where(:confidential, :expected) do
'0' | false
'1' | true
'yes' | true
'no' | false
true | true
false | false
end
2022-10-11 01:57:18 +05:30
let(:params) { { confidential: confidential } }
2021-01-03 14:25:43 +05:30
with_them do
it 'transforms confidentiality param' do
expect(::SearchService).to receive(:new).with(:the_current_user, { confidential: expected })
subject
end
end
end
2021-01-29 00:20:46 +05:30
describe '#issuable_state_to_badge_class' do
context 'with merge request' do
it 'returns correct badge based on status' do
2021-04-17 20:07:23 +05:30
expect(issuable_state_to_badge_class(build(:merge_request, :merged))).to eq(:info)
2021-01-29 00:20:46 +05:30
expect(issuable_state_to_badge_class(build(:merge_request, :closed))).to eq(:danger)
expect(issuable_state_to_badge_class(build(:merge_request, :opened))).to eq(:success)
end
end
context 'with an issue' do
it 'returns correct badge based on status' do
expect(issuable_state_to_badge_class(build(:issue, :closed))).to eq(:info)
expect(issuable_state_to_badge_class(build(:issue, :opened))).to eq(:success)
end
end
end
describe '#issuable_state_text' do
context 'with merge request' do
it 'returns correct badge based on status' do
expect(issuable_state_text(build(:merge_request, :merged))).to eq(_('Merged'))
expect(issuable_state_text(build(:merge_request, :closed))).to eq(_('Closed'))
expect(issuable_state_text(build(:merge_request, :opened))).to eq(_('Open'))
end
end
context 'with an issue' do
it 'returns correct badge based on status' do
expect(issuable_state_text(build(:issue, :closed))).to eq(_('Closed'))
expect(issuable_state_text(build(:issue, :opened))).to eq(_('Open'))
end
end
end
2021-03-11 19:13:27 +05:30
describe '#search_sort_options' do
let(:user) { create(:user) }
mock_created_sort = [
{
title: _('Created date'),
sortable: true,
sortParam: {
asc: 'created_asc',
desc: 'created_desc'
}
},
{
2022-03-02 08:16:31 +05:30
title: _('Updated date'),
2021-03-11 19:13:27 +05:30
sortable: true,
sortParam: {
asc: 'updated_asc',
desc: 'updated_desc'
}
}
]
before do
allow(self).to receive(:current_user).and_return(user)
end
it 'returns the correct data' do
expect(search_sort_options).to eq(mock_created_sort)
end
end
2022-04-04 11:22:00 +05:30
describe '#header_search_context' do
let(:user) { create(:user) }
let(:can_download) { false }
2023-01-13 00:05:48 +05:30
let_it_be(:group) { nil }
let_it_be(:project) { nil }
2022-04-04 11:22:00 +05:30
let(:scope) { nil }
2023-01-13 00:05:48 +05:30
2022-04-04 11:22:00 +05:30
let(:ref) { nil }
2023-01-13 00:05:48 +05:30
let(:snippet) { nil }
2022-04-04 11:22:00 +05:30
before do
2023-01-13 00:05:48 +05:30
@project = project
@group = group
@ref = ref
@snippet = snippet
2022-04-04 11:22:00 +05:30
allow(self).to receive(:current_user).and_return(user)
2023-01-13 00:05:48 +05:30
allow(self).to receive(:search_scope).and_return(scope)
2022-04-04 11:22:00 +05:30
allow(self).to receive(:can?).and_return(can_download)
2023-01-13 00:05:48 +05:30
end
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
context 'no group or project data' do
it 'does not add :group, :group_metadata, or :scope to hash' do
expect(header_search_context[:group]).to eq(nil)
expect(header_search_context[:group_metadata]).to eq(nil)
expect(header_search_context[:scope]).to eq(nil)
end
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
it 'does not add :project, :project_metadata, :code_search, or :ref' do
expect(header_search_context[:project]).to eq(nil)
expect(header_search_context[:project_metadata]).to eq(nil)
expect(header_search_context[:code_search]).to eq(nil)
expect(header_search_context[:ref]).to eq(nil)
end
2022-04-04 11:22:00 +05:30
end
context 'group data' do
2023-01-13 00:05:48 +05:30
let_it_be(:group) { create(:group) }
let(:group_metadata) { { issues_path: issues_group_path(group), mr_path: merge_requests_group_path(group) } }
2022-04-04 11:22:00 +05:30
let(:scope) { 'issues' }
2023-01-13 00:05:48 +05:30
it 'adds the :group, :group_metadata, and :scope correctly to hash' do
expect(header_search_context[:group]).to eq({ id: group.id, name: group.name, full_name: group.full_name })
expect(header_search_context[:group_metadata]).to eq(group_metadata)
expect(header_search_context[:scope]).to eq(scope)
2022-04-04 11:22:00 +05:30
end
2023-01-13 00:05:48 +05:30
it 'does not add :project, :project_metadata, :code_search, or :ref' do
expect(header_search_context[:project]).to eq(nil)
expect(header_search_context[:project_metadata]).to eq(nil)
expect(header_search_context[:code_search]).to eq(nil)
expect(header_search_context[:ref]).to eq(nil)
2022-04-04 11:22:00 +05:30
end
end
context 'project data' do
2023-01-13 00:05:48 +05:30
let_it_be(:project_group) { create(:group) }
let_it_be(:project) { create(:project, group: project_group) }
let(:project_metadata) { { issues_path: project_issues_path(project), mr_path: project_merge_requests_path(project) } }
let(:group_metadata) { { issues_path: issues_group_path(project_group), mr_path: merge_requests_group_path(project_group) } }
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
it 'adds the :group and :group-metadata from the project correctly to hash' do
expect(header_search_context[:group]).to eq({ id: project_group.id, name: project_group.name, full_name: project_group.full_name })
expect(header_search_context[:group_metadata]).to eq(group_metadata)
end
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
it 'adds the :project and :project-metadata correctly to hash' do
expect(header_search_context[:project]).to eq({ id: project.id, name: project.name })
expect(header_search_context[:project_metadata]).to eq(project_metadata)
2022-04-04 11:22:00 +05:30
end
2023-01-13 00:05:48 +05:30
context 'with scope' do
let(:scope) { 'issues' }
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
it 'adds :scope and false :code_search to hash' do
expect(header_search_context[:scope]).to eq(scope)
expect(header_search_context[:code_search]).to eq(false)
2022-04-04 11:22:00 +05:30
end
2023-01-13 00:05:48 +05:30
end
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
context 'without scope' do
it 'adds code_search true to hash and not :scope' do
2022-04-04 11:22:00 +05:30
expect(header_search_context[:scope]).to eq(nil)
2023-01-13 00:05:48 +05:30
expect(header_search_context[:code_search]).to eq(true)
2022-04-04 11:22:00 +05:30
end
end
end
context 'ref data' do
2023-01-13 00:05:48 +05:30
let_it_be(:project) { create(:project) }
2022-04-04 11:22:00 +05:30
let(:ref) { 'test-branch' }
context 'when user can? download project data' do
let(:can_download) { true }
it 'adds the :ref correctly to hash' do
expect(header_search_context[:ref]).to eq(ref)
end
end
context 'when user cannot download project data' do
let(:can_download) { false }
it 'does not add the :ref to hash' do
expect(header_search_context[:ref]).to eq(nil)
end
end
end
2023-01-13 00:05:48 +05:30
context 'snippet' do
context 'when searching from snippets' do
let(:snippet) { create(:snippet) }
2022-04-04 11:22:00 +05:30
2023-01-13 00:05:48 +05:30
it 'adds :for_snippets true correctly to hash' do
expect(header_search_context[:for_snippets]).to eq(true)
2022-04-04 11:22:00 +05:30
end
end
2023-01-13 00:05:48 +05:30
context 'when not searching from snippets' do
it 'adds :for_snippets nil correctly to hash' do
expect(header_search_context[:for_snippets]).to eq(nil)
2022-04-04 11:22:00 +05:30
end
end
end
end
2022-11-25 23:54:43 +05:30
describe '.search_navigation' do
using RSpec::Parameterized::TableSyntax
let(:user) { build(:user) }
let_it_be(:project) { build(:project) }
before do
allow(self).to receive(:current_user).and_return(user)
allow(self).to receive(:can?).and_return(true)
allow(self).to receive(:project_search_tabs?).and_return(false)
allow(self).to receive(:feature_flag_tab_enabled?).and_return(false)
end
context 'projects' do
where(:global_project, :condition) do
nil | true
ref(:project) | false
end
with_them do
it 'data item condition is set correctly' do
@project = global_project
expect(search_navigation[:projects][:condition]).to eq(condition)
end
end
end
context 'code' do
2023-03-04 22:38:38 +05:30
where(:feature_flag_tab_enabled, :show_elasticsearch_tabs, :global_project, :project_search_tabs, :condition) do
false | false | nil | false | false
true | true | nil | true | true
true | false | nil | false | false
false | true | nil | false | false
false | false | ref(:project) | true | true
true | false | ref(:project) | false | false
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
2023-03-04 22:38:38 +05:30
@project = global_project
2022-11-25 23:54:43 +05:30
allow(search_service).to receive(:show_elasticsearch_tabs?).and_return(show_elasticsearch_tabs)
allow(self).to receive(:feature_flag_tab_enabled?).with(:global_search_code_tab).and_return(feature_flag_tab_enabled)
allow(self).to receive(:project_search_tabs?).with(:blobs).and_return(project_search_tabs)
expect(search_navigation[:blobs][:condition]).to eq(condition)
end
end
end
context 'issues' do
2023-03-04 22:38:38 +05:30
where(:project_search_tabs, :global_search_issues_tab, :condition) do
false | false | false
false | true | true
true | false | true
true | true | true
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
2023-03-04 22:38:38 +05:30
allow(self).to receive(:feature_flag_tab_enabled?).with(:global_search_issues_tab).and_return(global_search_issues_tab)
2022-11-25 23:54:43 +05:30
allow(self).to receive(:project_search_tabs?).with(:issues).and_return(project_search_tabs)
expect(search_navigation[:issues][:condition]).to eq(condition)
end
end
end
context 'merge requests' do
2023-03-04 22:38:38 +05:30
where(:project_search_tabs, :feature_flag_tab_enabled, :condition) do
false | false | false
true | false | true
false | true | true
true | true | true
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
allow(self).to receive(:feature_flag_tab_enabled?).with(:global_search_merge_requests_tab).and_return(feature_flag_tab_enabled)
allow(self).to receive(:project_search_tabs?).with(:merge_requests).and_return(project_search_tabs)
expect(search_navigation[:merge_requests][:condition]).to eq(condition)
end
end
end
context 'wiki' do
2023-03-04 22:38:38 +05:30
where(:global_search_wiki_tab, :show_elasticsearch_tabs, :global_project, :project_search_tabs, :condition) do
false | false | nil | true | true
false | false | nil | false | false
false | true | nil | false | false
true | false | nil | false | false
true | true | ref(:project) | false | false
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
2023-03-04 22:38:38 +05:30
@project = global_project
2022-11-25 23:54:43 +05:30
allow(search_service).to receive(:show_elasticsearch_tabs?).and_return(show_elasticsearch_tabs)
2023-03-04 22:38:38 +05:30
allow(self).to receive(:feature_flag_tab_enabled?).with(:global_search_wiki_tab).and_return(global_search_wiki_tab)
2022-11-25 23:54:43 +05:30
allow(self).to receive(:project_search_tabs?).with(:wiki).and_return(project_search_tabs)
expect(search_navigation[:wiki_blobs][:condition]).to eq(condition)
end
end
end
context 'commits' do
2023-03-04 22:38:38 +05:30
where(:global_search_commits_tab, :show_elasticsearch_tabs, :global_project, :project_search_tabs, :condition) do
false | false | nil | true | true
false | false | nil | false | false
false | true | nil | false | false
true | false | nil | false | false
true | true | ref(:project) | false | false
true | true | nil | false | true
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
2023-03-04 22:38:38 +05:30
@project = global_project
2022-11-25 23:54:43 +05:30
allow(search_service).to receive(:show_elasticsearch_tabs?).and_return(show_elasticsearch_tabs)
2023-03-04 22:38:38 +05:30
allow(self).to receive(:feature_flag_tab_enabled?).with(:global_search_commits_tab).and_return(global_search_commits_tab)
2022-11-25 23:54:43 +05:30
allow(self).to receive(:project_search_tabs?).with(:commits).and_return(project_search_tabs)
expect(search_navigation[:commits][:condition]).to eq(condition)
end
end
end
context 'comments' do
2023-03-04 22:38:38 +05:30
where(:project_search_tabs, :show_elasticsearch_tabs, :condition) do
true | true | true
false | false | false
false | true | true
true | false | true
2022-11-25 23:54:43 +05:30
end
with_them do
it 'data item condition is set correctly' do
allow(search_service).to receive(:show_elasticsearch_tabs?).and_return(show_elasticsearch_tabs)
allow(self).to receive(:project_search_tabs?).with(:notes).and_return(project_search_tabs)
expect(search_navigation[:notes][:condition]).to eq(condition)
end
end
end
context 'milestones' do
where(:global_project, :project_search_tabs, :condition) do
ref(:project) | true | true
nil | false | true
ref(:project) | false | false
nil | true | true
end
with_them do
it 'data item condition is set correctly' do
@project = global_project
allow(self).to receive(:project_search_tabs?).with(:milestones).and_return(project_search_tabs)
expect(search_navigation[:milestones][:condition]).to eq(condition)
end
end
end
context 'users' do
where(:show_user_search_tab, :condition) do
true | true
false | false
end
with_them do
it 'data item condition is set correctly' do
allow(self).to receive(:show_user_search_tab?).and_return(show_user_search_tab)
expect(search_navigation[:users][:condition]).to eq(condition)
end
end
end
context 'snippet_titles' do
where(:global_project, :global_show_snippets, :condition) do
ref(:project) | true | false
nil | false | false
ref(:project) | false | false
nil | true | true
end
with_them do
it 'data item condition is set correctly' do
2023-03-04 22:38:38 +05:30
allow(search_service).to receive(:show_snippets?).and_return(global_show_snippets)
2022-11-25 23:54:43 +05:30
@project = global_project
expect(search_navigation[:snippet_titles][:condition]).to eq(condition)
end
end
end
end
describe '.search_navigation_json' do
using RSpec::Parameterized::TableSyntax
2023-01-13 00:05:48 +05:30
2022-11-25 23:54:43 +05:30
context 'with data' do
example_data_1 = {
projects: { label: _("Projects"), condition: true },
blobs: { label: _("Code"), condition: false }
}
example_data_2 = {
projects: { label: _("Projects"), condition: false },
blobs: { label: _("Code"), condition: false }
}
example_data_3 = {
projects: { label: _("Projects"), condition: true },
blobs: { label: _("Code"), condition: true },
epics: { label: _("Epics"), condition: true }
}
where(:data, :matcher) do
2023-01-13 00:05:48 +05:30
example_data_1 | -> { include("projects") }
example_data_2 | -> { eq("{}") }
example_data_3 | -> { include("projects", "blobs", "epics") }
2022-11-25 23:54:43 +05:30
end
with_them do
2023-01-13 00:05:48 +05:30
it 'renders data correctly' do
2022-11-25 23:54:43 +05:30
allow(self).to receive(:search_navigation).with(no_args).and_return(data)
expect(search_navigation_json).to instance_exec(&matcher)
end
end
end
end
2023-01-13 00:05:48 +05:30
describe '.search_navigation_json with .search_navigation' do
before do
allow(self).to receive(:current_user).and_return(build(:user))
allow(self).to receive(:can?).and_return(true)
allow(self).to receive(:project_search_tabs?).and_return(true)
allow(self).to receive(:feature_flag_tab_enabled?).and_return(true)
allow(self).to receive(:feature_flag_tab_enabled?).and_return(true)
2023-03-04 22:38:38 +05:30
allow(search_service).to receive(:show_elasticsearch_tabs?).and_return(true)
allow(search_service).to receive(:show_snippets?).and_return(true)
2023-01-13 00:05:48 +05:30
@project = nil
end
it 'test search navigation item order for CE all options enabled' do
expect(Gitlab::Json.parse(search_navigation_json).keys).to eq(%w[projects blobs issues merge_requests wiki_blobs commits notes milestones users snippet_titles])
end
end
2022-11-25 23:54:43 +05:30
describe '.search_filter_link_json' do
using RSpec::Parameterized::TableSyntax
context 'data' do
where(:scope, :label, :data, :search, :active_scope) do
"projects" | "Projects" | { qa_selector: 'projects_tab' } | nil | "projects"
"snippet_titles" | "Titles and Descriptions" | nil | { snippets: "test" } | "code"
"projects" | "Projects" | { qa_selector: 'projects_tab' } | nil | "issue"
"snippet_titles" | "Titles and Descriptions" | nil | { snippets: "test" } | "snippet_titles"
end
with_them do
it 'converts correctly' do
@timeout = false
@scope = active_scope
@search_results = double
dummy_count = 1000
allow(self).to receive(:search_path).with(any_args).and_return("link test")
allow(@search_results).to receive(:formatted_count).with(scope).and_return(dummy_count)
allow(self).to receive(:search_count_path).with(any_args).and_return("test count link")
current_scope = scope == active_scope
expected = {
label: label,
scope: scope,
data: data,
link: "link test",
active: current_scope
}
expected[:count] = dummy_count if current_scope
expected[:count_link] = "test count link" unless current_scope
expect(search_filter_link_json(scope, label, data, search)).to eq(expected)
end
end
end
end
describe 'show_elasticsearch_tabs' do
subject { search_service.show_elasticsearch_tabs? }
let(:user) { build(:user) }
before do
allow(self).to receive(:current_user).and_return(user)
end
it { is_expected.to eq(false) }
end
describe 'show_epics' do
subject { search_service.show_epics? }
let(:user) { build(:user) }
before do
allow(self).to receive(:current_user).and_return(user)
end
it { is_expected.to eq(false) }
end
2014-09-02 18:07:02 +05:30
end