2021-01-29 00:20:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe 'Query.project(fullPath).pipelines' do
|
|
|
|
include GraphqlHelpers
|
|
|
|
|
|
|
|
let_it_be(:project) { create(:project, :repository, :public) }
|
2021-03-08 18:12:59 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
around do |example|
|
|
|
|
travel_to(Time.current) { example.run }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'duration fields' do
|
|
|
|
let_it_be(:pipeline) do
|
|
|
|
create(:ci_pipeline, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:query_path) do
|
|
|
|
[
|
|
|
|
[:project, { full_path: project.full_path }],
|
|
|
|
[:pipelines],
|
|
|
|
[:nodes]
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
wrap_fields(query_graphql_path(query_path, 'queuedDuration duration'))
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
pipeline.update!(
|
|
|
|
created_at: 1.minute.ago,
|
|
|
|
started_at: 55.seconds.ago
|
|
|
|
)
|
|
|
|
create(:ci_build, :success,
|
|
|
|
pipeline: pipeline,
|
|
|
|
started_at: 55.seconds.ago,
|
|
|
|
finished_at: 10.seconds.ago)
|
|
|
|
pipeline.update_duration
|
|
|
|
pipeline.save!
|
|
|
|
|
|
|
|
post_graphql(query, current_user: user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the duration fields' do
|
|
|
|
path = query_path.map(&:first)
|
|
|
|
expect(graphql_data_at(*path, :queued_duration)).to eq [5.0]
|
|
|
|
expect(graphql_data_at(*path, :duration)).to eq [45]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.stages' do
|
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
|
|
|
let_it_be(:pipeline) { create(:ci_empty_pipeline, project: project) }
|
|
|
|
let_it_be(:stage) { create(:ci_stage_entity, pipeline: pipeline, project: project) }
|
|
|
|
let_it_be(:other_stage) { create(:ci_stage_entity, pipeline: pipeline, project: project, name: 'other') }
|
|
|
|
|
|
|
|
let(:first_n) { var('Int') }
|
|
|
|
let(:query_path) do
|
|
|
|
[
|
|
|
|
[:project, { full_path: project.full_path }],
|
|
|
|
[:pipelines],
|
|
|
|
[:nodes],
|
|
|
|
[:stages, { first: first_n }],
|
|
|
|
[:nodes]
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
with_signature([first_n], wrap_fields(query_graphql_path(query_path, :name)))
|
|
|
|
end
|
|
|
|
|
|
|
|
before_all do
|
|
|
|
# see app/services/ci/ensure_stage_service.rb to explain why we use stage_id
|
|
|
|
create(:ci_build, pipeline: pipeline, stage_id: stage.id, name: 'linux: [foo]')
|
|
|
|
create(:ci_build, pipeline: pipeline, stage_id: stage.id, name: 'linux: [bar]')
|
|
|
|
create(:ci_build, pipeline: pipeline, stage_id: other_stage.id, name: 'linux: [baz]')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is null if the user is a guest' do
|
|
|
|
project.add_guest(user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: user, variables: first_n.with(1))
|
|
|
|
|
|
|
|
expect(graphql_data_at(:project, :pipelines, :nodes)).to contain_exactly a_hash_including('stages' => be_nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is present if the user has reporter access' do
|
|
|
|
project.add_reporter(user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: user)
|
|
|
|
|
|
|
|
expect(graphql_data_at(:project, :pipelines, :nodes, :stages, :nodes, :name))
|
|
|
|
.to contain_exactly(eq(stage.name), eq(other_stage.name))
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.groups' do
|
|
|
|
let(:query_path) do
|
|
|
|
[
|
|
|
|
[:project, { full_path: project.full_path }],
|
|
|
|
[:pipelines],
|
|
|
|
[:nodes],
|
|
|
|
[:stages],
|
|
|
|
[:nodes],
|
|
|
|
[:groups],
|
|
|
|
[:nodes]
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
wrap_fields(query_graphql_path(query_path, :name))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is empty if the user is a guest' do
|
|
|
|
project.add_guest(user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: user)
|
|
|
|
|
|
|
|
expect(graphql_data_at(:project, :pipelines, :nodes, :stages, :nodes, :groups)).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is present if the user has reporter access' do
|
|
|
|
project.add_reporter(user)
|
|
|
|
|
|
|
|
post_graphql(query, current_user: user)
|
|
|
|
|
|
|
|
expect(graphql_data_at(:project, :pipelines, :nodes, :stages, :nodes, :groups, :nodes, :name))
|
|
|
|
.to contain_exactly('linux', 'linux')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
describe '.jobs' do
|
2021-03-08 18:12:59 +05:30
|
|
|
let(:first_n) { var('Int') }
|
|
|
|
let(:query_path) do
|
|
|
|
[
|
|
|
|
[:project, { full_path: project.full_path }],
|
|
|
|
[:pipelines, { first: first_n }],
|
|
|
|
[:nodes],
|
|
|
|
[:jobs],
|
|
|
|
[:nodes]
|
|
|
|
]
|
2021-01-29 00:20:46 +05:30
|
|
|
end
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
let(:query) do
|
|
|
|
with_signature([first_n], wrap_fields(query_graphql_path(query_path, :name)))
|
|
|
|
end
|
|
|
|
|
|
|
|
before_all do
|
2021-01-29 00:20:46 +05:30
|
|
|
pipeline = create(:ci_pipeline, project: project)
|
|
|
|
create(:ci_build, pipeline: pipeline, name: 'Job 1')
|
|
|
|
pipeline = create(:ci_pipeline, project: project)
|
|
|
|
create(:ci_build, pipeline: pipeline, name: 'Job 2')
|
2021-03-08 18:12:59 +05:30
|
|
|
end
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
it 'limits the results' do
|
|
|
|
post_graphql(query, current_user: user, variables: first_n.with(1))
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
expect(graphql_data_at(*query_path.map(&:first))).to contain_exactly a_hash_including(
|
|
|
|
'name' => 'Job 2'
|
|
|
|
)
|
|
|
|
end
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
it 'fetches all results' do
|
|
|
|
post_graphql(query, current_user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
expect(graphql_data_at(*query_path.map(&:first))).to contain_exactly(
|
|
|
|
a_hash_including('name' => 'Job 1'),
|
|
|
|
a_hash_including('name' => 'Job 2')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'fetches the jobs without an N+1' do
|
|
|
|
first_user = create(:personal_access_token).user
|
|
|
|
second_user = create(:personal_access_token).user
|
|
|
|
|
|
|
|
control_count = ActiveRecord::QueryRecorder.new do
|
|
|
|
post_graphql(query, current_user: first_user, variables: first_n.with(1))
|
|
|
|
end
|
2021-01-29 00:20:46 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
expect do
|
|
|
|
post_graphql(query, current_user: second_user)
|
|
|
|
end.not_to exceed_query_limit(control_count)
|
2021-01-29 00:20:46 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.jobs(securityReportTypes)' do
|
|
|
|
let_it_be(:query) do
|
|
|
|
%(
|
|
|
|
query {
|
|
|
|
project(fullPath: "#{project.full_path}") {
|
|
|
|
pipelines {
|
|
|
|
nodes {
|
|
|
|
jobs(securityReportTypes: [SAST]) {
|
|
|
|
nodes {
|
|
|
|
name
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'fetches the jobs matching the report type filter' do
|
|
|
|
pipeline = create(:ci_pipeline, project: project)
|
|
|
|
create(:ci_build, :dast, name: 'DAST Job 1', pipeline: pipeline)
|
|
|
|
create(:ci_build, :sast, name: 'SAST Job 1', pipeline: pipeline)
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
post_graphql(query, current_user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
|
|
|
|
pipelines_data = graphql_data.dig('project', 'pipelines', 'nodes')
|
|
|
|
|
|
|
|
job_names = pipelines_data.map do |pipeline_data|
|
|
|
|
jobs_data = pipeline_data.dig('jobs', 'nodes')
|
|
|
|
jobs_data.map { |job_data| job_data['name'] }
|
|
|
|
end.flatten
|
|
|
|
|
|
|
|
expect(job_names).to contain_exactly('SAST Job 1')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'upstream' do
|
2021-03-08 18:12:59 +05:30
|
|
|
let_it_be(:pipeline) { create(:ci_pipeline, project: project, user: user) }
|
2021-01-29 00:20:46 +05:30
|
|
|
let_it_be(:upstream_project) { create(:project, :repository, :public) }
|
2021-03-08 18:12:59 +05:30
|
|
|
let_it_be(:upstream_pipeline) { create(:ci_pipeline, project: upstream_project, user: user) }
|
2021-09-30 23:02:18 +05:30
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
let(:upstream_pipelines_graphql_data) { graphql_data.dig(*%w[project pipelines nodes]).first['upstream'] }
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
%(
|
|
|
|
query {
|
|
|
|
project(fullPath: "#{project.full_path}") {
|
|
|
|
pipelines {
|
|
|
|
nodes {
|
|
|
|
upstream {
|
|
|
|
iid
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:ci_sources_pipeline, source_pipeline: upstream_pipeline, pipeline: pipeline )
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
post_graphql(query, current_user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a working graphql query'
|
|
|
|
|
|
|
|
it 'returns the upstream pipeline of a pipeline' do
|
|
|
|
expect(upstream_pipelines_graphql_data['iid'].to_i).to eq(upstream_pipeline.iid)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when fetching the upstream pipeline from the pipeline' do
|
|
|
|
it 'avoids N+1 queries' do
|
2021-03-08 18:12:59 +05:30
|
|
|
first_user = create(:user)
|
|
|
|
second_user = create(:user)
|
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
control_count = ActiveRecord::QueryRecorder.new do
|
|
|
|
post_graphql(query, current_user: first_user)
|
|
|
|
end
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
pipeline_2 = create(:ci_pipeline, project: project, user: user)
|
|
|
|
upstream_pipeline_2 = create(:ci_pipeline, project: upstream_project, user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
create(:ci_sources_pipeline, source_pipeline: upstream_pipeline_2, pipeline: pipeline_2 )
|
2021-03-08 18:12:59 +05:30
|
|
|
pipeline_3 = create(:ci_pipeline, project: project, user: user)
|
|
|
|
upstream_pipeline_3 = create(:ci_pipeline, project: upstream_project, user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
create(:ci_sources_pipeline, source_pipeline: upstream_pipeline_3, pipeline: pipeline_3 )
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post_graphql(query, current_user: second_user)
|
|
|
|
end.not_to exceed_query_limit(control_count)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'downstream' do
|
2021-03-08 18:12:59 +05:30
|
|
|
let_it_be(:pipeline) { create(:ci_pipeline, project: project, user: user) }
|
|
|
|
let(:pipeline_2) { create(:ci_pipeline, project: project, user: user) }
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
let_it_be(:downstream_project) { create(:project, :repository, :public) }
|
2021-03-08 18:12:59 +05:30
|
|
|
let_it_be(:downstream_pipeline_a) { create(:ci_pipeline, project: downstream_project, user: user) }
|
|
|
|
let_it_be(:downstream_pipeline_b) { create(:ci_pipeline, project: downstream_project, user: user) }
|
2021-01-29 00:20:46 +05:30
|
|
|
|
|
|
|
let(:pipelines_graphql_data) { graphql_data.dig(*%w[project pipelines nodes]) }
|
|
|
|
|
|
|
|
let(:query) do
|
|
|
|
%(
|
|
|
|
query {
|
|
|
|
project(fullPath: "#{project.full_path}") {
|
|
|
|
pipelines {
|
|
|
|
nodes {
|
|
|
|
downstream {
|
|
|
|
nodes {
|
|
|
|
iid
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline, pipeline: downstream_pipeline_a)
|
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline_2, pipeline: downstream_pipeline_b)
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
post_graphql(query, current_user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a working graphql query'
|
|
|
|
|
|
|
|
it 'returns the downstream pipelines of a pipeline' do
|
|
|
|
downstream_pipelines_graphql_data = pipelines_graphql_data.map { |pip| pip['downstream']['nodes'] }.flatten
|
|
|
|
|
|
|
|
expect(
|
|
|
|
downstream_pipelines_graphql_data.map { |pip| pip['iid'].to_i }
|
|
|
|
).to contain_exactly(downstream_pipeline_a.iid, downstream_pipeline_b.iid)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when fetching the downstream pipelines from the pipeline' do
|
|
|
|
it 'avoids N+1 queries' do
|
2021-03-08 18:12:59 +05:30
|
|
|
first_user = create(:user)
|
|
|
|
second_user = create(:user)
|
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
control_count = ActiveRecord::QueryRecorder.new do
|
|
|
|
post_graphql(query, current_user: first_user)
|
|
|
|
end
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
downstream_pipeline_2a = create(:ci_pipeline, project: downstream_project, user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline, pipeline: downstream_pipeline_2a)
|
2021-03-08 18:12:59 +05:30
|
|
|
downsteam_pipeline_3a = create(:ci_pipeline, project: downstream_project, user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline, pipeline: downsteam_pipeline_3a)
|
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
downstream_pipeline_2b = create(:ci_pipeline, project: downstream_project, user: user)
|
2021-01-29 00:20:46 +05:30
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline_2, pipeline: downstream_pipeline_2b)
|
|
|
|
downsteam_pipeline_3b = create(:ci_pipeline, project: downstream_project, user: first_user)
|
|
|
|
create(:ci_sources_pipeline, source_pipeline: pipeline_2, pipeline: downsteam_pipeline_3b)
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post_graphql(query, current_user: second_user)
|
|
|
|
end.not_to exceed_query_limit(control_count)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|