debian-mirror-gitlab/doc/user/project/code_owners.md

340 lines
12 KiB
Markdown
Raw Normal View History

2019-12-21 20:55:43 +05:30
---
2020-10-24 23:57:45 +05:30
stage: Create
group: Source Code
2021-02-22 17:27:13 +05:30
info: "To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments"
2019-12-21 20:55:43 +05:30
type: reference
---
2021-03-11 19:13:27 +05:30
# Code Owners **(PREMIUM)**
2019-07-31 22:56:46 +05:30
2021-03-11 19:13:27 +05:30
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/6916) in GitLab 11.3.
> - Code Owners for Merge Request approvals was [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/4418) in GitLab Premium 11.9.
> - Moved to GitLab Premium in 13.9.
2019-07-31 22:56:46 +05:30
2021-09-30 23:02:18 +05:30
Code Owners define who owns specific files or paths in a repository.
You can require that Code Owners approve a merge request before it's merged.
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
Code Owners help you determine who should review or approve merge requests.
If you have a question about a file or feature, Code Owners
can help you find someone who knows the answer.
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
If you don't want to use Code Owners for approvals, you can
[configure rules](merge_requests/approvals/rules.md) instead.
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
## Set up Code Owners
2021-06-08 01:23:25 +05:30
2021-09-30 23:02:18 +05:30
You can specify users or [shared groups](members/share_project_with_groups.md)
that are responsible for specific files and directories in a repository.
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
To set up Code Owners:
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
1. Choose the location where you want to specify Code Owners:
- In the root directory of the repository
- In the `.gitlab/` directory
- In the `docs/` directory
2020-05-24 23:13:21 +05:30
2021-09-30 23:02:18 +05:30
1. In that location, create a file named `CODEOWNERS`.
1. In the file, enter text that follows one of these patterns:
```plaintext
# A member as Code Owner of a file
filename @username
# A member as Code Owner of a directory
directory @username
2019-07-31 22:56:46 +05:30
2021-09-30 23:02:18 +05:30
# All group members as Code Owners of a file
filename @groupname
2019-07-31 22:56:46 +05:30
2021-09-30 23:02:18 +05:30
# All group members as Code Owners of a directory
directory @groupname
```
2019-07-31 22:56:46 +05:30
2021-09-30 23:02:18 +05:30
The Code Owners are displayed in the UI by the files or directory they apply to.
These owners apply to this branch only. When you add new files to the repository,
you should update the `CODEOWNERS` file.
2021-01-29 00:20:46 +05:30
2021-09-30 23:02:18 +05:30
## When a file matches multiple `CODEOWNERS` entries
2019-07-31 22:56:46 +05:30
When a file matches multiple entries in the `CODEOWNERS` file,
2021-09-30 23:02:18 +05:30
the users from last pattern matching the file are used.
For example, in the following `CODEOWNERS` file:
2020-04-08 14:13:33 +05:30
2020-04-22 19:07:51 +05:30
```plaintext
2020-04-08 14:13:33 +05:30
README.md @user1
# This line would also match the file README.md
*.md @user2
```
The user that would show for `README.md` would be `@user2`.
2019-07-31 22:56:46 +05:30
2019-12-21 20:55:43 +05:30
## Approvals by Code Owners
2021-03-11 19:13:27 +05:30
After you've added Code Owners to a project, you can configure it to
2020-05-24 23:13:21 +05:30
be used for merge request approvals:
2019-12-21 20:55:43 +05:30
2021-06-08 01:23:25 +05:30
- As [merge request eligible approvers](merge_requests/approvals/rules.md#code-owners-as-eligible-approvers).
2021-09-30 23:02:18 +05:30
- As required approvers for [protected branches](protected_branches.md#require-code-owner-approval-on-a-protected-branch). **(PREMIUM)**
2019-12-21 20:55:43 +05:30
2021-03-11 19:13:27 +05:30
Developer or higher [permissions](../permissions.md) are required to
2020-06-23 00:09:42 +05:30
approve a merge request.
2021-03-11 19:13:27 +05:30
After it's set, Code Owners are displayed in merge request widgets:
2019-12-21 20:55:43 +05:30
![MR widget - Code Owners](img/code_owners_mr_widget_v12_4.png)
2021-03-11 19:13:27 +05:30
While you can use the `CODEOWNERS` file in addition to Merge Request
2021-06-08 01:23:25 +05:30
[Approval Rules](merge_requests/approvals/rules.md),
2021-03-11 19:13:27 +05:30
you can also use it as the sole driver of merge request approvals
2021-06-08 01:23:25 +05:30
without using [Approval Rules](merge_requests/approvals/rules.md):
2020-06-23 00:09:42 +05:30
2021-03-11 19:13:27 +05:30
1. Create the file in one of the three locations specified above.
1. Set the code owners as required approvers for
2021-09-30 23:02:18 +05:30
[protected branches](protected_branches.md#require-code-owner-approval-on-a-protected-branch).
1. Use [the syntax of Code Owners files](code_owners.md)
2021-03-11 19:13:27 +05:30
to specify the actual owners and granular permissions.
2021-09-30 23:02:18 +05:30
Using Code Owners in conjunction with [protected branches](protected_branches.md#require-code-owner-approval-on-a-protected-branch)
2021-03-11 19:13:27 +05:30
prevents any user who is not specified in the `CODEOWNERS` file from pushing
2021-01-03 14:25:43 +05:30
changes for the specified files/paths, except those included in the
2020-07-28 23:09:34 +05:30
**Allowed to push** column. This allows for a more inclusive push strategy, as
administrators don't have to restrict developers from pushing directly to the
protected branch, but can restrict pushing to certain files where a review by
Code Owners is required.
2020-05-24 23:13:21 +05:30
2021-01-03 14:25:43 +05:30
[Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/35097) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.5, users and groups who are allowed to push to protected branches do not require a merge request to merge their feature branches. Thus, they can skip merge request approval rules, Code Owners included.
2021-09-30 23:02:18 +05:30
## Groups as Code Owners
2020-05-30 21:06:31 +05:30
2021-03-11 19:13:27 +05:30
> - [Introduced](https://gitlab.com/gitlab-org/gitlab-foss/-/issues/53182) in GitLab 12.1.
> - Group and subgroup hierarchy support was [introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/32432) in GitLab 13.0.
2020-05-30 21:06:31 +05:30
2020-11-24 15:15:51 +05:30
Groups and subgroups members are inherited as eligible Code Owners to a
project, as long as the hierarchy is respected.
For example, consider a given group called "Group X" (slug `group-x`) and a
"Subgroup Y" (slug `group-x/subgroup-y`) that belongs to the Group X, and
suppose you have a project called "Project A" within the group and a
"Project B" within the subgroup.
2020-05-30 21:06:31 +05:30
2020-11-24 15:15:51 +05:30
The eligible Code Owners to Project B are both the members of the Group X and
2021-03-11 19:13:27 +05:30
the Subgroup Y. The eligible Code Owners to the Project A are just the
2020-11-24 15:15:51 +05:30
members of the Group X, given that Project A doesn't belong to the Subgroup Y:
2020-05-30 21:06:31 +05:30
2020-11-24 15:15:51 +05:30
![Eligible Code Owners](img/code_owners_members_v13_4.png)
2020-05-30 21:06:31 +05:30
2020-11-24 15:15:51 +05:30
But you have the option to [invite](members/share_project_with_groups.md)
the Subgroup Y to the Project A so that their members also become eligible
Code Owners:
2020-05-30 21:06:31 +05:30
2021-06-08 01:23:25 +05:30
NOTE:
If you do not invite Subgroup Y to Project A, but make them Code Owners, their approval
of the merge request becomes optional.
2020-11-24 15:15:51 +05:30
![Invite subgroup members to become eligible Code Owners](img/code_owners_invite_members_v13_4.png)
2019-07-31 22:56:46 +05:30
2021-03-11 19:13:27 +05:30
After being invited, any member (`@user`) of the group or subgroup can be set
as Code Owner to files of the Project A or B, and the entire Group X
(`@group-x`) or Subgroup Y (`@group-x/subgroup-y`), as follows:
2020-11-24 15:15:51 +05:30
```plaintext
# A member of the group or subgroup as Code Owner to a file
file.md @user
# All group members as Code Owners to a file
file.md @group-x
# All subgroup members as Code Owners to a file
file.md @group-x/subgroup-y
# All group and subgroup members as Code Owners to a file
file.md @group-x @group-x/subgroup-y
```
2019-07-31 22:56:46 +05:30
2020-07-28 23:09:34 +05:30
### Code Owners Sections **(PREMIUM)**
2021-03-11 19:13:27 +05:30
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/12137) in GitLab Premium 13.2 behind a feature flag, enabled by default.
2021-01-03 14:25:43 +05:30
> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/42389) in GitLab 13.4.
2020-07-28 23:09:34 +05:30
Code Owner rules can be grouped into named sections. This allows for better
organization of broader categories of Code Owner rules to be applied.
Additionally, the usual guidance that only the last pattern matching the file is
applied is expanded such that the last pattern matching _for each section_ is
applied.
For example, in a large organization, independent teams may have a common interest
in parts of the application, for instance, a payment processing company may have
"development", "security", and "compliance" teams looking after common parts of
the codebase. All three teams may need to approve changes. Although approval rules
make this possible, they apply to every merge request. Also, while Code Owners are
applied based on which files are changed, only one CODEOWNERS pattern can match per
file path.
Using `CODEOWNERS` sections allows multiple teams that only need to approve certain
changes, to set their own independent patterns by specifying discrete sections in the
`CODEOWNERS` file. The section rules may be used for shared paths so that multiple
teams can be added as reviewers.
Sections can be added to `CODEOWNERS` files as a new line with the name of the
2021-03-11 19:13:27 +05:30
section inside square brackets. Every entry following is assigned to that
section. The following example would create two Code Owner rules for the "README
2020-07-28 23:09:34 +05:30
Owners" section:
```plaintext
[README Owners]
2020-10-24 23:57:45 +05:30
README.md @user1 @user2
2020-07-28 23:09:34 +05:30
internal/README.md @user2
```
Multiple sections can be used, even with matching file or directory patterns.
2021-03-11 19:13:27 +05:30
Reusing the same section name groups the results together under the same
2020-07-28 23:09:34 +05:30
section, with the most specific rule or last matching pattern being used. For
example, consider the following entries in a `CODEOWNERS` file:
```plaintext
[Documentation]
ee/docs @gl-docs
docs @gl-docs
[Database]
README.md @gl-database
model/db @gl-database
[DOCUMENTATION]
README.md @gl-docs
```
2021-03-11 19:13:27 +05:30
This results in three entries under the "Documentation" section header, and two
2020-07-28 23:09:34 +05:30
entries under "Database". Case is not considered when combining sections, so in
this example, entries defined under the sections "Documentation" and
"DOCUMENTATION" would be combined into one, using the case of the first instance
of the section encountered in the file.
When assigned to a section, each code owner rule displayed in merge requests
widget is sorted under a "section" label. In the screenshot below, we can see
the rules for "Groups" and "Documentation" sections:
![MR widget - Sectional Code Owners](img/sectional_code_owners_v13.2.png)
2021-03-08 18:12:59 +05:30
#### Optional Code Owners Sections **(PREMIUM)**
2021-03-11 19:13:27 +05:30
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/232995) in GitLab Premium 13.8 behind a feature flag, enabled by default.
> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/53227) in GitLab 13.9.
2021-03-08 18:12:59 +05:30
2021-03-11 19:13:27 +05:30
To make a certain section optional, add a code owners section prepended with the
caret `^` character. Approvals from owners listed in the section are **not** required. For example:
2021-03-08 18:12:59 +05:30
```plaintext
[Documentation]
*.md @root
[Ruby]
*.rb @root
^[Go]
*.go @root
```
2021-03-11 19:13:27 +05:30
The optional code owners section displays in merge requests under the **Approval Rules** area:
2021-03-08 18:12:59 +05:30
![MR widget - Optional Code Owners Sections](img/optional_code_owners_sections_v13_8.png)
2021-03-11 19:13:27 +05:30
If a section is duplicated in the file, and one of them is marked as optional and the other isn't, the requirement prevails.
2021-03-08 18:12:59 +05:30
2021-03-11 19:13:27 +05:30
For example, the code owners of the "Documentation" section below is still required to approve merge requests:
2021-03-08 18:12:59 +05:30
```plaintext
[Documentation]
*.md @root
[Ruby]
*.rb @root
^[Go]
*.go @root
^[Documentation]
*.txt @root
```
2021-03-11 19:13:27 +05:30
Optional sections in the code owners file are treated as optional only
when changes are submitted by using merge requests. If a change is submitted directly
to the protected branch, approval from code owners is still required, even if the
section is marked as optional. We plan to change this behavior in a
2021-03-08 18:12:59 +05:30
[future release](https://gitlab.com/gitlab-org/gitlab/-/issues/297638),
2021-03-11 19:13:27 +05:30
and allow direct pushes to the protected branch for sections marked as optional.
2021-03-08 18:12:59 +05:30
2020-07-28 23:09:34 +05:30
## Example `CODEOWNERS` file
2019-07-31 22:56:46 +05:30
2020-04-22 19:07:51 +05:30
```plaintext
2020-05-24 23:13:21 +05:30
# This is an example of a code owners file
# lines starting with a `#` will be ignored.
2019-07-31 22:56:46 +05:30
# app/ @commented-rule
2019-09-04 21:01:54 +05:30
# We can specify a default match using wildcards:
2019-07-31 22:56:46 +05:30
* @default-codeowner
2020-05-24 23:13:21 +05:30
# We can also specify "multiple tab or space" separated codeowners:
* @multiple @code @owners
2019-07-31 22:56:46 +05:30
# Rules defined later in the file take precedence over the rules
# defined before.
# This will match all files for which the file name ends in `.rb`
*.rb @ruby-owner
2020-05-24 23:13:21 +05:30
# Files with a `#` can still be accessed by escaping the pound sign
2019-07-31 22:56:46 +05:30
\#file_with_pound.rb @owner-file-with-pound
2019-09-30 21:07:59 +05:30
# Multiple codeowners can be specified, separated by spaces or tabs
2020-05-24 23:13:21 +05:30
# In the following case the CODEOWNERS file from the root of the repo
# has 3 code owners (@multiple @code @owners)
2019-12-04 20:38:33 +05:30
CODEOWNERS @multiple @code @owners
2019-07-31 22:56:46 +05:30
# Both usernames or email addresses can be used to match
# users. Everything else will be ignored. For example this will
# specify `@legal` and a user with email `janedoe@gitlab.com` as the
# owner for the LICENSE file
LICENSE @legal this_does_not_match janedoe@gitlab.com
2019-09-30 21:07:59 +05:30
# Group names can be used to match groups and nested groups to specify
# them as owners for a file
README @group @group/with-nested/subgroup
2019-07-31 22:56:46 +05:30
# Ending a path in a `/` will specify the code owners for every file
# nested in that directory, on any level
/docs/ @all-docs
# Ending a path in `/*` will specify code owners for every file in
# that directory, but not nested deeper. This will match
# `docs/index.md` but not `docs/projects/index.md`
/docs/* @root-docs
# This will make a `lib` directory nested anywhere in the repository
# match
lib/ @lib-owner
# This will only match a `config` directory in the root of the
# repository
/config/ @config-owner
# If the path contains spaces, these need to be escaped like this:
path\ with\ spaces/ @space-owner
2020-07-28 23:09:34 +05:30
# Code Owners section:
[Documentation]
ee/docs @gl-docs
docs @gl-docs
[Database]
README.md @gl-database
model/db @gl-database
# This section will be joined with the [Documentation] section previously defined:
[DOCUMENTATION]
README.md @gl-docs
2019-07-31 22:56:46 +05:30
```