2015-10-24 18:46:33 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe MergeRequestsHelper do
|
2015-12-23 02:04:40 +05:30
|
|
|
describe 'ci_build_details_path' do
|
|
|
|
let(:project) { create :project }
|
|
|
|
let(:merge_request) { MergeRequest.new }
|
|
|
|
let(:ci_service) { CiService.new }
|
2016-06-16 23:09:34 +05:30
|
|
|
let(:last_commit) { Ci::Pipeline.new({}) }
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow(merge_request).to receive(:source_project).and_return(project)
|
|
|
|
allow(merge_request).to receive(:last_commit).and_return(last_commit)
|
|
|
|
allow(project).to receive(:ci_service).and_return(ci_service)
|
|
|
|
allow(last_commit).to receive(:sha).and_return('12d65c')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include api credentials in a link' do
|
|
|
|
allow(ci_service).
|
|
|
|
to receive(:build_page).and_return("http://secretuser:secretpass@jenkins.example.com:8888/job/test1/scm/bySHA1/12d65c")
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(helper.ci_build_details_path(merge_request)).not_to match("secret")
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#issues_sentence' do
|
2015-10-24 18:46:33 +05:30
|
|
|
subject { issues_sentence(issues) }
|
|
|
|
let(:issues) do
|
|
|
|
[build(:issue, iid: 1), build(:issue, iid: 2), build(:issue, iid: 3)]
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq('#1, #2, and #3') }
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
context 'for JIRA issues' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:issues) do
|
|
|
|
[
|
|
|
|
JiraIssue.new('JIRA-123', project),
|
|
|
|
JiraIssue.new('JIRA-456', project),
|
|
|
|
JiraIssue.new('FOOBAR-7890', project)
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq('FOOBAR-7890, JIRA-123, and JIRA-456') }
|
|
|
|
end
|
2015-10-24 18:46:33 +05:30
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
describe '#format_mr_branch_names' do
|
|
|
|
describe 'within the same project' do
|
2015-10-24 18:46:33 +05:30
|
|
|
let(:merge_request) { create(:merge_request) }
|
|
|
|
subject { format_mr_branch_names(merge_request) }
|
|
|
|
|
|
|
|
it { is_expected.to eq([merge_request.source_branch, merge_request.target_branch]) }
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
describe 'within different projects' do
|
2015-10-24 18:46:33 +05:30
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:fork_project) { create(:project, forked_from_project: project) }
|
|
|
|
let(:merge_request) { create(:merge_request, source_project: fork_project, target_project: project) }
|
|
|
|
subject { format_mr_branch_names(merge_request) }
|
|
|
|
let(:source_title) { "#{fork_project.path_with_namespace}:#{merge_request.source_branch}" }
|
|
|
|
let(:target_title) { "#{project.path_with_namespace}:#{merge_request.target_branch}" }
|
|
|
|
|
|
|
|
it { is_expected.to eq([source_title, target_title]) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|