debian-mirror-gitlab/spec/javascripts/notes_spec.js

947 lines
31 KiB
JavaScript
Raw Normal View History

2017-08-17 22:00:37 +05:30
/* eslint-disable space-before-function-paren, no-unused-expressions, no-var, object-shorthand, comma-dangle, max-len */
2018-03-17 18:26:18 +05:30
import _ from 'underscore';
import MockAdapter from 'axios-mock-adapter';
import axios from '~/lib/utils/axios_utils';
import * as urlUtils from '~/lib/utils/url_utility';
import 'autosize';
2017-08-17 22:00:37 +05:30
import '~/gl_form';
import '~/lib/utils/text_utility';
import '~/render_gfm';
2018-03-17 18:26:18 +05:30
import Notes from '~/notes';
import timeoutPromise from './helpers/set_timeout_promise_helper';
2016-09-13 17:45:13 +05:30
(function() {
window.gon || (window.gon = {});
2017-08-17 22:00:37 +05:30
window.gl = window.gl || {};
gl.utils = gl.utils || {};
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
const htmlEscape = (comment) => {
const escapedString = comment.replace(/["&'<>]/g, (a) => {
const escapedToken = {
'&': '&amp;',
'<': '&lt;',
'>': '&gt;',
'"': '&quot;',
"'": '&#x27;',
'`': '&#x60;'
}[a];
return escapedToken;
});
return escapedString;
};
2016-09-13 17:45:13 +05:30
describe('Notes', function() {
2017-09-10 17:25:29 +05:30
const FLASH_TYPE_ALERT = 'alert';
2018-03-27 19:54:05 +05:30
const NOTES_POST_PATH = /(.*)\/notes\?html=true$/;
2018-03-17 18:26:18 +05:30
var commentsTemplate = 'merge_requests/merge_request_with_comment.html.raw';
2017-08-17 22:00:37 +05:30
preloadFixtures(commentsTemplate);
2016-09-29 09:46:39 +05:30
2017-08-17 22:00:37 +05:30
beforeEach(function () {
loadFixtures(commentsTemplate);
gl.utils.disableButtonIfEmptyField = _.noop;
window.project_uploads_path = 'http://test.host/uploads';
2018-03-17 18:26:18 +05:30
$('body').attr('data-page', 'projects:merge_requets:show');
});
afterEach(() => {
// Undo what we did to the shared <body>
$('body').removeAttr('data-page');
2017-08-17 22:00:37 +05:30
});
describe('task lists', function() {
2018-03-17 18:26:18 +05:30
let mock;
2016-09-13 17:45:13 +05:30
beforeEach(function() {
2018-03-17 18:26:18 +05:30
spyOn(axios, 'patch').and.callThrough();
mock = new MockAdapter(axios);
mock.onPatch(`${gl.TEST_HOST}/frontend-fixtures/merge-requests-project/merge_requests/1.json`).reply(200, {});
2017-08-17 22:00:37 +05:30
$('.js-comment-button').on('click', function(e) {
2016-09-29 09:46:39 +05:30
e.preventDefault();
2016-09-13 17:45:13 +05:30
});
2017-08-17 22:00:37 +05:30
this.notes = new Notes('', []);
2016-09-13 17:45:13 +05:30
});
2016-09-29 09:46:39 +05:30
2018-03-17 18:26:18 +05:30
afterEach(() => {
mock.restore();
});
2016-09-13 17:45:13 +05:30
it('modifies the Markdown field', function() {
2017-09-10 17:25:29 +05:30
const changeEvent = document.createEvent('HTMLEvents');
changeEvent.initEvent('change', true, true);
2018-03-17 18:26:18 +05:30
$('input[type=checkbox]').attr('checked', true)[1].dispatchEvent(changeEvent);
expect($('.js-task-list-field.original-task-list').val()).toBe('- [x] Task List Item');
2016-09-13 17:45:13 +05:30
});
2016-09-29 09:46:39 +05:30
2018-03-17 18:26:18 +05:30
it('submits an ajax request on tasklist:changed', function(done) {
$('.js-task-list-container').trigger('tasklist:changed');
setTimeout(() => {
expect(axios.patch).toHaveBeenCalledWith(`${gl.TEST_HOST}/frontend-fixtures/merge-requests-project/merge_requests/1.json`, {
note: { note: '' },
});
done();
2016-09-13 17:45:13 +05:30
});
2016-09-29 09:46:39 +05:30
});
});
describe('comments', function() {
var textarea = '.js-note-text';
beforeEach(function() {
2017-08-17 22:00:37 +05:30
this.notes = new Notes('', []);
2016-09-29 09:46:39 +05:30
this.autoSizeSpy = spyOnEvent($(textarea), 'autosize:update');
spyOn(this.notes, 'renderNote').and.stub();
$(textarea).data('autosave', {
reset: function() {}
});
2017-08-17 22:00:37 +05:30
$('.js-comment-button').on('click', (e) => {
const $form = $(this);
2016-09-29 09:46:39 +05:30
e.preventDefault();
2017-08-17 22:00:37 +05:30
this.notes.addNote($form);
this.notes.reenableTargetFormSubmitButton(e);
this.notes.resetMainTargetForm(e);
2016-09-29 09:46:39 +05:30
});
2016-09-13 17:45:13 +05:30
});
2016-09-29 09:46:39 +05:30
it('autosizes after comment submission', function() {
$(textarea).text('This is an example comment note');
expect(this.autoSizeSpy).not.toHaveBeenTriggered();
$('.js-comment-button').click();
expect(this.autoSizeSpy).toHaveBeenTriggered();
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
it('should not place escaped text in the comment box in case of error', function() {
const deferred = $.Deferred();
spyOn($, 'ajax').and.returnValue(deferred.promise());
$(textarea).text('A comment with `markup`.');
deferred.reject();
$('.js-comment-button').click();
expect($(textarea).val()).toEqual('A comment with `markup`.');
});
2016-09-13 17:45:13 +05:30
});
2017-08-17 22:00:37 +05:30
describe('updateNote', () => {
let sampleComment;
let noteEntity;
let $form;
let $notesContainer;
2018-03-17 18:26:18 +05:30
let mock;
2017-08-17 22:00:37 +05:30
beforeEach(() => {
this.notes = new Notes('', []);
window.gon.current_username = 'root';
window.gon.current_user_fullname = 'Administrator';
sampleComment = 'foo';
noteEntity = {
id: 1234,
html: `<li class="note note-row-1234 timeline-entry" id="note_1234">
<div class="note-text">${sampleComment}</div>
</li>`,
note: sampleComment,
valid: true
};
$form = $('form.js-main-target-form');
$notesContainer = $('ul.main-notes-list');
$form.find('textarea.js-note-text').val(sampleComment);
2018-03-17 18:26:18 +05:30
mock = new MockAdapter(axios);
2018-03-27 19:54:05 +05:30
mock.onPost(NOTES_POST_PATH).reply(200, noteEntity);
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
afterEach(() => {
mock.restore();
});
it('updates note and resets edit form', (done) => {
2017-08-17 22:00:37 +05:30
spyOn(this.notes, 'revertNoteEditForm');
2017-09-10 17:25:29 +05:30
spyOn(this.notes, 'setupNewNote');
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
const $targetNote = $notesContainer.find(`#note_${noteEntity.id}`);
const updatedNote = Object.assign({}, noteEntity);
updatedNote.note = 'bar';
this.notes.updateNote(updatedNote, $targetNote);
expect(this.notes.revertNoteEditForm).toHaveBeenCalledWith($targetNote);
expect(this.notes.setupNewNote).toHaveBeenCalled();
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
done();
});
2017-09-10 17:25:29 +05:30
});
});
describe('updateNoteTargetSelector', () => {
const hash = 'note_foo';
let $note;
beforeEach(() => {
$note = $(`<div id="${hash}"></div>`);
spyOn($note, 'filter').and.callThrough();
spyOn($note, 'toggleClass').and.callThrough();
});
it('sets target when hash matches', () => {
2018-03-17 18:26:18 +05:30
spyOn(urlUtils, 'getLocationHash').and.returnValue(hash);
2017-09-10 17:25:29 +05:30
Notes.updateNoteTargetSelector($note);
expect($note.filter).toHaveBeenCalledWith(`#${hash}`);
expect($note.toggleClass).toHaveBeenCalledWith('target', true);
});
it('unsets target when hash does not match', () => {
2018-03-17 18:26:18 +05:30
spyOn(urlUtils, 'getLocationHash').and.returnValue('note_doesnotexist');
2017-09-10 17:25:29 +05:30
Notes.updateNoteTargetSelector($note);
expect($note.toggleClass).toHaveBeenCalledWith('target', false);
});
it('unsets target when there is not a hash fragment anymore', () => {
2018-03-17 18:26:18 +05:30
spyOn(urlUtils, 'getLocationHash').and.returnValue(null);
2017-09-10 17:25:29 +05:30
Notes.updateNoteTargetSelector($note);
expect($note.toggleClass).toHaveBeenCalledWith('target', false);
2017-08-17 22:00:37 +05:30
});
});
describe('renderNote', () => {
let notes;
let note;
let $notesList;
beforeEach(() => {
note = {
id: 1,
valid: true,
note: 'heya',
html: '<div>heya</div>',
};
$notesList = jasmine.createSpyObj('$notesList', [
'find',
'append',
]);
notes = jasmine.createSpyObj('notes', [
'setupNewNote',
'refresh',
'collapseLongCommitList',
'updateNotesCount',
'putConflictEditWarningInPlace'
]);
notes.taskList = jasmine.createSpyObj('tasklist', ['init']);
notes.note_ids = [];
notes.updatedNotesTrackingMap = {};
spyOn(Notes, 'isNewNote').and.callThrough();
spyOn(Notes, 'isUpdatedNote').and.callThrough();
spyOn(Notes, 'animateAppendNote').and.callThrough();
spyOn(Notes, 'animateUpdateNote').and.callThrough();
});
describe('when adding note', () => {
it('should call .animateAppendNote', () => {
Notes.isNewNote.and.returnValue(true);
Notes.prototype.renderNote.call(notes, note, null, $notesList);
expect(Notes.animateAppendNote).toHaveBeenCalledWith(note.html, $notesList);
});
});
describe('when note was edited', () => {
it('should call .animateUpdateNote', () => {
Notes.isNewNote.and.returnValue(false);
Notes.isUpdatedNote.and.returnValue(true);
const $note = $('<div>');
$notesList.find.and.returnValue($note);
2017-09-10 17:25:29 +05:30
const $newNote = $(note.html);
Notes.animateUpdateNote.and.returnValue($newNote);
2017-08-17 22:00:37 +05:30
Notes.prototype.renderNote.call(notes, note, null, $notesList);
expect(Notes.animateUpdateNote).toHaveBeenCalledWith(note.html, $note);
2017-09-10 17:25:29 +05:30
expect(notes.setupNewNote).toHaveBeenCalledWith($newNote);
2017-08-17 22:00:37 +05:30
});
describe('while editing', () => {
it('should update textarea if nothing has been touched', () => {
Notes.isNewNote.and.returnValue(false);
Notes.isUpdatedNote.and.returnValue(true);
const $note = $(`<div class="is-editing">
<div class="original-note-content">initial</div>
<textarea class="js-note-text">initial</textarea>
</div>`);
$notesList.find.and.returnValue($note);
Notes.prototype.renderNote.call(notes, note, null, $notesList);
expect($note.find('.js-note-text').val()).toEqual(note.note);
});
it('should call .putConflictEditWarningInPlace', () => {
Notes.isNewNote.and.returnValue(false);
Notes.isUpdatedNote.and.returnValue(true);
const $note = $(`<div class="is-editing">
<div class="original-note-content">initial</div>
<textarea class="js-note-text">different</textarea>
</div>`);
$notesList.find.and.returnValue($note);
Notes.prototype.renderNote.call(notes, note, null, $notesList);
expect(notes.putConflictEditWarningInPlace).toHaveBeenCalledWith(note, $note);
});
});
});
});
describe('isUpdatedNote', () => {
it('should consider same note text as the same', () => {
const result = Notes.isUpdatedNote(
{
note: 'initial'
},
$(`<div>
<div class="original-note-content">initial</div>
</div>`)
);
expect(result).toEqual(false);
});
it('should consider same note with trailing newline as the same', () => {
const result = Notes.isUpdatedNote(
{
note: 'initial\n'
},
$(`<div>
<div class="original-note-content">initial\n</div>
</div>`)
);
expect(result).toEqual(false);
});
it('should consider different notes as different', () => {
const result = Notes.isUpdatedNote(
{
note: 'foo'
},
$(`<div>
<div class="original-note-content">bar</div>
</div>`)
);
expect(result).toEqual(true);
});
});
describe('renderDiscussionNote', () => {
let discussionContainer;
let note;
let notes;
let $form;
let row;
beforeEach(() => {
note = {
html: '<li></li>',
discussion_html: '<div></div>',
discussion_id: 1,
discussion_resolvable: false,
diff_discussion_html: false,
};
$form = jasmine.createSpyObj('$form', ['closest', 'find']);
2018-03-17 18:26:18 +05:30
$form.length = 1;
2017-08-17 22:00:37 +05:30
row = jasmine.createSpyObj('row', ['prevAll', 'first', 'find']);
notes = jasmine.createSpyObj('notes', [
'isParallelView',
'updateNotesCount',
]);
notes.note_ids = [];
spyOn(Notes, 'isNewNote');
spyOn(Notes, 'animateAppendNote');
Notes.isNewNote.and.returnValue(true);
notes.isParallelView.and.returnValue(false);
row.prevAll.and.returnValue(row);
row.first.and.returnValue(row);
row.find.and.returnValue(row);
});
describe('Discussion root note', () => {
let body;
beforeEach(() => {
body = jasmine.createSpyObj('body', ['attr']);
discussionContainer = { length: 0 };
$form.closest.and.returnValues(row, $form);
$form.find.and.returnValues(discussionContainer);
body.attr.and.returnValue('');
});
it('should call Notes.animateAppendNote', () => {
2018-03-17 18:26:18 +05:30
Notes.prototype.renderDiscussionNote.call(notes, note, $form);
2017-08-17 22:00:37 +05:30
expect(Notes.animateAppendNote).toHaveBeenCalledWith(note.discussion_html, $('.main-notes-list'));
});
2018-03-17 18:26:18 +05:30
it('should append to row selected with line_code', () => {
$form.length = 0;
note.discussion_line_code = 'line_code';
note.diff_discussion_html = '<tr></tr>';
const line = document.createElement('div');
line.id = note.discussion_line_code;
document.body.appendChild(line);
$form.closest.and.returnValues($form);
Notes.prototype.renderDiscussionNote.call(notes, note, $form);
expect(line.nextSibling.outerHTML).toEqual(note.diff_discussion_html);
});
2017-08-17 22:00:37 +05:30
});
describe('Discussion sub note', () => {
beforeEach(() => {
discussionContainer = { length: 1 };
$form.closest.and.returnValues(row, $form);
$form.find.and.returnValues(discussionContainer);
Notes.prototype.renderDiscussionNote.call(notes, note, $form);
});
it('should call Notes.animateAppendNote', () => {
expect(Notes.animateAppendNote).toHaveBeenCalledWith(note.html, discussionContainer);
});
});
});
describe('animateAppendNote', () => {
let noteHTML;
let $notesList;
let $resultantNote;
beforeEach(() => {
noteHTML = '<div></div>';
$notesList = jasmine.createSpyObj('$notesList', ['append']);
$resultantNote = Notes.animateAppendNote(noteHTML, $notesList);
});
it('should have `fade-in-full` class', () => {
expect($resultantNote.hasClass('fade-in-full')).toEqual(true);
});
it('should append note to the notes list', () => {
expect($notesList.append).toHaveBeenCalledWith($resultantNote);
});
});
describe('animateUpdateNote', () => {
let noteHTML;
let $note;
let $updatedNote;
beforeEach(() => {
noteHTML = '<div></div>';
$note = jasmine.createSpyObj('$note', [
'replaceWith'
]);
$updatedNote = Notes.animateUpdateNote(noteHTML, $note);
});
it('should have `fade-in` class', () => {
expect($updatedNote.hasClass('fade-in')).toEqual(true);
});
it('should call replaceWith on $note', () => {
expect($note.replaceWith).toHaveBeenCalledWith($updatedNote);
});
});
2017-09-10 17:25:29 +05:30
describe('putEditFormInPlace', () => {
2018-03-17 18:26:18 +05:30
it('should call GLForm with GFM parameter passed through', () => {
const notes = new Notes('', []);
const $el = $(`
<div>
<form></form>
</div>
`);
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
notes.putEditFormInPlace($el);
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(notes.glForm.enableGFM).toBeTruthy();
2017-09-10 17:25:29 +05:30
});
});
2017-08-17 22:00:37 +05:30
describe('postComment & updateComment', () => {
const sampleComment = 'foo';
const updatedComment = 'bar';
const note = {
id: 1234,
html: `<li class="note note-row-1234 timeline-entry" id="note_1234">
<div class="note-text">${sampleComment}</div>
</li>`,
note: sampleComment,
valid: true
};
let $form;
let $notesContainer;
2018-03-17 18:26:18 +05:30
let mock;
function mockNotesPost() {
2018-03-27 19:54:05 +05:30
mock.onPost(NOTES_POST_PATH).reply(200, note);
2018-03-17 18:26:18 +05:30
}
function mockNotesPostError() {
2018-03-27 19:54:05 +05:30
mock.onPost(NOTES_POST_PATH).networkError();
2018-03-17 18:26:18 +05:30
}
2017-08-17 22:00:37 +05:30
beforeEach(() => {
2018-03-17 18:26:18 +05:30
mock = new MockAdapter(axios);
2017-08-17 22:00:37 +05:30
this.notes = new Notes('', []);
window.gon.current_username = 'root';
window.gon.current_user_fullname = 'Administrator';
$form = $('form.js-main-target-form');
$notesContainer = $('ul.main-notes-list');
$form.find('textarea.js-note-text').val(sampleComment);
});
2018-03-17 18:26:18 +05:30
afterEach(() => {
mock.restore();
});
2017-08-17 22:00:37 +05:30
it('should show placeholder note while new comment is being posted', () => {
2018-03-17 18:26:18 +05:30
mockNotesPost();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
expect($notesContainer.find('.note.being-posted').length > 0).toEqual(true);
});
2018-03-17 18:26:18 +05:30
it('should remove placeholder note when new comment is done posting', (done) => {
mockNotesPost();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
expect($notesContainer.find('.note.being-posted').length).toEqual(0);
done();
});
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
it('should show actual note element when new comment is done posting', (done) => {
mockNotesPost();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
expect($notesContainer.find(`#note_${note.id}`).length > 0).toEqual(true);
done();
});
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
it('should reset Form when new comment is done posting', (done) => {
mockNotesPost();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
expect($form.find('textarea.js-note-text').val()).toEqual('');
done();
});
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
it('should show flash error message when new comment failed to be posted', (done) => {
mockNotesPostError();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
expect($notesContainer.parent().find('.flash-container .flash-text').is(':visible')).toEqual(true);
done();
});
2017-08-17 22:00:37 +05:30
});
2018-03-17 18:26:18 +05:30
it('should show flash error message when comment failed to be updated', (done) => {
mockNotesPost();
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
timeoutPromise()
.then(() => {
const $noteEl = $notesContainer.find(`#note_${note.id}`);
$noteEl.find('.js-note-edit').click();
$noteEl.find('textarea.js-note-text').val(updatedComment);
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
mock.restore();
mockNotesPostError();
$noteEl.find('.js-comment-save-button').click();
})
.then(timeoutPromise)
.then(() => {
const $updatedNoteEl = $notesContainer.find(`#note_${note.id}`);
expect($updatedNoteEl.hasClass('.being-posted')).toEqual(false); // Remove being-posted visuals
expect($updatedNoteEl.find('.note-text').text().trim()).toEqual(sampleComment); // See if comment reverted back to original
expect($('.flash-container').is(':visible')).toEqual(true); // Flash error message shown
done();
})
.catch(done.fail);
2017-08-17 22:00:37 +05:30
});
});
2017-09-10 17:25:29 +05:30
describe('postComment with Slash commands', () => {
const sampleComment = '/assign @root\n/award :100:';
const note = {
commands_changes: {
assignee_id: 1,
emoji_award: '100'
},
errors: {
commands_only: ['Commands applied']
},
valid: false
};
let $form;
let $notesContainer;
2018-03-17 18:26:18 +05:30
let mock;
2017-09-10 17:25:29 +05:30
beforeEach(() => {
2018-03-17 18:26:18 +05:30
mock = new MockAdapter(axios);
2018-03-27 19:54:05 +05:30
mock.onPost(NOTES_POST_PATH).reply(200, note);
2018-03-17 18:26:18 +05:30
2017-09-10 17:25:29 +05:30
this.notes = new Notes('', []);
window.gon.current_username = 'root';
window.gon.current_user_fullname = 'Administrator';
gl.awardsHandler = {
addAwardToEmojiBar: () => {},
scrollToAwards: () => {}
};
gl.GfmAutoComplete = {
dataSources: {
commands: '/root/test-project/autocomplete_sources/commands'
}
};
$form = $('form.js-main-target-form');
$notesContainer = $('ul.main-notes-list');
$form.find('textarea.js-note-text').val(sampleComment);
});
2018-03-17 18:26:18 +05:30
afterEach(() => {
mock.restore();
});
it('should remove slash command placeholder when comment with slash commands is done posting', (done) => {
2017-09-10 17:25:29 +05:30
spyOn(gl.awardsHandler, 'addAwardToEmojiBar').and.callThrough();
$('.js-comment-button').click();
expect($notesContainer.find('.system-note.being-posted').length).toEqual(1); // Placeholder shown
2018-03-17 18:26:18 +05:30
setTimeout(() => {
expect($notesContainer.find('.system-note.being-posted').length).toEqual(0); // Placeholder removed
done();
});
2017-09-10 17:25:29 +05:30
});
});
2017-08-17 22:00:37 +05:30
describe('update comment with script tags', () => {
const sampleComment = '<script></script>';
const updatedComment = '<script></script>';
const note = {
id: 1234,
html: `<li class="note note-row-1234 timeline-entry" id="note_1234">
<div class="note-text">${sampleComment}</div>
</li>`,
note: sampleComment,
valid: true
};
let $form;
let $notesContainer;
2018-03-17 18:26:18 +05:30
let mock;
2017-08-17 22:00:37 +05:30
beforeEach(() => {
2018-03-17 18:26:18 +05:30
mock = new MockAdapter(axios);
2018-03-27 19:54:05 +05:30
mock.onPost(NOTES_POST_PATH).reply(200, note);
2018-03-17 18:26:18 +05:30
2017-08-17 22:00:37 +05:30
this.notes = new Notes('', []);
window.gon.current_username = 'root';
window.gon.current_user_fullname = 'Administrator';
$form = $('form.js-main-target-form');
$notesContainer = $('ul.main-notes-list');
$form.find('textarea.js-note-text').html(sampleComment);
});
2018-03-17 18:26:18 +05:30
afterEach(() => {
mock.restore();
});
it('should not render a script tag', (done) => {
2017-08-17 22:00:37 +05:30
$('.js-comment-button').click();
2018-03-17 18:26:18 +05:30
setTimeout(() => {
const $noteEl = $notesContainer.find(`#note_${note.id}`);
$noteEl.find('.js-note-edit').click();
$noteEl.find('textarea.js-note-text').html(updatedComment);
$noteEl.find('.js-comment-save-button').click();
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
const $updatedNoteEl = $notesContainer.find(`#note_${note.id}`).find('.js-task-list-container');
expect($updatedNoteEl.find('.note-text').text().trim()).toEqual('');
done();
});
2017-08-17 22:00:37 +05:30
});
});
describe('getFormData', () => {
2017-09-10 17:25:29 +05:30
let $form;
let sampleComment;
beforeEach(() => {
2017-08-17 22:00:37 +05:30
this.notes = new Notes('', []);
2017-09-10 17:25:29 +05:30
$form = $('form');
sampleComment = 'foobar';
});
it('should return form metadata object from form reference', () => {
2017-08-17 22:00:37 +05:30
$form.find('textarea.js-note-text').val(sampleComment);
const { formData, formContent, formAction } = this.notes.getFormData($form);
expect(formData.indexOf(sampleComment) > -1).toBe(true);
expect(formContent).toEqual(sampleComment);
expect(formAction).toEqual($form.attr('action'));
});
2017-09-10 17:25:29 +05:30
it('should return form metadata with sanitized formContent from form reference', () => {
spyOn(_, 'escape').and.callFake(htmlEscape);
sampleComment = '<script>alert("Boom!");</script>';
$form.find('textarea.js-note-text').val(sampleComment);
const { formContent } = this.notes.getFormData($form);
expect(_.escape).toHaveBeenCalledWith(sampleComment);
expect(formContent).toEqual('&lt;script&gt;alert(&quot;Boom!&quot;);&lt;/script&gt;');
});
2017-08-17 22:00:37 +05:30
});
2017-09-10 17:25:29 +05:30
describe('hasQuickActions', () => {
2017-08-17 22:00:37 +05:30
beforeEach(() => {
this.notes = new Notes('', []);
});
2017-09-10 17:25:29 +05:30
it('should return true when comment begins with a quick action', () => {
2017-08-17 22:00:37 +05:30
const sampleComment = '/wip\n/milestone %1.0\n/merge\n/unassign Merging this';
2017-09-10 17:25:29 +05:30
const hasQuickActions = this.notes.hasQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(hasQuickActions).toBeTruthy();
2017-08-17 22:00:37 +05:30
});
2017-09-10 17:25:29 +05:30
it('should return false when comment does NOT begin with a quick action', () => {
2017-08-17 22:00:37 +05:30
const sampleComment = 'Hey, /unassign Merging this';
2017-09-10 17:25:29 +05:30
const hasQuickActions = this.notes.hasQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(hasQuickActions).toBeFalsy();
2017-08-17 22:00:37 +05:30
});
2017-09-10 17:25:29 +05:30
it('should return false when comment does NOT have any quick actions', () => {
2017-08-17 22:00:37 +05:30
const sampleComment = 'Looking good, Awesome!';
2017-09-10 17:25:29 +05:30
const hasQuickActions = this.notes.hasQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(hasQuickActions).toBeFalsy();
2017-08-17 22:00:37 +05:30
});
});
2017-09-10 17:25:29 +05:30
describe('stripQuickActions', () => {
it('should strip quick actions from the comment which begins with a quick action', () => {
2017-08-17 22:00:37 +05:30
this.notes = new Notes();
const sampleComment = '/wip\n/milestone %1.0\n/merge\n/unassign Merging this';
2017-09-10 17:25:29 +05:30
const stripedComment = this.notes.stripQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
expect(stripedComment).toBe('');
});
2017-09-10 17:25:29 +05:30
it('should strip quick actions from the comment but leaves plain comment if it is present', () => {
2017-08-17 22:00:37 +05:30
this.notes = new Notes();
const sampleComment = '/wip\n/milestone %1.0\n/merge\n/unassign\nMerging this';
2017-09-10 17:25:29 +05:30
const stripedComment = this.notes.stripQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
expect(stripedComment).toBe('Merging this');
});
it('should NOT strip string that has slashes within', () => {
this.notes = new Notes();
const sampleComment = 'http://127.0.0.1:3000/root/gitlab-shell/issues/1';
2017-09-10 17:25:29 +05:30
const stripedComment = this.notes.stripQuickActions(sampleComment);
2017-08-17 22:00:37 +05:30
expect(stripedComment).toBe(sampleComment);
});
});
2017-09-10 17:25:29 +05:30
describe('getQuickActionDescription', () => {
const availableQuickActions = [
{ name: 'close', description: 'Close this issue', params: [] },
{ name: 'title', description: 'Change title', params: [{}] },
{ name: 'estimate', description: 'Set time estimate', params: [{}] }
];
beforeEach(() => {
this.notes = new Notes();
});
it('should return executing quick action description when note has single quick action', () => {
const sampleComment = '/close';
expect(this.notes.getQuickActionDescription(sampleComment, availableQuickActions)).toBe('Applying command to close this issue');
});
it('should return generic multiple quick action description when note has multiple quick actions', () => {
const sampleComment = '/close\n/title [Duplicate] Issue foobar';
expect(this.notes.getQuickActionDescription(sampleComment, availableQuickActions)).toBe('Applying multiple commands');
});
it('should return generic quick action description when available quick actions list is not populated', () => {
const sampleComment = '/close\n/title [Duplicate] Issue foobar';
expect(this.notes.getQuickActionDescription(sampleComment)).toBe('Applying command');
});
});
2017-08-17 22:00:37 +05:30
describe('createPlaceholderNote', () => {
const sampleComment = 'foobar';
const uniqueId = 'b1234-a4567';
const currentUsername = 'root';
const currentUserFullname = 'Administrator';
2017-09-10 17:25:29 +05:30
const currentUserAvatar = 'avatar_url';
2017-08-17 22:00:37 +05:30
beforeEach(() => {
this.notes = new Notes('', []);
});
it('should return constructed placeholder element for regular note based on form contents', () => {
const $tempNote = this.notes.createPlaceholderNote({
formContent: sampleComment,
uniqueId,
isDiscussionNote: false,
currentUsername,
2017-09-10 17:25:29 +05:30
currentUserFullname,
currentUserAvatar,
2017-08-17 22:00:37 +05:30
});
const $tempNoteHeader = $tempNote.find('.note-header');
expect($tempNote.prop('nodeName')).toEqual('LI');
expect($tempNote.attr('id')).toEqual(uniqueId);
2017-09-10 17:25:29 +05:30
expect($tempNote.hasClass('being-posted')).toBeTruthy();
expect($tempNote.hasClass('fade-in-half')).toBeTruthy();
2017-08-17 22:00:37 +05:30
$tempNote.find('.timeline-icon > a, .note-header-info > a').each(function() {
expect($(this).attr('href')).toEqual(`/${currentUsername}`);
});
2017-09-10 17:25:29 +05:30
expect($tempNote.find('.timeline-icon .avatar').attr('src')).toEqual(currentUserAvatar);
2017-08-17 22:00:37 +05:30
expect($tempNote.find('.timeline-content').hasClass('discussion')).toBeFalsy();
expect($tempNoteHeader.find('.hidden-xs').text().trim()).toEqual(currentUserFullname);
expect($tempNoteHeader.find('.note-headline-light').text().trim()).toEqual(`@${currentUsername}`);
expect($tempNote.find('.note-body .note-text p').text().trim()).toEqual(sampleComment);
});
2017-09-10 17:25:29 +05:30
it('should return constructed placeholder element for discussion note based on form contents', () => {
2017-08-17 22:00:37 +05:30
const $tempNote = this.notes.createPlaceholderNote({
2017-09-10 17:25:29 +05:30
formContent: sampleComment,
2017-08-17 22:00:37 +05:30
uniqueId,
2017-09-10 17:25:29 +05:30
isDiscussionNote: true,
2017-08-17 22:00:37 +05:30
currentUsername,
currentUserFullname
});
2017-09-10 17:25:29 +05:30
expect($tempNote.prop('nodeName')).toEqual('LI');
expect($tempNote.find('.timeline-content').hasClass('discussion')).toBeTruthy();
2017-08-17 22:00:37 +05:30
});
2017-09-10 17:25:29 +05:30
it('should return a escaped user name', () => {
const currentUserFullnameXSS = 'Foo <script>alert("XSS")</script>';
2017-08-17 22:00:37 +05:30
const $tempNote = this.notes.createPlaceholderNote({
formContent: sampleComment,
uniqueId,
2017-09-10 17:25:29 +05:30
isDiscussionNote: false,
2017-08-17 22:00:37 +05:30
currentUsername,
2017-09-10 17:25:29 +05:30
currentUserFullname: currentUserFullnameXSS,
currentUserAvatar,
});
const $tempNoteHeader = $tempNote.find('.note-header');
expect($tempNoteHeader.find('.hidden-xs').text().trim()).toEqual('Foo &lt;script&gt;alert(&quot;XSS&quot;)&lt;/script&gt;');
});
});
describe('createPlaceholderSystemNote', () => {
const sampleCommandDescription = 'Applying command to close this issue';
const uniqueId = 'b1234-a4567';
beforeEach(() => {
this.notes = new Notes('', []);
spyOn(_, 'escape').and.callFake(htmlEscape);
});
it('should return constructed placeholder element for system note based on form contents', () => {
const $tempNote = this.notes.createPlaceholderSystemNote({
formContent: sampleCommandDescription,
uniqueId,
2017-08-17 22:00:37 +05:30
});
expect($tempNote.prop('nodeName')).toEqual('LI');
2017-09-10 17:25:29 +05:30
expect($tempNote.attr('id')).toEqual(uniqueId);
expect($tempNote.hasClass('being-posted')).toBeTruthy();
expect($tempNote.hasClass('fade-in-half')).toBeTruthy();
expect($tempNote.find('.timeline-content i').text().trim()).toEqual(sampleCommandDescription);
});
});
describe('appendFlash', () => {
beforeEach(() => {
this.notes = new Notes();
});
it('shows a flash message', () => {
2018-03-17 18:26:18 +05:30
this.notes.addFlash('Error message', FLASH_TYPE_ALERT, this.notes.parentTimeline.get(0));
2017-09-10 17:25:29 +05:30
expect($('.flash-alert').is(':visible')).toBeTruthy();
});
});
describe('clearFlash', () => {
beforeEach(() => {
$(document).off('ajax:success');
this.notes = new Notes();
});
it('hides visible flash message', () => {
2018-03-17 18:26:18 +05:30
this.notes.addFlash('Error message 1', FLASH_TYPE_ALERT, this.notes.parentTimeline.get(0));
2017-09-10 17:25:29 +05:30
this.notes.clearFlash();
expect($('.flash-alert').is(':visible')).toBeFalsy();
2017-08-17 22:00:37 +05:30
});
});
});
}).call(window);