2021-04-17 20:07:23 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe MergeRequests::DeleteSourceBranchWorker do
|
|
|
|
let_it_be(:user) { create(:user) }
|
2023-03-04 22:38:38 +05:30
|
|
|
let_it_be(:merge_request) { create(:merge_request, author: user) }
|
2021-04-17 20:07:23 +05:30
|
|
|
|
|
|
|
let(:sha) { merge_request.source_branch_sha }
|
|
|
|
let(:worker) { described_class.new }
|
|
|
|
|
|
|
|
describe '#perform' do
|
2023-03-04 22:38:38 +05:30
|
|
|
before do
|
|
|
|
allow_next_instance_of(::Projects::DeleteBranchWorker) do |instance|
|
|
|
|
allow(instance).to receive(:perform).with(merge_request.source_project.id, user.id,
|
|
|
|
merge_request.source_branch)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'when the add_delete_branch_worker feature flag is enabled' do
|
|
|
|
context 'with a non-existing merge request' do
|
|
|
|
it 'does nothing' do
|
2023-03-04 22:38:38 +05:30
|
|
|
expect(::Projects::DeleteBranchWorker).not_to receive(:new)
|
2021-04-17 20:07:23 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
worker.perform(non_existing_record_id, sha, user.id)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'with a non-existing user' do
|
|
|
|
it 'does nothing' do
|
2023-03-04 22:38:38 +05:30
|
|
|
expect(::Projects::DeleteBranchWorker).not_to receive(:new)
|
2021-04-17 20:07:23 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
worker.perform(merge_request.id, sha, non_existing_record_id)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'with existing user and merge request' do
|
|
|
|
it 'creates a new delete branch worker async' do
|
2023-03-04 22:38:38 +05:30
|
|
|
expect_next_instance_of(::Projects::DeleteBranchWorker) do |instance|
|
|
|
|
expect(instance).to receive(:perform).with(merge_request.source_project.id, user.id,
|
|
|
|
merge_request.source_branch)
|
|
|
|
end
|
2023-01-13 00:05:48 +05:30
|
|
|
|
|
|
|
worker.perform(merge_request.id, sha, user.id)
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'source branch sha does not match' do
|
|
|
|
it 'does nothing' do
|
2023-03-04 22:38:38 +05:30
|
|
|
expect(::Projects::DeleteBranchWorker).not_to receive(:new)
|
2021-04-17 20:07:23 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
worker.perform(merge_request.id, 'new-source-branch-sha', user.id)
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
2023-01-13 00:05:48 +05:30
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
it_behaves_like 'an idempotent worker' do
|
|
|
|
let(:job_args) { [merge_request.id, sha, user.id] }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the add_delete_branch_worker feature flag is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(add_delete_branch_worker: false)
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'with a non-existing merge request' do
|
2021-04-17 20:07:23 +05:30
|
|
|
it 'does nothing' do
|
|
|
|
expect(::Branches::DeleteService).not_to receive(:new)
|
|
|
|
expect(::MergeRequests::RetargetChainService).not_to receive(:new)
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
worker.perform(non_existing_record_id, sha, user.id)
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'with a non-existing user' do
|
|
|
|
it 'does nothing' do
|
|
|
|
expect(::Branches::DeleteService).not_to receive(:new)
|
|
|
|
expect(::MergeRequests::RetargetChainService).not_to receive(:new)
|
|
|
|
|
|
|
|
worker.perform(merge_request.id, sha, non_existing_record_id)
|
|
|
|
end
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'with existing user and merge request' do
|
|
|
|
it 'calls service to delete source branch' do
|
2022-11-25 23:54:43 +05:30
|
|
|
expect_next_instance_of(::Branches::DeleteService) do |instance|
|
2023-01-13 00:05:48 +05:30
|
|
|
expect(instance).to receive(:execute).with(merge_request.source_branch)
|
2022-11-25 23:54:43 +05:30
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
worker.perform(merge_request.id, sha, user.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'calls service to try retarget merge requests' do
|
|
|
|
expect_next_instance_of(::MergeRequests::RetargetChainService) do |instance|
|
|
|
|
expect(instance).to receive(:execute).with(merge_request)
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
|
|
|
worker.perform(merge_request.id, sha, user.id)
|
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
context 'source branch sha does not match' do
|
|
|
|
it 'does nothing' do
|
|
|
|
expect(::Branches::DeleteService).not_to receive(:new)
|
|
|
|
expect(::MergeRequests::RetargetChainService).not_to receive(:new)
|
|
|
|
|
|
|
|
worker.perform(merge_request.id, 'new-source-branch-sha', user.id)
|
2022-11-25 23:54:43 +05:30
|
|
|
end
|
2023-01-13 00:05:48 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when delete service returns an error' do
|
|
|
|
let(:service_result) { ServiceResponse.error(message: 'placeholder') }
|
2022-11-25 23:54:43 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
it 'still retargets the merge request' do
|
2022-11-25 23:54:43 +05:30
|
|
|
expect_next_instance_of(::Branches::DeleteService) do |instance|
|
|
|
|
expect(instance).to receive(:execute).with(merge_request.source_branch).and_return(service_result)
|
|
|
|
end
|
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
expect_next_instance_of(::MergeRequests::RetargetChainService) do |instance|
|
|
|
|
expect(instance).to receive(:execute).with(merge_request)
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
|
|
|
worker.perform(merge_request.id, sha, user.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
|
2023-01-13 00:05:48 +05:30
|
|
|
it_behaves_like 'an idempotent worker' do
|
|
|
|
let(:job_args) { [merge_request.id, sha, user.id] }
|
|
|
|
end
|
2021-04-17 20:07:23 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|