2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
RSpec.describe 'Group show page', feature_category: :subgroups do
|
2021-11-11 11:23:49 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:path) { group_path(group) }
|
|
|
|
|
|
|
|
context 'when signed in' do
|
2021-11-11 11:23:49 +05:30
|
|
|
context 'with non-admin group concerns' do
|
|
|
|
before do
|
|
|
|
group.add_developer(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit path
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
it_behaves_like "an autodiscoverable RSS feed with current_user's feed token"
|
|
|
|
|
|
|
|
context 'when group does not exist' do
|
|
|
|
let(:path) { group_path('not-exist') }
|
|
|
|
|
|
|
|
it { expect(status_code).to eq(404) }
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
context 'when user is an owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows the invite banner and persists dismissal', :js do
|
|
|
|
visit path
|
|
|
|
|
|
|
|
expect(page).to have_content('Collaborate with your team')
|
2018-05-09 12:01:36 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
page.within(find('[data-testid="invite-members-banner"]')) do
|
|
|
|
find('[data-testid="close-icon"]').click
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(page).not_to have_content('Collaborate with your team')
|
|
|
|
|
|
|
|
visit path
|
|
|
|
|
|
|
|
expect(page).not_to have_content('Collaborate with your team')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when group has a project with emoji in description', :js do
|
|
|
|
let!(:project) { create(:project, description: ':smile:', namespace: group) }
|
|
|
|
|
|
|
|
it 'shows the project info', :aggregate_failures do
|
|
|
|
visit path
|
|
|
|
|
|
|
|
expect(page).to have_content(project.title)
|
|
|
|
expect(page).to have_emoji('smile')
|
|
|
|
end
|
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
context 'when group has projects' do
|
|
|
|
it 'allows users to sorts projects by most stars', :js do
|
|
|
|
project1 = create(:project, namespace: group, star_count: 2)
|
|
|
|
project2 = create(:project, namespace: group, star_count: 3)
|
|
|
|
project3 = create(:project, namespace: group, star_count: 0)
|
|
|
|
|
|
|
|
visit group_path(group, sort: :stars_desc)
|
|
|
|
|
|
|
|
expect(find('.group-row:nth-child(1) .namespace-title > a')).to have_content(project2.title)
|
|
|
|
expect(find('.group-row:nth-child(2) .namespace-title > a')).to have_content(project1.title)
|
|
|
|
expect(find('.group-row:nth-child(3) .namespace-title > a')).to have_content(project3.title)
|
|
|
|
end
|
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
2022-07-23 23:45:48 +05:30
|
|
|
|
|
|
|
context 'subgroups and projects empty state', :js do
|
|
|
|
context 'when user has permissions to create new subgroups or projects' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit path
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows `Create new subgroup` link' do
|
|
|
|
expect(page).to have_link(
|
|
|
|
s_('GroupsEmptyState|Create new subgroup'),
|
2022-08-27 11:52:29 +05:30
|
|
|
href: new_group_path(parent_id: group.id, anchor: 'create-group-pane')
|
2022-07-23 23:45:48 +05:30
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows `Create new project` link' do
|
|
|
|
expect(page).to have_link(
|
|
|
|
s_('GroupsEmptyState|Create new project'),
|
|
|
|
href: new_project_path(namespace_id: group.id)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
context 'visibility warning popover' do
|
2022-08-13 15:12:31 +05:30
|
|
|
let_it_be(:public_project) { create(:project, :public) }
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
shared_examples 'it shows warning popover' do
|
|
|
|
it 'shows warning popover', :js do
|
|
|
|
group_to_share_with.add_owner(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit group_path(group_to_share_with)
|
|
|
|
|
|
|
|
click_link _('Shared projects')
|
2022-08-13 15:12:31 +05:30
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
wait_for_requests
|
2022-08-13 15:12:31 +05:30
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
page.within("[data-testid=\"group-overview-item-#{public_project.id}\"]") do
|
|
|
|
click_button _('Less restrictive visibility')
|
|
|
|
end
|
2022-08-13 15:12:31 +05:30
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
expect(page).to have_content _('Project visibility level is less restrictive than the group settings.')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a public project is shared with a private group' do
|
|
|
|
let_it_be(:group_to_share_with) { create(:group, :private) }
|
|
|
|
let_it_be(:project_group_link) do
|
|
|
|
create(:project_group_link, group: group_to_share_with, project: public_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'it shows warning popover'
|
|
|
|
end
|
2022-08-13 15:12:31 +05:30
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
context 'when a public project is shared with an internal group' do
|
|
|
|
let_it_be(:group_to_share_with) { create(:group, :internal) }
|
|
|
|
let_it_be(:project_group_link) do
|
|
|
|
create(:project_group_link, group: group_to_share_with, project: public_project)
|
2022-08-13 15:12:31 +05:30
|
|
|
end
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
include_examples 'it shows warning popover'
|
2022-08-13 15:12:31 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
context 'when user does not have permissions to create new subgroups or projects', :js do
|
|
|
|
before do
|
|
|
|
group.add_reporter(user)
|
|
|
|
sign_in(user)
|
|
|
|
visit path
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show `Create new subgroup` link' do
|
|
|
|
expect(page).not_to have_link(
|
|
|
|
s_('GroupsEmptyState|Create new subgroup'),
|
|
|
|
href: new_group_path(parent_id: group.id)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show `Create new project` link' do
|
|
|
|
expect(page).not_to have_link(
|
|
|
|
s_('GroupsEmptyState|Create new project'),
|
|
|
|
href: new_project_path(namespace_id: group.id)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows empty state' do
|
|
|
|
expect(page).to have_content(s_('GroupsEmptyState|No subgroups or projects.'))
|
|
|
|
expect(page).to have_content(s_('GroupsEmptyState|You do not have necessary permissions to create a subgroup' \
|
|
|
|
' or project in this group. Please contact an owner of this group to create a new subgroup or project.'))
|
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when signed out' do
|
2018-05-09 12:01:36 +05:30
|
|
|
describe 'RSS' do
|
|
|
|
before do
|
|
|
|
visit path
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it_behaves_like "an autodiscoverable RSS feed without a feed token"
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when group has a public project', :js do
|
|
|
|
let!(:project) { create(:project, :public, namespace: group) }
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
it 'renders public project', :aggregate_failures do
|
2018-05-09 12:01:36 +05:30
|
|
|
visit path
|
|
|
|
|
|
|
|
expect(page).to have_link group.name
|
|
|
|
expect(page).to have_link project.name
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2018-05-09 12:01:36 +05:30
|
|
|
context 'when group has a private project', :js do
|
|
|
|
let!(:project) { create(:project, :private, namespace: group) }
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
it 'does not render private project', :aggregate_failures do
|
2018-05-09 12:01:36 +05:30
|
|
|
visit path
|
|
|
|
|
|
|
|
expect(page).to have_link group.name
|
|
|
|
expect(page).not_to have_link project.name
|
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context 'subgroup support' do
|
2021-11-11 11:23:49 +05:30
|
|
|
let_it_be(:restricted_group) do
|
2019-10-12 21:52:04 +05:30
|
|
|
create(:group, subgroup_creation_level: ::Gitlab::Access::OWNER_SUBGROUP_ACCESS)
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'for owners' do
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
restricted_group.add_owner(user)
|
|
|
|
sign_in(user)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'when subgroups are supported' do
|
|
|
|
it 'allows creating subgroups' do
|
2021-11-11 11:23:49 +05:30
|
|
|
visit group_path(restricted_group)
|
2019-10-12 21:52:04 +05:30
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
expect(page).to have_link('New subgroup')
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'for maintainers' do
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
sign_in(user)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'when subgroups are supported' do
|
|
|
|
context 'when subgroup_creation_level is set to maintainers' do
|
2021-11-11 11:23:49 +05:30
|
|
|
let(:relaxed_group) do
|
|
|
|
create(:group, subgroup_creation_level: ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS)
|
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
relaxed_group.add_maintainer(user)
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows creating subgroups' do
|
2021-11-11 11:23:49 +05:30
|
|
|
visit group_path(relaxed_group)
|
2019-10-12 21:52:04 +05:30
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
expect(page).to have_link('New subgroup')
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when subgroup_creation_level is set to owners' do
|
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
restricted_group.add_maintainer(user)
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating subgroups' do
|
2021-11-11 11:23:49 +05:30
|
|
|
visit group_path(restricted_group)
|
2019-10-12 21:52:04 +05:30
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
expect(page).not_to have_link('New subgroup')
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'notification button', :js do
|
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
group.add_maintainer(user)
|
|
|
|
sign_in(user)
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'is enabled by default' do
|
|
|
|
visit path
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect(page).to have_selector('[data-testid="notification-dropdown"] button:not(.disabled)')
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'is disabled if emails are disabled' do
|
2021-11-11 11:23:49 +05:30
|
|
|
group.update!(emails_disabled: true)
|
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
visit path
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect(page).to have_selector('[data-testid="notification-dropdown"] .disabled')
|
2019-10-12 21:52:04 +05:30
|
|
|
end
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
|
|
|
context 'page og:description' do
|
|
|
|
before do
|
2021-11-11 11:23:49 +05:30
|
|
|
group.update!(description: '**Lorem** _ipsum_ dolor sit [amet](https://example.com)')
|
|
|
|
group.add_maintainer(user)
|
|
|
|
sign_in(user)
|
2021-01-03 14:25:43 +05:30
|
|
|
visit path
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'page meta description', 'Lorem ipsum dolor sit amet'
|
|
|
|
end
|
2021-02-22 17:27:13 +05:30
|
|
|
|
|
|
|
context 'structured schema markup' do
|
|
|
|
let_it_be(:group) { create(:group, :public, :with_avatar, description: 'foo') }
|
|
|
|
let_it_be(:subgroup) { create(:group, :public, :with_avatar, parent: group, description: 'bar') }
|
|
|
|
let_it_be_with_reload(:project) { create(:project, :public, :with_avatar, namespace: group, description: 'foo') }
|
|
|
|
let_it_be(:subproject) { create(:project, :public, :with_avatar, namespace: subgroup, description: 'bar') }
|
|
|
|
|
|
|
|
it 'shows Organization structured markup', :js do
|
|
|
|
visit path
|
|
|
|
wait_for_all_requests
|
|
|
|
|
|
|
|
aggregate_failures do
|
|
|
|
expect(page).to have_selector('.content[itemscope][itemtype="https://schema.org/Organization"]')
|
|
|
|
|
|
|
|
page.within('.group-home-panel') do
|
2021-09-30 23:02:18 +05:30
|
|
|
expect(page).to have_selector('[itemprop="logo"]')
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(page).to have_selector('[itemprop="name"]', text: group.name)
|
|
|
|
expect(page).to have_selector('[itemprop="description"]', text: group.description)
|
|
|
|
end
|
|
|
|
|
|
|
|
page.within('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]') do
|
2021-09-30 23:02:18 +05:30
|
|
|
expect(page).to have_selector('[itemprop="image"]')
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(page).to have_selector('[itemprop="name"]', text: project.name)
|
|
|
|
expect(page).to have_selector('[itemprop="description"]', text: project.description)
|
|
|
|
end
|
|
|
|
|
|
|
|
# Finding the subgroup row and expanding it
|
|
|
|
el = find('[itemprop="subOrganization"][itemtype="https://schema.org/Organization"]')
|
|
|
|
el.click
|
|
|
|
wait_for_all_requests
|
|
|
|
page.within(el) do
|
2021-09-30 23:02:18 +05:30
|
|
|
expect(page).to have_selector('[itemprop="logo"]')
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(page).to have_selector('[itemprop="name"]', text: subgroup.name)
|
|
|
|
expect(page).to have_selector('[itemprop="description"]', text: subgroup.description)
|
|
|
|
|
|
|
|
page.within('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]') do
|
2021-09-30 23:02:18 +05:30
|
|
|
expect(page).to have_selector('[itemprop="image"]')
|
2021-02-22 17:27:13 +05:30
|
|
|
expect(page).to have_selector('[itemprop="name"]', text: subproject.name)
|
|
|
|
expect(page).to have_selector('[itemprop="description"]', text: subproject.description)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
it 'does not include structured markup in shared projects tab', :aggregate_failures, :js do
|
2021-02-22 17:27:13 +05:30
|
|
|
other_project = create(:project, :public)
|
|
|
|
other_project.project_group_links.create!(group: group)
|
|
|
|
|
|
|
|
visit group_shared_path(group)
|
|
|
|
wait_for_all_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('li.group-row')
|
|
|
|
expect(page).not_to have_selector('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]')
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
it 'does not include structured markup in archived projects tab', :aggregate_failures, :js do
|
2021-02-22 17:27:13 +05:30
|
|
|
project.update!(archived: true)
|
|
|
|
|
|
|
|
visit group_archived_path(group)
|
|
|
|
wait_for_all_requests
|
|
|
|
|
|
|
|
expect(page).to have_selector('li.group-row')
|
|
|
|
expect(page).not_to have_selector('[itemprop="owns"][itemtype="https://schema.org/SoftwareSourceCode"]')
|
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|