debian-mirror-gitlab/doc/development/audit_event_guide/index.md

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

248 lines
9.8 KiB
Markdown
Raw Normal View History

2021-06-08 01:23:25 +05:30
---
2022-10-11 01:57:18 +05:30
stage: Govern
2021-06-08 01:23:25 +05:30
group: Compliance
2022-11-25 23:54:43 +05:30
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/product/ux/technical-writing/#assignments
2021-06-08 01:23:25 +05:30
---
# Audit Event Guide
This guide provides an overview of how Audit Events work, and how to instrument
new audit events.
## What are Audit Events?
Audit Events are a tool for GitLab owners and administrators to view records of important
actions performed across the application.
2022-07-23 23:45:48 +05:30
## What should not be Audit Events?
While any events could trigger an Audit Event, not all events should. In general, events that are not good candidates for audit events are:
- Not attributable to one specific user.
2022-11-25 23:54:43 +05:30
- Not of specific interest to an administrator or owner persona.
2022-07-23 23:45:48 +05:30
- Are tracking information for product feature adoption.
2023-01-13 00:05:48 +05:30
- Are covered in the direction page's discussion on [what is not planned](https://about.gitlab.com/direction/govern/compliance/audit-events/#what-is-not-planned-right-now).
2022-07-23 23:45:48 +05:30
2023-01-13 00:05:48 +05:30
If you have any questions, please reach out to `@gitlab-org/govern/compliance` to see if an Audit Event, or some other approach, may be best for your event.
2022-07-23 23:45:48 +05:30
2021-06-08 01:23:25 +05:30
## Audit Event Schemas
To instrument an audit event, the following attributes should be provided:
2022-08-27 11:52:29 +05:30
| Attribute | Type | Required? | Description |
|:-------------|:---------------------|:----------|:------------------------------------------------------------------|
2022-10-11 01:57:18 +05:30
| `name` | String | false | Action name to be audited. Represents the [type of the event](#event-type-definitions). Used for error tracking |
2022-08-27 11:52:29 +05:30
| `author` | User | true | User who authors the change |
| `scope` | User, Project, Group | true | Scope which the audit event belongs to |
| `target` | Object | true | Target object being audited |
| `message` | String | true | Message describing the action ([not translated](#i18n-and-the-audit-event-message-attribute)) |
2022-07-16 23:28:13 +05:30
| `created_at` | DateTime | false | The time when the action occurred. Defaults to `DateTime.current` |
2021-06-08 01:23:25 +05:30
## How to instrument new Audit Events
2022-10-11 01:57:18 +05:30
1. Create a [YAML type definition](#add-a-new-audit-event-type) for the new audit event.
1. Call `Gitlab::Audit::Auditor.audit`, passing an action block.
The following ways of instrumenting audit events are deprecated:
2021-06-08 01:23:25 +05:30
- Create a new class in `ee/lib/ee/audit/` and extend `AuditEventService`
- Call `AuditEventService` after a successful action
2022-10-11 01:57:18 +05:30
With `Gitlab::Audit::Auditor` service, we can instrument audit events in two ways:
2021-06-08 01:23:25 +05:30
- Using block for multiple events.
- Using standard method call for single events.
### Using block to record multiple events
This method is useful when events are emitted deep in the call stack.
For example, we can record multiple audit events when the user updates a merge
request approval rule. As part of this user flow, we would like to audit changes
to both approvers and approval groups. In the initiating service
(for example, `MergeRequestRuleUpdateService`), we can wrap the `execute` call as follows:
```ruby
# in the initiating service
audit_context = {
2021-09-30 23:02:18 +05:30
name: 'update_merge_approval_rule',
2021-06-08 01:23:25 +05:30
author: current_user,
scope: project_alpha,
target: merge_approval_rule,
message: 'Attempted to update an approval rule'
}
2021-09-30 23:02:18 +05:30
::Gitlab::Audit::Auditor.audit(audit_context) do
2021-06-08 01:23:25 +05:30
service.execute
end
```
In the model (for example, `ApprovalProjectRule`), we can push audit events on model
callbacks (for example, `after_save` or `after_add`).
```ruby
# in the model
include Auditable
def audit_add(model)
push_audit_event('Added an approver on Security rule')
end
def audit_remove(model)
push_audit_event('Removed an approver on Security rule')
end
```
2021-10-27 15:23:28 +05:30
This method does not support actions that are asynchronous, or
2021-06-08 01:23:25 +05:30
span across multiple processes (for example, background jobs).
### Using standard method call to record single event
This method allows recording single audit event and involves fewer moving parts.
```ruby
if merge_approval_rule.save
audit_context = {
2021-09-30 23:02:18 +05:30
name: 'create_merge_approval_rule',
2021-06-08 01:23:25 +05:30
author: current_user,
scope: project_alpha,
target: merge_approval_rule,
2022-06-21 17:19:12 +05:30
message: 'Created a new approval rule',
created_at: DateTime.current # Useful for pre-dating an audit event when created asynchronously.
2021-06-08 01:23:25 +05:30
}
2021-09-30 23:02:18 +05:30
::Gitlab::Audit::Auditor.audit(audit_context)
2021-06-08 01:23:25 +05:30
end
```
2022-06-21 17:19:12 +05:30
### Data volume considerations
Because every audit event is persisted to the database, consider the amount of data we expect to generate, and the rate of generation, for new
audit events. For new audit events that will produce a lot of data in the database, consider adding a
[streaming-only audit event](#event-streaming) instead. If you have questions about this, feel free to ping
2023-01-13 00:05:48 +05:30
`@gitlab-org/govern/compliance/backend` in an issue or merge request.
2022-06-21 17:19:12 +05:30
2021-06-08 01:23:25 +05:30
## Audit Event instrumentation flows
The two ways we can instrument audit events have different flows.
### Using block to record multiple events
We wrap the operation block in a `Gitlab::Audit::Auditor` which captures the
2021-09-30 23:02:18 +05:30
initial audit context (that is, `author`, `scope`, `target`) object that are
2021-06-08 01:23:25 +05:30
available at the time the operation is initiated.
Extra instrumentation is required in the interacted classes in the chain with
`Auditable` mixin to add audit events to the Audit Event queue via `Gitlab::Audit::EventQueue`.
The `EventQueue` is stored in a local thread via `SafeRequestStore` and then later
extracted when we record an audit event in `Gitlab::Audit::Auditor`.
```plantuml
skinparam shadowing false
skinparam BoxPadding 10
skinparam ParticipantPadding 20
participant "Instrumented Class" as A
participant "Audit::Auditor" as A1 #LightBlue
participant "Audit::EventQueue" as B #LightBlue
participant "Interacted Class" as C
participant "AuditEvent" as D
A->A1: audit <b>{ block }
activate A1
A1->B: begin!
A1->C: <b>block.call
activate A1 #FFBBBB
activate C
C-->B: push [ message ]
C-->A1: true
deactivate A1
deactivate C
A1->B: read
activate A1 #FFBBBB
activate B
B-->A1: [ messages ]
deactivate B
A1->D: bulk_insert!
deactivate A1
A1->B: end!
A1-->A:
deactivate A1
```
### Using standard method call to record single event
This method has a more straight-forward flow, and does not rely on `EventQueue`
and local thread.
```plantuml
skinparam shadowing false
skinparam BoxPadding 10
skinparam ParticipantPadding 20
participant "Instrumented Class" as A
participant "Audit::Auditor" as B #LightBlue
participant "AuditEvent" as C
A->B: audit
activate B
B->C: bulk_insert!
B-->A:
deactivate B
```
In addition to recording to the database, we also write these events to
2022-08-27 11:52:29 +05:30
[a log file](../../administration/logs/index.md#audit_jsonlog).
2022-01-26 12:08:38 +05:30
2022-10-11 01:57:18 +05:30
## Event type definitions
> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/367847) in GitLab 15.4.
All new audit events must have a type definition stored in `config/audit_events/types/` that contains a single source of truth for every auditable event in GitLab.
### Add a new audit event type
To add a new audit event type:
2023-01-13 00:05:48 +05:30
1. Create the YAML definition. You can either:
- Use the `bin/audit-event-type` CLI to create the YAML definition automatically.
- Perform manual steps to create a new file in `config/audit_events/types/` with the filename matching the name of the event type. For example,
a definition for the event type triggered when a user is added to a project might be stored in `config/audit_events/types/project_add_user.yml`.
2022-10-11 01:57:18 +05:30
1. Add contents to the file that conform to the [schema](#schema) defined in `config/audit_events/types/type_schema.json`.
1. Ensure that all calls to `Gitlab::Audit::Auditor` use the `name` defined in your file.
### Schema
| Field | Required | Description |
| ----- | -------- |--------------|
| `name` | yes | Unique, lowercase and underscored name describing the type of event. Must match the filename. |
| `description` | yes | Human-readable description of how this event is triggered |
| `group` | yes | Name of the group that introduced this audit event. For example, `manage::compliance` |
| `introduced_by_issue` | yes | Issue URL that proposed the addition of this type |
| `introduced_by_mr` | yes | MR URL that added this new type |
| `milestone` | yes | Milestone in which this type was added |
| `saved_to_database` | yes | Indicate whether to persist events to database and JSON logs |
| `streamed` | yes | Indicate that events should be streamed to external services (if configured) |
2022-01-26 12:08:38 +05:30
## Event streaming
All events where the entity is a `Group` or `Project` are recorded in the audit log, and also streamed to one or more
[event streaming destinations](../../administration/audit_event_streaming.md). When the entity is a:
- `Group`, events are streamed to the group's root ancestor's event streaming destinations.
- `Project`, events are streamed to the project's root ancestor's event streaming destinations.
2022-06-21 17:19:12 +05:30
You can add streaming-only events that are not stored in the GitLab database. This is primarily intended to be used for actions that generate
a large amount of data. See [this merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76719/diffs#d56e47632f0384722d411ed3ab5b15e947bd2265_26_36)
for an example.
2022-01-26 12:08:38 +05:30
This feature is under heavy development. Follow the [parent epic](https://gitlab.com/groups/gitlab-org/-/epics/5925) for updates on feature
development.
2022-08-27 11:52:29 +05:30
### I18N and the Audit Event `:message` attribute
We intentionally do not translate audit event messages because translated messages would be saved in the database and served to users, regardless of their locale settings.
2023-03-17 16:20:25 +05:30
This could mean, for example, that we use the locale for the currently authenticated user to record an audit event message and stream the message to an external streaming
2022-08-27 11:52:29 +05:30
destination in the wrong language for that destination. Users could find that confusing.