debian-mirror-gitlab/spec/requests/api/variables_spec.rb

196 lines
6.5 KiB
Ruby
Raw Normal View History

require 'spec_helper'
2017-08-17 22:00:37 +05:30
describe API::Variables do
let(:user) { create(:user) }
let(:user2) { create(:user) }
2017-09-10 17:25:29 +05:30
let!(:project) { create(:project, creator_id: user.id) }
2018-11-18 11:00:15 +05:30
let!(:maintainer) { create(:project_member, :maintainer, user: user, project: project) }
2016-06-02 11:05:42 +05:30
let!(:developer) { create(:project_member, :developer, user: user2, project: project) }
let!(:variable) { create(:ci_variable, project: project) }
describe 'GET /projects/:id/variables' do
context 'authorized user with proper permissions' do
2016-09-13 17:45:13 +05:30
it 'returns project variables' do
get api("/projects/#{project.id}/variables", user)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(json_response).to be_a(Array)
end
end
context 'authorized user with invalid permissions' do
2016-09-13 17:45:13 +05:30
it 'does not return project variables' do
get api("/projects/#{project.id}/variables", user2)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
end
end
context 'unauthorized user' do
2016-09-13 17:45:13 +05:30
it 'does not return project variables' do
get api("/projects/#{project.id}/variables")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
end
end
end
describe 'GET /projects/:id/variables/:key' do
context 'authorized user with proper permissions' do
2016-09-13 17:45:13 +05:30
it 'returns project variable details' do
get api("/projects/#{project.id}/variables/#{variable.key}", user)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(json_response['value']).to eq(variable.value)
2017-09-10 17:25:29 +05:30
expect(json_response['protected']).to eq(variable.protected?)
end
2016-09-13 17:45:13 +05:30
it 'responds with 404 Not Found if requesting non-existing variable' do
get api("/projects/#{project.id}/variables/non_existing_variable", user)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
end
end
context 'authorized user with invalid permissions' do
2016-09-13 17:45:13 +05:30
it 'does not return project variable details' do
get api("/projects/#{project.id}/variables/#{variable.key}", user2)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
end
end
context 'unauthorized user' do
2016-09-13 17:45:13 +05:30
it 'does not return project variable details' do
get api("/projects/#{project.id}/variables/#{variable.key}")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
end
end
end
describe 'POST /projects/:id/variables' do
context 'authorized user with proper permissions' do
2016-09-13 17:45:13 +05:30
it 'creates variable' do
2017-09-10 17:25:29 +05:30
expect do
post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_2', value: 'VALUE_2', protected: true
2018-03-17 18:26:18 +05:30
end.to change {project.variables.count}.by(1)
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(201)
2017-09-10 17:25:29 +05:30
expect(json_response['key']).to eq('TEST_VARIABLE_2')
expect(json_response['value']).to eq('VALUE_2')
expect(json_response['protected']).to be_truthy
end
it 'creates variable with optional attributes' do
expect do
post api("/projects/#{project.id}/variables", user), key: 'TEST_VARIABLE_2', value: 'VALUE_2'
2018-03-17 18:26:18 +05:30
end.to change {project.variables.count}.by(1)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(201)
expect(json_response['key']).to eq('TEST_VARIABLE_2')
expect(json_response['value']).to eq('VALUE_2')
2017-09-10 17:25:29 +05:30
expect(json_response['protected']).to be_falsey
end
2016-09-13 17:45:13 +05:30
it 'does not allow to duplicate variable key' do
expect do
post api("/projects/#{project.id}/variables", user), key: variable.key, value: 'VALUE_2'
2018-03-17 18:26:18 +05:30
end.to change {project.variables.count}.by(0)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(400)
end
end
context 'authorized user with invalid permissions' do
2016-09-13 17:45:13 +05:30
it 'does not create variable' do
post api("/projects/#{project.id}/variables", user2)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
end
end
context 'unauthorized user' do
2016-09-13 17:45:13 +05:30
it 'does not create variable' do
post api("/projects/#{project.id}/variables")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
end
end
end
describe 'PUT /projects/:id/variables/:key' do
context 'authorized user with proper permissions' do
2016-09-13 17:45:13 +05:30
it 'updates variable data' do
2018-03-17 18:26:18 +05:30
initial_variable = project.variables.reload.first
value_before = initial_variable.value
2017-09-10 17:25:29 +05:30
put api("/projects/#{project.id}/variables/#{variable.key}", user), value: 'VALUE_1_UP', protected: true
2018-03-17 18:26:18 +05:30
updated_variable = project.variables.reload.first
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(value_before).to eq(variable.value)
expect(updated_variable.value).to eq('VALUE_1_UP')
2017-09-10 17:25:29 +05:30
expect(updated_variable).to be_protected
end
2016-09-13 17:45:13 +05:30
it 'responds with 404 Not Found if requesting non-existing variable' do
put api("/projects/#{project.id}/variables/non_existing_variable", user)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
end
end
context 'authorized user with invalid permissions' do
2016-09-13 17:45:13 +05:30
it 'does not update variable' do
put api("/projects/#{project.id}/variables/#{variable.key}", user2)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
end
end
context 'unauthorized user' do
2016-09-13 17:45:13 +05:30
it 'does not update variable' do
put api("/projects/#{project.id}/variables/#{variable.key}")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
end
end
end
describe 'DELETE /projects/:id/variables/:key' do
context 'authorized user with proper permissions' do
2016-09-13 17:45:13 +05:30
it 'deletes variable' do
expect do
delete api("/projects/#{project.id}/variables/#{variable.key}", user)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(204)
end.to change {project.variables.count}.by(-1)
end
2016-09-13 17:45:13 +05:30
it 'responds with 404 Not Found if requesting non-existing variable' do
delete api("/projects/#{project.id}/variables/non_existing_variable", user)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
end
end
context 'authorized user with invalid permissions' do
2016-09-13 17:45:13 +05:30
it 'does not delete variable' do
delete api("/projects/#{project.id}/variables/#{variable.key}", user2)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
end
end
context 'unauthorized user' do
2016-09-13 17:45:13 +05:30
it 'does not delete variable' do
delete api("/projects/#{project.id}/variables/#{variable.key}")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
end
end
end
end