debian-mirror-gitlab/spec/requests/api/services_spec.rb

202 lines
6.2 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
require "spec_helper"
2017-08-17 22:00:37 +05:30
describe API::Services do
2018-03-17 18:26:18 +05:30
set(:user) { create(:user) }
set(:admin) { create(:admin) }
set(:user2) { create(:user) }
set(:project) do
create(:project, creator_id: user.id, namespace: user.namespace)
end
2014-09-02 18:07:02 +05:30
2015-09-25 12:07:36 +05:30
Service.available_services_names.each do |service|
describe "PUT /projects/:id/services/#{service.dasherize}" do
include_context service
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "updates #{service} settings" do
2015-09-25 12:07:36 +05:30
put api("/projects/#{project.id}/services/#{dashed_service}", user), service_attrs
2014-09-02 18:07:02 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-08-17 22:00:37 +05:30
current_service = project.services.first
event = current_service.event_names.empty? ? "foo" : current_service.event_names.first
state = current_service[event] || false
put api("/projects/#{project.id}/services/#{dashed_service}?#{event}=#{!state}", user), service_attrs
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-08-17 22:00:37 +05:30
expect(project.services.first[event]).not_to eq(state) unless event == "foo"
2015-09-25 12:07:36 +05:30
end
2015-09-11 14:41:01 +05:30
2016-09-13 17:45:13 +05:30
it "returns if required fields missing" do
2015-09-25 12:07:36 +05:30
attrs = service_attrs
2015-09-11 14:41:01 +05:30
2015-09-25 12:07:36 +05:30
required_attributes = service_attrs_list.select do |attr|
service_klass.validators_on(attr).any? do |v|
v.class == ActiveRecord::Validations::PresenceValidator
end
end
2015-09-11 14:41:01 +05:30
2015-09-25 12:07:36 +05:30
if required_attributes.empty?
expected_code = 200
else
2015-12-23 02:04:40 +05:30
attrs.delete(required_attributes.sample)
2015-09-25 12:07:36 +05:30
expected_code = 400
end
2016-09-13 17:45:13 +05:30
2015-09-25 12:07:36 +05:30
put api("/projects/#{project.id}/services/#{dashed_service}", user), attrs
2015-09-11 14:41:01 +05:30
2015-09-25 12:07:36 +05:30
expect(response.status).to eq(expected_code)
end
2015-09-11 14:41:01 +05:30
end
2014-09-02 18:07:02 +05:30
2015-09-25 12:07:36 +05:30
describe "DELETE /projects/:id/services/#{service.dasherize}" do
include_context service
2014-09-02 18:07:02 +05:30
2018-03-17 18:26:18 +05:30
before do
initialize_service(service)
end
2016-09-13 17:45:13 +05:30
it "deletes #{service}" do
2015-09-25 12:07:36 +05:30
delete api("/projects/#{project.id}/services/#{dashed_service}", user)
2015-04-26 12:48:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(204)
2015-11-26 14:37:03 +05:30
project.send(service_method).reload
2015-09-25 12:07:36 +05:30
expect(project.send(service_method).activated?).to be_falsey
end
2015-04-26 12:48:37 +05:30
end
2015-09-25 12:07:36 +05:30
describe "GET /projects/:id/services/#{service.dasherize}" do
include_context service
2015-04-26 12:48:37 +05:30
2015-10-24 18:46:33 +05:30
# inject some properties into the service
before do
2018-03-17 18:26:18 +05:30
initialize_service(service)
2015-10-24 18:46:33 +05:30
end
2016-09-13 17:45:13 +05:30
it 'returns authentication error when unauthenticated' do
2015-10-24 18:46:33 +05:30
get api("/projects/#{project.id}/services/#{dashed_service}")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
2015-10-24 18:46:33 +05:30
end
2016-09-13 17:45:13 +05:30
it "returns all properties of service #{service} when authenticated as admin" do
2015-10-24 18:46:33 +05:30
get api("/projects/#{project.id}/services/#{dashed_service}", admin)
2016-09-13 17:45:13 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(json_response['properties'].keys).to match_array(service_instance.api_field_names)
2015-10-24 18:46:33 +05:30
end
2016-09-13 17:45:13 +05:30
it "returns properties of service #{service} other than passwords when authenticated as project owner" do
2015-09-25 12:07:36 +05:30
get api("/projects/#{project.id}/services/#{dashed_service}", user)
2015-04-26 12:48:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(json_response['properties'].keys).to match_array(service_instance.api_field_names)
2015-09-25 12:07:36 +05:30
end
2015-10-24 18:46:33 +05:30
2016-09-13 17:45:13 +05:30
it "returns error when authenticated but not a project owner" do
2018-03-17 18:26:18 +05:30
project.add_developer(user2)
2015-10-24 18:46:33 +05:30
get api("/projects/#{project.id}/services/#{dashed_service}", user2)
2016-09-13 17:45:13 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(403)
2015-10-24 18:46:33 +05:30
end
2014-09-02 18:07:02 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'POST /projects/:id/services/:slug/trigger' do
describe 'Mattermost Service' do
let(:service_name) { 'mattermost_slash_commands' }
context 'no service is available' do
it 'returns a not found message' do
post api("/projects/#{project.id}/services/idonotexist/trigger")
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2017-08-17 22:00:37 +05:30
expect(json_response["error"]).to eq("404 Not Found")
end
end
context 'the service exists' do
let(:params) { { token: 'token' } }
context 'the service is not active' do
before do
project.create_mattermost_slash_commands_service(
active: false,
properties: params
)
end
it 'when the service is inactive' do
post api("/projects/#{project.id}/services/#{service_name}/trigger"), params
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2017-08-17 22:00:37 +05:30
end
end
context 'the service is active' do
before do
project.create_mattermost_slash_commands_service(
active: true,
properties: params
)
end
it 'returns status 200' do
post api("/projects/#{project.id}/services/#{service_name}/trigger"), params
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-08-17 22:00:37 +05:30
end
end
context 'when the project can not be found' do
it 'returns a generic 404' do
post api("/projects/404/services/#{service_name}/trigger"), params
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2017-08-17 22:00:37 +05:30
expect(json_response["message"]).to eq("404 Service Not Found")
end
end
end
end
describe 'Slack Service' do
let(:service_name) { 'slack_slash_commands' }
before do
project.create_slack_slash_commands_service(
active: true,
properties: { token: 'token' }
)
end
it 'returns status 200' do
post api("/projects/#{project.id}/services/#{service_name}/trigger"), token: 'token', text: 'help'
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-08-17 22:00:37 +05:30
expect(json_response['response_type']).to eq("ephemeral")
end
end
end
2018-03-17 18:26:18 +05:30
describe 'Mattermost service' do
let(:service_name) { 'mattermost' }
let(:params) do
{ webhook: 'https://hook.example.com', username: 'username' }
end
before do
project.create_mattermost_service(
active: true,
properties: params
)
end
it 'accepts a username for update' do
put api("/projects/#{project.id}/services/mattermost", user), params.merge(username: 'new_username')
expect(response).to have_gitlab_http_status(200)
expect(json_response['properties']['username']).to eq('new_username')
end
end
2014-09-02 18:07:02 +05:30
end