debian-mirror-gitlab/spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb

173 lines
4.9 KiB
Ruby
Raw Normal View History

2019-12-21 20:55:43 +05:30
# frozen_string_literal: true
2018-05-09 12:01:36 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe ObjectStorage::MigrateUploadsWorker do
2018-05-09 12:01:36 +05:30
let(:model_class) { Project }
2018-10-15 14:42:47 +05:30
let(:uploads) { Upload.all }
2018-05-09 12:01:36 +05:30
let(:to_store) { ObjectStorage::Store::REMOTE }
2019-12-21 20:55:43 +05:30
def perform(uploads, store = nil)
described_class.new.perform(uploads.ids, model_class.to_s, mounted_as, store || to_store)
2018-11-08 19:23:39 +05:30
rescue ObjectStorage::MigrateUploadsWorker::Report::MigrationFailures
# swallow
end
2021-01-29 00:20:46 +05:30
# Expects the calling spec to define:
# - model_class
# - mounted_as
# - to_store
RSpec.shared_examples 'uploads migration worker' do
describe '.enqueue!' do
def enqueue!
described_class.enqueue!(uploads, model_class, mounted_as, to_store)
end
it 'is guarded by .sanity_check!' do
expect(described_class).to receive(:perform_async)
expect(described_class).to receive(:sanity_check!)
enqueue!
end
context 'sanity_check! fails' do
before do
expect(described_class).to receive(:sanity_check!).and_raise(described_class::SanityCheckError)
end
it 'does not enqueue a job' do
expect(described_class).not_to receive(:perform_async)
expect { enqueue! }.to raise_error(described_class::SanityCheckError)
end
end
end
describe '.sanity_check!' do
shared_examples 'raises a SanityCheckError' do |expected_message|
let(:mount_point) { nil }
it do
expect { described_class.sanity_check!(uploads, model_class, mount_point) }
.to raise_error(described_class::SanityCheckError).with_message(expected_message)
end
end
context 'uploader types mismatch' do
let!(:outlier) { create(:upload, uploader: 'GitlabUploader') }
include_examples 'raises a SanityCheckError', /Multiple uploaders found/
end
context 'mount point not found' do
include_examples 'raises a SanityCheckError', /Mount point [a-z:]+ not found in/ do
let(:mount_point) { :potato }
end
end
end
describe '#perform' do
it 'migrates files to remote storage' do
expect(Gitlab::AppLogger).to receive(:info).with(%r{Migrated 1/1 files})
perform(uploads)
expect(Upload.where(store: ObjectStorage::Store::LOCAL).count).to eq(0)
end
context 'reversed' do
let(:to_store) { ObjectStorage::Store::LOCAL }
before do
perform(uploads, ObjectStorage::Store::REMOTE)
end
it 'migrates files to local storage' do
expect(Upload.where(store: ObjectStorage::Store::REMOTE).count).to eq(1)
perform(uploads)
expect(Upload.where(store: ObjectStorage::Store::LOCAL).count).to eq(1)
end
end
context 'migration is unsuccessful' do
before do
allow_any_instance_of(ObjectStorage::Concern)
.to receive(:migrate!).and_raise(CarrierWave::UploadError, 'I am a teapot.')
end
it 'does not migrate files to remote storage' do
expect(Gitlab::AppLogger).to receive(:warn).with(/Error .* I am a teapot/)
perform(uploads)
expect(Upload.where(store: ObjectStorage::Store::LOCAL).count).to eq(1)
end
end
end
end
2018-10-15 14:42:47 +05:30
context "for AvatarUploader" do
2021-01-29 00:20:46 +05:30
let!(:project_with_avatar) { create(:project, :with_avatar) }
2018-10-15 14:42:47 +05:30
let(:mounted_as) { :avatar }
2018-05-09 12:01:36 +05:30
2018-10-15 14:42:47 +05:30
before do
stub_uploads_object_storage(AvatarUploader)
end
it_behaves_like "uploads migration worker"
2018-11-08 19:23:39 +05:30
describe "limits N+1 queries" do
it "to N*5" do
query_count = ActiveRecord::QueryRecorder.new { perform(uploads) }
2021-01-29 00:20:46 +05:30
create(:project, :with_avatar)
2018-11-08 19:23:39 +05:30
2021-01-29 00:20:46 +05:30
expect { perform(Upload.all) }.not_to exceed_query_limit(query_count).with_threshold(5)
2018-11-08 19:23:39 +05:30
end
end
2018-10-15 14:42:47 +05:30
end
context "for FileUploader" do
2021-01-29 00:20:46 +05:30
let!(:project_with_file) { create(:project) }
2018-10-15 14:42:47 +05:30
let(:secret) { SecureRandom.hex }
let(:mounted_as) { nil }
2018-11-08 19:23:39 +05:30
def upload_file(project)
uploader = FileUploader.new(project)
uploader.store!(fixture_file_upload('spec/fixtures/doc_sample.txt'))
end
2018-10-15 14:42:47 +05:30
before do
stub_uploads_object_storage(FileUploader)
2021-01-29 00:20:46 +05:30
upload_file(project_with_file)
2018-05-09 12:01:36 +05:30
end
2018-10-15 14:42:47 +05:30
it_behaves_like "uploads migration worker"
2018-11-08 19:23:39 +05:30
describe "limits N+1 queries" do
it "to N*5" do
query_count = ActiveRecord::QueryRecorder.new { perform(uploads) }
2021-01-29 00:20:46 +05:30
upload_file(create(:project))
2018-11-08 19:23:39 +05:30
2021-01-29 00:20:46 +05:30
expect { perform(Upload.all) }.not_to exceed_query_limit(query_count).with_threshold(5)
2018-11-08 19:23:39 +05:30
end
end
2018-05-09 12:01:36 +05:30
end
2020-05-24 23:13:21 +05:30
context 'for DesignManagement::DesignV432x230Uploader' do
let(:model_class) { DesignManagement::Action }
2021-01-29 00:20:46 +05:30
let!(:design_action) { create(:design_action, :with_image_v432x230) }
2020-05-24 23:13:21 +05:30
let(:mounted_as) { :image_v432x230 }
before do
stub_uploads_object_storage(DesignManagement::DesignV432x230Uploader)
end
it_behaves_like 'uploads migration worker'
end
2018-05-09 12:01:36 +05:30
end