debian-mirror-gitlab/spec/services/users/activity_service_spec.rb

130 lines
3.7 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Users::ActivityService do
2018-11-18 11:00:15 +05:30
include ExclusiveLeaseHelpers
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
let(:user) { create(:user, last_activity_on: last_activity_on) }
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
subject { described_class.new(user) }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
describe '#execute', :clean_gitlab_redis_shared_state do
2017-08-17 22:00:37 +05:30
context 'when last activity is nil' do
2018-11-18 11:00:15 +05:30
let(:last_activity_on) { nil }
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
it 'updates last_activity_on for the user' do
expect { subject.execute }
.to change(user, :last_activity_on).from(last_activity_on).to(Date.today)
2017-08-17 22:00:37 +05:30
end
2018-11-18 11:00:15 +05:30
end
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
context 'when last activity is in the past' do
let(:last_activity_on) { Date.today - 1.week }
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
it 'updates last_activity_on for the user' do
expect { subject.execute }
.to change(user, :last_activity_on)
.from(last_activity_on)
.to(Date.today)
2017-08-17 22:00:37 +05:30
end
2019-07-07 11:18:12 +05:30
it 'tries to obtain ExclusiveLease' do
2020-04-22 19:07:51 +05:30
expect(Gitlab::ExclusiveLease).to receive(:new).with("activity_service:#{user.id}", anything).and_call_original
2019-07-07 11:18:12 +05:30
subject.execute
end
2018-11-18 11:00:15 +05:30
end
context 'when a bad object is passed' do
let(:fake_object) { double(username: 'hello') }
it 'does not record activity' do
2020-03-13 15:44:24 +05:30
service = described_class.new(fake_object)
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
expect(service).not_to receive(:record_activity)
service.execute
2017-08-17 22:00:37 +05:30
end
2018-11-18 11:00:15 +05:30
end
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
context 'when last activity is today' do
let(:last_activity_on) { Date.today }
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
it 'does not update last_activity_on' do
expect { subject.execute }.not_to change(user, :last_activity_on)
2017-08-17 22:00:37 +05:30
end
2019-07-07 11:18:12 +05:30
it 'does not try to obtain ExclusiveLease' do
2020-04-22 19:07:51 +05:30
expect(Gitlab::ExclusiveLease).not_to receive(:new).with("activity_service:#{user.id}", anything)
2019-07-07 11:18:12 +05:30
subject.execute
end
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
context 'when in GitLab read-only instance' do
2018-11-18 11:00:15 +05:30
let(:last_activity_on) { nil }
2018-03-17 18:26:18 +05:30
before do
allow(Gitlab::Database).to receive(:read_only?).and_return(true)
end
2018-11-18 11:00:15 +05:30
it 'does not update last_activity_on' do
expect { subject.execute }.not_to change(user, :last_activity_on)
2018-03-17 18:26:18 +05:30
end
end
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
context 'when a lease could not be obtained' do
let(:last_activity_on) { nil }
it 'does not update last_activity_on' do
2019-07-31 22:56:46 +05:30
stub_exclusive_lease_taken("activity_service:#{user.id}", timeout: 1.minute.to_i)
2018-11-18 11:00:15 +05:30
expect { subject.execute }.not_to change(user, :last_activity_on)
end
end
2017-08-17 22:00:37 +05:30
end
2021-09-04 01:27:46 +05:30
2021-10-27 15:23:28 +05:30
context 'with DB Load Balancing' do
2021-09-04 01:27:46 +05:30
let(:user) { create(:user, last_activity_on: last_activity_on) }
context 'when last activity is in the past' do
let(:user) { create(:user, last_activity_on: Date.today - 1.week) }
2021-11-18 22:05:49 +05:30
context 'database load balancing is configured' do
2021-09-04 01:27:46 +05:30
before do
2021-11-18 22:05:49 +05:30
::Gitlab::Database::LoadBalancing::Session.clear_session
2021-09-04 01:27:46 +05:30
end
let(:service) do
service = described_class.new(user)
::Gitlab::Database::LoadBalancing::Session.clear_session
service
end
it 'does not stick to primary' do
expect(::Gitlab::Database::LoadBalancing::Session.current).not_to be_performed_write
service.execute
expect(user.last_activity_on).to eq(Date.today)
expect(::Gitlab::Database::LoadBalancing::Session.current).to be_performed_write
expect(::Gitlab::Database::LoadBalancing::Session.current).not_to be_using_primary
end
end
context 'database load balancing is not configured' do
let(:service) { described_class.new(user) }
it 'updates user without error' do
service.execute
expect(user.last_activity_on).to eq(Date.today)
end
end
end
end
2017-08-17 22:00:37 +05:30
end