2021-01-29 00:20:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe 'Repositioning an ImageDiffNote' do
|
|
|
|
include GraphqlHelpers
|
|
|
|
|
|
|
|
let_it_be(:noteable) { create(:merge_request) }
|
|
|
|
let_it_be(:project) { noteable.project }
|
2021-09-30 23:02:18 +05:30
|
|
|
|
2021-01-29 00:20:46 +05:30
|
|
|
let(:note) { create(:image_diff_note_on_merge_request, noteable: noteable, project: project) }
|
|
|
|
let(:new_position) { { x: 10 } }
|
|
|
|
let(:current_user) { project.creator }
|
|
|
|
|
|
|
|
let(:mutation_variables) do
|
|
|
|
{
|
|
|
|
id: global_id_of(note),
|
|
|
|
position: new_position
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:mutation) do
|
|
|
|
graphql_mutation(:reposition_image_diff_note, mutation_variables) do
|
|
|
|
<<~QL
|
|
|
|
note {
|
|
|
|
id
|
|
|
|
}
|
|
|
|
errors
|
|
|
|
QL
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def mutation_response
|
|
|
|
graphql_mutation_response(:reposition_image_diff_note)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the note', :aggregate_failures do
|
|
|
|
expect do
|
|
|
|
post_graphql_mutation(mutation, current_user: current_user)
|
|
|
|
end.to change { note.reset.position.x }.to(10)
|
|
|
|
|
|
|
|
expect(mutation_response['note']).to eq('id' => global_id_of(note))
|
|
|
|
expect(mutation_response['errors']).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the note is not a DiffNote' do
|
|
|
|
let(:note) { project }
|
|
|
|
|
|
|
|
it_behaves_like 'a mutation that returns top-level errors' do
|
|
|
|
let(:match_errors) { include(/does not represent an instance of DiffNote/) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when a position arg is nil' do
|
|
|
|
let(:new_position) { { x: nil, y: 10 } }
|
|
|
|
|
|
|
|
it 'does not set the property to nil', :aggregate_failures do
|
|
|
|
expect do
|
|
|
|
post_graphql_mutation(mutation, current_user: current_user)
|
|
|
|
end.not_to change { note.reset.position.x }
|
|
|
|
|
|
|
|
expect(mutation_response['note']).to eq('id' => global_id_of(note))
|
|
|
|
expect(mutation_response['errors']).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when all position args are nil' do
|
|
|
|
let(:new_position) { { x: nil } }
|
|
|
|
|
|
|
|
it_behaves_like 'a mutation that returns top-level errors' do
|
|
|
|
let(:match_errors) { include(/RepositionImageDiffNoteInput! was provided invalid value/) }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains an explanation for the error' do
|
|
|
|
post_graphql_mutation(mutation, current_user: current_user)
|
|
|
|
|
|
|
|
explanation = graphql_errors.first['extensions']['problems'].first['explanation']
|
|
|
|
|
|
|
|
expect(explanation).to eq('At least one property of `UpdateDiffImagePositionInput` must be set')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|