debian-mirror-gitlab/spec/models/suggestion_spec.rb

186 lines
5 KiB
Ruby
Raw Normal View History

2019-02-15 15:39:39 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Suggestion do
2019-02-15 15:39:39 +05:30
let(:suggestion) { create(:suggestion) }
describe 'associations' do
it { is_expected.to belong_to(:note) }
end
describe 'validations' do
it { is_expected.to validate_presence_of(:note) }
2021-02-22 17:27:13 +05:30
context 'when importing' do
subject { create(:suggestion, importing: true) }
it { is_expected.not_to validate_presence_of(:note) }
end
2019-02-15 15:39:39 +05:30
context 'when suggestion is applied' do
before do
allow(subject).to receive(:applied?).and_return(true)
end
it { is_expected.to validate_presence_of(:commit_id) }
end
end
2019-07-07 11:18:12 +05:30
describe '#diff_lines' do
let(:suggestion) { create(:suggestion, :content_from_repo) }
it 'returns parsed diff lines' do
expected_diff_lines = Gitlab::Diff::SuggestionDiff.new(suggestion).diff_lines
diff_lines = suggestion.diff_lines
expect(diff_lines.size).to eq(expected_diff_lines.size)
expect(diff_lines).to all(be_a(Gitlab::Diff::Line))
expected_diff_lines.each_with_index do |expected_line, index|
expect(diff_lines[index].to_hash).to eq(expected_line.to_hash)
end
end
end
2019-02-15 15:39:39 +05:30
describe '#appliable?' do
2020-07-28 23:09:34 +05:30
let(:suggestion) { build(:suggestion) }
2019-02-15 15:39:39 +05:30
2020-07-28 23:09:34 +05:30
subject(:appliable) { suggestion.appliable? }
before do
allow(suggestion).to receive(:inapplicable_reason).and_return(inapplicable_reason)
end
context 'when inapplicable_reason is nil' do
let(:inapplicable_reason) { nil }
it { is_expected.to be_truthy }
end
context 'when inapplicable_reason is not nil' do
2020-10-24 23:57:45 +05:30
let(:inapplicable_reason) { "Can't apply this suggestion." }
2020-07-28 23:09:34 +05:30
it { is_expected.to be_falsey }
end
end
describe '#inapplicable_reason' do
let(:merge_request) { create(:merge_request) }
let!(:note) do
create(
:diff_note_on_merge_request,
project: merge_request.project,
noteable: merge_request
)
end
let(:suggestion) { build(:suggestion, note: note) }
subject(:inapplicable_reason) { suggestion.inapplicable_reason }
context 'when suggestion is already applied' do
let(:suggestion) { build(:suggestion, :applied, note: note) }
2020-10-24 23:57:45 +05:30
it { is_expected.to eq("Can't apply this suggestion.") }
2020-07-28 23:09:34 +05:30
end
context 'when merge request was merged' do
before do
merge_request.mark_as_merged!
end
2020-10-24 23:57:45 +05:30
it { is_expected.to eq("This merge request was merged. To apply this suggestion, edit this file directly.") }
2020-07-28 23:09:34 +05:30
end
context 'when merge request is closed' do
before do
merge_request.close!
2019-02-15 15:39:39 +05:30
end
2020-07-28 23:09:34 +05:30
2020-10-24 23:57:45 +05:30
it { is_expected.to eq("This merge request is closed. To apply this suggestion, edit this file directly.") }
2019-02-15 15:39:39 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when source branch is deleted' do
before do
merge_request.project.repository.rm_branch(merge_request.author, merge_request.source_branch)
2019-02-15 15:39:39 +05:30
end
2020-10-24 23:57:45 +05:30
it { is_expected.to eq("Can't apply as the source branch was deleted.") }
2020-07-28 23:09:34 +05:30
end
2019-02-15 15:39:39 +05:30
2020-10-24 23:57:45 +05:30
context 'when outdated' do
shared_examples_for 'outdated suggestion' do
before do
allow(suggestion).to receive(:single_line?).and_return(single_line)
end
context 'and suggestion is for a single line' do
let(:single_line) { true }
it { is_expected.to eq("Can't apply as this line was changed in a more recent version.") }
end
context 'and suggestion is for multiple lines' do
let(:single_line) { false }
it { is_expected.to eq("Can't apply as these lines were changed in a more recent version.") }
end
2020-07-28 23:09:34 +05:30
end
2020-10-24 23:57:45 +05:30
context 'and content is outdated' do
before do
allow(suggestion).to receive(:outdated?).and_return(true)
end
it_behaves_like 'outdated suggestion'
end
context 'and note is outdated' do
before do
allow(note).to receive(:active?).and_return(false)
end
it_behaves_like 'outdated suggestion'
end
2020-07-28 23:09:34 +05:30
end
2020-10-24 23:57:45 +05:30
context 'when suggestion has the same content' do
2020-07-28 23:09:34 +05:30
before do
2020-10-24 23:57:45 +05:30
allow(suggestion).to receive(:different_content?).and_return(false)
2019-02-15 15:39:39 +05:30
end
2020-07-28 23:09:34 +05:30
2020-10-24 23:57:45 +05:30
it { is_expected.to eq("This suggestion already matches its content.") }
2020-07-28 23:09:34 +05:30
end
2021-12-11 22:18:48 +05:30
context 'when file is .ipynb' do
before do
allow(suggestion).to receive(:file_path).and_return("example.ipynb")
end
it { is_expected.to eq(_("This file was modified for readability, and can't accept suggestions. Edit it directly.")) }
end
2020-07-28 23:09:34 +05:30
context 'when applicable' do
it { is_expected.to be_nil }
end
end
describe '#single_line?' do
subject(:single_line) { suggestion.single_line? }
context 'when suggestion is for a single line' do
let(:suggestion) { build(:suggestion, lines_above: 0, lines_below: 0) }
it { is_expected.to eq(true) }
end
context 'when suggestion is for multiple lines' do
let(:suggestion) { build(:suggestion, lines_above: 2, lines_below: 0) }
it { is_expected.to eq(false) }
2019-02-15 15:39:39 +05:30
end
end
end