2017-08-17 22:00:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe MembersFinder, '#execute' do
|
2019-09-04 21:01:54 +05:30
|
|
|
set(:group) { create(:group) }
|
|
|
|
set(:nested_group) { create(:group, :access_requestable, parent: group) }
|
|
|
|
set(:project) { create(:project, namespace: nested_group) }
|
|
|
|
set(:user1) { create(:user) }
|
|
|
|
set(:user2) { create(:user) }
|
|
|
|
set(:user3) { create(:user) }
|
|
|
|
set(:user4) { create(:user) }
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
it 'returns members for project and parent groups' do
|
2017-08-17 22:00:37 +05:30
|
|
|
nested_group.request_access(user1)
|
2018-11-18 11:00:15 +05:30
|
|
|
member1 = group.add_maintainer(user2)
|
|
|
|
member2 = nested_group.add_maintainer(user3)
|
|
|
|
member3 = project.add_maintainer(user4)
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
result = described_class.new(project, user2).execute
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
expect(result).to contain_exactly(member1, member2, member3)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2018-11-08 19:23:39 +05:30
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
it 'includes nested group members if asked', :nested_groups do
|
2018-11-08 19:23:39 +05:30
|
|
|
nested_group.request_access(user1)
|
2018-11-18 11:00:15 +05:30
|
|
|
member1 = group.add_maintainer(user2)
|
|
|
|
member2 = nested_group.add_maintainer(user3)
|
|
|
|
member3 = project.add_maintainer(user4)
|
2018-11-08 19:23:39 +05:30
|
|
|
|
|
|
|
result = described_class.new(project, user2).execute(include_descendants: true)
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
expect(result).to contain_exactly(member1, member2, member3)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the members.access_level when the user is invited', :nested_groups do
|
|
|
|
member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email)
|
|
|
|
member1 = group.add_maintainer(user2)
|
|
|
|
|
|
|
|
result = described_class.new(project, user2).execute(include_descendants: true)
|
|
|
|
|
|
|
|
expect(result).to contain_exactly(member1, member_invite)
|
|
|
|
expect(result.last.access_level).to eq(member_invite.access_level)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the highest access_level for the user', :nested_groups do
|
|
|
|
member1 = project.add_guest(user1)
|
|
|
|
group.add_developer(user1)
|
|
|
|
nested_group.add_reporter(user1)
|
|
|
|
|
|
|
|
result = described_class.new(project, user1).execute(include_descendants: true)
|
|
|
|
|
|
|
|
expect(result).to contain_exactly(member1)
|
|
|
|
expect(result.first.access_level).to eq(Gitlab::Access::DEVELOPER)
|
2018-11-08 19:23:39 +05:30
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
context 'when include_invited_groups_members == true' do
|
2019-09-04 21:01:54 +05:30
|
|
|
subject { described_class.new(project, user2).execute(include_invited_groups_members: true) }
|
|
|
|
|
|
|
|
set(:linked_group) { create(:group, :public, :access_requestable) }
|
|
|
|
set(:nested_linked_group) { create(:group, parent: linked_group) }
|
2019-12-04 20:38:33 +05:30
|
|
|
set(:linked_group_member) { linked_group.add_guest(user1) }
|
|
|
|
set(:nested_linked_group_member) { nested_linked_group.add_guest(user2) }
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
it 'includes all the invited_groups members including members inherited from ancestor groups' do
|
2019-09-04 21:01:54 +05:30
|
|
|
create(:project_group_link, project: project, group: nested_linked_group)
|
|
|
|
|
|
|
|
expect(subject).to contain_exactly(linked_group_member, nested_linked_group_member)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes all the invited_groups members' do
|
|
|
|
create(:project_group_link, project: project, group: linked_group)
|
|
|
|
|
|
|
|
expect(subject).to contain_exactly(linked_group_member)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'excludes group_members not visible to the user' do
|
|
|
|
create(:project_group_link, project: project, group: linked_group)
|
|
|
|
private_linked_group = create(:group, :private)
|
|
|
|
private_linked_group.add_developer(user3)
|
|
|
|
create(:project_group_link, project: project, group: private_linked_group)
|
|
|
|
|
|
|
|
expect(subject).to contain_exactly(linked_group_member)
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
context 'when the user is a member of invited group and ancestor groups' do
|
|
|
|
it 'returns the highest access_level for the user limited by project_group_link.group_access', :nested_groups do
|
|
|
|
create(:project_group_link, project: project, group: nested_linked_group, group_access: Gitlab::Access::REPORTER)
|
|
|
|
nested_linked_group.add_developer(user1)
|
|
|
|
|
|
|
|
result = subject
|
|
|
|
|
|
|
|
expect(result).to contain_exactly(linked_group_member, nested_linked_group_member)
|
|
|
|
expect(result.first.access_level).to eq(Gitlab::Access::REPORTER)
|
|
|
|
end
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|