2020-04-22 19:07:51 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe Groups::Settings::IntegrationsController do
|
2021-02-22 17:27:13 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:group) { create(:group) }
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
it_behaves_like Integrations::Actions do
|
2021-11-11 11:23:49 +05:30
|
|
|
let(:integration_attributes) { { group: group, project: nil } }
|
|
|
|
|
|
|
|
let(:routing_params) do
|
|
|
|
{
|
|
|
|
group_id: group,
|
|
|
|
id: integration.to_param
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
describe '#index' do
|
|
|
|
context 'when user is not owner' do
|
|
|
|
it 'renders not_found' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'successfully displays the template' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:index)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#edit' do
|
|
|
|
context 'when user is not owner' do
|
|
|
|
it 'renders not_found' do
|
2021-09-30 23:02:18 +05:30
|
|
|
get :edit, params: { group_id: group, id: Integration.available_integration_names(include_project_specific: false).sample }
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
Integration.available_integration_names(include_project_specific: false).each do |integration_name|
|
|
|
|
context integration_name do
|
2020-04-22 19:07:51 +05:30
|
|
|
it 'successfully displays the template' do
|
|
|
|
get :edit, params: { group_id: group, id: integration_name }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:edit)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#update' do
|
2020-11-24 15:15:51 +05:30
|
|
|
include JiraServiceHelper
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
let(:integration) { create(:jira_integration, :group, group: group) }
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
2021-09-30 23:02:18 +05:30
|
|
|
stub_jira_integration_test
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2021-10-27 15:23:28 +05:30
|
|
|
put :update, params: { group_id: group, id: integration.class.to_param, service: params }
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'valid params' do
|
2021-10-27 15:23:28 +05:30
|
|
|
let(:params) { { url: 'https://jira.gitlab-example.com', password: 'password' } }
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
it 'updates the integration' do
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
2021-10-27 15:23:28 +05:30
|
|
|
expect(integration.reload).to have_attributes(params)
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'invalid params' do
|
2021-10-27 15:23:28 +05:30
|
|
|
let(:params) { { url: 'invalid', password: 'password' } }
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
it 'does not update the integration' do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:edit)
|
2021-10-27 15:23:28 +05:30
|
|
|
expect(integration.reload).not_to have_attributes(params)
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-02-22 17:27:13 +05:30
|
|
|
|
|
|
|
describe '#reset' do
|
2021-12-11 22:18:48 +05:30
|
|
|
let_it_be(:integration) { create(:jira_integration, :group, group: group) }
|
2021-09-30 23:02:18 +05:30
|
|
|
let_it_be(:inheriting_integration) { create(:jira_integration, inherit_from_id: integration.id) }
|
2021-02-22 17:27:13 +05:30
|
|
|
|
|
|
|
subject do
|
|
|
|
post :reset, params: { group_id: group, id: integration.class.to_param }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
it 'renders not_found' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 200 OK', :aggregate_failures do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expected_json = {}.to_json
|
|
|
|
|
|
|
|
expect(flash[:notice]).to eq('This integration, and inheriting projects were reset.')
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response.body).to eq(expected_json)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'deletes the integration and all inheriting integrations' do
|
2021-09-04 01:27:46 +05:30
|
|
|
expect { subject }.to change { Integrations::Jira.for_group(group.id).count }.by(-1)
|
|
|
|
.and change { Integrations::Jira.inherit_from_id(integration.id).count }.by(-1)
|
2021-02-22 17:27:13 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|