debian-mirror-gitlab/spec/features/issues_spec.rb

626 lines
18 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
require 'spec_helper'
2015-04-26 12:48:37 +05:30
describe 'Issues', feature: true do
2016-09-13 17:45:13 +05:30
include IssueHelpers
2015-04-26 12:48:37 +05:30
include SortingHelper
2014-09-02 18:07:02 +05:30
let(:project) { create(:project) }
before do
login_as :user
user2 = create(:user)
project.team << [[@user, user2], :developer]
end
2015-04-26 12:48:37 +05:30
describe 'Edit issue' do
2014-09-02 18:07:02 +05:30
let!(:issue) do
create(:issue,
author: @user,
assignee: @user,
project: project)
end
before do
2015-09-11 14:41:01 +05:30
visit edit_namespace_project_issue_path(project.namespace, project, issue)
2016-08-24 12:49:21 +05:30
find('.js-zen-enter').click
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it 'opens new issue popup' do
2015-04-26 12:48:37 +05:30
expect(page).to have_content("Issue ##{issue.iid}")
2014-09-02 18:07:02 +05:30
end
2015-04-26 12:48:37 +05:30
describe 'fill in' do
2014-09-02 18:07:02 +05:30
before do
2015-04-26 12:48:37 +05:30
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
2014-09-02 18:07:02 +05:30
end
end
end
2015-04-26 12:48:37 +05:30
describe 'Editing issue assignee' do
2014-09-02 18:07:02 +05:30
let!(:issue) do
create(:issue,
author: @user,
assignee: @user,
project: project)
end
2016-06-02 11:05:42 +05:30
it 'allows user to select unassigned', js: true do
2015-04-26 12:48:37 +05:30
visit edit_namespace_project_issue_path(project.namespace, project, issue)
2014-09-02 18:07:02 +05:30
2015-12-23 02:04:40 +05:30
expect(page).to have_content "Assignee #{@user.name}"
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
first('#s2id_issue_assignee_id').click
2014-09-02 18:07:02 +05:30
sleep 2 # wait for ajax stuff to complete
2015-04-26 12:48:37 +05:30
first('.user-result').click
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
click_button 'Save changes'
2014-09-02 18:07:02 +05:30
2015-12-23 02:04:40 +05:30
page.within('.assignee') do
2016-06-02 11:05:42 +05:30
expect(page).to have_content 'No assignee - assign yourself'
2015-12-23 02:04:40 +05:30
end
2015-04-26 12:48:37 +05:30
expect(issue.reload.assignee).to be_nil
2014-09-02 18:07:02 +05:30
end
end
describe 'due date', js: true do
context 'on new form' do
before do
visit new_namespace_project_issue_path(project.namespace, project)
end
2016-09-13 17:45:13 +05:30
it 'saves with due date' do
date = Date.today.at_beginning_of_month
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
find('#issuable-due-date').click
page.within '.ui-datepicker' do
click_link date.day
end
expect(find('#issuable-due-date').value).to eq date.to_s
click_button 'Submit issue'
page.within '.issuable-sidebar' do
expect(page).to have_content date.to_s(:medium)
end
end
end
context 'on edit form' do
2016-08-24 12:49:21 +05:30
let(:issue) { create(:issue, author: @user, project: project, due_date: Date.today.at_beginning_of_month.to_s) }
before do
visit edit_namespace_project_issue_path(project.namespace, project, issue)
end
2016-09-13 17:45:13 +05:30
it 'saves with due date' do
date = Date.today.at_beginning_of_month
expect(find('#issuable-due-date').value).to eq date.to_s
date = date.tomorrow
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
find('#issuable-due-date').click
page.within '.ui-datepicker' do
click_link date.day
end
expect(find('#issuable-due-date').value).to eq date.to_s
click_button 'Save changes'
page.within '.issuable-sidebar' do
expect(page).to have_content date.to_s(:medium)
end
end
2016-09-29 09:46:39 +05:30
it 'warns about version conflict' do
issue.update(title: "New title")
fill_in 'issue_title', with: 'bug 345'
fill_in 'issue_description', with: 'bug description'
click_button 'Save changes'
expect(page).to have_content 'Someone edited the issue the same time you did'
end
end
end
2016-06-02 11:05:42 +05:30
describe 'Issue info' do
it 'excludes award_emoji from comment count' do
issue = create(:issue, author: @user, assignee: @user, project: project, title: 'foobar')
create(:award_emoji, awardable: issue)
2016-06-02 11:05:42 +05:30
visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)
expect(page).to have_content 'foobar'
2016-09-29 09:46:39 +05:30
expect(page.all('.no-comments').first.text).to eq "0"
2016-06-02 11:05:42 +05:30
end
end
2015-04-26 12:48:37 +05:30
describe 'Filter issue' do
2014-09-02 18:07:02 +05:30
before do
['foobar', 'barbaz', 'gitlab'].each do |title|
create(:issue,
author: @user,
assignee: @user,
project: project,
title: title)
end
2015-04-26 12:48:37 +05:30
@issue = Issue.find_by(title: 'foobar')
2014-09-02 18:07:02 +05:30
@issue.milestone = create(:milestone, project: project)
@issue.assignee = nil
@issue.save
end
let(:issue) { @issue }
2016-09-13 17:45:13 +05:30
it 'allows filtering by issues with no specified assignee' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, assignee_id: IssuableFinder::NONE)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(page).to have_content 'foobar'
expect(page).not_to have_content 'barbaz'
expect(page).not_to have_content 'gitlab'
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
it 'allows filtering by a specified assignee' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, assignee_id: @user.id)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(page).not_to have_content 'foobar'
expect(page).to have_content 'barbaz'
expect(page).to have_content 'gitlab'
2014-09-02 18:07:02 +05:30
end
end
describe 'filter issue' do
2016-06-02 11:05:42 +05:30
titles = %w[foo bar baz]
2014-09-02 18:07:02 +05:30
titles.each_with_index do |title, index|
2015-04-26 12:48:37 +05:30
let!(title.to_sym) do
create(:issue, title: title,
project: project,
created_at: Time.now - (index * 60))
end
2014-09-02 18:07:02 +05:30
end
let(:newer_due_milestone) { create(:milestone, due_date: '2013-12-11') }
let(:later_due_milestone) { create(:milestone, due_date: '2013-12-12') }
it 'sorts by newest' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_created)
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
expect(first_issue).to include('foo')
expect(last_issue).to include('baz')
2014-09-02 18:07:02 +05:30
end
it 'sorts by oldest' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_created)
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
expect(first_issue).to include('baz')
expect(last_issue).to include('foo')
2014-09-02 18:07:02 +05:30
end
it 'sorts by most recently updated' do
baz.updated_at = Time.now + 100
baz.save
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_recently_updated)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(first_issue).to include('baz')
2014-09-02 18:07:02 +05:30
end
it 'sorts by least recently updated' do
baz.updated_at = Time.now - 100
baz.save
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_oldest_updated)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(first_issue).to include('baz')
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe 'sorting by due date' do
before do
foo.update(due_date: 1.day.from_now)
bar.update(due_date: 6.days.from_now)
end
it 'sorts by recently due date' do
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_soon)
expect(first_issue).to include('foo')
end
it 'sorts by least recently due date' do
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
expect(first_issue).to include('bar')
end
it 'sorts by least recently due date by excluding nil due dates' do
bar.update(due_date: nil)
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_due_date_later)
expect(first_issue).to include('foo')
end
context 'with a filter on labels' do
let(:label) { create(:label, project: project) }
before { create(:label_link, label: label, target: foo) }
it 'sorts by least recently due date by excluding nil due dates' do
bar.update(due_date: nil)
visit namespace_project_issues_path(project.namespace, project, label_names: [label.name], sort: sort_value_due_date_later)
expect(first_issue).to include('foo')
end
end
end
describe 'filtering by due date' do
before do
foo.update(due_date: 1.day.from_now)
bar.update(due_date: 6.days.from_now)
end
it 'filters by none' do
visit namespace_project_issues_path(project.namespace, project, due_date: Issue::NoDueDate.name)
expect(page).not_to have_content('foo')
expect(page).not_to have_content('bar')
expect(page).to have_content('baz')
end
it 'filters by any' do
visit namespace_project_issues_path(project.namespace, project, due_date: Issue::AnyDueDate.name)
expect(page).to have_content('foo')
expect(page).to have_content('bar')
expect(page).to have_content('baz')
end
it 'filters by due this week' do
foo.update(due_date: Date.today.beginning_of_week + 2.days)
bar.update(due_date: Date.today.end_of_week)
baz.update(due_date: Date.today - 8.days)
visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisWeek.name)
expect(page).to have_content('foo')
expect(page).to have_content('bar')
expect(page).not_to have_content('baz')
end
it 'filters by due this month' do
foo.update(due_date: Date.today.beginning_of_month + 2.days)
bar.update(due_date: Date.today.end_of_month)
baz.update(due_date: Date.today - 50.days)
visit namespace_project_issues_path(project.namespace, project, due_date: Issue::DueThisMonth.name)
expect(page).to have_content('foo')
expect(page).to have_content('bar')
expect(page).not_to have_content('baz')
end
it 'filters by overdue' do
foo.update(due_date: Date.today + 2.days)
bar.update(due_date: Date.today + 20.days)
baz.update(due_date: Date.yesterday)
visit namespace_project_issues_path(project.namespace, project, due_date: Issue::Overdue.name)
expect(page).not_to have_content('foo')
expect(page).not_to have_content('bar')
expect(page).to have_content('baz')
end
end
2014-09-02 18:07:02 +05:30
describe 'sorting by milestone' do
2016-06-02 11:05:42 +05:30
before do
2014-09-02 18:07:02 +05:30
foo.milestone = newer_due_milestone
foo.save
bar.milestone = later_due_milestone
bar.save
end
it 'sorts by recently due milestone' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_soon)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(first_issue).to include('foo')
2016-06-02 11:05:42 +05:30
expect(last_issue).to include('baz')
2014-09-02 18:07:02 +05:30
end
it 'sorts by least recently due milestone' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project, sort: sort_value_milestone_later)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(first_issue).to include('bar')
2016-06-02 11:05:42 +05:30
expect(last_issue).to include('baz')
2014-09-02 18:07:02 +05:30
end
end
describe 'combine filter and sort' do
let(:user2) { create(:user) }
2016-06-02 11:05:42 +05:30
before do
2014-09-02 18:07:02 +05:30
foo.assignee = user2
foo.save
bar.assignee = user2
bar.save
end
it 'sorts with a filter applied' do
2015-04-26 12:48:37 +05:30
visit namespace_project_issues_path(project.namespace, project,
sort: sort_value_oldest_created,
assignee_id: user2.id)
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
expect(first_issue).to include('bar')
expect(last_issue).to include('foo')
2015-04-26 12:48:37 +05:30
expect(page).not_to have_content 'baz'
2014-09-02 18:07:02 +05:30
end
end
end
describe 'update assignee from issue#show' do
2016-06-02 11:05:42 +05:30
let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
context 'by authorized user' do
it 'allows user to select unassigned', js: true do
2015-04-26 12:48:37 +05:30
visit namespace_project_issue_path(project.namespace, project, issue)
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
page.within('.assignee') do
expect(page).to have_content "#{@user.name}"
click_link 'Edit'
click_link 'Unassigned'
2016-06-02 11:05:42 +05:30
expect(page).to have_content 'No assignee'
end
expect(issue.reload.assignee).to be_nil
end
it 'allows user to select an assignee', js: true do
issue2 = create(:issue, project: project, author: @user)
visit namespace_project_issue_path(project.namespace, project, issue2)
page.within('.assignee') do
expect(page).to have_content "No assignee"
end
page.within '.assignee' do
click_link 'Edit'
end
2016-06-02 11:05:42 +05:30
page.within '.dropdown-menu-user' do
click_link @user.name
end
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
page.within('.assignee') do
expect(page).to have_content @user.name
end
2014-09-02 18:07:02 +05:30
end
it 'allows user to unselect themselves', js: true do
issue2 = create(:issue, project: project, author: @user)
visit namespace_project_issue_path(project.namespace, project, issue2)
page.within '.assignee' do
click_link 'Edit'
click_link @user.name
page.within '.value' do
expect(page).to have_content @user.name
end
click_link 'Edit'
click_link @user.name
page.within '.value' do
expect(page).to have_content "No assignee"
end
end
end
2014-09-02 18:07:02 +05:30
end
context 'by unauthorized user' do
let(:guest) { create(:user) }
2016-06-02 11:05:42 +05:30
before do
2014-09-02 18:07:02 +05:30
project.team << [[guest], :guest]
end
2015-04-26 12:48:37 +05:30
it 'shows assignee text', js: true do
2014-09-02 18:07:02 +05:30
logout
login_with guest
2015-04-26 12:48:37 +05:30
visit namespace_project_issue_path(project.namespace, project, issue)
expect(page).to have_content issue.assignee.name
2014-09-02 18:07:02 +05:30
end
end
end
describe 'update milestone from issue#show' do
let!(:issue) { create(:issue, project: project, author: @user) }
let!(:milestone) { create(:milestone, project: project) }
context 'by authorized user' do
2016-06-02 11:05:42 +05:30
it 'allows user to select unassigned', js: true do
visit namespace_project_issue_path(project.namespace, project, issue)
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
page.within('.milestone') do
expect(page).to have_content "None"
end
2015-12-23 02:04:40 +05:30
2016-06-02 11:05:42 +05:30
find('.block.milestone .edit-link').click
sleep 2 # wait for ajax stuff to complete
first('.dropdown-content li').click
sleep 2
2015-12-23 02:04:40 +05:30
page.within('.milestone') do
2016-06-02 11:05:42 +05:30
expect(page).to have_content 'None'
2015-12-23 02:04:40 +05:30
end
2016-06-02 11:05:42 +05:30
expect(issue.reload.milestone).to be_nil
2014-09-02 18:07:02 +05:30
end
it 'allows user to de-select milestone', js: true do
visit namespace_project_issue_path(project.namespace, project, issue)
page.within('.milestone') do
click_link 'Edit'
click_link milestone.title
page.within '.value' do
expect(page).to have_content milestone.title
end
click_link 'Edit'
click_link milestone.title
page.within '.value' do
expect(page).to have_content 'None'
end
end
end
2014-09-02 18:07:02 +05:30
end
context 'by unauthorized user' do
let(:guest) { create(:user) }
2016-06-02 11:05:42 +05:30
before do
2014-09-02 18:07:02 +05:30
project.team << [guest, :guest]
issue.milestone = milestone
issue.save
end
2015-04-26 12:48:37 +05:30
it 'shows milestone text', js: true do
2014-09-02 18:07:02 +05:30
logout
login_with guest
2015-04-26 12:48:37 +05:30
visit namespace_project_issue_path(project.namespace, project, issue)
expect(page).to have_content milestone.title
2014-09-02 18:07:02 +05:30
end
end
describe 'removing assignee' do
let(:user2) { create(:user) }
2016-06-02 11:05:42 +05:30
before do
2014-09-02 18:07:02 +05:30
issue.assignee = user2
issue.save
end
2016-06-02 11:05:42 +05:30
end
end
describe 'new issue' do
context 'dropzone upload file', js: true do
before do
visit new_namespace_project_issue_path(project.namespace, project)
end
2016-09-13 17:45:13 +05:30
it 'uploads file when dragging into textarea' do
2016-06-02 11:05:42 +05:30
drop_in_dropzone test_image_file
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
# Wait for the file to upload
sleep 1
expect(page.find_field("issue_description").value).to have_content 'banana_sample'
end
end
end
2016-09-13 17:45:13 +05:30
xdescribe 'new issue by email' do
shared_examples 'show the email in the modal' do
before do
stub_incoming_email_setting(enabled: true, address: "p+%{key}@gl.ab")
visit namespace_project_issues_path(project.namespace, project)
click_button('Email a new issue')
end
it 'click the button to show modal for the new email' do
page.within '#issue-email-modal' do
email = project.new_issue_address(@user)
expect(page).to have_selector("input[value='#{email}']")
end
end
end
context 'with existing issues' do
let!(:issue) { create(:issue, project: project, author: @user) }
it_behaves_like 'show the email in the modal'
end
context 'without existing issues' do
it_behaves_like 'show the email in the modal'
end
end
2016-06-02 11:05:42 +05:30
describe 'due date' do
context 'update due on issue#show', js: true do
let(:issue) { create(:issue, project: project, author: @user, assignee: @user) }
before do
2015-04-26 12:48:37 +05:30
visit namespace_project_issue_path(project.namespace, project, issue)
2016-06-02 11:05:42 +05:30
end
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it 'adds due date to issue' do
2016-06-02 11:05:42 +05:30
page.within '.due_date' do
click_link 'Edit'
page.within '.ui-datepicker-calendar' do
first('.ui-state-default').click
end
expect(page).to have_no_content 'None'
2015-12-23 02:04:40 +05:30
end
2016-06-02 11:05:42 +05:30
end
2015-12-23 02:04:40 +05:30
2016-09-13 17:45:13 +05:30
it 'removes due date from issue' do
2016-06-02 11:05:42 +05:30
page.within '.due_date' do
click_link 'Edit'
2014-09-02 18:07:02 +05:30
2016-06-02 11:05:42 +05:30
page.within '.ui-datepicker-calendar' do
first('.ui-state-default').click
end
2016-06-22 15:30:34 +05:30
expect(page).to have_no_content 'No due date'
2016-06-02 11:05:42 +05:30
click_link 'remove due date'
2016-06-22 15:30:34 +05:30
expect(page).to have_content 'No due date'
2015-12-23 02:04:40 +05:30
end
2014-09-02 18:07:02 +05:30
end
end
end
2016-06-02 11:05:42 +05:30
def drop_in_dropzone(file_path)
# Generate a fake input selector
page.execute_script <<-JS
var fakeFileInput = window.$('<input/>').attr(
{id: 'fakeFileInput', type: 'file'}
).appendTo('body');
JS
# Attach the file to the fake input selector with Capybara
attach_file("fakeFileInput", file_path)
# Add the file to a fileList array and trigger the fake drop event
page.execute_script <<-JS
var fileList = [$('#fakeFileInput')[0].files[0]];
var e = jQuery.Event('drop', { dataTransfer : { files : fileList } });
$('.div-dropzone')[0].dropzone.listeners[0].events.drop(e);
JS
end
def test_image_file
File.join(Rails.root, 'spec', 'fixtures', 'banana_sample.gif')
end
2014-09-02 18:07:02 +05:30
end