2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-09-13 17:45:13 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe Gitlab::Ci::Config::Entry::Artifacts do
|
2016-09-13 17:45:13 +05:30
|
|
|
let(:entry) { described_class.new(config) }
|
|
|
|
|
|
|
|
describe 'validation' do
|
|
|
|
context 'when entry config value is correct' do
|
|
|
|
let(:config) { { paths: %w[public/] } }
|
|
|
|
|
|
|
|
describe '#value' do
|
2019-02-15 15:39:39 +05:30
|
|
|
it 'returns artifacts configuration' do
|
2016-09-13 17:45:13 +05:30
|
|
|
expect(entry.value).to eq config
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#valid?' do
|
|
|
|
it 'is valid' do
|
|
|
|
expect(entry).to be_valid
|
|
|
|
end
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
|
|
|
|
context "when value includes 'reports' keyword" do
|
|
|
|
let(:config) { { paths: %w[public/], reports: { junit: 'junit.xml' } } }
|
|
|
|
|
|
|
|
it 'returns general artifact and report-type artifacts configuration' do
|
|
|
|
expect(entry.value).to eq config
|
|
|
|
end
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
|
|
|
context "when value includes 'expose_as' keyword" do
|
|
|
|
let(:config) { { paths: %w[results.txt], expose_as: "Test results" } }
|
|
|
|
|
|
|
|
it 'returns general artifact and report-type artifacts configuration' do
|
|
|
|
expect(entry.value).to eq config
|
|
|
|
end
|
|
|
|
end
|
2021-03-08 18:12:59 +05:30
|
|
|
|
|
|
|
context "when value includes 'public' keyword" do
|
|
|
|
let(:config) { { paths: %w[results.txt], public: false } }
|
|
|
|
|
|
|
|
it 'returns general artifact and report-type artifacts configuration' do
|
|
|
|
expect(entry.value).to eq config
|
|
|
|
end
|
|
|
|
end
|
2016-09-13 17:45:13 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when entry value is not correct' do
|
|
|
|
describe '#errors' do
|
|
|
|
context 'when value of attribute is invalid' do
|
|
|
|
let(:config) { { name: 10 } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts name should be a string'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is an unknown key present' do
|
|
|
|
let(:config) { { test: 100 } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts config contains unknown keys: test'
|
|
|
|
end
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
|
|
|
|
context "when 'reports' keyword is not hash" do
|
|
|
|
let(:config) { { paths: %w[public/], reports: 'junit.xml' } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts reports should be a hash'
|
|
|
|
end
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2021-03-08 18:12:59 +05:30
|
|
|
context "when 'public' is not a boolean" do
|
|
|
|
let(:config) { { paths: %w[results.txt], public: 'false' } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts public should be a boolean value'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
context "when 'expose_as' is not a string" do
|
|
|
|
let(:config) { { paths: %w[results.txt], expose_as: 1 } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts expose as should be a string'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when 'expose_as' is too long" do
|
|
|
|
let(:config) { { paths: %w[results.txt], expose_as: 'A' * 101 } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts expose as is too long (maximum is 100 characters)'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when 'expose_as' is an empty string" do
|
|
|
|
let(:config) { { paths: %w[results.txt], expose_as: '' } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts expose as ' + Gitlab::Ci::Config::Entry::Artifacts::EXPOSE_AS_ERROR_MESSAGE
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when 'expose_as' contains invalid characters" do
|
|
|
|
let(:config) do
|
|
|
|
{ paths: %w[results.txt], expose_as: '<script>alert("xss");</script>' }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts expose as ' + Gitlab::Ci::Config::Entry::Artifacts::EXPOSE_AS_ERROR_MESSAGE
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when 'expose_as' is used without 'paths'" do
|
|
|
|
let(:config) { { expose_as: 'Test results' } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include "artifacts paths can't be blank"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when 'paths' includes '*' and 'expose_as' is defined" do
|
|
|
|
let(:config) { { expose_as: 'Test results', paths: ['test.txt', 'test*.txt'] } }
|
|
|
|
|
|
|
|
it 'reports error' do
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include "artifacts paths can't contain '*' when used with 'expose_as'"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
context 'when the `when` keyword is not a string' do
|
|
|
|
context 'when it is an array' do
|
|
|
|
let(:config) { { paths: %w[results.txt], when: ['always'] } }
|
|
|
|
|
|
|
|
it 'returns error' do
|
|
|
|
expect(entry).not_to be_valid
|
|
|
|
expect(entry.errors).to include 'artifacts when should be a string'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when it is a boolean' do
|
|
|
|
let(:config) { { paths: %w[results.txt], when: true } }
|
|
|
|
|
|
|
|
it 'returns error' do
|
|
|
|
expect(entry).not_to be_valid
|
|
|
|
expect(entry.errors).to include 'artifacts when should be a string'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
describe 'excluded artifacts' do
|
2021-09-30 23:02:18 +05:30
|
|
|
context 'when configuration is valid' do
|
|
|
|
let(:config) { { untracked: true, exclude: ['some/directory/'] } }
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
it 'correctly parses the configuration' do
|
|
|
|
expect(entry).to be_valid
|
|
|
|
expect(entry.value).to eq config
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
context 'when configuration is not valid' do
|
|
|
|
let(:config) { { untracked: true, exclude: 1234 } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2021-09-30 23:02:18 +05:30
|
|
|
it 'returns an error' do
|
|
|
|
expect(entry).not_to be_valid
|
|
|
|
expect(entry.errors)
|
|
|
|
.to include 'artifacts exclude should be an array of strings'
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
2016-09-13 17:45:13 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|