debian-mirror-gitlab/spec/graphql/mutations/issues/update_spec.rb

168 lines
5.4 KiB
Ruby
Raw Normal View History

2020-04-08 14:13:33 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Mutations::Issues::Update do
2020-10-24 23:57:45 +05:30
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user) }
let_it_be(:project_label) { create(:label, project: project) }
let_it_be(:issue) { create(:issue, project: project, labels: [project_label]) }
let_it_be(:milestone) { create(:milestone, project: project) }
2020-04-08 14:13:33 +05:30
let(:expected_attributes) do
{
title: 'new title',
description: 'new description',
confidential: true,
2020-10-24 23:57:45 +05:30
due_date: Date.tomorrow,
discussion_locked: true,
milestone_id: milestone.id
2020-04-08 14:13:33 +05:30
}
end
2020-10-24 23:57:45 +05:30
2020-04-08 14:13:33 +05:30
let(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) }
let(:mutated_issue) { subject[:issue] }
2020-05-24 23:13:21 +05:30
specify { expect(described_class).to require_graphql_authorizations(:update_issue) }
2020-04-08 14:13:33 +05:30
describe '#resolve' do
let(:mutation_params) do
{
2020-10-24 23:57:45 +05:30
project_path: project.full_path,
2020-04-08 14:13:33 +05:30
iid: issue.iid
}.merge(expected_attributes)
end
2021-02-22 17:27:13 +05:30
subject { mutation.resolve(**mutation_params) }
2020-04-08 14:13:33 +05:30
2021-09-30 23:02:18 +05:30
before do
stub_spam_services
end
2021-01-29 00:20:46 +05:30
it_behaves_like 'permission level for issue mutation is correctly verified'
2020-04-08 14:13:33 +05:30
context 'when the user can update the issue' do
before do
2020-10-24 23:57:45 +05:30
project.add_developer(user)
2020-04-08 14:13:33 +05:30
end
it 'updates issue with correct values' do
subject
expect(issue.reload).to have_attributes(expected_attributes)
end
context 'when iid does not exist' do
it 'raises resource not available error' do
2020-04-22 19:07:51 +05:30
mutation_params[:iid] = non_existing_record_iid
2020-04-08 14:13:33 +05:30
expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)
end
end
2020-10-24 23:57:45 +05:30
context 'when setting milestone to nil' do
let(:expected_attributes) { { milestone_id: nil } }
it 'changes the milestone corrrectly' do
issue.update_column(:milestone_id, milestone.id)
expect { subject }.to change { issue.reload.milestone }.from(milestone).to(nil)
end
end
2021-01-03 14:25:43 +05:30
context 'when changing state' do
let_it_be_with_refind(:issue) { create(:issue, project: project, state: :opened) }
2021-09-04 01:27:46 +05:30
it 'closes issue' do
mutation_params[:state_event] = 'close'
2021-01-03 14:25:43 +05:30
2021-09-04 01:27:46 +05:30
expect { subject }.to change { issue.reload.state }.from('opened').to('closed')
2021-01-03 14:25:43 +05:30
end
2021-09-04 01:27:46 +05:30
it 'reopens issue' do
issue.close
mutation_params[:state_event] = 'reopen'
2021-01-03 14:25:43 +05:30
2021-09-04 01:27:46 +05:30
expect { subject }.to change { issue.reload.state }.from('closed').to('opened')
2021-01-03 14:25:43 +05:30
end
end
2020-10-24 23:57:45 +05:30
context 'when changing labels' do
let_it_be(:label_1) { create(:label, project: project) }
let_it_be(:label_2) { create(:label, project: project) }
let_it_be(:external_label) { create(:label, project: create(:project)) }
it 'adds and removes labels correctly' do
mutation_params[:add_label_ids] = [label_1.id, label_2.id]
mutation_params[:remove_label_ids] = [project_label.id]
subject
expect(issue.reload.labels).to match_array([label_1, label_2])
end
it 'does not add label if label id is nil' do
mutation_params[:add_label_ids] = [nil, label_2.id]
subject
expect(issue.reload.labels).to match_array([project_label, label_2])
end
it 'does not add label if label is not found' do
mutation_params[:add_label_ids] = [external_label.id, label_2.id]
subject
expect(issue.reload.labels).to match_array([project_label, label_2])
end
it 'does not modify labels if label is already present' do
mutation_params[:add_label_ids] = [project_label.id]
expect(issue.reload.labels).to match_array([project_label])
end
it 'does not modify labels if label is addded and removed in the same request' do
mutation_params[:add_label_ids] = [label_1.id, label_2.id]
mutation_params[:remove_label_ids] = [label_1.id]
subject
expect(issue.reload.labels).to match_array([project_label, label_2])
end
2021-10-27 15:23:28 +05:30
context 'when setting labels with label_ids' do
it 'replaces existing labels with provided ones' do
expect(issue.reload.labels).to match_array([project_label])
mutation_params[:label_ids] = [label_1.id, label_2.id]
subject
expect(issue.reload.labels).to match_array([label_1, label_2])
end
it 'raises error when label_ids is combined with remove_label_ids' do
expect { mutation.ready?(label_ids: [label_1.id, label_2.id], remove_label_ids: [label_1.id]) }
.to raise_error(Gitlab::Graphql::Errors::ArgumentError, 'labelIds is mutually exclusive with any of addLabelIds or removeLabelIds')
end
it 'raises error when label_ids is combined with add_label_ids' do
expect { mutation.ready?(label_ids: [label_1.id, label_2.id], add_label_ids: [label_2.id]) }
.to raise_error(Gitlab::Graphql::Errors::ArgumentError, 'labelIds is mutually exclusive with any of addLabelIds or removeLabelIds')
end
end
2020-10-24 23:57:45 +05:30
end
2021-06-08 01:23:25 +05:30
context 'when changing type' do
it 'changes the type of the issue' do
mutation_params[:issue_type] = 'incident'
expect { subject }.to change { issue.reload.issue_type }.from('issue').to('incident')
end
end
2020-04-08 14:13:33 +05:30
end
end
end