2020-10-24 23:57:45 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
# Add capabilities to increment a numeric model attribute efficiently by
|
|
|
|
# using Redis and flushing the increments asynchronously to the database
|
|
|
|
# after a period of time (10 minutes).
|
|
|
|
# When an attribute is incremented by a value, the increment is added
|
|
|
|
# to a Redis key. Then, FlushCounterIncrementsWorker will execute
|
|
|
|
# `flush_increments_to_database!` which removes increments from Redis for a
|
|
|
|
# given model attribute and updates the values in the database.
|
|
|
|
#
|
|
|
|
# @example:
|
|
|
|
#
|
|
|
|
# class ProjectStatistics
|
|
|
|
# include CounterAttribute
|
|
|
|
#
|
|
|
|
# counter_attribute :commit_count
|
|
|
|
# counter_attribute :storage_size
|
|
|
|
# end
|
|
|
|
#
|
2023-03-04 22:38:38 +05:30
|
|
|
# It's possible to define a conditional counter attribute. You need to pass a proc
|
|
|
|
# that must accept a single argument, the object instance on which this concern is
|
|
|
|
# included.
|
|
|
|
#
|
|
|
|
# @example:
|
|
|
|
#
|
|
|
|
# class ProjectStatistics
|
|
|
|
# include CounterAttribute
|
|
|
|
#
|
|
|
|
# counter_attribute :conditional_one, if: -> { |object| object.use_counter_attribute? }
|
|
|
|
# end
|
|
|
|
#
|
2020-10-24 23:57:45 +05:30
|
|
|
# To increment the counter we can use the method:
|
2023-03-04 22:38:38 +05:30
|
|
|
# increment_counter(:commit_count, 3)
|
|
|
|
#
|
|
|
|
# This method would determine whether it would increment the counter using Redis,
|
|
|
|
# or fallback to legacy increment on ActiveRecord counters.
|
2020-10-24 23:57:45 +05:30
|
|
|
#
|
2021-01-03 14:25:43 +05:30
|
|
|
# It is possible to register callbacks to be executed after increments have
|
|
|
|
# been flushed to the database. Callbacks are not executed if there are no increments
|
|
|
|
# to flush.
|
|
|
|
#
|
2023-03-04 22:38:38 +05:30
|
|
|
# counter_attribute_after_commit do |statistic|
|
2021-01-03 14:25:43 +05:30
|
|
|
# Namespaces::ScheduleAggregationWorker.perform_async(statistic.namespace_id)
|
|
|
|
# end
|
|
|
|
#
|
2020-10-24 23:57:45 +05:30
|
|
|
module CounterAttribute
|
|
|
|
extend ActiveSupport::Concern
|
|
|
|
extend AfterCommitQueue
|
|
|
|
include Gitlab::ExclusiveLeaseHelpers
|
2023-03-04 22:38:38 +05:30
|
|
|
include Gitlab::Utils::StrongMemoize
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
class_methods do
|
2023-03-04 22:38:38 +05:30
|
|
|
def counter_attribute(attribute, if: nil)
|
|
|
|
counter_attributes << {
|
|
|
|
attribute: attribute,
|
|
|
|
if_proc: binding.local_variable_get(:if) # can't read `if` directly
|
|
|
|
}
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def counter_attributes
|
2023-03-04 22:38:38 +05:30
|
|
|
@counter_attributes ||= []
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def after_commit_callbacks
|
|
|
|
@after_commit_callbacks ||= []
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
# perform registered callbacks after increments have been committed to the database
|
|
|
|
def counter_attribute_after_commit(&callback)
|
|
|
|
after_commit_callbacks << callback
|
2022-10-11 01:57:18 +05:30
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def counter_attribute_enabled?(attribute)
|
|
|
|
counter_attribute = self.class.counter_attributes.find { |registered| registered[:attribute] == attribute }
|
|
|
|
return false unless counter_attribute
|
|
|
|
return true unless counter_attribute[:if_proc]
|
2021-01-03 14:25:43 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
counter_attribute[:if_proc].call(self)
|
|
|
|
end
|
2022-08-27 11:52:29 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def counter(attribute)
|
|
|
|
strong_memoize_with(:counter, attribute) do
|
|
|
|
# This needs #to_sym because attribute could come from a Sidekiq param,
|
|
|
|
# which would be a string.
|
|
|
|
build_counter_for(attribute.to_sym)
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def increment_counter(attribute, increment)
|
2020-10-24 23:57:45 +05:30
|
|
|
return if increment == 0
|
|
|
|
|
|
|
|
run_after_commit_or_now do
|
2023-03-04 22:38:38 +05:30
|
|
|
new_value = counter(attribute).increment(increment)
|
2022-08-27 11:52:29 +05:30
|
|
|
|
|
|
|
log_increment_counter(attribute, increment, new_value)
|
2022-05-07 20:08:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
def update_counters_with_lease(increments)
|
|
|
|
detect_race_on_record(log_fields: { caller: __method__, attributes: increments.keys }) do
|
|
|
|
self.class.update_counters(id, increments)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def reset_counter!(attribute)
|
2023-03-04 22:38:38 +05:30
|
|
|
detect_race_on_record(log_fields: { caller: __method__, attributes: attribute }) do
|
|
|
|
counter(attribute).reset!
|
2022-05-07 20:08:51 +05:30
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
log_clear_counter(attribute)
|
2022-05-07 20:08:51 +05:30
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def execute_after_commit_callbacks
|
|
|
|
self.class.after_commit_callbacks.each do |callback|
|
|
|
|
callback.call(self.reset)
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
|
2021-01-03 14:25:43 +05:30
|
|
|
private
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def build_counter_for(attribute)
|
|
|
|
raise ArgumentError, %(attribute "#{attribute}" does not exist) unless has_attribute?(attribute)
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
if counter_attribute_enabled?(attribute)
|
|
|
|
Gitlab::Counters::BufferedCounter.new(self, attribute)
|
|
|
|
else
|
|
|
|
Gitlab::Counters::LegacyCounter.new(self, attribute)
|
2021-01-03 14:25:43 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-03-04 22:38:38 +05:30
|
|
|
def database_lock_key
|
|
|
|
"project:{#{project_id}}:#{self.class}:#{id}"
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
2022-08-27 11:52:29 +05:30
|
|
|
|
2022-11-25 23:54:43 +05:30
|
|
|
# detect_race_on_record uses a lease to monitor access
|
|
|
|
# to the project statistics row. This is needed to detect
|
|
|
|
# concurrent attempts to increment columns, which could result in a
|
|
|
|
# race condition.
|
|
|
|
#
|
|
|
|
# As the purpose is to detect and warn concurrent attempts,
|
|
|
|
# it falls back to direct update on the row if it fails to obtain the lease.
|
|
|
|
#
|
|
|
|
# It does not guarantee that there will not be any concurrent updates.
|
|
|
|
def detect_race_on_record(log_fields: {})
|
|
|
|
return yield unless Feature.enabled?(:counter_attribute_db_lease_for_update, project)
|
|
|
|
|
|
|
|
# Ensure attributes is always an array before we log
|
|
|
|
log_fields[:attributes] = Array(log_fields[:attributes])
|
|
|
|
|
|
|
|
Gitlab::AppLogger.info(
|
|
|
|
message: 'Acquiring lease for project statistics update',
|
|
|
|
project_statistics_id: id,
|
|
|
|
project_id: project.id,
|
|
|
|
**log_fields,
|
|
|
|
**Gitlab::ApplicationContext.current
|
|
|
|
)
|
|
|
|
|
|
|
|
in_lock(database_lock_key, retries: 0) do
|
|
|
|
yield
|
|
|
|
end
|
|
|
|
rescue Gitlab::ExclusiveLeaseHelpers::FailedToObtainLockError
|
|
|
|
Gitlab::AppLogger.warn(
|
|
|
|
message: 'Concurrent project statistics update detected',
|
|
|
|
project_statistics_id: id,
|
|
|
|
project_id: project.id,
|
|
|
|
**log_fields,
|
|
|
|
**Gitlab::ApplicationContext.current
|
|
|
|
)
|
|
|
|
|
|
|
|
yield
|
|
|
|
end
|
|
|
|
|
2022-08-27 11:52:29 +05:30
|
|
|
def log_increment_counter(attribute, increment, new_value)
|
|
|
|
payload = Gitlab::ApplicationContext.current.merge(
|
|
|
|
message: 'Increment counter attribute',
|
|
|
|
attribute: attribute,
|
|
|
|
project_id: project_id,
|
|
|
|
increment: increment,
|
|
|
|
new_counter_value: new_value,
|
|
|
|
current_db_value: read_attribute(attribute)
|
|
|
|
)
|
|
|
|
|
|
|
|
Gitlab::AppLogger.info(payload)
|
|
|
|
end
|
|
|
|
|
|
|
|
def log_clear_counter(attribute)
|
|
|
|
payload = Gitlab::ApplicationContext.current.merge(
|
|
|
|
message: 'Clear counter attribute',
|
|
|
|
attribute: attribute,
|
|
|
|
project_id: project_id
|
|
|
|
)
|
|
|
|
|
|
|
|
Gitlab::AppLogger.info(payload)
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|