2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe Groups::Settings::CiCdController do
|
2019-07-07 11:18:12 +05:30
|
|
|
include ExternalAuthorizationServiceHelpers
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:sub_group) { create(:group, parent: group) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project, group: group) }
|
|
|
|
let_it_be(:project_2) { create(:project, group: sub_group) }
|
|
|
|
let_it_be(:runner_group) { create(:ci_runner, :group, groups: [group]) }
|
|
|
|
let_it_be(:runner_project_1) { create(:ci_runner, :project, projects: [project])}
|
|
|
|
let_it_be(:runner_project_2) { create(:ci_runner, :project, projects: [project_2])}
|
|
|
|
let_it_be(:runner_project_3) { create(:ci_runner, :project, projects: [project, project_2])}
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET #show' do
|
2019-01-03 12:48:30 +05:30
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'renders show with 200 status code and correct runners' do
|
2019-02-15 15:39:39 +05:30
|
|
|
get :show, params: { group_id: group }
|
2019-01-03 12:48:30 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-01-03 12:48:30 +05:30
|
|
|
expect(response).to render_template(:show)
|
2020-07-28 23:09:34 +05:30
|
|
|
expect(assigns(:group_runners)).to match_array([runner_group, runner_project_1, runner_project_2, runner_project_3])
|
2019-01-03 12:48:30 +05:30
|
|
|
end
|
2021-06-08 01:23:25 +05:30
|
|
|
|
|
|
|
it 'paginates runners' do
|
|
|
|
stub_const("Groups::Settings::CiCdController::NUMBER_OF_RUNNERS_PER_PAGE", 1)
|
|
|
|
|
|
|
|
create(:ci_runner)
|
|
|
|
|
|
|
|
get :show, params: { group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(assigns(:group_runners).count).to be(1)
|
|
|
|
end
|
2019-01-03 12:48:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
2019-02-15 15:39:39 +05:30
|
|
|
get :show, params: { group_id: group }
|
2019-01-03 12:48:30 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2020-07-28 23:09:34 +05:30
|
|
|
expect(assigns(:group_runners)).to be_nil
|
2019-01-03 12:48:30 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
context 'external authorization' do
|
|
|
|
before do
|
|
|
|
enable_external_authorization_service_check
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders show with 200 status code' do
|
|
|
|
get :show, params: { group_id: group }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
|
|
|
|
describe 'PUT #reset_registration_token' do
|
2019-02-15 15:39:39 +05:30
|
|
|
subject { put :reset_registration_token, params: { group_id: group } }
|
2018-12-05 23:21:45 +05:30
|
|
|
|
2019-01-03 12:48:30 +05:30
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'resets runner registration token' do
|
|
|
|
expect { subject }.to change { group.reload.runners_token }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'redirects the user to admin runners page' do
|
|
|
|
subject
|
|
|
|
|
|
|
|
expect(response).to redirect_to(group_settings_ci_cd_path)
|
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
end
|
|
|
|
|
2019-01-03 12:48:30 +05:30
|
|
|
context 'when user is not owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
|
|
|
subject
|
2018-12-05 23:21:45 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-01-03 12:48:30 +05:30
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
end
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
describe 'PATCH #update_auto_devops' do
|
|
|
|
let(:auto_devops_param) { '1' }
|
|
|
|
|
|
|
|
subject do
|
|
|
|
patch :update_auto_devops, params: {
|
|
|
|
group_id: group,
|
|
|
|
group: { auto_devops_enabled: auto_devops_param }
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have enough permission' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has enough privileges' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
|
|
|
|
|
|
|
|
context 'when service execution went wrong' do
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Groups::AutoDevopsService).to receive(:execute).and_return(false)
|
|
|
|
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
|
|
|
|
.and_return(['Error 1'])
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a flash alert' do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(controller).to set_flash[:alert]
|
2019-07-07 11:18:12 +05:30
|
|
|
.to eq("There was a problem updating Auto DevOps pipeline: [\"Error 1\"].")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service execution was successful' do
|
|
|
|
it 'returns a flash notice' do
|
|
|
|
subject
|
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(controller).to set_flash[:notice]
|
2019-07-07 11:18:12 +05:30
|
|
|
.to eq('Auto DevOps pipeline was updated for the group')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when changing auto devops value' do
|
|
|
|
before do
|
|
|
|
subject
|
|
|
|
|
|
|
|
group.reload
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when explicitly enabling auto devops' do
|
|
|
|
it 'updates group attribute' do
|
|
|
|
expect(group.auto_devops_enabled).to eq(true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when explicitly disabling auto devops' do
|
|
|
|
let(:auto_devops_param) { '0' }
|
|
|
|
|
|
|
|
it 'updates group attribute' do
|
|
|
|
expect(group.auto_devops_enabled).to eq(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
|
|
|
|
describe 'PATCH #update' do
|
|
|
|
subject do
|
|
|
|
patch :update, params: {
|
|
|
|
group_id: group,
|
|
|
|
group: { max_artifacts_size: 10 }
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not an admin' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is an admin' do
|
|
|
|
let(:user) { create(:admin) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'when admin mode is disabled' do
|
|
|
|
it { is_expected.to have_gitlab_http_status(:not_found) }
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'when admin mode is enabled', :enable_admin_mode do
|
|
|
|
it { is_expected.to redirect_to(group_settings_ci_cd_path) }
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'when service execution went wrong' do
|
|
|
|
let(:update_service) { double }
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
before do
|
|
|
|
allow(Groups::UpdateService).to receive(:new).and_return(update_service)
|
|
|
|
allow(update_service).to receive(:execute).and_return(false)
|
|
|
|
allow_any_instance_of(Group).to receive_message_chain(:errors, :full_messages)
|
|
|
|
.and_return(['Error 1'])
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
subject
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a flash alert' do
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(controller).to set_flash[:alert]
|
2020-04-22 19:07:51 +05:30
|
|
|
.to eq("There was a problem updating the pipeline settings: [\"Error 1\"].")
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'when service execution was successful' do
|
|
|
|
it 'returns a flash notice' do
|
|
|
|
subject
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
expect(controller).to set_flash[:notice]
|
2020-04-22 19:07:51 +05:30
|
|
|
.to eq('Pipeline settings was updated for the group')
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
|
|
|
describe 'GET #runner_setup_scripts' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders the setup scripts' do
|
|
|
|
get :runner_setup_scripts, params: { os: 'linux', arch: 'amd64', group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(json_response).to have_key("install")
|
|
|
|
expect(json_response).to have_key("register")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders errors if they occur' do
|
|
|
|
get :runner_setup_scripts, params: { os: 'foo', arch: 'bar', group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:bad_request)
|
|
|
|
expect(json_response).to have_key("errors")
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|