104 lines
2.7 KiB
Ruby
104 lines
2.7 KiB
Ruby
|
# frozen_string_literal: true
|
||
|
|
|
||
|
|
require 'spec_helper'
|
||
|
|
|
||
|
|
RSpec.describe Uploads::DestroyService do
|
||
|
|
let_it_be(:project) { create(:project) }
|
||
|
|
let_it_be(:user) { create(:user) }
|
||
|
|
let_it_be_with_reload(:upload) { create(:upload, :issuable_upload, model: project) }
|
||
|
|
|
||
|
|
let(:filename) { File.basename(upload.path) }
|
||
|
|
let(:secret) { upload.secret }
|
||
|
|
let(:model) { project }
|
||
|
|
let(:service) { described_class.new(model, user) }
|
||
|
|
|
||
|
|
describe '#execute' do
|
||
|
|
subject { service.execute(secret, filename) }
|
||
|
|
|
||
|
|
shared_examples_for 'upload not found' do
|
||
|
|
it 'does not delete any upload' do
|
||
|
|
expect { subject }.not_to change { Upload.count }
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'returns an error' do
|
||
|
|
expect(subject[:status]).to eq(:error)
|
||
|
|
expect(subject[:message]).to eq("The resource that you are attempting to access does not "\
|
||
|
|
"exist or you don't have permission to perform this action.")
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when user is nil' do
|
||
|
|
let(:user) { nil }
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when user cannot destroy upload' do
|
||
|
|
before do
|
||
|
|
project.add_developer(user)
|
||
|
|
end
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when user can destroy upload' do
|
||
|
|
before do
|
||
|
|
project.add_maintainer(user)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'deletes the upload' do
|
||
|
|
expect { subject }.to change { Upload.count }.by(-1)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'returns success response' do
|
||
|
|
expect(subject[:status]).to eq(:success)
|
||
|
|
expect(subject[:upload]).to eq(upload)
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when upload is not found' do
|
||
|
|
let(:filename) { 'not existing filename' }
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when upload secret is not found' do
|
||
|
|
let(:secret) { 'aaaaaaaaaa' }
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when upload secret has invalid format' do
|
||
|
|
let(:secret) { 'invalid' }
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when unknown model is used' do
|
||
|
|
let(:model) { user }
|
||
|
|
|
||
|
|
it 'raises an error' do
|
||
|
|
expect { subject }.to raise_exception(ArgumentError)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when upload belongs to other model' do
|
||
|
|
let_it_be(:upload) { create(:upload, :namespace_upload) }
|
||
|
|
|
||
|
|
it_behaves_like 'upload not found'
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when upload destroy fails' do
|
||
|
|
before do
|
||
|
|
allow(service).to receive(:find_upload).and_return(upload)
|
||
|
|
allow(upload).to receive(:destroy).and_return(false)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'returns error' do
|
||
|
|
expect(subject[:status]).to eq(:error)
|
||
|
|
expect(subject[:message]).to eq('Upload could not be deleted.')
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|