2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe EventCollection do
|
|
|
|
include DesignManagementTestHelpers
|
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
shared_examples 'EventCollection examples' do
|
|
|
|
describe '#to_a' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:project) { create(:project_empty_repo, group: group) }
|
|
|
|
let_it_be(:projects) { Project.where(id: project.id) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:merge_request) { create(:merge_request) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
enable_design_management
|
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
context 'with project events' do
|
|
|
|
let_it_be(:push_event_payloads) do
|
|
|
|
Array.new(9) do
|
|
|
|
create(:push_event_payload,
|
|
|
|
event: create(:push_event, project: project, author: user))
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
let_it_be(:merge_request_events) { create_list(:event, 10, :merged, project: project, target: merge_request) }
|
|
|
|
let_it_be(:closed_issue_event) { create(:closed_issue_event, project: project, author: user) }
|
|
|
|
let_it_be(:wiki_page_event) { create(:wiki_page_event, project: project) }
|
|
|
|
let_it_be(:design_event) { create(:design_event, project: project) }
|
|
|
|
|
|
|
|
let(:push_events) { push_event_payloads.map(&:event) }
|
|
|
|
|
|
|
|
it 'returns an Array of all event types when no filter is passed', :aggregate_failures do
|
|
|
|
most_recent_20_events = [
|
|
|
|
wiki_page_event,
|
|
|
|
design_event,
|
|
|
|
closed_issue_event,
|
|
|
|
*push_events,
|
|
|
|
*merge_request_events
|
|
|
|
].sort_by(&:id).reverse.take(20)
|
|
|
|
events = described_class.new(projects).to_a
|
|
|
|
|
|
|
|
expect(events).to be_an_instance_of(Array)
|
|
|
|
expect(events).to match_array(most_recent_20_events)
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'includes the wiki page events when using to_a' do
|
|
|
|
events = described_class.new(projects).to_a
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to include(wiki_page_event)
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'includes the design events' do
|
|
|
|
collection = described_class.new(projects)
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(collection.to_a).to include(design_event)
|
|
|
|
expect(collection.all_project_events).to include(design_event)
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'includes the wiki page events when using all_project_events' do
|
|
|
|
events = described_class.new(projects).all_project_events
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to include(wiki_page_event)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'applies a limit to the number of events' do
|
|
|
|
events = described_class.new(projects).to_a
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events.length).to eq(20)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'can paginate through events' do
|
|
|
|
events = described_class.new(projects, limit: 5, offset: 15).to_a
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events.length).to eq(5)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'returns an empty Array when crossing the maximum page number' do
|
|
|
|
events = described_class.new(projects, limit: 1, offset: 15).to_a
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to be_empty
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'allows filtering of events using an EventFilter, returning single item' do
|
|
|
|
filter = EventFilter.new(EventFilter::ISSUE)
|
|
|
|
events = described_class.new(projects, filter: filter).to_a
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to contain_exactly(closed_issue_event)
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'allows filtering of events using an EventFilter, returning several items' do
|
|
|
|
filter = EventFilter.new(EventFilter::MERGED)
|
|
|
|
events = described_class.new(projects, filter: filter).to_a
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to match_array(merge_request_events)
|
|
|
|
end
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'allows filtering of events using an EventFilter, returning pushes' do
|
|
|
|
filter = EventFilter.new(EventFilter::PUSH)
|
|
|
|
events = described_class.new(projects, filter: filter).to_a
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(events).to match_array(push_events)
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
context 'with group events' do
|
|
|
|
let(:groups) { group.self_and_descendants.public_or_visible_to_user(user) }
|
|
|
|
let(:subject) { described_class.new(projects, groups: groups).to_a }
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'includes also group events' do
|
|
|
|
subgroup = create(:group, parent: group)
|
|
|
|
event1 = create(:event, project: project, author: user)
|
|
|
|
event2 = create(:event, project: nil, group: group, author: user)
|
|
|
|
event3 = create(:event, project: nil, group: subgroup, author: user)
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(subject).to eq([event3, event2, event1])
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'does not include events from inaccessible groups' do
|
|
|
|
subgroup = create(:group, :private, parent: group)
|
|
|
|
event1 = create(:event, project: nil, group: group, author: user)
|
|
|
|
create(:event, project: nil, group: subgroup, author: user)
|
2019-12-21 20:55:43 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(subject).to match_array([event1])
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'pagination through events' do
|
|
|
|
let_it_be(:project_events) { create_list(:event, 10, project: project) }
|
|
|
|
let_it_be(:group_events) { create_list(:event, 10, group: group, author: user) }
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
let(:subject) { described_class.new(projects, limit: 10, offset: 5, groups: groups).to_a }
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'returns recent groups and projects events' do
|
|
|
|
recent_events_with_offset = (project_events[5..] + group_events[..4]).reverse
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
expect(subject).to eq(recent_events_with_offset)
|
|
|
|
end
|
|
|
|
end
|
2022-05-07 20:08:51 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
context 'project exclusive event types' do
|
|
|
|
using RSpec::Parameterized::TableSyntax
|
|
|
|
|
|
|
|
where(:filter, :event) do
|
|
|
|
EventFilter::PUSH | lazy { create(:push_event, project: project) }
|
|
|
|
EventFilter::MERGED | lazy { create(:event, :merged, project: project, target: merge_request) }
|
|
|
|
EventFilter::TEAM | lazy { create(:event, :joined, project: project) }
|
|
|
|
EventFilter::ISSUE | lazy { create(:closed_issue_event, project: project) }
|
|
|
|
EventFilter::DESIGNS | lazy { create(:design_event, project: project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
with_them do
|
|
|
|
let(:subject) do
|
|
|
|
described_class.new(projects, groups: Group.where(id: group.id), filter: EventFilter.new(filter))
|
|
|
|
end
|
|
|
|
|
|
|
|
it "queries only project events" do
|
|
|
|
expected_event = event # Forcing lazy evaluation
|
|
|
|
expect(subject).to receive(:project_events).with(no_args).and_call_original
|
|
|
|
expect(subject).not_to receive(:group_events)
|
|
|
|
|
|
|
|
expect(subject.to_a).to match_array(expected_event)
|
|
|
|
end
|
|
|
|
end
|
2022-05-07 20:08:51 +05:30
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
2022-07-16 23:28:13 +05:30
|
|
|
|
|
|
|
context 'when the optimized_project_and_group_activity_queries FF is on' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(optimized_project_and_group_activity_queries: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'EventCollection examples'
|
|
|
|
|
|
|
|
it 'returns no events if no projects are passed' do
|
|
|
|
events = described_class.new(Project.none).to_a
|
|
|
|
|
|
|
|
expect(events).to be_empty
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the optimized_project_and_group_activity_queries FF is off' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(optimized_project_and_group_activity_queries: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'EventCollection examples'
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|