2020-11-24 15:15:51 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe Gitlab::UsageDataCounters::IssueActivityUniqueCounter, :clean_gitlab_redis_shared_state do
|
|
|
|
let(:user1) { build(:user, id: 1) }
|
|
|
|
let(:user2) { build(:user, id: 2) }
|
|
|
|
let(:user3) { build(:user, id: 3) }
|
|
|
|
let(:time) { Time.zone.now }
|
|
|
|
|
|
|
|
shared_examples 'tracks and counts action' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(usage_ping_enabled: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
def count_unique(date_from:, date_to:)
|
|
|
|
Gitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: action, start_date: date_from, end_date: date_to)
|
|
|
|
end
|
|
|
|
|
|
|
|
specify do
|
|
|
|
aggregate_failures do
|
|
|
|
expect(track_action(author: user1)).to be_truthy
|
|
|
|
expect(track_action(author: user1)).to be_truthy
|
|
|
|
expect(track_action(author: user2)).to be_truthy
|
|
|
|
expect(track_action(author: user3, time: time - 3.days)).to be_truthy
|
|
|
|
|
|
|
|
expect(count_unique(date_from: time, date_to: time)).to eq(2)
|
|
|
|
expect(count_unique(date_from: time - 5.days, date_to: 1.day.since(time))).to eq(3)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not track edit actions if author is not present' do
|
|
|
|
expect(track_action(author: nil)).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when feature flag track_issue_activity_actions is disabled' do
|
|
|
|
it 'does not track edit actions' do
|
|
|
|
stub_feature_flags(track_issue_activity_actions: false)
|
|
|
|
|
|
|
|
expect(track_action(author: user1)).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue title edit actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_TITLE_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
2021-01-03 14:25:43 +05:30
|
|
|
described_class.track_issue_title_changed_action(**params)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue description edit actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_DESCRIPTION_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
2021-01-03 14:25:43 +05:30
|
|
|
described_class.track_issue_description_changed_action(**params)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue assignee edit actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_ASSIGNEE_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
2021-01-03 14:25:43 +05:30
|
|
|
described_class.track_issue_assignee_changed_action(**params)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue make confidential actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_MADE_CONFIDENTIAL }
|
|
|
|
|
|
|
|
def track_action(params)
|
2021-01-03 14:25:43 +05:30
|
|
|
described_class.track_issue_made_confidential_action(**params)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue make visible actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_MADE_VISIBLE }
|
|
|
|
|
|
|
|
def track_action(params)
|
2021-01-03 14:25:43 +05:30
|
|
|
described_class.track_issue_made_visible_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue created actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_CREATED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_created_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue closed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_CLOSED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_closed_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue reopened actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_REOPENED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_reopened_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue label changed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_LABEL_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_label_changed_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue cross-referenced actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_CROSS_REFERENCED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_cross_referenced_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue moved actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_MOVED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_moved_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue relate actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_RELATED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_related_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue unrelate actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_UNRELATED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_unrelated_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue marked as duplicate actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_MARKED_AS_DUPLICATE }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_marked_as_duplicate_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue locked actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_LOCKED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_locked_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue unlocked actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_UNLOCKED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_unlocked_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue added to epic actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_ADDED_TO_EPIC}
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_added_to_epic_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue removed from epic actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_REMOVED_FROM_EPIC}
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_removed_from_epic_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue changed epic actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_CHANGED_EPIC}
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_changed_epic_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue designs added actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_DESIGNS_ADDED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_designs_added_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue designs modified actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_DESIGNS_MODIFIED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_designs_modified_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue designs removed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_DESIGNS_REMOVED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_designs_removed_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue due date changed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_DUE_DATE_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_due_date_changed_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue time estimate changed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_TIME_ESTIMATE_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_time_estimate_changed_action(**params)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for Issue time spent changed actions' do
|
|
|
|
it_behaves_like 'tracks and counts action' do
|
|
|
|
let(:action) { described_class::ISSUE_TIME_SPENT_CHANGED }
|
|
|
|
|
|
|
|
def track_action(params)
|
|
|
|
described_class.track_issue_time_spent_changed_action(**params)
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can return the count of actions per user deduplicated', :aggregate_failures do
|
|
|
|
described_class.track_issue_title_changed_action(author: user1)
|
|
|
|
described_class.track_issue_description_changed_action(author: user1)
|
|
|
|
described_class.track_issue_assignee_changed_action(author: user1)
|
|
|
|
described_class.track_issue_title_changed_action(author: user2, time: time - 2.days)
|
|
|
|
described_class.track_issue_title_changed_action(author: user3, time: time - 3.days)
|
|
|
|
described_class.track_issue_description_changed_action(author: user3, time: time - 3.days)
|
|
|
|
described_class.track_issue_assignee_changed_action(author: user3, time: time - 3.days)
|
|
|
|
|
|
|
|
events = Gitlab::UsageDataCounters::HLLRedisCounter.events_for_category(described_class::ISSUE_CATEGORY)
|
|
|
|
today_count = Gitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: events, start_date: time, end_date: time)
|
|
|
|
week_count = Gitlab::UsageDataCounters::HLLRedisCounter.unique_events(event_names: events, start_date: time - 5.days, end_date: 1.day.since(time))
|
|
|
|
|
|
|
|
expect(today_count).to eq(1)
|
|
|
|
expect(week_count).to eq(3)
|
|
|
|
end
|
|
|
|
end
|