2019-06-05 12:25:43 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2016-01-19 16:12:03 +05:30
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe SentNotificationsController do
|
2016-09-29 09:46:39 +05:30
|
|
|
let(:user) { create(:user) }
|
2019-06-05 12:25:43 +05:30
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:private_project) { create(:project, :private) }
|
|
|
|
let(:sent_notification) { create(:sent_notification, project: target_project, noteable: noteable, recipient: user) }
|
2016-01-19 16:12:03 +05:30
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
let(:issue) do
|
2019-06-05 12:25:43 +05:30
|
|
|
create(:issue, project: target_project) do |issue|
|
|
|
|
issue.subscriptions.create(user: user, project: target_project, subscribed: true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:confidential_issue) do
|
|
|
|
create(:issue, project: target_project, confidential: true) do |issue|
|
|
|
|
issue.subscriptions.create(user: user, project: target_project, subscribed: true)
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-06-05 12:25:43 +05:30
|
|
|
let(:merge_request) do
|
|
|
|
create(:merge_request, source_project: target_project, target_project: target_project) do |mr|
|
|
|
|
mr.subscriptions.create(user: user, project: target_project, subscribed: true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:noteable) { issue }
|
|
|
|
let(:target_project) { project }
|
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
describe 'GET unsubscribe' do
|
2020-03-13 15:44:24 +05:30
|
|
|
shared_examples 'returns 404' do
|
|
|
|
it 'does not set the flash message' do
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns a 404' do
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
context 'when the user is not logged in' do
|
|
|
|
context 'when the force param is passed' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key, force: true })
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
it 'unsubscribes the user' do
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(issue.subscribed?(user, project)).to be_falsey
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets the flash message' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(controller).to set_flash[:notice].to(/unsubscribed/)
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'redirects to the login page' do
|
|
|
|
expect(response).to redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the force param is not passed' do
|
2019-06-05 12:25:43 +05:30
|
|
|
render_views
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
shared_examples 'unsubscribing as anonymous' do |project_visibility|
|
2019-06-05 12:25:43 +05:30
|
|
|
it 'does not unsubscribe the user' do
|
|
|
|
expect(noteable.subscribed?(user, target_project)).to be_truthy
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not set the flash message' do
|
|
|
|
expect(controller).not_to set_flash[:notice]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders unsubscribe page' do
|
2020-04-22 19:07:51 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-06-05 12:25:43 +05:30
|
|
|
expect(response).to render_template :unsubscribe
|
|
|
|
end
|
2020-01-03 18:37:03 +05:30
|
|
|
|
|
|
|
if project_visibility == :private
|
|
|
|
it 'does not show project name or path' do
|
|
|
|
expect(response.body).not_to include(noteable.project.name)
|
|
|
|
expect(response.body).not_to include(noteable.project.full_name)
|
|
|
|
end
|
|
|
|
else
|
|
|
|
it 'shows project name or path' do
|
|
|
|
expect(response.body).to include(noteable.project.name)
|
|
|
|
expect(response.body).to include(noteable.project.full_name)
|
|
|
|
end
|
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
|
2019-06-05 12:25:43 +05:30
|
|
|
context 'when project is public' do
|
|
|
|
context 'when unsubscribing from issue' do
|
|
|
|
let(:noteable) { issue }
|
|
|
|
|
|
|
|
it 'shows issue title' do
|
|
|
|
expect(response.body).to include(issue.title)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it_behaves_like 'unsubscribing as anonymous', :public
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when unsubscribing from confidential issue' do
|
|
|
|
let(:noteable) { confidential_issue }
|
|
|
|
|
|
|
|
it 'does not show issue title' do
|
|
|
|
expect(response.body).not_to include(confidential_issue.title)
|
|
|
|
expect(response.body).to include(confidential_issue.to_reference)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it_behaves_like 'unsubscribing as anonymous', :public
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when unsubscribing from merge request' do
|
|
|
|
let(:noteable) { merge_request }
|
|
|
|
|
|
|
|
it 'shows merge request title' do
|
|
|
|
expect(response.body).to include(merge_request.title)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it 'shows project name or path' do
|
|
|
|
expect(response.body).to include(issue.project.name)
|
|
|
|
expect(response.body).to include(issue.project.full_name)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'unsubscribing as anonymous', :public
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
2019-06-05 12:25:43 +05:30
|
|
|
context 'when project is not public' do
|
|
|
|
let(:target_project) { private_project }
|
|
|
|
|
|
|
|
context 'when unsubscribing from issue' do
|
|
|
|
let(:noteable) { issue }
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it 'does not show issue title' do
|
2019-06-05 12:25:43 +05:30
|
|
|
expect(response.body).not_to include(issue.title)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it_behaves_like 'unsubscribing as anonymous', :private
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when unsubscribing from confidential issue' do
|
|
|
|
let(:noteable) { confidential_issue }
|
|
|
|
|
|
|
|
it 'does not show issue title' do
|
|
|
|
expect(response.body).not_to include(confidential_issue.title)
|
|
|
|
expect(response.body).to include(confidential_issue.to_reference)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it_behaves_like 'unsubscribing as anonymous', :private
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when unsubscribing from merge request' do
|
|
|
|
let(:noteable) { merge_request }
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it 'dos not show merge request title' do
|
2019-06-05 12:25:43 +05:30
|
|
|
expect(response.body).not_to include(merge_request.title)
|
|
|
|
end
|
|
|
|
|
2020-01-03 18:37:03 +05:30
|
|
|
it_behaves_like 'unsubscribing as anonymous', :private
|
2019-06-05 12:25:43 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
end
|
2020-03-13 15:44:24 +05:30
|
|
|
|
|
|
|
context 'when the noteable associated to the notification has been deleted' do
|
|
|
|
before do
|
|
|
|
sent_notification.noteable.destroy!
|
|
|
|
|
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'returns 404'
|
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
end
|
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
context 'when the user is logged in' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
context 'when the ID passed does not exist' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key.reverse })
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it_behaves_like 'returns 404'
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the force param is passed' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key, force: true })
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
it 'unsubscribes the user' do
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(issue.subscribed?(user, project)).to be_falsey
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets the flash message' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(controller).to set_flash[:notice].to(/unsubscribed/)
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'redirects to the issue page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(response)
|
|
|
|
.to redirect_to(project_issue_path(project, issue))
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the force param is not passed' do
|
|
|
|
let(:merge_request) do
|
|
|
|
create(:merge_request, source_project: project, author: user) do |merge_request|
|
2017-08-17 22:00:37 +05:30
|
|
|
merge_request.subscriptions.create(user: user, project: project, subscribed: true)
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:sent_notification) { create(:sent_notification, project: project, noteable: merge_request, recipient: user) }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
before do
|
2019-02-15 15:39:39 +05:30
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2016-09-29 09:46:39 +05:30
|
|
|
|
|
|
|
it 'unsubscribes the user' do
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(merge_request.subscribed?(user, project)).to be_falsey
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
it 'sets the flash message' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(controller).to set_flash[:notice].to(/unsubscribed/)
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
|
2016-09-29 09:46:39 +05:30
|
|
|
it 'redirects to the merge request page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(response)
|
|
|
|
.to redirect_to(project_merge_request_path(project, merge_request))
|
2016-09-29 09:46:39 +05:30
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
end
|
2019-09-30 23:59:55 +05:30
|
|
|
|
|
|
|
context 'when project is private' do
|
|
|
|
context 'and user does not have access' do
|
|
|
|
let(:noteable) { issue }
|
|
|
|
let(:target_project) { private_project }
|
|
|
|
|
|
|
|
before do
|
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'unsubscribes user and redirects to root path' do
|
|
|
|
expect(response).to redirect_to(root_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and user has access' do
|
|
|
|
let(:noteable) { issue }
|
|
|
|
let(:target_project) { private_project }
|
|
|
|
|
|
|
|
before do
|
|
|
|
private_project.add_developer(user)
|
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'unsubscribes user and redirects to issue path' do
|
|
|
|
expect(response).to redirect_to(project_issue_path(private_project, issue))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-03-13 15:44:24 +05:30
|
|
|
|
|
|
|
context 'when the noteable associated to the notification has been deleted' do
|
|
|
|
before do
|
|
|
|
sent_notification.noteable.destroy!
|
|
|
|
|
|
|
|
get(:unsubscribe, params: { id: sent_notification.reply_key })
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'returns 404'
|
|
|
|
end
|
2016-01-19 16:12:03 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|