2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe Projects::HooksController do
|
2021-06-08 01:23:25 +05:30
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
|
|
|
|
let(:user) { project.owner }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#index' do
|
2020-04-08 14:13:33 +05:30
|
|
|
it 'renders index with 200 status code' do
|
|
|
|
get :index, params: { namespace_id: project.namespace, project_id: project }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:index)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2021-06-08 01:23:25 +05:30
|
|
|
describe '#edit' do
|
|
|
|
let_it_be(:hook) { create(:project_hook, project: project) }
|
|
|
|
|
|
|
|
let(:params) do
|
|
|
|
{ namespace_id: project.namespace, project_id: project, id: hook.id }
|
|
|
|
end
|
|
|
|
|
|
|
|
render_views
|
|
|
|
|
|
|
|
it 'does not error if the hook cannot be found' do
|
|
|
|
get :edit, params: params.merge(id: non_existing_record_id)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'assigns hook_logs' do
|
|
|
|
get :edit, params: params
|
|
|
|
|
|
|
|
expect(assigns[:hook]).to be_present
|
|
|
|
expect(assigns[:hook_logs]).to be_empty
|
|
|
|
it_renders_correctly
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'handles when logs are present' do
|
|
|
|
create_list(:web_hook_log, 3, web_hook: hook)
|
|
|
|
|
|
|
|
get :edit, params: params
|
|
|
|
|
|
|
|
expect(assigns[:hook]).to be_present
|
|
|
|
expect(assigns[:hook_logs].count).to eq 3
|
|
|
|
it_renders_correctly
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can paginate logs' do
|
|
|
|
create_list(:web_hook_log, 21, web_hook: hook)
|
|
|
|
|
|
|
|
get :edit, params: params.merge(page: 2)
|
|
|
|
|
|
|
|
expect(assigns[:hook]).to be_present
|
|
|
|
expect(assigns[:hook_logs].count).to eq 1
|
|
|
|
it_renders_correctly
|
|
|
|
end
|
|
|
|
|
|
|
|
def it_renders_correctly
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:edit)
|
|
|
|
expect(response).to render_template('projects/hook_logs/_index')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
describe '#create' do
|
|
|
|
it 'sets all parameters' do
|
|
|
|
hook_params = {
|
|
|
|
enable_ssl_verification: true,
|
|
|
|
token: "TEST TOKEN",
|
|
|
|
url: "http://example.com",
|
|
|
|
|
|
|
|
push_events: true,
|
|
|
|
tag_push_events: true,
|
|
|
|
merge_requests_events: true,
|
|
|
|
issues_events: true,
|
2018-11-20 20:47:30 +05:30
|
|
|
confidential_note_events: true,
|
2018-03-17 18:26:18 +05:30
|
|
|
confidential_issues_events: true,
|
|
|
|
note_events: true,
|
|
|
|
job_events: true,
|
|
|
|
pipeline_events: true,
|
2020-10-24 23:57:45 +05:30
|
|
|
wiki_page_events: true,
|
|
|
|
deployment_events: true
|
2018-03-17 18:26:18 +05:30
|
|
|
}
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
post :create, params: { namespace_id: project.namespace, project_id: project, hook: hook_params }
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(ProjectHook.all.size).to eq(1)
|
|
|
|
expect(ProjectHook.first).to have_attributes(hook_params)
|
|
|
|
end
|
|
|
|
end
|
2020-09-03 11:15:55 +05:30
|
|
|
|
2021-01-03 14:25:43 +05:30
|
|
|
describe 'DELETE #destroy' do
|
|
|
|
let!(:hook) { create(:project_hook, project: project) }
|
|
|
|
let!(:log) { create(:web_hook_log, web_hook: hook) }
|
|
|
|
let(:params) { { namespace_id: project.namespace, project_id: project, id: hook } }
|
|
|
|
|
|
|
|
it_behaves_like 'Web hook destroyer'
|
|
|
|
end
|
|
|
|
|
2020-09-03 11:15:55 +05:30
|
|
|
describe '#test' do
|
|
|
|
let(:hook) { create(:project_hook, project: project) }
|
|
|
|
|
|
|
|
context 'when the endpoint receives requests above the limit' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab::ApplicationRateLimiter).to receive(:rate_limits)
|
|
|
|
.and_return(project_testing_hook: { threshold: 1, interval: 1.minute })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'prevents making test requests' do
|
|
|
|
expect_next_instance_of(TestHooks::ProjectService) do |service|
|
|
|
|
expect(service).to receive(:execute).and_return(http_status: 200)
|
|
|
|
end
|
|
|
|
|
|
|
|
2.times { post :test, params: { namespace_id: project.namespace, project_id: project, id: hook } }
|
|
|
|
|
|
|
|
expect(response.body).to eq(_('This endpoint has been requested too many times. Try again later.'))
|
|
|
|
expect(response).to have_gitlab_http_status(:too_many_requests)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|