2018-11-20 20:47:30 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
# This module takes care of updating cache columns for Markdown-containing
|
|
|
|
# fields. Use like this in the body of your class:
|
|
|
|
#
|
|
|
|
# include CacheMarkdownField
|
|
|
|
# cache_markdown_field :foo
|
|
|
|
# cache_markdown_field :bar
|
|
|
|
# cache_markdown_field :baz, pipeline: :single_line
|
2019-07-07 11:18:12 +05:30
|
|
|
# cache_markdown_field :baz, whitelisted: true
|
2016-11-03 12:29:30 +05:30
|
|
|
#
|
|
|
|
# Corresponding foo_html, bar_html and baz_html fields should exist.
|
|
|
|
module CacheMarkdownField
|
2017-08-17 22:00:37 +05:30
|
|
|
extend ActiveSupport::Concern
|
|
|
|
|
|
|
|
# changes to these attributes cause the cache to be invalidates
|
|
|
|
INVALIDATED_BY = %w[author project].freeze
|
|
|
|
|
|
|
|
def skip_project_check?
|
|
|
|
false
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def can_cache_field?(field)
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Returns the default Banzai render context for the cached markdown field.
|
|
|
|
def banzai_render_context(field)
|
2021-06-08 01:23:25 +05:30
|
|
|
raise ArgumentError, "Unknown field: #{field.inspect}" unless
|
2017-08-17 22:00:37 +05:30
|
|
|
cached_markdown_fields.markdown_fields.include?(field)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Always include a project key, or Banzai complains
|
|
|
|
project = self.project if self.respond_to?(:project)
|
2018-10-15 14:42:47 +05:30
|
|
|
group = self.group if self.respond_to?(:group)
|
2018-03-17 18:26:18 +05:30
|
|
|
context = cached_markdown_fields[field].merge(project: project, group: group)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
# Banzai is less strict about authors, so don't always have an author key
|
|
|
|
context[:author] = self.author if self.respond_to?(:author)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2019-03-02 22:35:43 +05:30
|
|
|
context[:markdown_engine] = :common_mark
|
2018-10-15 14:42:47 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
if Feature.enabled?(:personal_snippet_reference_filters, context[:author])
|
|
|
|
context[:user] = self.parent_user
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def rendered_field_content(markdown_field)
|
|
|
|
return unless can_cache_field?(markdown_field)
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
options = { skip_project_check: skip_project_check? }
|
2020-04-08 14:13:33 +05:30
|
|
|
Banzai::Renderer.cacheless_render_field(self, markdown_field, options)
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
# Update every applicable column in a row if any one is invalidated, as we only store
|
|
|
|
# one version per row
|
|
|
|
def refresh_markdown_cache
|
2021-04-29 21:17:54 +05:30
|
|
|
updates = cached_markdown_fields.markdown_fields.to_h do |markdown_field|
|
2017-08-17 22:00:37 +05:30
|
|
|
[
|
|
|
|
cached_markdown_fields.html_field(markdown_field),
|
2020-04-08 14:13:33 +05:30
|
|
|
rendered_field_content(markdown_field)
|
2017-08-17 22:00:37 +05:30
|
|
|
]
|
2021-04-29 21:17:54 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
updates['cached_markdown_version'] = latest_cached_markdown_version
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
updates.each { |field, data| write_markdown_field(field, data) }
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def refresh_markdown_cache!
|
|
|
|
updates = refresh_markdown_cache
|
2021-02-22 17:27:13 +05:30
|
|
|
if updates.present? && save_markdown(updates)
|
|
|
|
# save_markdown updates DB columns directly, so compute and save mentions
|
|
|
|
# by calling store_mentions! or we end-up with missing mentions although those
|
|
|
|
# would appear in the notes, descriptions, etc in the UI
|
|
|
|
store_mentions! if mentionable_attributes_changed?(updates)
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def cached_html_up_to_date?(markdown_field)
|
2019-09-04 21:01:54 +05:30
|
|
|
return false if cached_html_for(markdown_field).nil? && __send__(markdown_field).present? # rubocop:disable GitlabSecurity/PublicSend
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
html_field = cached_markdown_fields.html_field(markdown_field)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
markdown_changed = markdown_field_changed?(markdown_field)
|
|
|
|
html_changed = markdown_field_changed?(html_field)
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
latest_cached_markdown_version == cached_markdown_version &&
|
2017-08-17 22:00:37 +05:30
|
|
|
(html_changed || markdown_changed == html_changed)
|
|
|
|
end
|
|
|
|
|
|
|
|
def invalidated_markdown_cache?
|
|
|
|
cached_markdown_fields.html_fields.any? {|html_field| attribute_invalidated?(html_field) }
|
|
|
|
end
|
|
|
|
|
|
|
|
def attribute_invalidated?(attr)
|
2018-03-17 18:26:18 +05:30
|
|
|
__send__("#{attr}_invalidated?") # rubocop:disable GitlabSecurity/PublicSend
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def cached_html_for(markdown_field)
|
2021-06-08 01:23:25 +05:30
|
|
|
raise ArgumentError, "Unknown field: #{markdown_field}" unless
|
2017-08-17 22:00:37 +05:30
|
|
|
cached_markdown_fields.markdown_fields.include?(markdown_field)
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
__send__(cached_markdown_fields.html_field(markdown_field)) # rubocop:disable GitlabSecurity/PublicSend
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
2019-09-30 21:07:59 +05:30
|
|
|
# Updates the markdown cache if necessary, then returns the field
|
|
|
|
# Unlike `cached_html_for` it returns `nil` if the field does not exist
|
|
|
|
def updated_cached_html_for(markdown_field)
|
|
|
|
return unless cached_markdown_fields.markdown_fields.include?(markdown_field)
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
if attribute_invalidated?(cached_markdown_fields.html_field(markdown_field))
|
|
|
|
# Invalidated due to Markdown content change
|
|
|
|
# We should not persist the updated HTML here since this will depend on whether the
|
|
|
|
# Markdown content change will be persisted. Both will be persisted together when the model is saved.
|
|
|
|
if changed_attributes.key?(markdown_field)
|
|
|
|
refresh_markdown_cache
|
|
|
|
else
|
|
|
|
# Invalidated due to stale HTML cache
|
|
|
|
# This could happen when the Markdown cache version is bumped or when a model is imported and the HTML is empty.
|
|
|
|
# We persist the updated HTML here so that subsequent calls to this method do not have to regenerate the HTML again.
|
|
|
|
refresh_markdown_cache!
|
|
|
|
end
|
|
|
|
end
|
2019-09-30 21:07:59 +05:30
|
|
|
|
|
|
|
cached_html_for(markdown_field)
|
|
|
|
end
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
def latest_cached_markdown_version
|
2019-09-04 21:01:54 +05:30
|
|
|
@latest_cached_markdown_version ||= (Gitlab::MarkdownCache::CACHE_COMMONMARK_VERSION << 16) | local_version
|
2019-03-02 22:35:43 +05:30
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
|
2019-03-02 22:35:43 +05:30
|
|
|
def local_version
|
|
|
|
# because local_markdown_version is stored in application_settings which
|
|
|
|
# uses cached_markdown_version too, we check explicitly to avoid
|
|
|
|
# endless loop
|
2019-09-04 21:01:54 +05:30
|
|
|
return local_markdown_version if respond_to?(:has_attribute?) && has_attribute?(:local_markdown_version)
|
2019-03-02 22:35:43 +05:30
|
|
|
|
|
|
|
settings = Gitlab::CurrentSettings.current_application_settings
|
|
|
|
|
|
|
|
# Following migrations are not properly isolated and
|
|
|
|
# use real models (by calling .ghost method), in these migrations
|
|
|
|
# local_markdown_version attribute doesn't exist yet, so we
|
|
|
|
# use a default value:
|
|
|
|
# db/migrate/20170825104051_migrate_issues_to_ghost_user.rb
|
|
|
|
# db/migrate/20171114150259_merge_requests_author_id_foreign_key.rb
|
|
|
|
if settings.respond_to?(:local_markdown_version)
|
|
|
|
settings.local_markdown_version
|
2018-10-15 14:42:47 +05:30
|
|
|
else
|
2019-03-02 22:35:43 +05:30
|
|
|
0
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
def parent_user
|
|
|
|
nil
|
|
|
|
end
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
def store_mentions!
|
|
|
|
refs = all_references(self.author)
|
|
|
|
|
|
|
|
references = {}
|
|
|
|
references[:mentioned_users_ids] = refs.mentioned_users&.pluck(:id).presence
|
|
|
|
references[:mentioned_groups_ids] = refs.mentioned_groups&.pluck(:id).presence
|
|
|
|
references[:mentioned_projects_ids] = refs.mentioned_projects&.pluck(:id).presence
|
|
|
|
|
|
|
|
# One retry is enough as next time `model_user_mention` should return the existing mention record,
|
|
|
|
# that threw the `ActiveRecord::RecordNotUnique` exception in first place.
|
|
|
|
self.class.safe_ensure_unique(retries: 1) do
|
|
|
|
user_mention = model_user_mention
|
|
|
|
|
|
|
|
# this may happen due to notes polymorphism, so noteable_id may point to a record
|
|
|
|
# that no longer exists as we cannot have FK on noteable_id
|
|
|
|
break if user_mention.blank?
|
|
|
|
|
|
|
|
user_mention.mentioned_users_ids = references[:mentioned_users_ids]
|
|
|
|
user_mention.mentioned_groups_ids = references[:mentioned_groups_ids]
|
|
|
|
user_mention.mentioned_projects_ids = references[:mentioned_projects_ids]
|
|
|
|
|
|
|
|
if user_mention.has_mentions?
|
|
|
|
user_mention.save!
|
|
|
|
else
|
|
|
|
user_mention.destroy!
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
|
|
|
def mentionable_attributes_changed?(changes = saved_changes)
|
|
|
|
return false unless is_a?(Mentionable)
|
|
|
|
|
|
|
|
self.class.mentionable_attrs.any? do |attr|
|
|
|
|
changes.key?(cached_markdown_fields.html_field(attr.first)) &&
|
|
|
|
changes.fetch(cached_markdown_fields.html_field(attr.first)).last.present?
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
included do
|
|
|
|
cattr_reader :cached_markdown_fields do
|
2019-09-04 21:01:54 +05:30
|
|
|
Gitlab::MarkdownCache::FieldData.new
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
if self < ActiveRecord::Base
|
|
|
|
include Gitlab::MarkdownCache::ActiveRecord::Extension
|
|
|
|
else
|
|
|
|
prepend Gitlab::MarkdownCache::Redis::Extension
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class_methods do
|
|
|
|
private
|
|
|
|
|
|
|
|
# Specify that a field is markdown. Its rendered output will be cached in
|
|
|
|
# a corresponding _html field. Any custom rendering options may be provided
|
|
|
|
# as a context.
|
|
|
|
def cache_markdown_field(markdown_field, context = {})
|
|
|
|
cached_markdown_fields[markdown_field] = context
|
|
|
|
|
|
|
|
html_field = cached_markdown_fields.html_field(markdown_field)
|
|
|
|
invalidation_method = "#{html_field}_invalidated?".to_sym
|
|
|
|
|
|
|
|
# The HTML becomes invalid if any dependent fields change. For now, assume
|
|
|
|
# author and project invalidate the cache in all circumstances.
|
|
|
|
define_method(invalidation_method) do
|
2019-09-30 21:07:59 +05:30
|
|
|
changed_fields = changed_attributes.keys
|
|
|
|
invalidations = changed_fields & [markdown_field.to_s, *INVALIDATED_BY]
|
2017-08-17 22:00:37 +05:30
|
|
|
!invalidations.empty? || !cached_html_up_to_date?(markdown_field)
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|