debian-mirror-gitlab/spec/requests/api/applications_spec.rb

213 lines
8.6 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2018-03-17 18:26:18 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe API::Applications, :api do
2018-03-17 18:26:18 +05:30
let(:admin_user) { create(:user, admin: true) }
let(:user) { create(:user, admin: false) }
2021-10-29 20:43:33 +05:30
let(:scopes) { 'api' }
let!(:application) { create(:application, name: 'another_application', owner: nil, redirect_uri: 'http://other_application.url', scopes: scopes) }
2018-03-17 18:26:18 +05:30
describe 'POST /applications' do
context 'authenticated and authorized user' do
it 'creates and returns an OAuth application' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: scopes }
2018-03-17 18:26:18 +05:30
end.to change { Doorkeeper::Application.count }.by 1
application = Doorkeeper::Application.find_by(name: 'application_name', redirect_uri: 'http://application.url')
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2018-03-17 18:26:18 +05:30
expect(json_response).to be_a Hash
expect(json_response['application_id']).to eq application.uid
expect(json_response['secret']).to eq application.secret
expect(json_response['callback_url']).to eq application.redirect_uri
2020-03-13 15:44:24 +05:30
expect(json_response['confidential']).to eq application.confidential
2021-10-29 20:43:33 +05:30
expect(application.scopes.to_s).to eq('api')
2018-03-17 18:26:18 +05:30
end
it 'does not allow creating an application with the wrong redirect_uri format' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://', scopes: scopes }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2018-03-17 18:26:18 +05:30
expect(json_response).to be_a Hash
2021-03-11 19:13:27 +05:30
expect(json_response['message']['redirect_uri'][0]).to eq('must be a valid URI.')
2018-03-17 18:26:18 +05:30
end
2018-11-29 20:51:05 +05:30
it 'does not allow creating an application with a forbidden URI format' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'javascript://alert()', scopes: scopes }
2018-11-29 20:51:05 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2018-11-29 20:51:05 +05:30
expect(json_response).to be_a Hash
expect(json_response['message']['redirect_uri'][0]).to eq('is forbidden by the server.')
end
2018-03-17 18:26:18 +05:30
it 'does not allow creating an application without a name' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { redirect_uri: 'http://application.url', scopes: scopes }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2018-03-17 18:26:18 +05:30
expect(json_response).to be_a Hash
expect(json_response['error']).to eq('name is missing')
end
it 'does not allow creating an application without a redirect_uri' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { name: 'application_name', scopes: scopes }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2018-03-17 18:26:18 +05:30
expect(json_response).to be_a Hash
expect(json_response['error']).to eq('redirect_uri is missing')
end
2021-10-29 20:43:33 +05:30
it 'does not allow creating an application without specifying `scopes`' do
2018-03-17 18:26:18 +05:30
expect do
2019-02-15 15:39:39 +05:30
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url' }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2018-03-17 18:26:18 +05:30
expect(json_response).to be_a Hash
2021-10-29 20:43:33 +05:30
expect(json_response['error']).to eq('scopes is missing, scopes is empty')
end
it 'does not allow creating an application with blank `scopes`' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: '' }
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['error']).to eq('scopes is empty')
end
it 'does not allow creating an application with invalid `scopes`' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: 'non_existent_scope' }
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['message']['scopes'][0]).to eq('doesn\'t match configured on the server.')
end
context 'multiple scopes' do
it 'creates an application with multiple `scopes` when each scope specified is seperated by a space' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: 'api read_user' }
end.to change { Doorkeeper::Application.count }.by 1
application = Doorkeeper::Application.last
expect(response).to have_gitlab_http_status(:created)
expect(application.scopes.to_s).to eq('api read_user')
end
it 'does not allow creating an application with multiple `scopes` when one of the scopes is invalid' do
expect do
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: 'api non_existent_scope' }
end.not_to change { Doorkeeper::Application.count }
expect(response).to have_gitlab_http_status(:bad_request)
expect(json_response['message']['scopes'][0]).to eq('doesn\'t match configured on the server.')
end
2018-03-17 18:26:18 +05:30
end
2020-03-13 15:44:24 +05:30
2020-07-28 23:09:34 +05:30
it 'defaults to creating an application with confidential' do
2020-03-13 15:44:24 +05:30
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', admin_user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: scopes, confidential: nil }
2020-07-28 23:09:34 +05:30
end.to change { Doorkeeper::Application.count }.by(1)
2020-03-13 15:44:24 +05:30
2020-07-28 23:09:34 +05:30
expect(response).to have_gitlab_http_status(:created)
2020-03-13 15:44:24 +05:30
expect(json_response).to be_a Hash
2020-07-28 23:09:34 +05:30
expect(json_response['callback_url']).to eq('http://application.url')
expect(json_response['confidential']).to be true
2020-03-13 15:44:24 +05:30
end
2018-03-17 18:26:18 +05:30
end
context 'authorized user without authorization' do
it 'does not create application' do
expect do
2021-10-29 20:43:33 +05:30
post api('/applications', user), params: { name: 'application_name', redirect_uri: 'http://application.url', scopes: scopes }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2018-03-17 18:26:18 +05:30
end
end
context 'non-authenticated user' do
it 'does not create application' do
expect do
2019-02-15 15:39:39 +05:30
post api('/applications'), params: { name: 'application_name', redirect_uri: 'http://application.url' }
2018-03-17 18:26:18 +05:30
end.not_to change { Doorkeeper::Application.count }
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2018-12-13 13:39:08 +05:30
end
end
end
describe 'GET /applications' do
context 'authenticated and authorized user' do
it 'can list application' do
get api('/applications', admin_user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-12-13 13:39:08 +05:30
expect(json_response).to be_a(Array)
end
end
context 'authorized user without authorization' do
it 'cannot list application' do
get api('/applications', user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2018-12-13 13:39:08 +05:30
end
end
context 'non-authenticated user' do
it 'cannot list application' do
get api('/applications')
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2018-12-13 13:39:08 +05:30
end
end
end
describe 'DELETE /applications/:id' do
context 'authenticated and authorized user' do
it 'can delete an application' do
expect do
delete api("/applications/#{application.id}", admin_user)
end.to change { Doorkeeper::Application.count }.by(-1)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:no_content)
2018-12-13 13:39:08 +05:30
end
2021-04-29 21:17:54 +05:30
it 'cannot delete non-existing application' do
delete api("/applications/#{non_existing_record_id}", admin_user)
expect(response).to have_gitlab_http_status(:not_found)
end
2018-12-13 13:39:08 +05:30
end
context 'authorized user without authorization' do
it 'cannot delete an application' do
delete api("/applications/#{application.id}", user)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2018-12-13 13:39:08 +05:30
end
end
context 'non-authenticated user' do
it 'cannot delete an application' do
delete api("/applications/#{application.id}")
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2018-03-17 18:26:18 +05:30
end
end
end
end