2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-09-25 12:07:36 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe "Admin Runners" do
|
2017-08-17 22:00:37 +05:30
|
|
|
include StubENV
|
2018-12-05 23:21:45 +05:30
|
|
|
include FilteredSearchHelpers
|
|
|
|
include SortingHelper
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2015-09-25 12:07:36 +05:30
|
|
|
before do
|
2017-08-17 22:00:37 +05:30
|
|
|
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
|
2017-09-10 17:25:29 +05:30
|
|
|
sign_in(create(:admin))
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "Runners page" do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:pipeline) { create(:ci_pipeline) }
|
|
|
|
|
|
|
|
context "when there are runners" do
|
2018-12-05 23:21:45 +05:30
|
|
|
it 'has all necessary texts' do
|
|
|
|
runner = create(:ci_runner, contacted_at: Time.now)
|
|
|
|
create(:ci_build, pipeline: pipeline, runner_id: runner.id)
|
2017-09-10 17:25:29 +05:30
|
|
|
visit admin_runners_path
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_text "Set up a shared Runner manually"
|
2018-11-20 20:47:30 +05:30
|
|
|
expect(page).to have_text "Runners currently online: 1"
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
describe 'search', :js do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
2018-12-05 23:21:45 +05:30
|
|
|
create(:ci_runner, description: 'runner-foo')
|
|
|
|
create(:ci_runner, description: 'runner-bar')
|
|
|
|
|
|
|
|
visit admin_runners_path
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows correct runner when description matches' do
|
2018-12-05 23:21:45 +05:30
|
|
|
input_filtered_search_keys('runner-foo')
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(page).to have_content("runner-foo")
|
|
|
|
expect(page).not_to have_content("runner-bar")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows no runner when description does not match' do
|
2018-12-05 23:21:45 +05:30
|
|
|
input_filtered_search_keys('runner-baz')
|
|
|
|
|
|
|
|
expect(page).to have_text 'No runners found'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'filter by status', :js do
|
|
|
|
it 'shows correct runner when status matches' do
|
|
|
|
create(:ci_runner, description: 'runner-active', active: true)
|
|
|
|
create(:ci_runner, description: 'runner-paused', active: false)
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
expect(page).to have_content 'runner-active'
|
|
|
|
expect(page).to have_content 'runner-paused'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('status:=active')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-active'
|
|
|
|
expect(page).not_to have_content 'runner-paused'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows no runner when status does not match' do
|
|
|
|
create(:ci_runner, :online, description: 'runner-active', active: true)
|
|
|
|
create(:ci_runner, :online, description: 'runner-paused', active: false)
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('status:=offline')
|
2018-12-05 23:21:45 +05:30
|
|
|
|
|
|
|
expect(page).not_to have_content 'runner-active'
|
|
|
|
expect(page).not_to have_content 'runner-paused'
|
|
|
|
|
|
|
|
expect(page).to have_text 'No runners found'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows correct runner when status is selected and search term is entered' do
|
|
|
|
create(:ci_runner, description: 'runner-a-1', active: true)
|
|
|
|
create(:ci_runner, description: 'runner-a-2', active: false)
|
|
|
|
create(:ci_runner, description: 'runner-b-1', active: true)
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('status:=active')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('status:=active runner-a')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).not_to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'filter by type', :js do
|
|
|
|
it 'shows correct runner when type matches' do
|
|
|
|
create :ci_runner, :project, description: 'runner-project'
|
|
|
|
create :ci_runner, :group, description: 'runner-group'
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
expect(page).to have_content 'runner-project'
|
|
|
|
expect(page).to have_content 'runner-group'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('type:=project_type')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-project'
|
|
|
|
expect(page).not_to have_content 'runner-group'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows no runner when type does not match' do
|
|
|
|
create :ci_runner, :project, description: 'runner-project'
|
|
|
|
create :ci_runner, :group, description: 'runner-group'
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('type:=instance_type')
|
2018-12-05 23:21:45 +05:30
|
|
|
|
|
|
|
expect(page).not_to have_content 'runner-project'
|
|
|
|
expect(page).not_to have_content 'runner-group'
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
expect(page).to have_text 'No runners found'
|
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
|
|
|
|
it 'shows correct runner when type is selected and search term is entered' do
|
|
|
|
create :ci_runner, :project, description: 'runner-a-1'
|
|
|
|
create :ci_runner, :instance, description: 'runner-a-2'
|
|
|
|
create :ci_runner, :project, description: 'runner-b-1'
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('type:=project_type')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('type:=project_type runner-a')
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).not_to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
describe 'filter by tag', :js do
|
|
|
|
it 'shows correct runner when tag matches' do
|
|
|
|
create :ci_runner, description: 'runner-blue', tag_list: ['blue']
|
|
|
|
create :ci_runner, description: 'runner-red', tag_list: ['red']
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
expect(page).to have_content 'runner-blue'
|
|
|
|
expect(page).to have_content 'runner-red'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('tag:=blue')
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
expect(page).to have_content 'runner-blue'
|
|
|
|
expect(page).not_to have_content 'runner-red'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows no runner when tag does not match' do
|
|
|
|
create :ci_runner, description: 'runner-blue', tag_list: ['blue']
|
|
|
|
create :ci_runner, description: 'runner-red', tag_list: ['blue']
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('tag:=red')
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
expect(page).not_to have_content 'runner-blue'
|
|
|
|
expect(page).not_to have_content 'runner-blue'
|
|
|
|
expect(page).to have_text 'No runners found'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'shows correct runner when tag is selected and search term is entered' do
|
|
|
|
create :ci_runner, description: 'runner-a-1', tag_list: ['blue']
|
|
|
|
create :ci_runner, description: 'runner-a-2', tag_list: ['red']
|
|
|
|
create :ci_runner, description: 'runner-b-1', tag_list: ['blue']
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('tag:=blue')
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
input_filtered_search_keys('tag:=blue runner-a')
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
expect(page).to have_content 'runner-a-1'
|
|
|
|
expect(page).not_to have_content 'runner-b-1'
|
|
|
|
expect(page).not_to have_content 'runner-a-2'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
it 'sorts by last contact date', :js do
|
|
|
|
create(:ci_runner, description: 'runner-1', created_at: '2018-07-12 15:37', contacted_at: '2018-07-12 15:37')
|
|
|
|
create(:ci_runner, description: 'runner-2', created_at: '2018-07-12 16:37', contacted_at: '2018-07-12 16:37')
|
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
within '.runners-content .gl-responsive-table-row:nth-child(2)' do
|
|
|
|
expect(page).to have_content 'runner-2'
|
|
|
|
end
|
|
|
|
|
|
|
|
within '.runners-content .gl-responsive-table-row:nth-child(3)' do
|
|
|
|
expect(page).to have_content 'runner-1'
|
|
|
|
end
|
|
|
|
|
|
|
|
sorting_by 'Last Contact'
|
|
|
|
|
|
|
|
within '.runners-content .gl-responsive-table-row:nth-child(2)' do
|
|
|
|
expect(page).to have_content 'runner-1'
|
|
|
|
end
|
|
|
|
|
|
|
|
within '.runners-content .gl-responsive-table-row:nth-child(3)' do
|
|
|
|
expect(page).to have_content 'runner-2'
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
context "when there are no runners" do
|
2015-09-25 12:07:36 +05:30
|
|
|
before do
|
2017-09-10 17:25:29 +05:30
|
|
|
visit admin_runners_path
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'has all necessary texts including no runner message' do
|
2018-12-05 23:21:45 +05:30
|
|
|
expect(page).to have_text "Set up a shared Runner manually"
|
2018-11-20 20:47:30 +05:30
|
|
|
expect(page).to have_text "Runners currently online: 0"
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(page).to have_text 'No runners found'
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
context 'group runner' do
|
|
|
|
let(:group) { create(:group) }
|
2018-11-08 19:23:39 +05:30
|
|
|
let!(:runner) { create(:ci_runner, :group, groups: [group]) }
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
it 'shows the label and does not show the project count' do
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
within "#runner_#{runner.id}" do
|
2018-11-08 19:23:39 +05:30
|
|
|
expect(page).to have_selector '.badge', text: 'group'
|
2018-10-15 14:42:47 +05:30
|
|
|
expect(page).to have_text 'n/a'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'shared runner' do
|
|
|
|
it 'shows the label and does not show the project count' do
|
2018-12-05 23:21:45 +05:30
|
|
|
runner = create(:ci_runner, :instance)
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
within "#runner_#{runner.id}" do
|
2018-11-08 19:23:39 +05:30
|
|
|
expect(page).to have_selector '.badge', text: 'shared'
|
2018-10-15 14:42:47 +05:30
|
|
|
expect(page).to have_text 'n/a'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'specific runner' do
|
|
|
|
it 'shows the label and the project count' do
|
2018-12-05 23:21:45 +05:30
|
|
|
project = create(:project)
|
|
|
|
runner = create(:ci_runner, :project, projects: [project])
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
visit admin_runners_path
|
|
|
|
|
|
|
|
within "#runner_#{runner.id}" do
|
2018-11-08 19:23:39 +05:30
|
|
|
expect(page).to have_selector '.badge', text: 'specific'
|
2018-10-15 14:42:47 +05:30
|
|
|
expect(page).to have_text '1'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "Runner show page" do
|
2018-12-05 23:21:45 +05:30
|
|
|
let(:runner) { create(:ci_runner) }
|
2015-09-25 12:07:36 +05:30
|
|
|
|
|
|
|
before do
|
2018-12-05 23:21:45 +05:30
|
|
|
@project1 = create(:project)
|
|
|
|
@project2 = create(:project)
|
2015-12-23 02:04:40 +05:30
|
|
|
visit admin_runner_path(runner)
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'projects' do
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'contains project names' do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(page).to have_content(@project1.full_name)
|
|
|
|
expect(page).to have_content(@project2.full_name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'search' do
|
|
|
|
before do
|
|
|
|
search_form = find('#runner-projects-search')
|
2015-12-23 02:04:40 +05:30
|
|
|
search_form.fill_in 'search', with: @project1.name
|
2015-09-25 12:07:36 +05:30
|
|
|
search_form.click_button 'Search'
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'contains name of correct project' do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(page).to have_content(@project1.full_name)
|
|
|
|
expect(page).not_to have_content(@project2.full_name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
|
|
|
describe 'enable/create' do
|
2016-08-24 12:49:21 +05:30
|
|
|
shared_examples 'assignable runner' do
|
|
|
|
it 'enables a runner for a project' do
|
|
|
|
within '.unassigned-projects' do
|
|
|
|
click_on 'Enable'
|
|
|
|
end
|
|
|
|
|
|
|
|
assigned_project = page.find('.assigned-projects')
|
|
|
|
|
|
|
|
expect(assigned_project).to have_content(@project2.path)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'with specific runner' do
|
2018-11-08 19:23:39 +05:30
|
|
|
let(:runner) { create(:ci_runner, :project, projects: [@project1]) }
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
before do
|
|
|
|
visit admin_runner_path(runner)
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
it_behaves_like 'assignable runner'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with locked runner' do
|
2018-11-08 19:23:39 +05:30
|
|
|
let(:runner) { create(:ci_runner, :project, projects: [@project1], locked: true) }
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
before do
|
|
|
|
visit admin_runner_path(runner)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'assignable runner'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with shared runner' do
|
2018-11-08 19:23:39 +05:30
|
|
|
let(:runner) { create(:ci_runner, :instance) }
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
before do
|
|
|
|
@project1.destroy
|
|
|
|
visit admin_runner_path(runner)
|
|
|
|
end
|
2016-06-22 15:30:34 +05:30
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
it_behaves_like 'assignable runner'
|
2016-06-22 15:30:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'disable/destroy' do
|
2018-11-08 19:23:39 +05:30
|
|
|
let(:runner) { create(:ci_runner, :project, projects: [@project1]) }
|
|
|
|
|
2016-06-22 15:30:34 +05:30
|
|
|
before do
|
|
|
|
visit admin_runner_path(runner)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'enables specific runner for project' do
|
|
|
|
within '.assigned-projects' do
|
|
|
|
click_on 'Disable'
|
|
|
|
end
|
|
|
|
|
|
|
|
new_runner_project = page.find('.unassigned-projects')
|
|
|
|
|
|
|
|
expect(new_runner_project).to have_content(@project1.path)
|
|
|
|
end
|
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
describe 'runners registration token' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let!(:token) { Gitlab::CurrentSettings.runners_registration_token }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
visit admin_runners_path
|
|
|
|
end
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
it 'has a registration token' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(page.find('#registration_token')).to have_content(token)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'reload registration token' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:page_token) { find('#registration_token').text }
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
click_button 'Reset runners registration token'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'changes registration token' do
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(page_token).not_to eq token
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-09-25 12:07:36 +05:30
|
|
|
end
|