2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe 'Admin::Hooks' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:user) { create(:admin) }
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
|
|
|
sign_in(user)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
describe 'GET /admin/hooks' do
|
|
|
|
it 'is ok' do
|
2014-09-02 18:07:02 +05:30
|
|
|
visit admin_root_path
|
2016-06-16 23:09:34 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
page.within '.nav-sidebar' do
|
|
|
|
click_on 'System Hooks', match: :first
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2016-06-16 23:09:34 +05:30
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'has hooks list' do
|
2018-03-17 18:26:18 +05:30
|
|
|
system_hook = create(:system_hook)
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
visit admin_hooks_path
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(page).to have_content(system_hook.url)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2018-03-27 19:54:05 +05:30
|
|
|
|
|
|
|
it 'renders plugins list as well' do
|
2020-03-13 15:44:24 +05:30
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['foo.rb', 'bar.clj'])
|
2018-03-27 19:54:05 +05:30
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(page).to have_content('File Hooks')
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(page).to have_content('foo.rb')
|
|
|
|
expect(page).to have_content('bar.clj')
|
|
|
|
end
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'deprecation warning' do
|
|
|
|
it 'shows warning for plugins directory' do
|
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['plugins/foo.rb'])
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
expect(page).to have_content('Plugins directory is deprecated and will be removed in 14.0')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show warning for file_hooks directory' do
|
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['file_hooks/foo.rb'])
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
expect(page).not_to have_content('Plugins directory is deprecated and will be removed in 14.0')
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
describe 'New Hook' do
|
|
|
|
let(:url) { generate(:url) }
|
|
|
|
|
|
|
|
it 'adds new hook' do
|
2014-09-02 18:07:02 +05:30
|
|
|
visit admin_hooks_path
|
2017-08-17 22:00:37 +05:30
|
|
|
fill_in 'hook_url', with: url
|
|
|
|
check 'Enable SSL verification'
|
|
|
|
|
|
|
|
expect { click_button 'Add system hook' }.to change(SystemHook, :count).by(1)
|
|
|
|
expect(page).to have_content 'SSL Verification: enabled'
|
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
|
|
|
expect(page).to have_content(url)
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Update existing hook' do
|
|
|
|
let(:new_url) { generate(:url) }
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
|
|
|
create(:system_hook)
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'updates existing hook' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
click_link 'Edit'
|
|
|
|
fill_in 'hook_url', with: new_url
|
|
|
|
check 'Enable SSL verification'
|
|
|
|
click_button 'Save changes'
|
2014-09-02 18:07:02 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).to have_content 'SSL Verification: enabled'
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(page).to have_content(new_url)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
describe 'Remove existing hook', :js do
|
2019-07-31 22:56:46 +05:30
|
|
|
let(:hook_url) { generate(:url) }
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
before do
|
2019-07-31 22:56:46 +05:30
|
|
|
create(:system_hook, url: hook_url)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
context 'removes existing hook' do
|
|
|
|
it 'from hooks list page' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
accept_confirm { click_link 'Delete' }
|
2019-07-31 22:56:46 +05:30
|
|
|
expect(page).not_to have_content(hook_url)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
it 'from hook edit page' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
click_link 'Edit'
|
|
|
|
|
2020-01-01 13:55:28 +05:30
|
|
|
accept_confirm { click_link 'Delete' }
|
2019-07-31 22:56:46 +05:30
|
|
|
expect(page).not_to have_content(hook_url)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
describe 'Test', :js do
|
2014-09-02 18:07:02 +05:30
|
|
|
before do
|
2018-03-17 18:26:18 +05:30
|
|
|
system_hook = create(:system_hook)
|
|
|
|
WebMock.stub_request(:post, system_hook.url)
|
2014-09-02 18:07:02 +05:30
|
|
|
visit admin_hooks_path
|
2017-09-10 17:25:29 +05:30
|
|
|
|
|
|
|
find('.hook-test-button.dropdown').click
|
|
|
|
click_link 'Push events'
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
it { expect(current_path).to eq(admin_hooks_path) }
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context 'Merge request hook' do
|
|
|
|
describe 'New Hook' do
|
|
|
|
let(:url) { generate(:url) }
|
|
|
|
|
|
|
|
it 'adds new hook' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
fill_in 'hook_url', with: url
|
|
|
|
uncheck 'Repository update events'
|
|
|
|
check 'Merge request events'
|
|
|
|
|
|
|
|
expect { click_button 'Add system hook' }.to change(SystemHook, :count).by(1)
|
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
|
|
|
expect(page).to have_content(url)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Test', :js do
|
|
|
|
before do
|
|
|
|
system_hook = create(:system_hook)
|
|
|
|
WebMock.stub_request(:post, system_hook.url)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'succeeds if the user has a repository with a merge request' do
|
|
|
|
project = create(:project, :repository)
|
|
|
|
create(:project_member, user: user, project: project)
|
|
|
|
create(:merge_request, source_project: project)
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
find('.hook-test-button.dropdown').click
|
|
|
|
click_link 'Merge requests events'
|
|
|
|
|
|
|
|
expect(page).to have_content 'Hook executed successfully'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|