debian-mirror-gitlab/spec/services/ci/create_pipeline_service/rules_spec.rb

392 lines
12 KiB
Ruby
Raw Normal View History

2019-12-21 20:55:43 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Ci::CreatePipelineService do
2021-01-29 00:20:46 +05:30
let(:project) { create(:project, :repository) }
let(:user) { project.owner }
2019-12-26 22:10:19 +05:30
let(:ref) { 'refs/heads/master' }
let(:source) { :push }
let(:service) { described_class.new(project, user, { ref: ref }) }
let(:pipeline) { service.execute(source) }
let(:build_names) { pipeline.builds.pluck(:name) }
2019-12-21 20:55:43 +05:30
2019-12-26 22:10:19 +05:30
context 'job:rules' do
2019-12-21 20:55:43 +05:30
before do
stub_ci_pipeline_yaml_file(config)
2020-01-01 13:55:28 +05:30
allow_next_instance_of(Ci::BuildScheduleWorker) do |instance|
allow(instance).to receive(:perform).and_return(true)
end
2019-12-21 20:55:43 +05:30
end
context 'exists:' do
let(:config) do
<<-EOY
regular-job:
script: 'echo Hello, World!'
rules-job:
script: "echo hello world, $CI_COMMIT_REF_NAME"
rules:
- exists:
- README.md
when: manual
- exists:
- app.rb
when: on_success
delayed-job:
script: "echo See you later, World!"
rules:
- exists:
- README.md
when: delayed
start_in: 4 hours
EOY
end
2019-12-26 22:10:19 +05:30
2019-12-21 20:55:43 +05:30
let(:regular_job) { pipeline.builds.find_by(name: 'regular-job') }
let(:rules_job) { pipeline.builds.find_by(name: 'rules-job') }
let(:delayed_job) { pipeline.builds.find_by(name: 'delayed-job') }
context 'with matches' do
let(:project) { create(:project, :custom_repo, files: { 'README.md' => '' }) }
it 'creates two jobs' do
expect(pipeline).to be_persisted
expect(build_names).to contain_exactly('regular-job', 'rules-job', 'delayed-job')
end
it 'sets when: for all jobs' do
expect(regular_job.when).to eq('on_success')
expect(rules_job.when).to eq('manual')
expect(delayed_job.when).to eq('delayed')
expect(delayed_job.options[:start_in]).to eq('4 hours')
end
end
context 'with matches on the second rule' do
let(:project) { create(:project, :custom_repo, files: { 'app.rb' => '' }) }
it 'includes both jobs' do
expect(pipeline).to be_persisted
expect(build_names).to contain_exactly('regular-job', 'rules-job')
end
it 'sets when: for the created rules job based on the second clause' do
expect(regular_job.when).to eq('on_success')
expect(rules_job.when).to eq('on_success')
end
end
context 'without matches' do
let(:project) { create(:project, :custom_repo, files: { 'useless_script.rb' => '' }) }
it 'only persists the job without rules' do
expect(pipeline).to be_persisted
expect(regular_job).to be_persisted
expect(rules_job).to be_nil
expect(delayed_job).to be_nil
end
it 'sets when: for the created job' do
expect(regular_job.when).to eq('on_success')
end
end
end
2021-02-22 17:27:13 +05:30
context 'with allow_failure and exit_codes', :aggregate_failures do
def find_job(name)
pipeline.builds.find_by(name: name)
end
let(:config) do
<<-EOY
job-1:
script: exit 42
allow_failure:
exit_codes: 42
rules:
- if: $CI_COMMIT_REF_NAME == "master"
allow_failure: false
job-2:
script: exit 42
allow_failure:
exit_codes: 42
rules:
- if: $CI_COMMIT_REF_NAME == "master"
allow_failure: true
job-3:
script: exit 42
allow_failure:
exit_codes: 42
rules:
- if: $CI_COMMIT_REF_NAME == "master"
when: manual
EOY
end
it 'creates a pipeline' do
expect(pipeline).to be_persisted
expect(build_names).to contain_exactly(
'job-1', 'job-2', 'job-3'
)
end
it 'assigns job:allow_failure values to the builds' do
expect(find_job('job-1').allow_failure).to eq(false)
expect(find_job('job-2').allow_failure).to eq(true)
expect(find_job('job-3').allow_failure).to eq(false)
end
it 'removes exit_codes if allow_failure is specified' do
expect(find_job('job-1').options.dig(:allow_failure_criteria)).to be_nil
expect(find_job('job-2').options.dig(:allow_failure_criteria)).to be_nil
expect(find_job('job-3').options.dig(:allow_failure_criteria, :exit_codes)).to eq([42])
end
end
context 'if:' do
context 'variables:' do
let(:config) do
<<-EOY
job:
script: "echo job1"
variables:
VAR1: my var 1
VAR2: my var 2
rules:
- if: $CI_COMMIT_REF_NAME =~ /master/
variables:
VAR1: overridden var 1
- if: $CI_COMMIT_REF_NAME =~ /feature/
variables:
VAR2: overridden var 2
VAR3: new var 3
- when: on_success
EOY
end
let(:job) { pipeline.builds.find_by(name: 'job') }
context 'when matching to the first rule' do
let(:ref) { 'refs/heads/master' }
it 'overrides VAR1' do
variables = job.scoped_variables_hash
expect(variables['VAR1']).to eq('overridden var 1')
expect(variables['VAR2']).to eq('my var 2')
expect(variables['VAR3']).to be_nil
end
context 'when FF ci_rules_variables is disabled' do
before do
stub_feature_flags(ci_rules_variables: false)
end
it 'does not affect variables' do
variables = job.scoped_variables_hash
expect(variables['VAR1']).to eq('my var 1')
expect(variables['VAR2']).to eq('my var 2')
expect(variables['VAR3']).to be_nil
end
end
end
context 'when matching to the second rule' do
let(:ref) { 'refs/heads/feature' }
it 'overrides VAR2 and adds VAR3' do
variables = job.scoped_variables_hash
expect(variables['VAR1']).to eq('my var 1')
expect(variables['VAR2']).to eq('overridden var 2')
expect(variables['VAR3']).to eq('new var 3')
end
end
context 'when no match' do
let(:ref) { 'refs/heads/wip' }
it 'does not affect vars' do
variables = job.scoped_variables_hash
expect(variables['VAR1']).to eq('my var 1')
expect(variables['VAR2']).to eq('my var 2')
expect(variables['VAR3']).to be_nil
end
end
end
end
2019-12-21 20:55:43 +05:30
end
2019-12-26 22:10:19 +05:30
context 'when workflow:rules are used' do
before do
stub_ci_pipeline_yaml_file(config)
end
context 'with a single regex-matching if: clause' do
let(:config) do
<<-EOY
workflow:
rules:
- if: $CI_COMMIT_REF_NAME =~ /master/
- if: $CI_COMMIT_REF_NAME =~ /wip$/
when: never
- if: $CI_COMMIT_REF_NAME =~ /feature/
regular-job:
script: 'echo Hello, World!'
EOY
end
context 'matching the first rule in the list' do
2020-01-01 13:55:28 +05:30
it 'saves a pending pipeline' do
2019-12-26 22:10:19 +05:30
expect(pipeline).to be_pending
2020-01-01 13:55:28 +05:30
expect(pipeline).to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'matching the last rule in the list' do
let(:ref) { 'refs/heads/feature' }
2020-01-01 13:55:28 +05:30
it 'saves a pending pipeline' do
2019-12-26 22:10:19 +05:30
expect(pipeline).to be_pending
2020-01-01 13:55:28 +05:30
expect(pipeline).to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'matching the when:never rule' do
let(:ref) { 'refs/heads/wip' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with a workflow rules error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('Pipeline filtered out by workflow rules.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'matching no rules in the list' do
let(:ref) { 'refs/heads/fix' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with a workflow rules error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('Pipeline filtered out by workflow rules.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
end
context 'when root variables are used' do
let(:config) do
<<-EOY
variables:
VARIABLE: value
workflow:
rules:
- if: $VARIABLE
regular-job:
script: 'echo Hello, World!'
EOY
end
context 'matching the first rule in the list' do
2020-01-01 13:55:28 +05:30
it 'saves a pending pipeline' do
2019-12-26 22:10:19 +05:30
expect(pipeline).to be_pending
2020-01-01 13:55:28 +05:30
expect(pipeline).to be_persisted
2019-12-26 22:10:19 +05:30
end
end
end
context 'with a multiple regex-matching if: clause' do
let(:config) do
<<-EOY
workflow:
rules:
- if: $CI_COMMIT_REF_NAME =~ /master/
- if: $CI_COMMIT_REF_NAME =~ /^feature/ && $CI_COMMIT_REF_NAME =~ /conflict$/
when: never
- if: $CI_COMMIT_REF_NAME =~ /feature/
regular-job:
script: 'echo Hello, World!'
EOY
end
context 'with partial match' do
let(:ref) { 'refs/heads/feature' }
2020-01-01 13:55:28 +05:30
it 'saves a pending pipeline' do
2019-12-26 22:10:19 +05:30
expect(pipeline).to be_pending
2020-01-01 13:55:28 +05:30
expect(pipeline).to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'with complete match' do
let(:ref) { 'refs/heads/feature_conflict' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with a workflow rules error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('Pipeline filtered out by workflow rules.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
end
context 'with job rules' do
let(:config) do
<<-EOY
workflow:
rules:
- if: $CI_COMMIT_REF_NAME =~ /master/
- if: $CI_COMMIT_REF_NAME =~ /feature/
regular-job:
script: 'echo Hello, World!'
rules:
- if: $CI_COMMIT_REF_NAME =~ /wip/
- if: $CI_COMMIT_REF_NAME =~ /feature/
EOY
end
context 'where workflow passes and the job fails' do
let(:ref) { 'refs/heads/master' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with an empty jobs error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('No stages / jobs for this pipeline.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'where workflow passes and the job passes' do
let(:ref) { 'refs/heads/feature' }
2020-01-01 13:55:28 +05:30
it 'saves a pending pipeline' do
2019-12-26 22:10:19 +05:30
expect(pipeline).to be_pending
2020-01-01 13:55:28 +05:30
expect(pipeline).to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'where workflow fails and the job fails' do
let(:ref) { 'refs/heads/fix' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with a workflow rules error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('Pipeline filtered out by workflow rules.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
context 'where workflow fails and the job passes' do
let(:ref) { 'refs/heads/wip' }
2020-01-01 13:55:28 +05:30
it 'invalidates the pipeline with a workflow rules error' do
2019-12-26 22:10:19 +05:30
expect(pipeline.errors[:base]).to include('Pipeline filtered out by workflow rules.')
2020-01-01 13:55:28 +05:30
expect(pipeline).not_to be_persisted
2019-12-26 22:10:19 +05:30
end
end
end
end
2019-12-21 20:55:43 +05:30
end