2019-07-07 11:18:12 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
describe RedmineService do
|
2016-06-02 11:05:42 +05:30
|
|
|
describe 'Associations' do
|
|
|
|
it { is_expected.to belong_to :project }
|
|
|
|
it { is_expected.to have_one :service_hook }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Validations' do
|
2019-12-04 20:38:33 +05:30
|
|
|
# if redmine is set in setting the urls are set to defaults
|
|
|
|
# therefore the validation passes as the values are not nil
|
|
|
|
before do
|
|
|
|
settings = {
|
|
|
|
'redmine' => {}
|
|
|
|
}
|
|
|
|
allow(Gitlab.config).to receive(:issues_tracker).and_return(settings)
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
context 'when service is active' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
subject.active = true
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
it { is_expected.to validate_presence_of(:project_url) }
|
|
|
|
it { is_expected.to validate_presence_of(:issues_url) }
|
|
|
|
it { is_expected.to validate_presence_of(:new_issue_url) }
|
2019-12-04 20:38:33 +05:30
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
it_behaves_like 'issue tracker service URL attribute', :project_url
|
|
|
|
it_behaves_like 'issue tracker service URL attribute', :issues_url
|
|
|
|
it_behaves_like 'issue tracker service URL attribute', :new_issue_url
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when service is inactive' do
|
2017-09-10 17:25:29 +05:30
|
|
|
before do
|
|
|
|
subject.active = false
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
|
|
|
it { is_expected.not_to validate_presence_of(:project_url) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:issues_url) }
|
|
|
|
it { is_expected.not_to validate_presence_of(:new_issue_url) }
|
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
describe '.reference_pattern' do
|
2016-11-03 12:29:30 +05:30
|
|
|
it_behaves_like 'allows project key on reference pattern'
|
|
|
|
|
|
|
|
it 'does allow # on the reference' do
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(described_class.reference_pattern.match('#123')[:issue]).to eq('123')
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
2019-09-30 21:07:59 +05:30
|
|
|
|
|
|
|
context 'overriding properties' do
|
|
|
|
let(:url) { 'http://redmine.example.com' }
|
|
|
|
let(:access_params) do
|
|
|
|
{ project_url: url, issues_url: url, new_issue_url: url }
|
|
|
|
end
|
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
# this will be removed as part of https://gitlab.com/gitlab-org/gitlab/issues/29404
|
2019-09-30 21:07:59 +05:30
|
|
|
context 'when data are stored in properties' do
|
|
|
|
let(:properties) { access_params.merge(title: title, description: description) }
|
|
|
|
let(:service) do
|
|
|
|
create(:redmine_service, :without_properties_callback, properties: properties)
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-09-30 21:07:59 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in separated fields' do
|
|
|
|
let(:service) do
|
|
|
|
create(:redmine_service, title: title, description: description, properties: access_params)
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-09-30 21:07:59 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when data are stored in both properties and separated fields' do
|
|
|
|
let(:properties) { access_params.merge(title: 'wrong title', description: 'wrong description') }
|
|
|
|
let(:service) do
|
|
|
|
create(:redmine_service, :without_properties_callback, title: title, description: description, properties: properties)
|
|
|
|
end
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
it_behaves_like 'issue tracker fields'
|
2019-09-30 21:07:59 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no title & description are set' do
|
|
|
|
let(:service) do
|
|
|
|
create(:redmine_service, properties: access_params)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns default values' do
|
|
|
|
expect(service.title).to eq('Redmine')
|
|
|
|
expect(service.description).to eq('Redmine issue tracker')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|