2016-06-02 11:05:42 +05:30
|
|
|
require('spec_helper')
|
|
|
|
|
|
|
|
describe Projects::ProjectMembersController do
|
|
|
|
describe '#apply_import' do
|
2016-06-16 23:09:34 +05:30
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:another_project) { create(:project, :private) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:member) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
another_project.team << [member, :guest]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
shared_context 'import applied' do
|
|
|
|
before do
|
2016-06-16 23:09:34 +05:30
|
|
|
post(:apply_import, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
2016-06-02 11:05:42 +05:30
|
|
|
source_project_id: another_project.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user can access source project members' do
|
|
|
|
before { another_project.team << [user, :guest] }
|
|
|
|
include_context 'import applied'
|
|
|
|
|
|
|
|
it 'imports source project members' do
|
|
|
|
expect(project.team_members).to include member
|
|
|
|
expect(response).to set_flash.to 'Successfully imported'
|
|
|
|
expect(response).to redirect_to(
|
|
|
|
namespace_project_project_members_path(project.namespace, project)
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not member of a source project' do
|
|
|
|
include_context 'import applied'
|
|
|
|
|
|
|
|
it 'does not import team members' do
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(project.team_members).not_to include member
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'responds with not found' do
|
|
|
|
expect(response.status).to eq 404
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#index' do
|
|
|
|
context 'when user is member' do
|
|
|
|
before do
|
2016-06-16 23:09:34 +05:30
|
|
|
project = create(:project, :private)
|
|
|
|
member = create(:user)
|
2016-06-02 11:05:42 +05:30
|
|
|
project.team << [member, :guest]
|
|
|
|
sign_in(member)
|
2016-06-16 23:09:34 +05:30
|
|
|
|
|
|
|
get :index, namespace_id: project.namespace, project_id: project
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
it { expect(response).to have_http_status(200) }
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2016-06-16 23:09:34 +05:30
|
|
|
|
|
|
|
describe '#destroy' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
context 'when member is not found' do
|
|
|
|
it 'returns 404' do
|
|
|
|
delete :destroy, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: 42
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to have_http_status(404)
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member is found' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:team_user) { create(:user) }
|
|
|
|
let(:member) do
|
|
|
|
project.team << [team_user, :developer]
|
|
|
|
project.members.find_by(user_id: team_user.id)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have enough rights' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :developer]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
delete :destroy, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: member
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to have_http_status(404)
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(project.users).to include team_user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has enough rights' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it '[HTML] removes user from members' do
|
|
|
|
delete :destroy, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: member
|
|
|
|
|
|
|
|
expect(response).to redirect_to(
|
|
|
|
namespace_project_project_members_path(project.namespace, project)
|
|
|
|
)
|
|
|
|
expect(project.users).not_to include team_user
|
|
|
|
end
|
|
|
|
|
|
|
|
it '[JS] removes user from members' do
|
|
|
|
xhr :delete, :destroy, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: member
|
|
|
|
|
|
|
|
expect(response).to be_success
|
|
|
|
expect(project.users).not_to include team_user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#leave' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
context 'when member is not found' do
|
|
|
|
before { sign_in(user) }
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
it 'returns 404' do
|
2016-06-16 23:09:34 +05:30
|
|
|
delete :leave, namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
expect(response).to have_http_status(404)
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member is found' do
|
|
|
|
context 'and is not an owner' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :developer]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes user from members' do
|
|
|
|
delete :leave, namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
|
|
|
|
expect(response).to set_flash.to "You left the \"#{project.human_name}\" project."
|
|
|
|
expect(response).to redirect_to(dashboard_projects_path)
|
|
|
|
expect(project.users).not_to include user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and is an owner' do
|
|
|
|
before do
|
|
|
|
project.update(namespace_id: user.namespace_id)
|
|
|
|
project.team << [user, :master, user]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'cannot remove himself from the project' do
|
|
|
|
delete :leave, namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to have_http_status(403)
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'and is a requester' do
|
|
|
|
before do
|
|
|
|
project.request_access(user)
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes user from members' do
|
|
|
|
delete :leave, namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
|
|
|
|
expect(response).to set_flash.to 'Your access request to the project has been withdrawn.'
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to redirect_to(namespace_project_path(project.namespace, project))
|
|
|
|
expect(project.requesters).to be_empty
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(project.users).not_to include user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#request_access' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a new ProjectMember that is not a team member' do
|
|
|
|
post :request_access, namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
|
|
|
|
expect(response).to set_flash.to 'Your request for access has been queued for review.'
|
|
|
|
expect(response).to redirect_to(
|
|
|
|
namespace_project_path(project.namespace, project)
|
|
|
|
)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(project.requesters.exists?(user_id: user)).to be_truthy
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(project.users).not_to include user
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#approve' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
|
|
|
|
context 'when member is not found' do
|
|
|
|
it 'returns 404' do
|
|
|
|
post :approve_access_request, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: 42
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to have_http_status(404)
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when member is found' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:team_requester) { create(:user) }
|
|
|
|
let(:member) do
|
|
|
|
project.request_access(team_requester)
|
2016-08-24 12:49:21 +05:30
|
|
|
project.requesters.find_by(user_id: team_requester.id)
|
2016-06-16 23:09:34 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user does not have enough rights' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :developer]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
post :approve_access_request, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: member
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(response).to have_http_status(404)
|
2016-06-16 23:09:34 +05:30
|
|
|
expect(project.users).not_to include team_requester
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user has enough rights' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'adds user to members' do
|
|
|
|
post :approve_access_request, namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: member
|
|
|
|
|
|
|
|
expect(response).to redirect_to(
|
|
|
|
namespace_project_project_members_path(project.namespace, project)
|
|
|
|
)
|
|
|
|
expect(project.users).to include team_requester
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
describe 'POST create' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:stranger) { create(:user) }
|
|
|
|
|
|
|
|
context 'when creating owner' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a member' do
|
|
|
|
expect do
|
|
|
|
post :create, user_ids: stranger.id,
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
access_level: Member::OWNER,
|
|
|
|
project_id: project
|
|
|
|
end.to change { project.members.count }.by(0)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when create master' do
|
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a member' do
|
|
|
|
expect do
|
|
|
|
post :create, user_ids: stranger.id,
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
access_level: Member::MASTER,
|
|
|
|
project_id: project
|
|
|
|
end.to change { project.members.count }.by(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|