debian-mirror-gitlab/spec/finders/group_descendants_finder_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

285 lines
9.2 KiB
Ruby
Raw Normal View History

2019-12-21 20:55:43 +05:30
# frozen_string_literal: true
2018-03-17 18:26:18 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe GroupDescendantsFinder do
2021-01-29 00:20:46 +05:30
let_it_be(:user) { create(:user) }
2022-01-26 12:08:38 +05:30
let_it_be_with_reload(:group) do
create(:group).tap do |g|
g.add_owner(user)
end
end
2021-09-30 23:02:18 +05:30
2018-03-17 18:26:18 +05:30
let(:params) { {} }
2020-01-01 13:55:28 +05:30
2018-03-17 18:26:18 +05:30
subject(:finder) do
described_class.new(current_user: user, parent_group: group, params: params)
end
2022-03-02 08:16:31 +05:30
describe '#has_children?' do
it 'is true when there are projects' do
create(:project, namespace: group)
expect(finder.has_children?).to be_truthy
end
context 'when there are subgroups' do
2018-03-17 18:26:18 +05:30
it 'is true when there are projects' do
2022-03-02 08:16:31 +05:30
create(:group, parent: group)
2018-03-17 18:26:18 +05:30
expect(finder.has_children?).to be_truthy
end
2022-03-02 08:16:31 +05:30
end
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
describe '#execute' do
it 'includes projects' do
project = create(:project, namespace: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(project)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
context 'when archived is `true`' do
let(:params) { { archived: 'true' } }
it 'includes archived projects' do
archived_project = create(:project, namespace: group, archived: true)
2018-03-17 18:26:18 +05:30
project = create(:project, namespace: group)
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(archived_project, project)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
context 'when archived is `only`' do
let(:params) { { archived: 'only' } }
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'includes only archived projects' do
archived_project = create(:project, namespace: group, archived: true)
_project = create(:project, namespace: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(archived_project)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'does not include archived projects' do
_archived_project = create(:project, :archived, namespace: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to be_empty
end
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
it 'does not include projects aimed for deletion' do
_project_aimed_for_deletion = create(:project, :archived, marked_for_deletion_at: 2.days.ago, pending_delete: false)
expect(finder.execute).to be_empty
end
2022-03-02 08:16:31 +05:30
context 'with a filter' do
let(:params) { { filter: 'test' } }
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'includes only projects matching the filter' do
_other_project = create(:project, namespace: group)
matching_project = create(:project, namespace: group, name: 'testproject')
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(matching_project)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'sorts elements by name as default' do
project1 = create(:project, namespace: group, name: 'z')
project2 = create(:project, namespace: group, name: 'a')
2019-02-15 15:39:39 +05:30
2022-03-02 08:16:31 +05:30
expect(subject.execute).to match_array([project2, project1])
end
2019-02-15 15:39:39 +05:30
2022-03-02 08:16:31 +05:30
context 'sorting by name' do
let!(:project1) { create(:project, namespace: group, name: 'a', path: 'project-a') }
let!(:project2) { create(:project, namespace: group, name: 'z', path: 'project-z') }
let(:params) do
{
sort: 'name_asc'
}
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
it 'sorts elements by name' do
expect(subject.execute).to eq(
[
project1,
project2
]
)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
context 'with nested groups' do
let!(:subgroup1) { create(:group, parent: group, name: 'a', path: 'sub-a') }
let!(:subgroup2) { create(:group, parent: group, name: 'z', path: 'sub-z') }
2018-03-17 18:26:18 +05:30
it 'sorts elements by name' do
expect(subject.execute).to eq(
[
2022-03-02 08:16:31 +05:30
subgroup1,
subgroup2,
2018-03-17 18:26:18 +05:30
project1,
project2
]
)
end
2022-01-26 12:08:38 +05:30
end
2022-03-02 08:16:31 +05:30
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'does not include projects shared with the group' do
project = create(:project, namespace: group)
other_project = create(:project)
other_project.project_group_links.create!(group: group,
group_access: Gitlab::Access::MAINTAINER)
2021-01-29 00:20:46 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(project)
2021-01-29 00:20:46 +05:30
end
2022-03-02 08:16:31 +05:30
end
2021-01-29 00:20:46 +05:30
2022-03-02 08:16:31 +05:30
context 'with shared groups' do
let_it_be(:other_group) { create(:group) }
let_it_be(:shared_group_link) do
create(:group_group_link,
shared_group: group,
shared_with_group: other_group)
end
2021-01-29 00:20:46 +05:30
2022-03-02 08:16:31 +05:30
context 'without common ancestor' do
it { expect(finder.execute).to be_empty }
end
context 'with common ancestor' do
let_it_be(:common_ancestor) { create(:group) }
let_it_be(:other_group) { create(:group, parent: common_ancestor) }
let_it_be(:group) { create(:group, parent: common_ancestor) }
context 'querying under the common ancestor' do
2021-01-29 00:20:46 +05:30
it { expect(finder.execute).to be_empty }
end
2022-03-02 08:16:31 +05:30
context 'querying the common ancestor' do
subject(:finder) do
described_class.new(current_user: user, parent_group: common_ancestor, params: params)
2021-01-29 00:20:46 +05:30
end
2022-03-02 08:16:31 +05:30
it 'contains shared subgroups' do
expect(finder.execute).to contain_exactly(group, other_group)
2021-01-29 00:20:46 +05:30
end
end
end
2022-03-02 08:16:31 +05:30
end
2021-01-29 00:20:46 +05:30
2022-03-02 08:16:31 +05:30
context 'with nested groups' do
2022-04-04 11:22:00 +05:30
let_it_be(:project) { create(:project, namespace: group) }
let_it_be_with_reload(:subgroup) { create(:group, :private, parent: group) }
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
describe '#execute' do
it 'contains projects and subgroups' do
expect(finder.execute).to contain_exactly(subgroup, project)
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'does not include subgroups the user does not have access to' do
subgroup.update!(visibility_level: Gitlab::VisibilityLevel::PRIVATE)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
public_subgroup = create(:group, :public, parent: group, path: 'public-group')
other_subgroup = create(:group, :private, parent: group, path: 'visible-private-group')
other_user = create(:user)
other_subgroup.add_developer(other_user)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
finder = described_class.new(current_user: other_user, parent_group: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(public_subgroup, other_subgroup)
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'only includes public groups when no user is given' do
public_subgroup = create(:group, :public, parent: group)
_private_subgroup = create(:group, :private, parent: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
finder = described_class.new(current_user: nil, parent_group: group)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute).to contain_exactly(public_subgroup)
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
context 'when archived is `true`' do
let(:params) { { archived: 'true' } }
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
it 'includes archived projects in the count of subgroups' do
create(:project, namespace: subgroup, archived: true)
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
expect(finder.execute.first.preloaded_project_count).to eq(1)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
end
2018-03-17 18:26:18 +05:30
2022-03-02 08:16:31 +05:30
context 'with a filter' do
let(:params) { { filter: 'test' } }
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
shared_examples 'filter examples' do
it 'contains only matching projects and subgroups' do
matching_project = create(:project, namespace: group, name: 'Testproject')
matching_subgroup = create(:group, name: 'testgroup', parent: group)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).to contain_exactly(matching_subgroup, matching_project)
end
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
it 'does not include subgroups the user does not have access to' do
_invisible_subgroup = create(:group, :private, parent: group, name: 'test1')
other_subgroup = create(:group, :private, parent: group, name: 'test2')
public_subgroup = create(:group, :public, parent: group, name: 'test3')
other_subsubgroup = create(:group, :private, parent: other_subgroup, name: 'test4')
other_user = create(:user)
other_subgroup.add_developer(other_user)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
finder = described_class.new(current_user: other_user,
parent_group: group,
params: params)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).to contain_exactly(other_subgroup, public_subgroup, other_subsubgroup)
end
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
context 'with matching children' do
it 'includes a group that has a subgroup matching the query and its parent' do
matching_subgroup = create(:group, :private, name: 'testgroup', parent: subgroup)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).to contain_exactly(subgroup, matching_subgroup)
end
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
it 'includes the parent of a matching project' do
matching_project = create(:project, namespace: subgroup, name: 'Testproject')
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).to contain_exactly(subgroup, matching_project)
end
context 'with a small page size' do
let(:params) { { filter: 'test', per_page: 1 } }
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
it 'contains all the ancestors of a matching subgroup regardless the page size' do
subgroup = create(:group, :private, parent: group)
matching = create(:group, :private, name: 'testgroup', parent: subgroup)
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).to contain_exactly(subgroup, matching)
end
end
it 'does not include the parent itself' do
group.update!(name: 'test')
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
expect(finder.execute).not_to include(group)
2018-03-17 18:26:18 +05:30
end
2022-03-02 08:16:31 +05:30
end
2022-04-04 11:22:00 +05:30
end
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
it_behaves_like 'filter examples'
2018-03-17 18:26:18 +05:30
2022-04-04 11:22:00 +05:30
context 'when feature flag :linear_group_descendants_finder_upto is disabled' do
before do
stub_feature_flags(linear_group_descendants_finder_upto: false)
2018-03-17 18:26:18 +05:30
end
2022-04-04 11:22:00 +05:30
it_behaves_like 'filter examples'
2018-03-17 18:26:18 +05:30
end
end
end
end
end