2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-10-15 14:42:47 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe Groups::RunnersController do
|
2021-11-11 11:23:49 +05:30
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:project) { create(:project, group: group) }
|
|
|
|
|
|
|
|
let!(:runner) { create(:ci_runner, :group, groups: [group]) }
|
|
|
|
let!(:runner_project) { create(:ci_runner, :project, projects: [project]) }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
let(:params_runner_project) { { group_id: group, id: runner_project } }
|
2019-09-04 21:01:54 +05:30
|
|
|
let(:params) { { group_id: group, id: runner } }
|
2018-10-15 14:42:47 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
2022-06-21 17:19:12 +05:30
|
|
|
describe '#index', :snowplow do
|
2021-10-27 15:23:28 +05:30
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders show with 200 status code' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:index)
|
2021-11-11 11:23:49 +05:30
|
|
|
expect(assigns(:group_runners_limited_count)).to be(2)
|
2021-10-27 15:23:28 +05:30
|
|
|
end
|
2022-06-21 17:19:12 +05:30
|
|
|
|
|
|
|
it 'tracks the event' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect_snowplow_event(category: described_class.name, action: 'index', user: user, namespace: group)
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
2022-06-21 17:19:12 +05:30
|
|
|
|
|
|
|
it 'does not track the event' do
|
|
|
|
get :index, params: { group_id: group }
|
|
|
|
|
|
|
|
expect_no_snowplow_event
|
|
|
|
end
|
2021-10-27 15:23:28 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
describe '#show' do
|
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders show with 200 status code' do
|
|
|
|
get :show, params: { group_id: group, id: runner }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(response).to render_template(:show)
|
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'renders show with 200 status code project runner' do
|
|
|
|
get :show, params: { group_id: group, id: runner_project }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:show)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
|
|
|
get :show, params: { group_id: group, id: runner }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'renders a 404 project runner' do
|
|
|
|
get :show, params: { group_id: group, id: runner_project }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#edit' do
|
|
|
|
context 'when user is owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders show with 200 status code' do
|
|
|
|
get :edit, params: { group_id: group, id: runner }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(response).to render_template(:edit)
|
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'renders show with 200 status code project runner' do
|
|
|
|
get :edit, params: { group_id: group, id: runner_project }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template(:edit)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders a 404' do
|
|
|
|
get :edit, params: { group_id: group, id: runner }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'renders a 404 project runner' do
|
|
|
|
get :edit, params: { group_id: group, id: runner_project }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe '#update' do
|
2019-09-04 21:01:54 +05:30
|
|
|
context 'when user is an owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
it 'updates the runner, ticks the queue, and redirects' do
|
|
|
|
new_desc = runner.description.swapcase
|
2018-10-15 14:42:47 +05:30
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
expect do
|
|
|
|
post :update, params: params.merge(runner: { description: new_desc } )
|
|
|
|
end.to change { runner.ensure_runner_queue_value }
|
2018-10-15 14:42:47 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(runner.reload.description).to eq(new_desc)
|
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'updates the project runner, ticks the queue, and redirects project runner' do
|
|
|
|
new_desc = runner_project.description.swapcase
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post :update, params: params_runner_project.merge(runner: { description: new_desc } )
|
|
|
|
end.to change { runner_project.ensure_runner_queue_value }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:found)
|
|
|
|
expect(runner_project.reload.description).to eq(new_desc)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not an owner' do
|
|
|
|
before do
|
|
|
|
group.add_maintainer(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'rejects the update and responds 404' do
|
|
|
|
old_desc = runner.description
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post :update, params: params.merge(runner: { description: old_desc.swapcase } )
|
|
|
|
end.not_to change { runner.ensure_runner_queue_value }
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-09-04 21:01:54 +05:30
|
|
|
expect(runner.reload.description).to eq(old_desc)
|
|
|
|
end
|
2020-07-28 23:09:34 +05:30
|
|
|
|
|
|
|
it 'rejects the update and responds 404 project runner' do
|
|
|
|
old_desc = runner_project.description
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post :update, params: params_runner_project.merge(runner: { description: old_desc.swapcase } )
|
|
|
|
end.not_to change { runner_project.ensure_runner_queue_value }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
expect(runner_project.reload.description).to eq(old_desc)
|
|
|
|
end
|
2018-10-15 14:42:47 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|