107 lines
3.3 KiB
Ruby
107 lines
3.3 KiB
Ruby
|
# frozen_string_literal: true
|
||
|
|
|
||
|
|
require 'spec_helper'
|
||
|
|
|
||
|
|
RSpec.describe Groups::OpenIssuesCountService, :use_clean_rails_memory_store_caching do
|
||
|
|
let_it_be(:group) { create(:group, :public)}
|
||
|
|
let_it_be(:project) { create(:project, :public, namespace: group) }
|
||
|
|
let_it_be(:user) { create(:user) }
|
||
|
|
let_it_be(:issue) { create(:issue, :opened, project: project) }
|
||
|
|
let_it_be(:confidential) { create(:issue, :opened, confidential: true, project: project) }
|
||
|
|
let_it_be(:closed) { create(:issue, :closed, project: project) }
|
||
|
|
|
||
|
|
subject { described_class.new(group, user) }
|
||
|
|
|
||
|
|
describe '#relation_for_count' do
|
||
|
|
before do
|
||
|
|
allow(IssuesFinder).to receive(:new).and_call_original
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'uses the IssuesFinder to scope issues' do
|
||
|
|
expect(IssuesFinder)
|
||
|
|
.to receive(:new)
|
||
|
|
.with(user, group_id: group.id, state: 'opened', non_archived: true, include_subgroups: true, public_only: true)
|
||
|
|
|
||
|
|
subject.count
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
describe '#count' do
|
||
|
|
context 'when user is nil' do
|
||
|
|
it 'does not include confidential issues in the issue count' do
|
||
|
|
expect(described_class.new(group).count).to eq(1)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when user is provided' do
|
||
|
|
context 'when user can read confidential issues' do
|
||
|
|
before do
|
||
|
|
group.add_reporter(user)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'returns the right count with confidential issues' do
|
||
|
|
expect(subject.count).to eq(2)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when user cannot read confidential issues' do
|
||
|
|
before do
|
||
|
|
group.add_guest(user)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not include confidential issues' do
|
||
|
|
expect(subject.count).to eq(1)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'with different cache values' do
|
||
|
|
let(:public_count_key) { subject.cache_key(described_class::PUBLIC_COUNT_KEY) }
|
||
|
|
let(:under_threshold) { described_class::CACHED_COUNT_THRESHOLD - 1 }
|
||
|
|
let(:over_threshold) { described_class::CACHED_COUNT_THRESHOLD + 1 }
|
||
|
|
|
||
|
|
context 'when cache is empty' do
|
||
|
|
before do
|
||
|
|
Rails.cache.delete(public_count_key)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'refreshes cache if value over threshold' do
|
||
|
|
allow(subject).to receive(:uncached_count).and_return(over_threshold)
|
||
|
|
|
||
|
|
expect(subject.count).to eq(over_threshold)
|
||
|
|
expect(Rails.cache.read(public_count_key)).to eq(over_threshold)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not refresh cache if value under threshold' do
|
||
|
|
allow(subject).to receive(:uncached_count).and_return(under_threshold)
|
||
|
|
|
||
|
|
expect(subject.count).to eq(under_threshold)
|
||
|
|
expect(Rails.cache.read(public_count_key)).to be_nil
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when cached count is under the threshold value' do
|
||
|
|
before do
|
||
|
|
Rails.cache.write(public_count_key, under_threshold)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not refresh cache' do
|
||
|
|
expect(Rails.cache).not_to receive(:write)
|
||
|
|
expect(subject.count).to eq(under_threshold)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'when cached count is over the threshold value' do
|
||
|
|
before do
|
||
|
|
Rails.cache.write(public_count_key, over_threshold)
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'does not refresh cache' do
|
||
|
|
expect(Rails.cache).not_to receive(:write)
|
||
|
|
expect(subject.count).to eq(over_threshold)
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|